Peter Nelson
eaa765d615
Codechange: Disentangle news window style from news flags. ( #13482 )
...
This avoids NewsFlags being used as both bitmask and bitstuffed data.
2025-02-07 13:10:39 +00:00
Peter Nelson
afc0745aa2
Codechange: Specify underlying type for all enums excluding those exposed to scripts. ( #13383 )
2025-01-28 22:17:34 +00:00
Rubidium
08d84b2f4a
Codechange: use AdviceType over StringID to remove vehicle advice news
2025-01-08 02:03:55 +01:00
Peter Nelson
6f8e30c55d
Codechange: Use unique_ptr throughout instead of new raw pointer for company news data. ( #13148 )
...
The pointer was already captured and converted to a unqiue_ptr, but hidden within the call stack.
This now makes it clearer that the object passed to Add.*NewsItem will become owned by the news item.
2024-12-04 12:18:34 +00:00
Peter Nelson
446db2c826
Codechange: Remove redundant NewsStringData data. ( #12983 )
...
Since SetDParamStr() always owns a copy of the string, there is no need to make another copy of it to keep it around while the news item exists.
This also fixes a leak in `CmdIndustrySetProduction` as the allocated data wasn't passed to AddIndustryNewsItem.
2024-10-08 19:48:55 +01:00
Peter Nelson
3d8d0e0d26
Codechange: Use std::variant to store string parameter data.
...
This avoids storing two separate values and makes the test for which type is held clearer.
This replaces use of unique_ptr for conditionally storing a string, and is also used in place of StringParameterBackup.
2024-09-14 15:31:05 +01:00
Peter Nelson
f6a88e40a4
Codechange: Use std::list for News Items. ( #12338 )
2024-04-04 07:53:14 +01:00
Patric Stout
a3cfd23cf9
Codechange: rename byte to uint8_t ( #12308 )
2024-03-16 23:59:32 +01:00
Tyler Trahan
735abfe111
Codechange: Split dates and timers into Economy and Calendar time ( #10700 )
2024-01-22 09:04:34 -05:00
Peter Nelson
c0ab436077
Codechange: Store Colours in Colours type. ( #11625 )
...
This reduces casts, some magic numbers, and introduces a bit of type-safety.
2024-01-21 13:23:04 +00:00
Rubidium
eaae0bb5e7
Codechange: automatic adding of _t to (u)int types, and WChar to char32_t
...
for i in `find src -type f|grep -v 3rdparty/fmt|grep -v 3rdparty/catch2|grep -v 3rdparty/opengl|grep -v stdafx.h`; do sed 's/uint16& /uint16 \&/g;s/int8\([ >*),;[]\)/int8_t\1/g;s/int16\([ >*),;[]\)/int16_t\1/g;s/int32\([ >*),;[]\)/int32_t\1/g;s/int64\([ >*),;[]\)/int64_t\1/g;s/ uint32(/ uint32_t(/g;s/_uint8_t/_uint8/;s/Uint8_t/Uint8/;s/ft_int64_t/ft_int64/g;s/uint64$/uint64_t/;s/WChar/char32_t/g;s/char32_t char32_t/char32_t WChar/' -i $i; done
2023-07-19 19:30:14 +02:00
Rubidium
0943402bab
Codechange: move news over to the new StringParameterBackup type
2023-07-02 22:31:01 +02:00
Patric Stout
199e41c762
Codechange: use default dtor instead of empty ( #10826 )
2023-05-14 23:31:03 +02:00
Tyler Trahan
930f0a16d8
Codechange: Define Date/Year/Month/Day within TimerGameCalendar class
2023-04-26 07:14:03 -04:00
Michael Lutz
13528bfcd0
Codechange: Un-bitstuff all remaining commands.
2021-12-16 22:28:32 +01:00
Guillaume Renoult
c38af72978
Update: add setting to hide news about competitors vehicle crash ( #9653 )
2021-11-07 19:54:50 +01:00
Rubidium
9c7a7b53a1
Codechange: use a contructor for NewsItem to set the values
...
And use std::unique_ptr to manage the memory of the allocated data
2021-07-01 19:04:38 +02:00
rubidium42
9a7750f14e
Codechange: use the constructor for CompanyNewsItem to fill the data instead of a separate function
2021-07-01 19:04:38 +02:00
rubidium42
aa9818db90
Codechange: create a type for the "free_data" of NewsItems and (de)allocate it with new and delete
2021-07-01 19:04:38 +02:00
S. D. Cloudt
13cc8a0cee
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
JMcKiern
04f659e768
Fix: Some typos found using codespell
2019-09-29 21:27:32 +01:00
Henry Wilson
7c8e7c6b6e
Codechange: Use null pointer literal instead of the NULL macro
2019-04-10 23:22:20 +02:00
Charles Pigott
52ed3bcbaa
Remove: A few bits of dead code
2018-10-31 12:41:49 +01:00
frosch
21b43b63f5
(svn r24843) -Codechange: Move news display options into the general settings framework. (based on patch by eagle_rainbow)
2012-12-23 21:07:12 +00:00
frosch
01100053ff
(svn r24285) -Codechange: Add a more explcit NewsFlag to indicate that the first string parameter is a vehicle ID.
2012-05-26 14:16:07 +00:00
frosch
a8c88f43b6
(svn r24284) -Codechange: Remove NewsSubtypes and directly use NewsTypes and NewsFlag instead.
2012-05-26 14:16:03 +00:00
frosch
c796801c4d
(svn r24281) -Cleanup: Merge all company news subtypes into a single one; they all behave the same.
2012-05-26 14:15:46 +00:00
truebrain
bcbdc3933c
(svn r23600) -Codechange: link WC+number to a Widget, and the Widget to a Window class
2011-12-19 20:46:17 +00:00
rubidium
df16ebd730
(svn r23595) -Codechange: add comma after last enum to get a more uniform coding style
2011-12-19 17:48:04 +00:00
frosch
2981404793
(svn r22897) -Change: More suitable default news settings instead of everything on 'full'.
2011-09-05 21:55:05 +00:00
rubidium
4d5dbf5170
(svn r22410) -Document: some more bits ;)
2011-05-02 16:14:23 +00:00
smatz
53aaabe6e9
(svn r19507) -Codechange: remove semicolon after DECLARE_POSTFIX_INCREMENT and DECLARE_ENUM_AS_BIT_SET
2010-03-23 22:25:43 +00:00
yexo
7d5cfa5884
(svn r19105) -Fix [FS#3614]: not all news data was properly freed when starting a new game
2010-02-12 16:42:29 +00:00
alberth
5fd5ae125a
(svn r17398) -Codechange: Fill normal news item window with widgets.
2009-09-02 20:59:30 +00:00
alberth
0f9da2d636
(svn r17397) -Codechange: Add new vehicle news window.
2009-09-02 20:55:55 +00:00
alberth
c0b9a6a9bc
(svn r17396) -Codechange: Add company news window.
2009-09-02 20:54:27 +00:00
alberth
96617e804c
(svn r17394) -Codechange: Add news flags for viewport settings.
2009-09-02 20:49:25 +00:00
rubidium
b1d4594fa7
(svn r17343) -Codechange: it's bankruptcy, not bankrupcy, according to my Oxford Dictionary of English and Merriam-Webster.
2009-09-01 12:28:46 +00:00
rubidium
7fbc33dae1
(svn r17248) -Fix: add GPL license notice where appropriate
2009-08-21 20:21:05 +00:00
alberth
3409385e1d
(svn r17199) -Codechange: Remove NF_VIEWPORT since it is implied by the news mode.
2009-08-16 07:31:36 +00:00
frosch
52f9b8ffbd
(svn r17147) -Fix [FS#3048]: Keep vehicle news and viewports following vehicles, when autoreplacing/renewing them.
2009-08-10 20:06:39 +00:00
frosch
a4557c7da4
(svn r16416) -Fix [FS#2912]: Rework deleting of news when referenced vehicles/stations/industries are deleted.
2009-05-24 16:52:42 +00:00
rubidium
9c24e2bb8f
(svn r16340) -Codechange: introduce SoundID (uint16) and use that instead of SoundFX, which was used as a byte and uint16 at different places, when the uint16 sound ID is meant.
2009-05-17 17:17:48 +00:00
rubidium
5f81ba886c
(svn r16297) -Codechange: silence more ICC warnings
2009-05-13 17:39:00 +00:00
alberth
eab4fb07c6
(svn r16200) -Codechange: Moving news-type description to NewsTypeData array.
2009-05-02 13:05:00 +00:00
smatz
c299bac5be
(svn r15830) -Codechange: don't use fixed size of array in news_gui.cpp and news_func.h
2009-03-23 11:48:05 +00:00
smatz
8585aa71ed
(svn r15726) -Codechange: unify coding style for const pointers
2009-03-15 16:04:39 +00:00
rubidium
c0a8d09ca7
(svn r15428) -Codechange: consistently use colour instead of having both color and colour.
2009-02-09 02:57:15 +00:00
rubidium
3b798599b6
(svn r14421) -Codechange: rename all player variables/types to company *or* client so it is immediatelly clear which one you are working with.
2008-09-30 20:39:50 +00:00
belugas
7564dbd32f
(svn r14059) -Fix(r13872): Wrong comments in enum. Dear old copy/paste...
2008-08-13 01:48:58 +00:00
