gronod/iccery-v2-mac
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix(ui): media Apply missing-printer notice visible in manage sheet (#170) #171

Merged
gronod merged 1 commits from fix/170-media-library-missing-printer-notice into develop 2026-09-14 14:37:17 +01:00
Conversation 0 Commits 1 Files Changed 3
+33 -25
gronod commented 2026-09-14 14:37:01 +01:00
Owner
Copy Link
Copy Source

Fixes #170

The window banner is occluded by #manageMediaDialog on Monterey. Failed Apply now also sets manageApplyNotice inside the sheet; the UI test waits for manageMediaNotice.

Fixes #170 The window banner is occluded by `#manageMediaDialog` on Monterey. Failed Apply now also sets `manageApplyNotice` inside the sheet; the UI test waits for `manageMediaNotice`.
gronod added 1 commit 2026-09-14 14:37:03 +01:00
fix(ui): show media Apply failure inside the manage sheet (#170)
macOS CI / build-and-test (push) Skipped
macOS CI / package (pull_request) Canceled after 0s
Details
macOS CI / build-and-test (pull_request) Canceled after 2m31s
Details
890e7281eb 
Failed Apply kept the sheet open while the window banner sat
behind it, so Monterey XCTest never saw noticeText. Mirror the
failure string in the dialog (manageMediaNotice) and point the
UI test at that identifier.

Fixes #170
gronod merged commit 1b91b0a94e into develop 2026-09-14 14:37:17 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug/Architecture
Core / wizard / process infra defect
 Bug/Backend
Argyll orchestration, file/data defect
 Bug/DevOps
Build, packaging, CI defect
 Bug/UI
Views, controls, dialogs defect
 Compat/Breaking
Breaking change that won't be backward compatible
 Feature/Architecture
Core / wizard / process infra
 Feature/Backend
Argyll orchestration, file/data engines
 Feature/DevOps
Build, packaging, CI
 Feature/UI
Views, controls, dialogs
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Project/ICCery-v2
ICCery v2 Mac rewrite
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
gronod
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gronod/iccery-v2-mac#171