gronod/iccery-v2-mac
1
0
Fork 0
Code Issues 3 Pull Requests 1 Actions 1 Packages Projects Releases 3 Wiki Activity

Milestone 10 — Studio workflow (#146–#149) #156

Open
gronod wants to merge 18 commits from milestone/m10-studio into develop
pull from: milestone/m10-studio
merge into: :develop
Conversation 2 Commits 18 Files Changed 57
+7752 -130
gronod commented 2026-09-13 12:45:25 +01:00
Owner
Copy Link
Copy Source

This PR is opened so Gitea Actions runs. Merge is deferred; do not merge in this session. .gitea/workflows/macos.yml only triggers on PRs targeting develop; this is the only M10 PR with that base. A later session / human merges once CI evidence is reviewed.

Scope — Milestone 10 (id 32): Studio workflow

Issue Feature Feature PR Merge SHA on milestone/m10-studio
#146 Media recipe library bound to presets #151 1931da8
#148 Spot-read console (spotread, bundled sidecar only) #152 538ef1e
#147 Gamut compare: second profile + click-inspect #153 99c0d7e
#149 .icceryproj project file index + recents + report #154 c39afe0
— Docs hygiene: default_instrument seeds Spot Read; README floor macOS 12.0 #155 48d2816
— M10 tracking (BUILD-PLAN / README rows) #150 2f305c4

All four issues are closed (manually, with evidence). Milestone 32 stays open — hardware gates (R6) and this merge are deferred.

Local full host-arch gate (on head SHA 48d2816)

xcodegen generate --spec project.yml
xcodebuild test -scheme ICCery -destination 'platform=macOS' \
  -derivedDataPath build/DerivedData-m10-final \
  ARCHS="$(uname -m)" CODE_SIGNING_ALLOWED=YES CODE_SIGN_IDENTITY='-'
  • ICCeryCoreTests: 439 executed, 0 failures
  • ICCeryUITests: 49 executed, 0 failures — real Automation attach, no skip
  • xcresult: build/DerivedData-m10-final/Logs/Test/Test-ICCery-2026.09.13_12-25-16-+0100.xcresult
  • Known flakes (testNonZeroExitThrowsToolFailed, testHandheldFixtureChartreadAndAverage, testSpotReadButtonDisabledDuringChartread) all passed without rerun

Sync status

origin/develop (800c980) is still an ancestor of this head — no sync merge needed; the diff is exactly M10.

Refs #146
Refs #147
Refs #148
Refs #149

**This PR is opened so Gitea Actions runs. Merge is deferred; do not merge in this session.** `.gitea/workflows/macos.yml` only triggers on PRs targeting `develop`; this is the only M10 PR with that base. A later session / human merges once CI evidence is reviewed. ## Scope — Milestone 10 (id 32): Studio workflow | Issue | Feature | Feature PR | Merge SHA on `milestone/m10-studio` | |---|---|---|---| | #146 | Media recipe library bound to presets | #151 | `1931da8` | | #148 | Spot-read console (`spotread`, bundled sidecar only) | #152 | `538ef1e` | | #147 | Gamut compare: second profile + click-inspect | #153 | `99c0d7e` | | #149 | `.icceryproj` project file index + recents + report | #154 | `c39afe0` | | — | Docs hygiene: `default_instrument` seeds Spot Read; README floor macOS 12.0 | #155 | `48d2816` | | — | M10 tracking (BUILD-PLAN / README rows) | #150 | `2f305c4` | All four issues are closed (manually, with evidence). Milestone 32 stays **open** — hardware gates (R6) and this merge are deferred. ## Local full host-arch gate (on head SHA `48d2816`) ``` xcodegen generate --spec project.yml xcodebuild test -scheme ICCery -destination 'platform=macOS' \ -derivedDataPath build/DerivedData-m10-final \ ARCHS="$(uname -m)" CODE_SIGNING_ALLOWED=YES CODE_SIGN_IDENTITY='-' ``` - ICCeryCoreTests: **439 executed, 0 failures** - ICCeryUITests: **49 executed, 0 failures** — real Automation attach, no skip - xcresult: `build/DerivedData-m10-final/Logs/Test/Test-ICCery-2026.09.13_12-25-16-+0100.xcresult` - Known flakes (`testNonZeroExitThrowsToolFailed`, `testHandheldFixtureChartreadAndAverage`, `testSpotReadButtonDisabledDuringChartread`) all passed without rerun ## Sync status `origin/develop` (`800c980`) is still an ancestor of this head — no sync merge needed; the diff is exactly M10. Refs #146 Refs #147 Refs #148 Refs #149
gronod added 12 commits 2026-09-13 12:45:26 +01:00
docs(m10): record studio-workflow milestone tracking 4249067345 
Refs #146

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Merge pull request 'docs(m10): record studio-workflow milestone tracking' (#150) from chore/m10-tracking into milestone/m10-studio 2f305c481e
feat(media): media recipe library bound to presets (#146) f896f60d1a 
Refs #146

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Merge pull request 'feat(media): media recipe library bound to presets (#146)' (#151) from feat/146-media-library into milestone/m10-studio 1931da8448
feat(spotread): spot-read console for live Lab (#148) d40932f4cf 
Refs #148

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Merge pull request 'feat(spotread): spot-read console for live Lab (#148)' (#152) from feat/148-spot-read into milestone/m10-studio 538ef1e05f
feat(gamut): second-profile compare and click-inspect (#147) 398d9b4756 
Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Merge pull request 'feat(gamut): second-profile compare and click-inspect (#147)' (#153) from feat/147-gamut-compare into milestone/m10-studio 99c0d7e83d
feat(project): .icceryproj index over basename and cwd + recipe + last ΔE (#149) 1d78957d7a 
Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Merge pull request 'feat(project): .icceryproj index over basename and cwd + recipe + last ΔE (#149)' (#154) from feat/149-project-file into milestone/m10-studio c39afe0dfd
docs(m10): defaultInstrument seeds Spot Read; README floor is macOS 12 b494b4fffd 
Refs #148

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Merge pull request 'docs(m10): defaultInstrument seeds Spot Read; README floor is macOS 12' (#155) from chore/m10-docs-hygiene into milestone/m10-studio
macOS CI / build-and-test (pull_request) Failing after 1m23s
Details
macOS CI / package (pull_request) Skipped
Details
48d2816c73
gronod added this to the M10 — Studio workflow (media library, gamut compare, spot-read, projects) milestone 2026-09-13 12:45:34 +01:00
gronod commented 2026-09-13 12:52:35 +01:00
Author
Owner
Copy Link
Copy Source

CI result (Actions run 33666): FAILED at build. Deterministic product bug, not infrastructure.

build-and-test (job 34939), step "Build for testing (host arch)", runner macos-12 / Xcode 14.2 (Swift 5.7):

Sources/ICCery/SidebarView.swift:40:13: error: extra arguments at positions #11, #12, #13, #14 in call
Sources/ICCery/MediaLibraryDialogs.swift:51:13: error: extra arguments at positions #11, #12, #13 in call

ViewBuilder.buildBlock caps at 10 children on Swift 5.7 (no buildPartialBlock until 5.9). Two M10 view builders exceed it — 14 and 13 children respectively. Local gates missed it because the dev host runs Xcode 15.x. Unit/UI steps were skipped; package never ran.

Issue #146 reopened with the evidence comment (the over-capacity builders are its deliverable). A fix/ branch into milestone/m10-studio is a later session. This PR remains open and unmerged; milestone 32 remains open.

**CI result (Actions run 33666): FAILED at build.** Deterministic product bug, not infrastructure. `build-and-test` (job 34939), step "Build for testing (host arch)", runner `macos-12` / Xcode 14.2 (Swift 5.7): ``` Sources/ICCery/SidebarView.swift:40:13: error: extra arguments at positions #11, #12, #13, #14 in call Sources/ICCery/MediaLibraryDialogs.swift:51:13: error: extra arguments at positions #11, #12, #13 in call ``` `ViewBuilder.buildBlock` caps at 10 children on Swift 5.7 (no `buildPartialBlock` until 5.9). Two M10 view builders exceed it — 14 and 13 children respectively. Local gates missed it because the dev host runs Xcode 15.x. Unit/UI steps were skipped; `package` never ran. Issue #146 reopened with the evidence comment (the over-capacity builders are its deliverable). A `fix/` branch into `milestone/m10-studio` is a later session. **This PR remains open and unmerged; milestone 32 remains open.**
gronod added 2 commits 2026-09-13 13:35:41 +01:00
fix(ui): split ViewBuilders for Swift 5.7 ten-child limit (#146) f43c275152 
Actions run 33666 (Xcode 14.2, macOS 12) failed to compile: the
sidebar VStack had 14 children and SaveMediaRecipeDialog had 13,
over the Swift 5.7 ViewBuilder 10-child cap. Extracted
layout-transparent Group subviews (header/presetBlock/mediaBlock/
studioButtons/stepperAndProject; fields/readOnlyRows) — no id,
order, or layout change.

Refs #146

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Merge pull request 'fix(ui): split ViewBuilders for Swift 5.7 ten-child limit (#146)' (#157) from fix/146-viewbuilder-ten-child into milestone/m10-studio
macOS CI / build-and-test (pull_request) Failing after 29m46s
Details
macOS CI / package (pull_request) Skipped
Details
3d8e70be62
gronod commented 2026-09-13 14:18:11 +01:00
Author
Owner
Copy Link
Copy Source

Status update — Actions run 33718 on head 3d8e70b (includes #157 ViewBuilder fix):

  • Build for testing (host arch): PASS — Xcode 14.2 / Swift 5.7 compiles cleanly; the SidebarView (14→5) and SaveMediaRecipeDialog (13→7) Group splits resolved the run-33666 compile failure.
  • Unit (ICCeryCoreTests): PASS
  • UI (ICCeryUITests): real run, 48 tests, 4 failures (Automation attached — no skip):
    • Milestone10GamutCompareUITests.testLayerTogglesExistWithSRGB
    • Milestone10GamutCompareUITests.testCompareGamLoadEnablesToggle — "Compare toggle should enable after load"
    • Milestone10GamutCompareUITests.testOpenProfileRunsIccgamutForCompare — "Compare toggle should enable after iccgamut"
    • Milestone10ProjectUITests.testNewProjectClearsBasenameDoesNotDeleteFixtureTi3 — "expected the New or dirty alert"

All four exercise untouched #147/#149 paths (gamutLayer-* toolbar checkboxes, stubbed compare-gamut load, ⌘N File-menu alert) and pass locally on newer macOS/Xcode — first time these tests ran on the macOS 12 CI runner (33666 died at build). Looks environment-specific, needs its own investigation.

#146 stays open. Do not merge this PR.

Status update — Actions run **33718** on head `3d8e70b` (includes #157 ViewBuilder fix): - **Build for testing (host arch): PASS** — Xcode 14.2 / Swift 5.7 compiles cleanly; the `SidebarView` (14→5) and `SaveMediaRecipeDialog` (13→7) Group splits resolved the run-33666 compile failure. - **Unit (ICCeryCoreTests): PASS** - **UI (ICCeryUITests): real run, 48 tests, 4 failures** (Automation attached — no skip): - `Milestone10GamutCompareUITests.testLayerTogglesExistWithSRGB` - `Milestone10GamutCompareUITests.testCompareGamLoadEnablesToggle` — "Compare toggle should enable after load" - `Milestone10GamutCompareUITests.testOpenProfileRunsIccgamutForCompare` — "Compare toggle should enable after iccgamut" - `Milestone10ProjectUITests.testNewProjectClearsBasenameDoesNotDeleteFixtureTi3` — "expected the New or dirty alert" All four exercise untouched #147/#149 paths (`gamutLayer-*` toolbar checkboxes, stubbed compare-gamut load, ⌘N File-menu alert) and pass locally on newer macOS/Xcode — first time these tests ran on the macOS 12 CI runner (33666 died at build). Looks environment-specific, needs its own investigation. #146 stays open. **Do not merge this PR.**
gronod added 2 commits 2026-09-13 14:59:49 +01:00
test(m10): wait for gamut layer enable; drive New via File menu on macOS 12 eb3ae08cf9 
Actions run 33718 (Xcode 14.2, macOS 12) failed four UI tests that
pass locally. Gamut layer toggles render as disabled placeholders
until the async layer load lands, so waitFor(id) won the race on the
placeholder — added waitUntilEnabled and gate on isEnabled. The
project New test's ⌘N may not reach the CommandGroup and alert
buttons often lack identifiers on macOS 12 — drive New through the
File menu "New Project" item and confirm the alert by button title
with id fallback.

Refs #147 #149 #146

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Merge pull request 'test(m10): wait for gamut layer enable; drive New via File menu on macOS 12' (#158) from fix/m10-ci-ui-macos12 into milestone/m10-studio
macOS CI / build-and-test (pull_request) Failing after 32m15s
Details
macOS CI / package (pull_request) Skipped
Details
e967502ea7
gronod added 2 commits 2026-09-13 15:53:51 +01:00
test(m10): combine gamut layer toggle AX; harden gallery wait on macOS 12 f5c57649e1 
Run 33803 still reported the layer toggles disabled after a real
waitUntilEnabled: on macOS 12 the identifier lands on the Toggle's
container element, which never reports isEnabled — combine the
Toggle's children so the a11y leaf is the checkbox itself (checkbox
style unchanged). testPrinttargFixtureGalleryAndStubbedPrint flaked
once on the same runner: wait for btnCreateLayout enabled before
clicking and retry once when the gallery never materialises.

Refs #147 #149 #146

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Merge pull request 'test(m10): combine gamut layer toggle AX; harden gallery wait on macOS 12' (#159) from fix/m10-ci-ui-macos12 into milestone/m10-studio
macOS CI / package (pull_request) Blocked by required conditions
Details
macOS CI / build-and-test (pull_request) In progress
Details
9fcd21dc2d
Some checks are pending
macOS CI / package (pull_request) Blocked by required conditions
Details
macOS CI / build-and-test (pull_request) In progress
Details
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin milestone/m10-studio:milestone/m10-studio
git checkout milestone/m10-studio
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug/Architecture
Core / wizard / process infra defect
 Bug/Backend
Argyll orchestration, file/data defect
 Bug/DevOps
Build, packaging, CI defect
 Bug/UI
Views, controls, dialogs defect
 Compat/Breaking
Breaking change that won't be backward compatible
 Feature/Architecture
Core / wizard / process infra
 Feature/Backend
Argyll orchestration, file/data engines
 Feature/DevOps
Build, packaging, CI
 Feature/UI
Views, controls, dialogs
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Project/ICCery-v2
ICCery v2 Mac rewrite
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels Feature/Architecture Feature/Backend Feature/UI Kind/Feature
Priority
High
2
 Project/ICCery-v2
Milestone
No items
No Milestone M10 — Studio workflow (media library, gamut compare, spot-read, projects)
Projects
Clear projects
No projects
Assignees
Clear assignees
gronod
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gronod/iccery-v2-mac#156