gronod/iccery-v2-mac
1
0
Fork 0
Code Issues 5 Pull Requests 1 Actions Packages Projects Releases 4 Wiki Activity

fix(gamut): don't disable layer toggles when SceneKit is unavailable (#147) #160

Merged
gronod merged 1 commits from fix/147-gamut-toggle-disabled into milestone/m10-studio 2026-09-13 17:05:07 +01:00
Conversation 0 Commits 1 Files Changed 2
+12 -1
gronod commented 2026-09-13 17:04:38 +01:00
Owner
Copy Link
Copy Source

Layer toggles are data-driven: disable a toggle only when that layer has no mesh (layer == nil). viewerUnavailable now only controls the canvas — hides GamutSceneView and shows the gamutViewerUnavailable fallback text — so gamut chrome (toggles, inspect, status) stays usable on hosts without a GPU/SceneKit context, including the macOS 12 Actions runner.

Tests: waitUntilEnabled is now valid for gamutLayer-sRGB/gamutLayer-compare; compare toggle asserts value == 1 and status contains the layer name after both Open .gam and Open profile paths.

Refs #147 #146

Layer toggles are data-driven: disable a toggle only when that layer has no mesh (`layer == nil`). `viewerUnavailable` now only controls the canvas — hides `GamutSceneView` and shows the `gamutViewerUnavailable` fallback text — so gamut chrome (toggles, inspect, status) stays usable on hosts without a GPU/SceneKit context, including the macOS 12 Actions runner. Tests: `waitUntilEnabled` is now valid for `gamutLayer-sRGB`/`gamutLayer-compare`; compare toggle asserts `value == 1` and status contains the layer name after both Open .gam and Open profile paths. Refs #147 #146
gronod added the Kind/Bug
Priority
High
2
Project/ICCery-v2Feature/UI labels 2026-09-13 17:04:38 +01:00
gronod added 1 commit 2026-09-13 17:04:40 +01:00
fix(gamut): don't disable layer toggles when SceneKit is unavailable (#147) f16825be72 
Refs #147 #146
gronod added this to the M10 — Studio workflow (media library, gamut compare, spot-read, projects) milestone 2026-09-13 17:04:49 +01:00
gronod merged commit 14f9e6f78d into milestone/m10-studio 2026-09-13 17:05:07 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug/Architecture
Core / wizard / process infra defect
 Bug/Backend
Argyll orchestration, file/data defect
 Bug/DevOps
Build, packaging, CI defect
 Bug/UI
Views, controls, dialogs defect
 Compat/Breaking
Breaking change that won't be backward compatible
 Feature/Architecture
Core / wizard / process infra
 Feature/Backend
Argyll orchestration, file/data engines
 Feature/DevOps
Build, packaging, CI
 Feature/UI
Views, controls, dialogs
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Project/ICCery-v2
ICCery v2 Mac rewrite
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels Feature/UI Kind/Bug
Priority
High
2
 Project/ICCery-v2
Milestone
No items
No Milestone M10 — Studio workflow (media library, gamut compare, spot-read, projects)
Projects
Clear projects
No projects
Assignees
Clear assignees
gronod
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gronod/iccery-v2-mac#160