Gandalf/OctoPrint-Enclosure
1
0
Fork 0
Code Issues 156 Pull Requests 6 Actions Packages Projects Releases 28 Wiki Activity

Temporary fix for PWM, Spelling mistakes and debug messages #229

Merged
Tirpitz93 merged 22 commits from master into master 2019-03-28 19:19:39 +00:00
Conversation 0 Commits 22 Files Changed 3 +327 -503
Tirpitz93 commented 2019-03-28 17:11:52 +00:00 (Migrated from github.com)
Copy Link

PR attempts to fix:

  • PWM not working (fixed #226)
  • Debug messages not showing when using logging plugin to set log level (#227)
    • temperature and humidity still need to be set manually in enclosure setting page
  • Spelling errors: fixed a plethora of spelling mistakes in strings, comments and variable names.
  • added more debug messages to aid in debugging GPIO actions.

apologies for the mess of commits, I was testing via github to install on my octopi. Also pycharm "fixed" a lot of the code to PEP8 standards, so some formatting has gone from the code.

PR attempts to fix: - PWM not working (fixed #226) - Debug messages not showing when using logging plugin to set log level (#227) - temperature and humidity still need to be set manually in enclosure setting page - Spelling errors: fixed a plethora of spelling mistakes in strings, comments and variable names. - added more debug messages to aid in debugging GPIO actions. apologies for the mess of commits, I was testing via github to install on my octopi. Also pycharm "fixed" a lot of the code to PEP8 standards, so some formatting has gone from the code.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
documentation
duplicate
enhancement
help wanted
invalid
Missing Data
Missing necessary data to troubleshoot
 question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Gandalf
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Gandalf/OctoPrint-Enclosure#229
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?