gronod/talk-android
1
0
Fork 1
mirror of https://github.com/nextcloud/talk-android synced 2025-03-06 14:27:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid to fetchSignalingSettings in onMicrophoneClick

Browse Source 
this led to duplicated call of fetchSignalingSettings.
because it's already called from checkDevicePermissions().
From my pov it shouldn't be triggered in onMicrophoneClick() again, at least i can not think of any scenario and while testing everything worked as expected.

The duplicated call was there since ever(?), but after implementing #3216 this also caused the call duration timer to be run twice.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
This commit is contained in:
Marcel Hibbe 2023-07-28 13:46:28 +02:00
parent 87cff6fc80
commit 75c154acf3
No known key found for this signature in database
GPG Key ID: C793F8B59F43CE7B
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/java/com/nextcloud/talk/activities/CallActivity.kt
View File

@ -1050,9 +1050,6 @@ class CallActivity : CallBaseActivity() {
binding!!.microphoneButton.setImageResource(R.drawable.ic_mic_off_white_24px) binding!!.microphoneButton.setImageResource(R.drawable.ic_mic_off_white_24px)
toggleMedia(false, false) toggleMedia(false, false)
} }
if (isVoiceOnlyCall && !isConnectionEstablished) {
fetchSignalingSettings()
}
if (!canPublishAudioStream) { if (!canPublishAudioStream) {
// In the case no audio stream will be published it's not needed to check microphone permissions // In the case no audio stream will be published it's not needed to check microphone permissions
return return