From 75c154acf3f2d372abaa707d72105d030d827063 Mon Sep 17 00:00:00 2001 From: Marcel Hibbe Date: Fri, 28 Jul 2023 13:46:28 +0200 Subject: [PATCH] Avoid to fetchSignalingSettings in onMicrophoneClick this led to duplicated call of fetchSignalingSettings. because it's already called from checkDevicePermissions(). From my pov it shouldn't be triggered in onMicrophoneClick() again, at least i can not think of any scenario and while testing everything worked as expected. The duplicated call was there since ever(?), but after implementing #3216 this also caused the call duration timer to be run twice. Signed-off-by: Marcel Hibbe --- .../main/java/com/nextcloud/talk/activities/CallActivity.kt | 3 --- 1 file changed, 3 deletions(-) diff --git a/app/src/main/java/com/nextcloud/talk/activities/CallActivity.kt b/app/src/main/java/com/nextcloud/talk/activities/CallActivity.kt index a334c6f26..8e7ca273e 100644 --- a/app/src/main/java/com/nextcloud/talk/activities/CallActivity.kt +++ b/app/src/main/java/com/nextcloud/talk/activities/CallActivity.kt @@ -1050,9 +1050,6 @@ class CallActivity : CallBaseActivity() { binding!!.microphoneButton.setImageResource(R.drawable.ic_mic_off_white_24px) toggleMedia(false, false) } - if (isVoiceOnlyCall && !isConnectionEstablished) { - fetchSignalingSettings() - } if (!canPublishAudioStream) { // In the case no audio stream will be published it's not needed to check microphone permissions return