gronod/talk-android
1
0
Fork 1
mirror of https://github.com/nextcloud/talk-android synced 2025-06-20 03:59:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add comment for refactoring FileViewerUtils

Browse Source 
Signed-off-by: Tim Krüger <t@timkrueger.me>
This commit is contained in:
Tim Krüger 2022-05-19 17:20:26 +02:00
parent 0d65824fa6
commit 52ec1b76fa
No known key found for this signature in database
GPG Key ID: FECE3A7222C52A4E
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/main/java/com/nextcloud/talk/shareditems/adapters/SharedItemsViewHolder.kt
View File

@ -48,6 +48,12 @@ abstract class SharedItemsViewHolder(
image.controller = configurePreview(item) image.controller = configurePreview(item)
} }
/*
The FileViewerUtils forces us to do things at this points which should be done separated in the activity and
the view model.
This should be done after a refactoring of FileViewerUtils.
*/
val fileViewerUtils = FileViewerUtils(image.context, userEntity) val fileViewerUtils = FileViewerUtils(image.context, userEntity)
clickTarget.setOnClickListener { clickTarget.setOnClickListener {

6
app/src/main/java/com/nextcloud/talk/utils/FileViewerUtils.kt
View File

@ -52,6 +52,12 @@ import com.nextcloud.talk.utils.bundle.BundleKeys.KEY_FILE_ID
import java.io.File import java.io.File
import java.util.concurrent.ExecutionException import java.util.concurrent.ExecutionException
/*
Usage of this class forces us to do things at one location which should be separated in a activity and view model.
Example:
- SharedItemsViewHolder
*/
class FileViewerUtils(private val context: Context, private val userEntity: UserEntity) { class FileViewerUtils(private val context: Context, private val userEntity: UserEntity) {
fun openFile( fun openFile(