From 52ec1b76faaff2c0edc45ce711c0cd91c04bdf3c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20Kr=C3=BCger?= Date: Thu, 19 May 2022 17:20:26 +0200 Subject: [PATCH] Add comment for refactoring FileViewerUtils MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Tim Krüger --- .../talk/shareditems/adapters/SharedItemsViewHolder.kt | 6 ++++++ .../main/java/com/nextcloud/talk/utils/FileViewerUtils.kt | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/app/src/main/java/com/nextcloud/talk/shareditems/adapters/SharedItemsViewHolder.kt b/app/src/main/java/com/nextcloud/talk/shareditems/adapters/SharedItemsViewHolder.kt index a3d2a3dc3..d8c9dbf3a 100644 --- a/app/src/main/java/com/nextcloud/talk/shareditems/adapters/SharedItemsViewHolder.kt +++ b/app/src/main/java/com/nextcloud/talk/shareditems/adapters/SharedItemsViewHolder.kt @@ -48,6 +48,12 @@ abstract class SharedItemsViewHolder( image.controller = configurePreview(item) } + /* + The FileViewerUtils forces us to do things at this points which should be done separated in the activity and + the view model. + + This should be done after a refactoring of FileViewerUtils. + */ val fileViewerUtils = FileViewerUtils(image.context, userEntity) clickTarget.setOnClickListener { diff --git a/app/src/main/java/com/nextcloud/talk/utils/FileViewerUtils.kt b/app/src/main/java/com/nextcloud/talk/utils/FileViewerUtils.kt index f3eaf5b34..03c7fca0f 100644 --- a/app/src/main/java/com/nextcloud/talk/utils/FileViewerUtils.kt +++ b/app/src/main/java/com/nextcloud/talk/utils/FileViewerUtils.kt @@ -52,6 +52,12 @@ import com.nextcloud.talk.utils.bundle.BundleKeys.KEY_FILE_ID import java.io.File import java.util.concurrent.ExecutionException +/* +Usage of this class forces us to do things at one location which should be separated in a activity and view model. + +Example: + - SharedItemsViewHolder + */ class FileViewerUtils(private val context: Context, private val userEntity: UserEntity) { fun openFile(