gronod/iccery-v2-mac
1
0
Fork 0
Code Issues 5 Pull Requests 1 Actions 1 Packages Projects Releases 4 Wiki Activity

#85 Split PrintSessionViewModel onto milestone/M7-grok #93

Closed
gronod wants to merge 0 commits from feat/85-print-session into milestone/M7-grok
pull from: feat/85-print-session
merge into: :milestone/M7-grok
Conversation 1 Commits - Files Changed -
gronod commented 2026-09-10 18:48:38 +01:00
Owner
Copy Link
Copy Source

Summary

Applies print-session split onto milestone/M7-grok.

Fixes #85.

Stacked with #79–#86 in d4261ba. Merge one M7 PR; close the rest after.

#85 scope

  • PrintSessionViewModel owns CUPS/spool state
  • Stage 2 binds workflow.print
  • Accessibility ids unchanged
## Summary Applies print-session split onto `milestone/M7-grok`. Fixes #85. Stacked with #79–#86 in `d4261ba`. Merge one M7 PR; close the rest after. ## #85 scope - `PrintSessionViewModel` owns CUPS/spool state - Stage 2 binds `workflow.print` - Accessibility ids unchanged
gronod added this to the M7 — Deduplicate & consolidate (develop) milestone 2026-09-10 18:48:38 +01:00
gronod self-assigned this 2026-09-10 18:48:38 +01:00
gronod added 1 commit 2026-09-10 18:48:39 +01:00
Implement M7 consolidation (#79–#86) d4261ba2c9 
Extract ArgyllRunner.runStreamingTool and collapse toolFailed errors.
Share ProcessManager process factory and ROW_COLORS_JSON emission.
Add JSONFileStore, CalibrationIdentity, PresetMapping, and ArgsBuilder.
Unify Notice-backed print/finish banners, ProcessLogView, and log sinks.
Split PrintSessionViewModel out of TargetWorkflowViewModel.
Merge XYZ/Lab Codable types, drop StagePlaceholderView, and add unit tests.
gronod commented 2026-09-10 20:24:20 +01:00
Author
Owner
Copy Link
Copy Source

Landed on milestone/M7-grok with #87. All feat/79–86 branches pointed at the same stacked commit d4261ba; the merge commit is 118b77b4419d556e8eec7adacea33c7c23b5affa. Marking this PR merged onto that tip.

Landed on `milestone/M7-grok` with #87. All feat/79–86 branches pointed at the same stacked commit `d4261ba`; the merge commit is `118b77b4419d556e8eec7adacea33c7c23b5affa`. Marking this PR merged onto that tip.
gronod closed this pull request 2026-09-10 20:24:21 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug/Architecture
Core / wizard / process infra defect
 Bug/Backend
Argyll orchestration, file/data defect
 Bug/DevOps
Build, packaging, CI defect
 Bug/UI
Views, controls, dialogs defect
 Compat/Breaking
Breaking change that won't be backward compatible
 Feature/Architecture
Core / wizard / process infra
 Feature/Backend
Argyll orchestration, file/data engines
 Feature/DevOps
Build, packaging, CI
 Feature/UI
Views, controls, dialogs
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Project/ICCery-v2
ICCery v2 Mac rewrite
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels Feature/Architecture Feature/UI Kind/Enhancement
Priority
Medium
3
 Project/ICCery-v2
Milestone
No items
No Milestone M7 — Deduplicate & consolidate (develop)
Projects
Clear projects
No projects
Assignees
Clear assignees
gronod
No Assignees gronod
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gronod/iccery-v2-mac#93