The AboutHelp UI test still failed on the self-hosted runner because the close-button query was scoped to app.sheets.firstMatch.buttons["closeAboutBtn"]. SwiftUI .sheet on macOS is not exposed as an XCUIElement sheet in this build, so the helper returned nil.
Use the existing waitFor(_:timeout:) helper to search the entire app hierarchy for closeAboutBtn.
Keep the launchApp() foreground-wait pattern that already stabilised app.activate().
This is a follow-up to the earlier UI-test fixes for run #28967.
The AboutHelp UI test still failed on the self-hosted runner because the close-button query was scoped to `app.sheets.firstMatch.buttons["closeAboutBtn"]`. SwiftUI `.sheet` on macOS is not exposed as an XCUIElement `sheet` in this build, so the helper returned nil.
- Use the existing `waitFor(_:timeout:)` helper to search the entire app hierarchy for `closeAboutBtn`.
- Keep the `launchApp()` foreground-wait pattern that already stabilised `app.activate()`.
This is a follow-up to the earlier UI-test fixes for run `#28967`.
Labels: `Project/ICCery-v2`, `Bug/DevOps`, `Priority/Critical`.
The previous sheet-scoped query did not resolve on the runner. Use the
existing waitFor helper to locate closeAboutBtn anywhere in the app and
remove the redundant immediate activation call.
Refs gronod/iccery-v2-mac#72
The outer VStack was missing .accessibilityElement(children: .contain),
so the close button identifier was not visible to XCUITest on the runner.
Add the container modifier to match other dialog views and keep the
aboutDialog identifier usable by tests.
Refs gronod/iccery-v2-mac#75
gronod
merged commit f7ba49d3d5 into develop2026-09-10 08:07:37 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The AboutHelp UI test still failed on the self-hosted runner because the close-button query was scoped to
app.sheets.firstMatch.buttons["closeAboutBtn"]. SwiftUI.sheeton macOS is not exposed as an XCUIElementsheetin this build, so the helper returned nil.waitFor(_:timeout:)helper to search the entire app hierarchy forcloseAboutBtn.launchApp()foreground-wait pattern that already stabilisedapp.activate().This is a follow-up to the earlier UI-test fixes for run
#28967.Labels:
Project/ICCery-v2,Bug/DevOps,Priority/Critical.