gronod/iccery-v2-mac
1
0
Fork 0
Code Issues 21 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Native NSPrintPanel bound to selected queue (#13) #44

Merged
gronod merged 1 commits from feat/13-nsprintpanel into milestone/m3-printing 2026-09-09 00:14:54 +01:00
Conversation 0 Commits 1 Files Changed 4
+280 -1
gronod commented 2026-09-09 00:14:22 +01:00
Owner
Copy Link
Copy Source

Native NSPrintPanel bound to the selected CUPS queue via PMPrinterCreateFromPrinterID → PMSessionSetCurrentPMPrinter → session defaults — never System Settings, CUPS web UI, or NSWorkspace (#188).

  • Default button “Use Settings” (settings capture, not print); cancel → nil, not an error.
  • NSPrinter(name: displayName) fallback (from lpoptions printer-info) when PM binding fails; PMRelease on every path via defer.
  • UITestHooks panel stub (ICCERY_TEST_PRINT_PANEL=ok|cancel + PANEL_OPTIONS/PANEL_PRINTER) and ICCERY_CUPS_BIN_DIR for mock CUPS binaries — XCUITest can't drive the modal.
  • Layers ②–⑥ (ColorSync suppression + capture) land in issue 14 between binding and runModal.

Tests: PrintPanelStubTests cover cancel→nil, ok→result, default printer mapping. Panel-on-hardware PDE check is the M3 hardware gate.

Closes #13.

Generated with Devin

Native `NSPrintPanel` bound to the selected CUPS queue via `PMPrinterCreateFromPrinterID` → `PMSessionSetCurrentPMPrinter` → session defaults — never System Settings, CUPS web UI, or `NSWorkspace` (#188). - Default button **“Use Settings”** (settings capture, not print); cancel → `nil`, not an error. - `NSPrinter(name: displayName)` fallback (from `lpoptions` `printer-info`) when PM binding fails; `PMRelease` on every path via `defer`. - `UITestHooks` panel stub (`ICCERY_TEST_PRINT_PANEL=ok|cancel` + `PANEL_OPTIONS`/`PANEL_PRINTER`) and `ICCERY_CUPS_BIN_DIR` for mock CUPS binaries — XCUITest can't drive the modal. - Layers ②–⑥ (ColorSync suppression + capture) land in issue 14 between binding and `runModal`. Tests: `PrintPanelStubTests` cover cancel→nil, ok→result, default printer mapping. Panel-on-hardware PDE check is the M3 hardware gate. Closes #13. Generated with [Devin](https://devin.ai)
gronod added 1 commit 2026-09-09 00:14:23 +01:00
Native NSPrintPanel bound to selected queue (#13) 4281d07754 
- PrintPanelService: PMPrinterCreateFromPrinterID(CUPS queue id) ->
  PMSessionSetCurrentPMPrinter -> session default settings/page format.
- NSPrinter(name: displayName) fallback when PM binding fails; display
  name resolved via lpoptions printer-info (docs/11 #188).
- Default button 'Use Settings' (capture, not print); cancel -> nil.
- PMPrinter released on every path via defer.
- UITestHooks: printPanelResult stub (ICCERY_TEST_PRINT_PANEL=ok/cancel
  + PANEL_OPTIONS/PANEL_PRINTER), printPanelStubbed gate, cupsBinaryDir
  + lpArgvOutURL env seams; CupsService injected via AppEnvironment.

Never opens System Settings / CUPS web UI / NSWorkspace.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
gronod merged commit 14f521a65e into milestone/m3-printing 2026-09-09 00:14:54 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug/Architecture
Core / wizard / process infra defect
 Bug/Backend
Argyll orchestration, file/data defect
 Bug/DevOps
Build, packaging, CI defect
 Bug/UI
Views, controls, dialogs defect
 Compat/Breaking
Breaking change that won't be backward compatible
 Feature/Architecture
Core / wizard / process infra
 Feature/Backend
Argyll orchestration, file/data engines
 Feature/DevOps
Build, packaging, CI
 Feature/UI
Views, controls, dialogs
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Project/ICCery-v2
ICCery v2 Mac rewrite
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels Feature/Backend Feature/UI Kind/Feature
Priority
Critical
1
 Project/ICCery-v2
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
gronod
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gronod/iccery-v2-mac#44