gronod/iccery-v2-mac
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions 1 Packages Projects Releases 1 Wiki Activity

Milestone 11 — Printer settings completeness & dialog binding (#183, #180, #181, #186) #199

Open
gronod wants to merge 11 commits from milestone/m11-print-settings into develop
pull from: milestone/m11-print-settings
merge into: :develop
Conversation 0 Commits 11 Files Changed 18
+1576 -34
gronod commented 2026-09-15 22:26:03 +01:00
Owner
Copy Link
Copy Source

This PR is opened for CI only — merge is DEFERRED to a later session pending the Actions run and the hardware gate (R6/R12). Do not merge.

Issue completion matrix

Issue Summary Feature PR Merge tip
#183 Stage 2 paper-size + quality selection: CUPS caps parse, LpArgs emit, picker UI #193 51c3073
#180 Epson EPIJ_Qual seven-option quality enumeration with driver order + PPD labels #194 c9b423b
#181 Canon PPD locale precedence (unqualified > en_US > en > first-qualified), UTF-8-first/Latin-1-fallback decode, <XX> hex escapes #195 1767792
#186 NSPrintPanel bound to selected queue with paper/quality/media/orientation preselected + capture-return #196 6adbf99

Integration commits on this head

  • Phase 6.0 docs hygiene — PR #197 (docs/21 a11y-id roster: paperSizeGroup, printerPaperSizeSelect, qualityGroup, printerQualitySelect)
  • Phase 6 develop sync — PR #198 (merged origin/develop@62a45d9 in via chore/m11-sync-develop, tree-empty, no rebase)

Gate evidence

Full host-arch gate on this exact head SHA 19f619ad98fc8a5c18481517388e29e4033326fc (x86_64):

  • ICCeryCoreTests: 483 passed / 0 failed
  • ICCeryUITests: 67 passed / 0 failed — real ICCeryUITests.xctest pass summary, no UI-skip warning
  • Log: build/m11-sync-gate.log

Phase 5 milestone gate at 6adbf99 (pre-sync, same tree): Core 483/0, UI 67/0.

Deferred

  • Hardware gate (real Epson EPIJ_Qual enumeration, real Canon Pro9500 media labels, driver-PDE preselect acceptance via capture echo, lp argv) — milestone exit gate, not a PR blocker.
  • Milestone 34 remains open.

Refs #183
Refs #180
Refs #181
Refs #186

**This PR is opened for CI only — merge is DEFERRED to a later session pending the Actions run and the hardware gate (R6/R12). Do not merge.** ## Issue completion matrix | Issue | Summary | Feature PR | Merge tip | |---|---|---|---| | #183 | Stage 2 paper-size + quality selection: CUPS caps parse, `LpArgs` emit, picker UI | #193 | `51c3073` | | #180 | Epson `EPIJ_Qual` seven-option quality enumeration with driver order + PPD labels | #194 | `c9b423b` | | #181 | Canon PPD locale precedence (unqualified > en_US > en > first-qualified), UTF-8-first/Latin-1-fallback decode, `<XX>` hex escapes | #195 | `1767792` | | #186 | NSPrintPanel bound to selected queue with paper/quality/media/orientation preselected + capture-return | #196 | `6adbf99` | ## Integration commits on this head - Phase 6.0 docs hygiene — PR #197 (`docs/21` a11y-id roster: `paperSizeGroup`, `printerPaperSizeSelect`, `qualityGroup`, `printerQualitySelect`) - Phase 6 develop sync — PR #198 (merged `origin/develop@62a45d9` in via `chore/m11-sync-develop`, tree-empty, no rebase) ## Gate evidence Full host-arch gate on this exact head SHA `19f619ad98fc8a5c18481517388e29e4033326fc` (x86_64): - ICCeryCoreTests: **483 passed / 0 failed** - ICCeryUITests: **67 passed / 0 failed** — real `ICCeryUITests.xctest` pass summary, no UI-skip warning - Log: `build/m11-sync-gate.log` Phase 5 milestone gate at `6adbf99` (pre-sync, same tree): Core 483/0, UI 67/0. ## Deferred - Hardware gate (real Epson `EPIJ_Qual` enumeration, real Canon Pro9500 media labels, driver-PDE preselect acceptance via capture echo, `lp` argv) — milestone exit gate, not a PR blocker. - Milestone 34 remains open. Refs #183 Refs #180 Refs #181 Refs #186
gronod added 11 commits 2026-09-15 22:26:05 +01:00
feat(print): Stage 2 paper size + quality selection (#183)
macOS CI / build-and-test (push) Skipped
37d1f7eb24 
Devin-AI: Devin <devin@cognition.ai>
Co-authored-by: Devin <devin@cognition.ai>
Merge pull request 'feat(print): Stage 2 paper size + quality selection (#183)' (#193) from feat/183-stage2-print-settings into milestone/m11-print-settings
macOS CI / build-and-test (push) Skipped
51c30737c7
fix(print): enumerate all EPIJ_Qual quality options (#180)
macOS CI / build-and-test (push) Skipped
79209eb911 
The Phase 1 (#183) quality plumbing already covers detection,
extraction, capture, and lp emission — this change proves the Epson
path end-to-end with recorded fixtures.

- CupsParserTests: replace the synthetic cupsPrintQuality listing with
  the recorded XP-55 line (301 302 *303 308 304 305 307 — driver order,
  308 between 303 and 304); assert all seven ids enumerate unsorted,
  the * default is 303, all seven PPD labels resolve, and EPIJ_Qual
  wins detection over OutputMode/Resolution (R11).
- CupsOptionsFilterTests: captured EPIJ_Qual + canonical quality keys
  survive the filter (roster verified complete post-#183 — no source
  change needed; EPIJ_Quality kept as harmless alias, R16).
- LpArgsTests: explicit quality 305 emits -o EPIJ_Qual=305.
- PrintSessionViewModelTests + UI lpoptions fixture: recorded
  seven-choice line feeds the picker; Stage 2 picker lists all seven
  entries in driver order (new UI test).

Devin-AI: Devin <devin@cognition.ai>
Co-authored-by: Devin <devin@cognition.ai>
Merge pull request 'fix(print): enumerate all EPIJ_Qual quality options (#180)' (#194) from feat/180-epson-qual-options into milestone/m11-print-settings
macOS CI / build-and-test (push) Skipped
c9b423b229
fix(print): deterministic PPD locale precedence for media labels (#181)
macOS CI / build-and-test (push) Skipped
e8678586bd 
Refs #181

Co-Authored-By: Devin <devin@cognition.ai>
Merge pull request 'fix(print): deterministic PPD locale precedence for media labels (#181)' (#195) from feat/181-canon-media-locale into milestone/m11-print-settings
macOS CI / build-and-test (push) Skipped
1767792f75
fix(print): bind selected printer and settings in NSPrintPanel (#186)
macOS CI / build-and-test (push) Skipped
d8c41444b9 
Refs #186

Co-Authored-By: Devin <devin@cognition.ai>
Merge pull request 'fix(print): bind selected printer and settings in NSPrintPanel (#186)' (#196) from feat/186-panel-binding into milestone/m11-print-settings
macOS CI / build-and-test (push) Skipped
6adbf99bd9
docs(ui): add M11 printer settings a11y ids to stage-2 roster
macOS CI / build-and-test (push) Skipped
d228594bd3 
Refs #183
Merge pull request 'docs(ui): M11 stage-2 a11y id roster update' (#197) from chore/m11-docs-hygiene into milestone/m11-print-settings
macOS CI / build-and-test (push) Skipped
09f466ae46
Merge branch 'develop' into chore/m11-sync-develop
macOS CI / build-and-test (push) Skipped
macOS CI / package (pull_request) Blocked by required conditions
Details
macOS CI / build-and-test (pull_request) In progress
Details
19f619ad98
Some checks are pending
macOS CI / build-and-test (push) Skipped
macOS CI / package (pull_request) Blocked by required conditions
Details
macOS CI / build-and-test (pull_request) In progress
Details
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin milestone/m11-print-settings:milestone/m11-print-settings
git checkout milestone/m11-print-settings
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug/Architecture
Core / wizard / process infra defect
 Bug/Backend
Argyll orchestration, file/data defect
 Bug/DevOps
Build, packaging, CI defect
 Bug/UI
Views, controls, dialogs defect
 Compat/Breaking
Breaking change that won't be backward compatible
 Feature/Architecture
Core / wizard / process infra
 Feature/Backend
Argyll orchestration, file/data engines
 Feature/DevOps
Build, packaging, CI
 Feature/UI
Views, controls, dialogs
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Project/ICCery-v2
ICCery v2 Mac rewrite
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels Bug/Backend Bug/UI Feature/UI Kind/Feature
Priority
High
2
Priority
Medium
3
 Project/ICCery-v2
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
gronod
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gronod/iccery-v2-mac#199