fix(ui): settings sheet — ΔE clip + duplicated numeric-field labels (#165) #166

Merged

gronod merged 5 commits from fix/165-settings-deltae-clip into develop 2026-09-14 07:57:01 +01:00

Conversation 0 Commits 5 Files Changed 3

+220 -29

5 Commits

Author	SHA1	Message	Date
gronod	8b931e3625	fix(ui): settings numeric fields no longer render default value as inline label (#165) ... - TextField("30"/"2.0"/"5.0") passed the default value as the label, which macOS draws inline next to the box — the rows read "Stale after 30 [30] days" / "Good ΔE ≤ 2.0 [2.0]". - The three fields are now direct Form children carrying their descriptive label, so it renders once in the label column and the box fills the control column, matching the Pickers. The stale-days row folds "days" into the label ("Stale after (days)"). - New identifier settingsCalStaleDays; docs/21 roster 357→358. - New testNumericFieldsCarryLabelsNotDuplicatedValues asserts each field's value, a single label-column staticText, and no staticText echoing the old label literal. testVerificationRowsStayInsideSheet updated for label-column geometry (fields end ~3.5 pt inside the sheet, same as the PopUpButtons — the 12 pt inset only applied to the old 60 pt boxes). Refs #165	2026-09-14 02:05:06 +01:00
gronod	73b18dec5b	test(settings): drop waitForNonExistence for Xcode 14.2 CI (#165) ... waitForNonExistence requires the macOS 14 SDK XCTest; the macos-12 runner toolchain has no such member on XCUIElement. Poll sheet.exists on the run loop instead, matching the waitForGone pattern in Milestone10GamutCompareUITests.	2026-09-14 01:08:01 +01:00
gronod	3bc0d14a34	test(settings): add Foundation import and simplify column alignment assertion	2026-09-14 00:46:32 +01:00
gronod	4aa2815c6e	test(settings): use abs diff instead of accuracy for Swift 5.7 compatibility	2026-09-14 00:42:32 +01:00
gronod	8596f15d52	fix(ui): settings ΔE threshold rows no longer clip the sheet edge (#165) ... - Split Section("Verification") from one 4-across non-wrapping HStack into two adjacent label+field rows (#settingsDeltaEGood, #settingsDeltaEWarning). - Add .padding(.leading, 45) to the Settings Form so the control column aligns at ~522 pt, matching develop, and all labels have 41–100 pt breathing room from the left boundary. - Add SettingsUITests with frame-containment, control alignment, and validation/save round-trip coverage. - Update docs/21-ui-reference.md Settings entry with new identifiers. Refs #165	2026-09-14 00:34:35 +01:00