fix(ui): calibrate dashboard no longer overflows window; Escape exits (#163) #164

Merged
gronod merged 1 commits from fix/163-cal-view-overflow into develop 2026-09-13 23:16:34 +01:00
Owner

Summary

Fixes the Stage 0 calibration dashboard overflowing the window (pushing the sidebar off-screen) and adds Escape dismissal to Return to Profiling.

  • Constrain RootView right content column with .frame(maxWidth: .infinity, maxHeight: .infinity) so child ideal width does not expand the root HStack.
  • Rebuild CalibrationView using ScrollView and section cards matching Stages 1–5 (removing Form and expanding spacers).
  • Use ProcessLogView for the calibration process log.
  • Add .keyboardShortcut(.cancelAction) to #btnCalReturn.
  • Add .accessibilityElement(children: .contain) and stage-cal identifier to CalibrationView.
  • Update docs/21-ui-reference.md Stage 0 identifier list (btnCalReturn, calNeutralEmphasis).
  • Add UI tests in Milestone6CalibrationUITests verifying sidebar frame on-screen bounds and Return button / Escape dismissal.

Verification

  • Targeted suite: Milestone6CalibrationUITests (4/4 passed in 71.9s)
  • Interactive layout rendered as expected

Refs #163

### Summary Fixes the Stage 0 calibration dashboard overflowing the window (pushing the sidebar off-screen) and adds Escape dismissal to Return to Profiling. - Constrain `RootView` right content column with `.frame(maxWidth: .infinity, maxHeight: .infinity)` so child ideal width does not expand the root `HStack`. - Rebuild `CalibrationView` using `ScrollView` and section cards matching Stages 1–5 (removing `Form` and expanding spacers). - Use `ProcessLogView` for the calibration process log. - Add `.keyboardShortcut(.cancelAction)` to `#btnCalReturn`. - Add `.accessibilityElement(children: .contain)` and `stage-cal` identifier to `CalibrationView`. - Update `docs/21-ui-reference.md` Stage 0 identifier list (`btnCalReturn`, `calNeutralEmphasis`). - Add UI tests in `Milestone6CalibrationUITests` verifying sidebar frame on-screen bounds and Return button / Escape dismissal. ### Verification - Targeted suite: `Milestone6CalibrationUITests` (4/4 passed in 71.9s) - Interactive layout rendered as expected Refs #163
gronod added the Kind/Bug
Priority
High
2
Project/ICCery-v2Bug/UI
labels 2026-09-13 22:16:13 +01:00
gronod added 1 commit 2026-09-13 22:16:14 +01:00
fix(ui): calibrate dashboard no longer overflows window; Escape exits (#163)
macOS CI / build-and-test (pull_request) Successful in 6m4s
macOS CI / package (pull_request) Skipped
macOS CI / build-and-test (push) Canceled after 1m44s
macOS CI / package (push) Skipped
407136c5a2
gronod merged commit 407136c5a2 into develop 2026-09-13 23:16:34 +01:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gronod/iccery-v2-mac#164