gronod/iccery-v2-mac
1
0
Fork 0
Code Issues 2 Pull Requests Actions 1 Packages Projects Releases 3 Wiki Activity

fix(m9): revert sidebar container a11y id; measure presetSelect frame (#130) #131

Merged
gronod merged 1 commits from feat/130-sidebar-a11y-revert into milestone/m9-monterey 2026-09-12 12:37:40 +01:00
Conversation 0 Commits 1 Files Changed 2
+9 -7
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Sources/ICCery/SidebarView.swift
-1
View File
@@ -129,7 +129,6 @@ struct SidebarView: View {
} }
.frame(width: Theme.Metrics.sidebarWidth) .frame(width: Theme.Metrics.sidebarWidth)
.background(Theme.panel) .background(Theme.panel)
.accessibilityIdentifier("sidebar")
} }
} }
Tests/ICCeryUITests/AboutHelpUITests.swift
+9 -6
View File
@@ -69,15 +69,18 @@ final class AboutHelpUITests: XCTestCase {
let toggle = app.buttons["btnToggleAllHelp"] let toggle = app.buttons["btnToggleAllHelp"]
XCTAssertTrue(toggle.waitForExistence(timeout: 10)) XCTAssertTrue(toggle.waitForExistence(timeout: 10))
let sidebar = app.descendants(matching: .any)["sidebar"] // SDK 13.1 emits no AXGroup for the sidebar root, and an
XCTAssertTrue(sidebar.waitForExistence(timeout: 10)) // identifier on the container clobbers child identifiers
let before = sidebar.frame // (#130) — measure a stable sidebar child instead.
let sidebarChild = app.descendants(matching: .any)["presetSelect"]
XCTAssertTrue(sidebarChild.waitForExistence(timeout: 10))
let before = sidebarChild.frame
toggle.click() toggle.click()
let after = sidebar.frame let after = sidebarChild.frame
XCTAssertEqual(before.size.height, after.size.height, XCTAssertEqual(before, after,
"Toggling global help must not reflow the sidebar height.") "Toggling global help must not reflow the sidebar.")
XCTAssertTrue(app.descendants(matching: .any)["openSettingsBtn"].exists) XCTAssertTrue(app.descendants(matching: .any)["openSettingsBtn"].exists)
} }
} }