From a975f1a4e4638dc0684a10c4928fadd98d37a7b2 Mon Sep 17 00:00:00 2001 From: Gronod Date: Sat, 12 Sep 2026 12:37:21 +0100 Subject: [PATCH] fix(m9): revert sidebar container a11y id; measure presetSelect frame (#130) On SDK 13.1 the 'sidebar' identifier on the root VStack propagates to every child, erasing openSettingsBtn/openAboutBtn/btnToggleAllHelp (a11y dump, run 32201). Revert it; the test now compares presetSelect frame before/after toggling help overlays. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> --- Sources/ICCery/SidebarView.swift | 1 - Tests/ICCeryUITests/AboutHelpUITests.swift | 15 +++++++++------ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/Sources/ICCery/SidebarView.swift b/Sources/ICCery/SidebarView.swift index f7928b0..0c4d3c1 100644 --- a/Sources/ICCery/SidebarView.swift +++ b/Sources/ICCery/SidebarView.swift @@ -129,7 +129,6 @@ struct SidebarView: View { } .frame(width: Theme.Metrics.sidebarWidth) .background(Theme.panel) - .accessibilityIdentifier("sidebar") } } diff --git a/Tests/ICCeryUITests/AboutHelpUITests.swift b/Tests/ICCeryUITests/AboutHelpUITests.swift index 2a6ba18..4fcd1af 100644 --- a/Tests/ICCeryUITests/AboutHelpUITests.swift +++ b/Tests/ICCeryUITests/AboutHelpUITests.swift @@ -69,15 +69,18 @@ final class AboutHelpUITests: XCTestCase { let toggle = app.buttons["btnToggleAllHelp"] XCTAssertTrue(toggle.waitForExistence(timeout: 10)) - let sidebar = app.descendants(matching: .any)["sidebar"] - XCTAssertTrue(sidebar.waitForExistence(timeout: 10)) - let before = sidebar.frame + // SDK 13.1 emits no AXGroup for the sidebar root, and an + // identifier on the container clobbers child identifiers + // (#130) — measure a stable sidebar child instead. + let sidebarChild = app.descendants(matching: .any)["presetSelect"] + XCTAssertTrue(sidebarChild.waitForExistence(timeout: 10)) + let before = sidebarChild.frame toggle.click() - let after = sidebar.frame + let after = sidebarChild.frame - XCTAssertEqual(before.size.height, after.size.height, - "Toggling global help must not reflow the sidebar height.") + XCTAssertEqual(before, after, + "Toggling global help must not reflow the sidebar.") XCTAssertTrue(app.descendants(matching: .any)["openSettingsBtn"].exists) } } -- 2.39.5