gronod/iccery-v2-mac
1
0
Fork 0
Code Issues 21 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

File dialogs — dedicated pickers + host helpers (#6, part 2) #37

Merged
gronod merged 1 commits from feat/6-file-dialogs into milestone/m1-foundation 2026-09-08 19:09:42 +01:00
Conversation 0 Commits 1 Files Changed 5
+298 -41
gronod commented 2026-09-08 19:09:33 +01:00
Owner
Copy Link
Copy Source

Completes issue #6 — the first PR missed several dedicated helpers; issue was reopened.

  • One dedicated method per purpose, no shared generic picker (#103/#210/#211): selectTargetFile (save .ti1), selectExistingTarget (.ti1/.ti2), selectProfileFile (.icc/.icm/.mpp, never .ti* — #172), selectSpectrumFile (.sp), selectDatasetFile (open-only .ti3/.txt/.cgats/.csv — #211), selectCsvSavePath, selectCalFile, selectDirectory.
  • Ti2Header: TARGET_INSTRUMENT, NUMBER_OF_SETS → patchCount, NUMBER_OF_PAGES, sibling .ti1 detection; NUMBER_OF_FIELDS explicitly not the patch count.
  • TiffPreview: host-side TIFF→PNG, 1200 px max edge via ImageIO (#58).
  • ArtefactFiles: defaultWorkingDirectory (resolveSafeCwd), readBase64, appInfo.

Verified: 47/47 tests pass (incl. real generated-TIFF thumbnail + ti2 fixtures).

Closes #6

Completes issue #6 — the first PR missed several dedicated helpers; issue was reopened. - One dedicated method per purpose, no shared generic picker (#103/#210/#211): `selectTargetFile` (save `.ti1`), `selectExistingTarget` (`.ti1`/`.ti2`), `selectProfileFile` (`.icc`/`.icm`/`.mpp`, never `.ti*` — #172), `selectSpectrumFile` (`.sp`), `selectDatasetFile` (open-only `.ti3`/`.txt`/`.cgats`/`.csv` — #211), `selectCsvSavePath`, `selectCalFile`, `selectDirectory`. - `Ti2Header`: `TARGET_INSTRUMENT`, `NUMBER_OF_SETS` → patchCount, `NUMBER_OF_PAGES`, sibling `.ti1` detection; `NUMBER_OF_FIELDS` explicitly not the patch count. - `TiffPreview`: host-side TIFF→PNG, 1200 px max edge via ImageIO (#58). - `ArtefactFiles`: `defaultWorkingDirectory` (resolveSafeCwd), `readBase64`, `appInfo`. Verified: 47/47 tests pass (incl. real generated-TIFF thumbnail + ti2 fixtures). Closes #6
gronod added the
Priority
Medium
3
Project/ICCery-v2Feature/Backend labels 2026-09-08 19:09:33 +01:00
gronod added 1 commit 2026-09-08 19:09:34 +01:00
File dialogs & artefact helpers — dedicated pickers + host helpers (#6) 2a608c8962 
- One dedicated method per purpose: selectTargetFile (save .ti1),
  selectExistingTarget (ti1/ti2), selectProfileFile (icc/icm/mpp —
  never ti*, #172), selectSpectrumFile (.sp), selectDatasetFile
  (open-only ti3/txt/cgats/csv, #211), selectCsvSavePath, selectCalFile,
  selectDirectory. No shared generic picker API (#103/#210/#211).
- Ti2Header: TARGET_INSTRUMENT / NUMBER_OF_SETS / NUMBER_OF_PAGES +
  sibling .ti1 detection; NUMBER_OF_FIELDS explicitly not patch count
- TiffPreview: host-side TIFF→PNG thumbnail, 1200px max edge (#58)
- ArtefactFiles: defaultWorkingDirectory, readBase64, appInfo
- 7 new tests; 47/47 green

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
gronod merged commit 933eadd1c3 into milestone/m1-foundation 2026-09-08 19:09:42 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug/Architecture
Core / wizard / process infra defect
 Bug/Backend
Argyll orchestration, file/data defect
 Bug/DevOps
Build, packaging, CI defect
 Bug/UI
Views, controls, dialogs defect
 Compat/Breaking
Breaking change that won't be backward compatible
 Feature/Architecture
Core / wizard / process infra
 Feature/Backend
Argyll orchestration, file/data engines
 Feature/DevOps
Build, packaging, CI
 Feature/UI
Views, controls, dialogs
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Project/ICCery-v2
ICCery v2 Mac rewrite
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels Feature/Backend
Priority
Medium
3
 Project/ICCery-v2
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
gronod
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gronod/iccery-v2-mac#37