gronod/iccery-v2-mac
1
0
Fork 0
Code Issues 21 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

File dialogs & artefact helpers #6

New Issue
Closed
opened 2026-09-08 17:39:31 +01:00 by gronod · 0 comments
gronod commented 2026-09-08 17:39:31 +01:00
Owner
Copy Link
Copy Source

Summary

One NSOpenPanel/NSSavePanel wrapper per purpose. Never a shared picker.

Spec refs

docs/04-argyll-binaries.md §0.2/§13, 24-issues-invariants.md #103 #210 #211 #172 #58 #69.

Scope

In: pickers, TIFF→PNG, ti2 header, cwd helpers, getAppInfo, getProfilePath.
Out: CGATS parse (issue 30).

Implementation notes

  • selectTargetFile — save, .ti1
  • selectExistingTarget — open, .ti1/.ti2
  • selectProfileFile — .icc/.icm/.mpp (NOT .ti*)
  • selectSpectrumFile — .sp
  • selectDatasetFile — open, .ti3/.txt/.cgats/.csv
  • selectDirectory, selectCsvSavePath, selectCalFile
  • readTiffPreviewPng: decode TIFF → PNG, max edge 1200, high-quality. Never use raw TIFF as gallery source.
  • parseTi2Header: TARGET_INSTRUMENT, NUMBER_OF_SETS → patch_count, NUMBER_OF_PAGES, sibling .ti1. Note: NUMBER_OF_FIELDS is CGATS field count, not ink count.
  • resolveSafeCwd, getDefaultWorkingDir, getAppInfo, readFileBase64 for text artefacts only.

Rewrite invariants

#103/#210/#211 dedicated pickers. #172 profile filter. #58 host-side PNG.

Dependencies

Blocks-on: 1.
Unblocks: 5, 7, 8, 10, 23, 30.

Test

  • CI/mock: each picker mode+filters documented as unit-testable helpers; TIFF→PNG fixture; ti2 header fixtures.
  • Hardware: N/A.

Acceptance criteria

  • No shared “generic file dialog” API used by more than one purpose.
## Summary One NSOpenPanel/NSSavePanel wrapper per purpose. Never a shared picker. ## Spec refs docs/04-argyll-binaries.md §0.2/§13, 24-issues-invariants.md #103 #210 #211 #172 #58 #69. ## Scope In: pickers, TIFF→PNG, ti2 header, cwd helpers, getAppInfo, getProfilePath. Out: CGATS parse (issue 30). ## Implementation notes - `selectTargetFile` — save, `.ti1` - `selectExistingTarget` — open, `.ti1/.ti2` - `selectProfileFile` — `.icc/.icm/.mpp` (NOT `.ti*`) - `selectSpectrumFile` — `.sp` - `selectDatasetFile` — open, `.ti3/.txt/.cgats/.csv` - `selectDirectory`, `selectCsvSavePath`, `selectCalFile` - `readTiffPreviewPng`: decode TIFF → PNG, max edge 1200, high-quality. Never use raw TIFF as gallery source. - `parseTi2Header`: `TARGET_INSTRUMENT`, `NUMBER_OF_SETS` → patch_count, `NUMBER_OF_PAGES`, sibling `.ti1`. Note: `NUMBER_OF_FIELDS` is CGATS field count, not ink count. - `resolveSafeCwd`, `getDefaultWorkingDir`, `getAppInfo`, `readFileBase64` for text artefacts only. ## Rewrite invariants #103/#210/#211 dedicated pickers. #172 profile filter. #58 host-side PNG. ## Dependencies Blocks-on: 1. Unblocks: 5, 7, 8, 10, 23, 30. ## Test - CI/mock: each picker mode+filters documented as unit-testable helpers; TIFF→PNG fixture; ti2 header fixtures. - Hardware: N/A. ## Acceptance criteria - [ ] No shared “generic file dialog” API used by more than one purpose.
gronod added this to the M1 — Foundation & process core milestone 2026-09-08 17:39:31 +01:00
gronod added the
Priority
High
2
Project/ICCery-v2Feature/Backend labels 2026-09-08 17:39:31 +01:00
gronod reopened this issue 2026-09-08 19:06:39 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Bug/Architecture
Core / wizard / process infra defect
 Bug/Backend
Argyll orchestration, file/data defect
 Bug/DevOps
Build, packaging, CI defect
 Bug/UI
Views, controls, dialogs defect
 Compat/Breaking
Breaking change that won't be backward compatible
 Feature/Architecture
Core / wizard / process infra
 Feature/Backend
Argyll orchestration, file/data engines
 Feature/DevOps
Build, packaging, CI
 Feature/UI
Views, controls, dialogs
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Project/ICCery-v2
ICCery v2 Mac rewrite
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels Feature/Backend
Priority
High
2
 Project/ICCery-v2
Milestone
No items
No Milestone M1 — Foundation & process core
Projects
Clear projects
No projects
Assignees
Clear assignees
gronod
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gronod/iccery-v2-mac#6