gronod/iccery-v2-mac
1
0
Fork 0
Code Issues 21 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

File dialogs & artefact helpers (#6) #36

Merged
gronod merged 2 commits from feat/6-file-dialogs into milestone/m1-foundation 2026-09-08 19:06:27 +01:00
Conversation 0 Commits 2 Files Changed 7
+1809 -11
gronod commented 2026-09-08 19:06:19 +01:00
Owner
Copy Link
Copy Source

Implements issue #6 (M1).

  • PathSecurity.sanitizeBasename — rejects /, \, .., empty; never invents a default basename (#60).
  • PathSecurity.resolveSafeCwd — explicit dir → Documents → Home → app-data; never returns empty (#59).
  • AtomicFileWriter — .tmp + replaceItemAt/move; parent dirs created (#213 convention).
  • ArtefactProbe — verify_stage_artefacts (.ti1/.ti2/.ti3/profile + profilePath), .icm-over-.icc resolution with .icc macOS default (#69), artefact enumeration covering .tif, .N.tif, _NN.tif, _passN.ti3, and the CAL_ namespace.
  • FileDialogService — NSOpenPanel/NSSavePanel wrappers: directory (Documents default), .ti1/.ti2/existing-target, .ti3, .icc/.icm, .cal, save panel.

Also includes the #3 follow-up commit: ad-hoc sign+verify in fetch-argyll.sh, and the real 448v/892f sRGB.gam.

Verified: 40/40 tests pass.

Closes #6

Implements issue #6 (M1). - `PathSecurity.sanitizeBasename` — rejects `/`, `\`, `..`, empty; never invents a default basename (#60). - `PathSecurity.resolveSafeCwd` — explicit dir → Documents → Home → app-data; never returns empty (#59). - `AtomicFileWriter` — `.tmp` + `replaceItemAt`/move; parent dirs created (#213 convention). - `ArtefactProbe` — `verify_stage_artefacts` (`.ti1`/`.ti2`/`.ti3`/profile + `profilePath`), `.icm`-over-`.icc` resolution with `.icc` macOS default (#69), artefact enumeration covering `.tif`, `.N.tif`, `_NN.tif`, `_passN.ti3`, and the `CAL_` namespace. - `FileDialogService` — `NSOpenPanel`/`NSSavePanel` wrappers: directory (Documents default), `.ti1`/`.ti2`/existing-target, `.ti3`, `.icc`/`.icm`, `.cal`, save panel. Also includes the #3 follow-up commit: ad-hoc sign+verify in `fetch-argyll.sh`, and the **real** 448v/892f `sRGB.gam`. Verified: 40/40 tests pass. Closes #6
gronod added the
Priority
Medium
3
Project/ICCery-v2Feature/Backend labels 2026-09-08 19:06:19 +01:00
gronod added 2 commits 2026-09-08 19:06:21 +01:00
fetch-argyll: ad-hoc sign + verify; ship real sRGB.gam (#3 follow-up) 5ed3ff5428 
- codesign -f -s - every fetched Mach-O, then codesign -dvv verify —
  an unsigned sidecar now fails the script (#165)
- Replace the 8-cusp reference_gamuts stub with the real v0.8.5
  src/assets/sRGB.gam (448 verts / 892 faces) used by the Stage 5
  gamut overlay (#185)

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
File dialogs & artefact helpers (#6) 552227c3af 
- PathSecurity: basename sanitisation (reject / \ .., empty); resolveSafeCwd explicit - Documents - Home - app-data (#59, #60)
- AtomicFileWriter: .tmp + rename/replaceItemAt, parent dirs (#213)
- ArtefactProbe: verify_stage_artefacts, .icm-over-.icc resolution (#69), enumeration incl. .N.tif/_NN.tif/_passN.ti3/CAL_
- FileDialogService: NSOpenPanel/NSSavePanel wrappers (v2 select_* equivalents)
- 11 new tests; 40/40 total green

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
gronod merged commit 3d206e27c1 into milestone/m1-foundation 2026-09-08 19:06:27 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug/Architecture
Core / wizard / process infra defect
 Bug/Backend
Argyll orchestration, file/data defect
 Bug/DevOps
Build, packaging, CI defect
 Bug/UI
Views, controls, dialogs defect
 Compat/Breaking
Breaking change that won't be backward compatible
 Feature/Architecture
Core / wizard / process infra
 Feature/Backend
Argyll orchestration, file/data engines
 Feature/DevOps
Build, packaging, CI
 Feature/UI
Views, controls, dialogs
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Project/ICCery-v2
ICCery v2 Mac rewrite
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels Feature/Backend
Priority
Medium
3
 Project/ICCery-v2
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
gronod
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gronod/iccery-v2-mac#36