fix(m9): link ICCeryCore statically so the app launches standalone (#117)

When the app and test bundles share the local ICCeryCore package, Xcode
builds it as a dynamic package-product framework that is not embedded
in ICCery.app — the app crashes in dyld at launch when run outside the
test host (macOS 12 VM crash, run 31985 products). Declare the product
.static so each consumer links it directly.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

.gitea/workflows/macos.yml

@@ -24,10 +24,11 @@ jobs:
       - name: Assert Xcode 14 toolchain
         run: xcodebuild -version | grep -E "Xcode 14." || (echo "Unexpected Xcode version" && exit 1)
 
+      # Homebrew's xcodegen formula requires Xcode 15.3, which cannot be
+      # installed on macOS 12 (#109). The script installs a pinned
+      # prebuilt release instead.
       - name: Ensure host tools
-        run: |
-          command -v xcodegen || brew install xcodegen
-          python3 -c "import dmgbuild" 2>/dev/null || pip3 install dmgbuild
+        run: scripts/ensure-host-tools.sh
 
       - name: Generate Xcode project
         run: xcodegen generate --spec project.yml
@@ -134,6 +135,11 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
+      # scripts/package-release.sh runs `xcodegen generate` and dmgbuild;
+      # see build-and-test for why brew is not used on macOS 12 (#109).
+      - name: Ensure host tools
+        run: scripts/ensure-host-tools.sh
+
       - name: Package release
         run: scripts/package-release.sh
         env:

Packages/ICCeryCore/Package.swift

@@ -5,7 +5,10 @@ let package = Package(
     name: "ICCeryCore",
     platforms: [.macOS(.v12)],
     products: [
-        .library(name: "ICCeryCore", targets: ["ICCeryCore"]),
+        // Static so app + test bundles each link ICCeryCore directly —
+        // a dynamic package product framework is not embedded in the
+        // .app and dyld kills the app at launch on macOS 12 (#117).
+        .library(name: "ICCeryCore", type: .static, targets: ["ICCeryCore"]),
     ],
     targets: [
         .target(name: "ICCeryCore"),

Sources/ICCery/Print/PrintSessionViewModel.swift

@@ -110,7 +110,8 @@ final class PrintSessionViewModel: ObservableObject {
         isPrinting = true
         let task = Task { @MainActor [weak self] in
             guard let self else { return }
-            defer { self.printTask = nil }
+            // `defer` cannot mutate isolated state under Swift 5.7
+            // (Xcode 14.2 / macOS 12 runner), so clear explicitly (#113).
             var printed = 0
             for page in result.pages {
                 do {
@@ -123,6 +124,7 @@ final class PrintSessionViewModel: ObservableObject {
                             + error.localizedDescription
                     )
                     isPrinting = false
+                    self.printTask = nil
                     return
                 }
             }
@@ -132,6 +134,7 @@ final class PrintSessionViewModel: ObservableObject {
                 autoHideAfter: nil
             )
             isPrinting = false
+            self.printTask = nil
         }
         printTask = task
     }
@@ -141,7 +144,6 @@ final class PrintSessionViewModel: ObservableObject {
         isPrinting = true
         let task = Task { @MainActor [weak self] in
             guard let self else { return }
-            defer { self.printTask = nil }
             do {
                 try await spool(page, index: page.index, pageSize: pageSize)
                 printNotice = Notice(
@@ -156,6 +158,7 @@ final class PrintSessionViewModel: ObservableObject {
                 )
             }
             isPrinting = false
+            self.printTask = nil
         }
         printTask = task
     }

Sources/ICCery/Stage4View.swift

@@ -138,6 +138,9 @@ struct Stage4View: View {
                 .textFieldStyle(.roundedBorder)
                 .accessibilityIdentifier("colprofCopyright")
 
+            // Nested VStack keeps the parent at the Swift 5.7 ViewBuilder
+            // 10-child limit (Xcode 14.2 / macOS 12 CI runner, #111).
+            VStack(alignment: .leading, spacing: 12) {
                 Toggle("Apply calibration curve", isOn: $model.applyCalibration)
                     .accessibilityIdentifier("colprofApplyCalibration")
 
@@ -151,6 +154,7 @@ struct Stage4View: View {
                     }
                 }
             }
+        }
         .padding(16)
         .background(Theme.panel)
     }

Tests/ICCeryCoreTests/ProcessRunSupportTests.swift

@@ -21,7 +21,9 @@ final class ProcessRunSupportTests: XCTestCase {
             setRunning: { running.append($0) },
             resetLog: { resets += 1 },
             onLog: { batch in
-                MainActor.assertIsolated()
+                // MainActor.assertIsolated() needs Swift 5.9; the runner is
+                // on Xcode 14.2 (Swift 5.7) (#115).
+                XCTAssertTrue(Thread.isMainThread)
                 received.append(contentsOf: batch)
             }
         ) { onLog in

Tests/ICCeryUITests/Milestone6CalibrationUITests.swift

@@ -76,8 +76,15 @@ final class Milestone6CalibrationUITests: XCTestCase {
         // After generation the wizard should advance to Stage 2 (layout) because
         // a CAL_ .ti1 now exists and the session is in calibration mode.
         let layout = app.buttons["btnCreateLayout"]
+        if !layout.waitForExistence(timeout: 25) {
+            // The generate tap can be dropped while the dashboard is still
+            // settling after the stage transition; retry once before failing.
+            if calGenerate.waitForExistence(timeout: 2) {
+                calGenerate.tap()
+            }
             XCTAssertTrue(layout.waitForExistence(timeout: 25))
         }
+    }
 
     /// A failing calibration targen surfaces the error through the
     /// wizard notice and restores the original basename (issue #80).

scripts/ensure-host-tools.sh

@@ -0,0 +1,40 @@
+#!/bin/sh
+# scripts/ensure-host-tools.sh
+#
+# Bootstrap host tools needed by CI on the macOS 12 runner:
+#   - xcodegen: pinned prebuilt release from GitHub (Homebrew's current
+#     formula requires Xcode 15.3, which cannot be installed on macOS 12).
+#   - dmgbuild: via pip3 (used by scripts/package-release.sh).
+#
+# Safe to run repeatedly: existing tools are left alone.
+
+set -eu
+
+XCODEGEN_VERSION="2.38.0"
+INSTALL_ROOT="${XCODEGEN_HOME:-$HOME/.local/xcodegen/$XCODEGEN_VERSION}"
+
+echo "==> Ensuring dmgbuild"
+python3 -c "import dmgbuild" 2>/dev/null || pip3 install dmgbuild
+
+if command -v xcodegen >/dev/null 2>&1; then
+    echo "==> xcodegen already on PATH: $(xcodegen --version)"
+else
+    echo "==> Installing xcodegen $XCODEGEN_VERSION (prebuilt)"
+    TMP="${RUNNER_TEMP:-${TMPDIR:-/tmp}}"
+    ZIP="$TMP/xcodegen-$XCODEGEN_VERSION.zip"
+    curl -fL --retry 3 \
+        "https://github.com/yonaskolb/XcodeGen/releases/download/$XCODEGEN_VERSION/xcodegen.zip" \
+        -o "$ZIP"
+    rm -rf "$INSTALL_ROOT"
+    mkdir -p "$INSTALL_ROOT"
+    # Zip contains xcodegen/{bin/xcodegen,share/xcodegen/SettingPresets};
+    # XcodeGen resolves its presets relative to the binary, so keep the tree.
+    unzip -q "$ZIP" -d "$INSTALL_ROOT"
+    BIN_DIR="$INSTALL_ROOT/xcodegen/bin"
+    chmod +x "$BIN_DIR/xcodegen"
+    if [ -n "${GITHUB_PATH:-}" ]; then
+        echo "$BIN_DIR" >> "$GITHUB_PATH"
+    fi
+    PATH="$BIN_DIR:$PATH"
+    echo "==> Installed: $("$BIN_DIR/xcodegen" --version)"
+fi