Merge pull request 'fix(uitest): resolve AboutHelp close button lookup on runner' (#75 ) from fix/m7-ci-uitest-runner-sign into develop

Reviewed-on: #75
fix(about): expose closeAboutBtn in AboutView accessibility hierarchy
2026-09-10 08:07:35 +01:00 · 2026-09-10 07:50:24 +01:00 · 2026-09-10 07:30:07 +01:00
2 changed files with 2 additions and 2 deletions
@@ -61,6 +61,7 @@ struct AboutView: View {
        .padding(32)
        .frame(width: 360)
        .background(Theme.panel)
+        .accessibilityElement(children: .contain)
        .accessibilityIdentifier("aboutDialog")
    }
 }
@@ -52,8 +52,7 @@ final class AboutHelpUITests: XCTestCase {
        _ = waitFor("aboutVersion", timeout: 10)
        XCTAssertTrue(element("aboutBuildDate").exists)

-        let close = app.sheets.firstMatch.buttons["closeAboutBtn"]
-        XCTAssertTrue(close.waitForExistence(timeout: 5))
+        let close = waitFor("closeAboutBtn", timeout: 10)
        close.click()

        XCTAssertFalse(element("aboutDialog").exists)
Author	SHA1	Message	Date
gronod	f7ba49d3d5	Merge pull request 'fix(uitest): resolve AboutHelp close button lookup on runner' (#75 ) from fix/m7-ci-uitest-runner-sign into develop macOS CI / build-and-test (push) Successful in 9m0s Details macOS CI / package (push) Failing after 2m58s Details Reviewed-on: #75	2026-09-10 08:07:35 +01:00
gronod	0122d92f2b	fix(about): expose closeAboutBtn in AboutView accessibility hierarchy macOS CI / build-and-test (pull_request) Successful in 13m26s Details macOS CI / package (pull_request) Skipped Details The outer VStack was missing .accessibilityElement(children: .contain), so the close button identifier was not visible to XCUITest on the runner. Add the container modifier to match other dialog views and keep the aboutDialog identifier usable by tests. Refs gronod/iccery-v2-mac#75	2026-09-10 07:50:24 +01:00
gronod	d11232813b	fix(uitest): wait for closeAboutBtn in AboutHelp using app-wide identifier macOS CI / build-and-test (pull_request) Failing after 13m25s Details macOS CI / package (pull_request) Skipped Details The previous sheet-scoped query did not resolve on the runner. Use the existing waitFor helper to locate closeAboutBtn anywhere in the app and remove the redundant immediate activation call. Refs gronod/iccery-v2-mac#72	2026-09-10 07:30:07 +01:00