gronod/argyllcms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 11 Wiki Activity

Feature: Add -d switch to printtarg for custom target label string #20

Merged
gronod merged 1 commits from feature/issue-19-printtarg-custom-label into development 2026-08-28 20:05:43 +01:00
Conversation 0 Commits 1 Files Changed 3
+71 -9
gronod commented 2026-08-28 20:01:56 +01:00
Owner
Copy Link
Copy Source

Summary

This PR implements the -d "<string>" switch for printtarg, allowing users to specify custom chart description/label text or suppress border labelling when passed an empty string (-d "").

Fixes #19

Changes

  • target/printtarg.c:
    • Added -d label CLI parsing in main().
    • Expanded label buffer to 1024 bytes and added safe bounded strncpy copying.
    • Implemented label omission logic (dopglabel = 0) when -d "" is supplied.
    • Added CHART_LABEL keyword to output .ti2 CGATS files for downstream traceability.
    • Added ps_escape_str() in PostScript rendering (ps_string, ps_vstring) to escape (, ), \ and normalize newlines.
    • Added null/empty string guards in PS and TIFF string rendering routines.
    • Updated usage() banner.
  • doc/printtarg.html:
    • Documented -d switch in command summary table and options detail section.
  • doc/ChangesSummary.html:
    • Added change note under latest release section.
### Summary This PR implements the `-d "<string>"` switch for `printtarg`, allowing users to specify custom chart description/label text or suppress border labelling when passed an empty string (`-d ""`). Fixes #19 ### Changes - **`target/printtarg.c`**: - Added `-d label` CLI parsing in `main()`. - Expanded `label` buffer to 1024 bytes and added safe bounded `strncpy` copying. - Implemented label omission logic (`dopglabel = 0`) when `-d ""` is supplied. - Added `CHART_LABEL` keyword to output `.ti2` CGATS files for downstream traceability. - Added `ps_escape_str()` in PostScript rendering (`ps_string`, `ps_vstring`) to escape `(`, `)`, `\` and normalize newlines. - Added null/empty string guards in PS and TIFF string rendering routines. - Updated `usage()` banner. - **`doc/printtarg.html`**: - Documented `-d` switch in command summary table and options detail section. - **`doc/ChangesSummary.html`**: - Added change note under latest release section.
gronod added 1 commit 2026-08-28 20:01:57 +01:00
feat(printtarg): add -d switch for custom chart label string and omission (fixes #19) c88187b200
gronod merged commit b763dd78d1 into development 2026-08-28 20:05:43 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Area/UI
User Interface and Subprocess Integration
 Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
gronod
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gronod/argyllcms#20