fix(alerts): skip read-only/small volumes in low-storage rule (Issue #33) #37

Merged
gronod merged 1 commits from fix/33-readonly-storage-alerts into milestone/m6-bugfix-stability 2026-09-08 15:17:05 +01:00
Owner

Summary

Fixes the "Low disk space on 'Ghostty'" false positive: the low-storage rule evaluated every mounted volume including read-only DMG images.

Changes

  • StorageVolumeContext gains isReadOnly and totalBytes; context builder populates both from StorageVolumeItem.
  • AlertEngine low-storage rule now skips isReadOnly volumes and volumes under 1 GB total (thresholds meaningless at that size).
  • Regression tests: read-only below-threshold → no alert; sub-1 GB volume → no alert; normal writable low volume → alert.

Verified

  • 95 tests, 0 failures. swiftlint — 0 violations.

Fixes #33.

## Summary Fixes the "Low disk space on 'Ghostty'" false positive: the low-storage rule evaluated every mounted volume including read-only DMG images. ### Changes - `StorageVolumeContext` gains `isReadOnly` and `totalBytes`; context builder populates both from `StorageVolumeItem`. - `AlertEngine` low-storage rule now skips `isReadOnly` volumes and volumes under 1 GB total (thresholds meaningless at that size). - Regression tests: read-only below-threshold → no alert; sub-1 GB volume → no alert; normal writable low volume → alert. ### Verified - 95 tests, 0 failures. `swiftlint` — 0 violations. Fixes #33.
gronod added 1 commit 2026-09-08 15:16:56 +01:00
Read-only mounts (DMG images like /Volumes/Ghostty, update snapshots) with
~0% free produced false-positive low-storage alerts. StorageVolumeContext
now carries isReadOnly and totalBytes; the rule skips read-only volumes and
volumes under 1 GB where thresholds are meaningless. Regression tests cover
both exclusions plus the normal trigger path.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
gronod added the Bug/BackendKind/Bug
Priority
Medium
3
Project/Antigravity
labels 2026-09-08 15:17:03 +01:00
gronod merged commit d0c286e7c8 into milestone/m6-bugfix-stability 2026-09-08 15:17:05 +01:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gronod/MacMonitor#37