gronod/ICCery
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 6 Wiki Activity

enh(stage4): contextual tooltips and tests for colprof options (#176) #201

Closed
gronod wants to merge 1 commits from enh/176-colprof-fwa into feat/184-configurable-delta-e
pull from: enh/176-colprof-fwa
merge into: :feat/184-configurable-delta-e
Conversation 0 Commits 1 Files Changed -
gronod commented 2026-09-04 00:53:14 +01:00
Owner
Copy Link
Copy Source

Closes #176.

This branch stacks on feat/184-configurable-delta-e and polishes the Stage 4 colprof options.

Changes

  • Wrapped every Stage 4 colprof control in .has-tooltip and added contextual .tooltip-text help:
    • OBA/FWA compensation (-f): D50, None, D65, and custom .sp spectrum.
    • Custom spectrum file row.
    • Standard Illuminant (-i) and Observer (-o).
    • Input (-c) and Output (-d) viewing conditions.
  • Added a combined build_colprof_args test exercising FWA, illuminant, observer, and viewing conditions together.
  • Updated AGENTS.md, README.md, and ROADMAP.md.

Verification

  • CARGO_INCREMENTAL=0 cargo test in src-tauri/: 79 passed.
Closes #176. This branch stacks on `feat/184-configurable-delta-e` and polishes the Stage 4 `colprof` options. ### Changes - Wrapped every Stage 4 `colprof` control in `.has-tooltip` and added contextual `.tooltip-text` help: - OBA/FWA compensation (`-f`): D50, None, D65, and custom `.sp` spectrum. - Custom spectrum file row. - Standard Illuminant (`-i`) and Observer (`-o`). - Input (`-c`) and Output (`-d`) viewing conditions. - Added a combined `build_colprof_args` test exercising FWA, illuminant, observer, and viewing conditions together. - Updated `AGENTS.md`, `README.md`, and `ROADMAP.md`. ### Verification - `CARGO_INCREMENTAL=0 cargo test` in `src-tauri/`: 79 passed.
gronod added 1 commit 2026-09-04 00:53:15 +01:00
enh(stage4): add contextual tooltips and tests for colprof options (#176) 84df0b7a7d 
- Add has-tooltip / tooltip-text to all Stage 4 colprof controls:
  OBA/FWA compensation, custom spectrum, illuminant, observer,
  input/output viewing conditions.
- Add combined  test covering FWA, illuminant,
  observer, and viewing conditions simultaneously.
- Update AGENTS.md, README.md, and ROADMAP.md.

Generated with Devin
gronod added 1 commit 2026-09-06 08:55:00 +01:00
Merge branch 'feat/184-configurable-delta-e' into enh/176-colprof-fwa 7b7e19ef02
gronod closed this pull request 2026-09-06 08:55:05 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
gronod
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gronod/ICCery#201