enh(stage3): polish swatch grid orientation, white patches, and tooltips (#178) #199

Closed
gronod wants to merge 1 commits from enh/178-swatch-grid into enh/177-button-standardization
Owner

Closes #178.

This branch stacks on enh/177-button-standardization and finalises the Stage 3 live swatch grid.

Changes

  • Added a clear comment explaining the is_pad guard: white reference patches (-e white steps) may also carry is_pad, but are preserved if they have measurement data or non-zero device values; true spacers with no data and all-zero device values are skipped.
  • Documented the row/patch ordering assumption: chartread rows A→Z and patches 1→N map to the physical left-to-right / top-to-bottom layout produced by printtarg.
  • Restructured the .swatch-patch tooltip to show intended Lab (or device %), measured Lab, and a Good / Warning / Bad ΔE₀₀ classification.
  • Added a classifyDeltaE() helper with default thresholds (2.0 / 5.0) in preparation for #184 configurable thresholds.
  • Added a manual smoke-test stub src/js/swatch_grid.test.js.
  • Updated AGENTS.md, README.md, and ROADMAP.md.

Verification

  • CARGO_INCREMENTAL=0 cargo test in src-tauri/: 75 passed.
Closes #178. This branch stacks on `enh/177-button-standardization` and finalises the Stage 3 live swatch grid. ### Changes - Added a clear comment explaining the `is_pad` guard: white reference patches (`-e` white steps) may also carry `is_pad`, but are preserved if they have measurement data or non-zero device values; true spacers with no data and all-zero device values are skipped. - Documented the row/patch ordering assumption: `chartread` rows A→Z and patches 1→N map to the physical left-to-right / top-to-bottom layout produced by `printtarg`. - Restructured the `.swatch-patch` tooltip to show intended Lab (or device %), measured Lab, and a `Good / Warning / Bad` ΔE₀₀ classification. - Added a `classifyDeltaE()` helper with default thresholds (2.0 / 5.0) in preparation for #184 configurable thresholds. - Added a manual smoke-test stub `src/js/swatch_grid.test.js`. - Updated `AGENTS.md`, `README.md`, and `ROADMAP.md`. ### Verification - `CARGO_INCREMENTAL=0 cargo test` in `src-tauri/`: 75 passed.
gronod added 1 commit 2026-09-04 00:26:24 +01:00
- Document the is_pad guard so legitimate white reference patches are
  preserved while true spacer pads are skipped.
- Document row/patch ordering assumption (matches printtarg layout).
- Restructure patch tooltip to include intended Lab/device, measured Lab,
  and a Good/Warning/Bad ΔE₀₀ classification.
- Add classifyDeltaE() helper with default thresholds (reused later by
  configurable thresholds).
- Add a manual smoke-test stub in swatch_grid.test.js.
- Update AGENTS.md, README.md, and ROADMAP.md.

Generated with Devin
gronod added 1 commit 2026-09-06 08:54:07 +01:00
gronod closed this pull request 2026-09-06 08:54:14 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.