This PR polishes the global button sizing hierarchy and removes remaining inline style overrides on buttons and their parent rows.
Changes
Added CSS variables for button tier heights/radii (--btn-height-sm, --btn-height-md, --btn-height-lg, --btn-radius-sm, --btn-radius-md) and refactored .btn-sm, .btn-md, .btn-lg, .btn-icon-sq to use them.
Normalized button.primary, button.secondary, button.danger, .icon-btn, .btn-properties, and .btn-icon to consistent heights with box-sizing: border-box.
Removed inline style attributes from buttons and replaced immediate-parent inline flex rows with utility classes: .btn-row, .btn-row-sm, .btn-row-end, .input-row-sm, .form-group-header.
Applied .btn-lg to the major Stage 4/5 primary actions (#btnCreateProfile, #btnGoToVerify, #btnVerify).
Removed the inert .btn-print class from #btnPrintAll.
Added a "UI Button Conventions" section to AGENTS.md, a bullet to README.md, and the Milestone 13 checklist to ROADMAP.md.
Also includes a small build fix in src-tauri/src/print/unix.rs to make test_merge_printer_info robust to the optional display_name field and to align detect_driver_color_bypass with the existing test expectations (EPIJ_CCor, StpColorCorrection ordering).
Verification
CARGO_INCREMENTAL=0 cargo test in src-tauri/: 75 passed.
Grepped src/index.html for <button with inline style: none remaining.
Closes #177.
This PR polishes the global button sizing hierarchy and removes remaining inline `style` overrides on buttons and their parent rows.
### Changes
- Added CSS variables for button tier heights/radii (`--btn-height-sm`, `--btn-height-md`, `--btn-height-lg`, `--btn-radius-sm`, `--btn-radius-md`) and refactored `.btn-sm`, `.btn-md`, `.btn-lg`, `.btn-icon-sq` to use them.
- Normalized `button.primary`, `button.secondary`, `button.danger`, `.icon-btn`, `.btn-properties`, and `.btn-icon` to consistent heights with `box-sizing: border-box`.
- Removed inline `style` attributes from buttons and replaced immediate-parent inline flex rows with utility classes: `.btn-row`, `.btn-row-sm`, `.btn-row-end`, `.input-row-sm`, `.form-group-header`.
- Applied `.btn-lg` to the major Stage 4/5 primary actions (`#btnCreateProfile`, `#btnGoToVerify`, `#btnVerify`).
- Removed the inert `.btn-print` class from `#btnPrintAll`.
- Added a "UI Button Conventions" section to `AGENTS.md`, a bullet to `README.md`, and the Milestone 13 checklist to `ROADMAP.md`.
Also includes a small build fix in `src-tauri/src/print/unix.rs` to make `test_merge_printer_info` robust to the optional `display_name` field and to align `detect_driver_color_bypass` with the existing test expectations (`EPIJ_CCor`, `StpColorCorrection` ordering).
### Verification
- `CARGO_INCREMENTAL=0 cargo test` in `src-tauri/`: 75 passed.
- Grepped `src/index.html` for `<button` with inline `style`: none remaining.
- Update test_merge_printer_info to assert individual Printer fields,
decoupling the test from the optional display_name field populated
by lpoptions in different environments.
- Add EPIJ_CCor (Epson Color Correction) to detect_driver_color_bypass
and reorder StpColorCorrection/ColorCorrection checks so the more
specific StpColorCorrection key is preferred.
Generated with Devin
- Add CSS variables for button tier heights/radii and refactor .btn-sm,
.btn-md, .btn-lg, .btn-icon-sq to use them.
- Normalize button.primary, button.secondary, button.danger, .icon-btn,
.btn-properties, and .btn-icon to 36px (or their tier) with
box-sizing: border-box.
- Remove inline style attributes from buttons and their immediate row
containers; replace with .btn-row, .btn-row-sm, .btn-row-end,
.input-row-sm, and .form-group-header utility classes.
- Apply .btn-lg to the major Stage 4/5 primary actions.
- Add UI Button Conventions to AGENTS.md, README, and Milestone 13 to
ROADMAP.md.
Generated with Devin
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #177.
This PR polishes the global button sizing hierarchy and removes remaining inline
styleoverrides on buttons and their parent rows.Changes
--btn-height-sm,--btn-height-md,--btn-height-lg,--btn-radius-sm,--btn-radius-md) and refactored.btn-sm,.btn-md,.btn-lg,.btn-icon-sqto use them.button.primary,button.secondary,button.danger,.icon-btn,.btn-properties, and.btn-iconto consistent heights withbox-sizing: border-box.styleattributes from buttons and replaced immediate-parent inline flex rows with utility classes:.btn-row,.btn-row-sm,.btn-row-end,.input-row-sm,.form-group-header..btn-lgto the major Stage 4/5 primary actions (#btnCreateProfile,#btnGoToVerify,#btnVerify)..btn-printclass from#btnPrintAll.AGENTS.md, a bullet toREADME.md, and the Milestone 13 checklist toROADMAP.md.Also includes a small build fix in
src-tauri/src/print/unix.rsto maketest_merge_printer_inforobust to the optionaldisplay_namefield and to aligndetect_driver_color_bypasswith the existing test expectations (EPIJ_CCor,StpColorCorrectionordering).Verification
CARGO_INCREMENTAL=0 cargo testinsrc-tauri/: 75 passed.src/index.htmlfor<buttonwith inlinestyle: none remaining.Pull request closed