21 Commits
Author SHA1 Message Date
gronod 18a6d9394c ci(macos): compile tests with --no-run on cross-target Apple Silicon
Build Linux Packages / Build Linux (push) Successful in 7m9s
Build Windows Packages / Build Windows (push) Successful in 6m48s
Build macOS Packages / Build macOS (Apple Silicon) (push) Successful in 20m33s
Build macOS Packages / Build macOS (Intel) (push) Successful in 20m38s
Build macOS Packages / Build macOS (Universal (Intel + Apple Silicon)) (push) Successful in 26m25s
2026-09-05 21:25:13 +01:00
gronod 9016932547 ci(macos): remove hanging rust-cache and run native cargo test for all platforms
Build Windows Packages / Build Windows (push) Successful in 7m13s
Build macOS Packages / Build macOS (Apple Silicon) (push) Failing after 7m15s
Build Linux Packages / Build Linux (push) Successful in 8m0s
Build macOS Packages / Build macOS (Intel) (push) Canceled after 10m57s
Build macOS Packages / Build macOS (Universal (Intel + Apple Silicon)) (push) Canceled after 12m4s
2026-09-05 21:14:14 +01:00
gronod 2f7d8f3ca7 ci(macos): run cargo test without target for universal-apple-darwin
Build Windows Packages / Build Windows (push) Successful in 7m6s
Build Linux Packages / Build Linux (push) Successful in 7m43s
Build macOS Packages / Build macOS (Apple Silicon) (push) Failing after 9m16s
Build macOS Packages / Build macOS (Universal (Intel + Apple Silicon)) (push) Canceled after 43m44s
Build macOS Packages / Build macOS (Intel) (push) Canceled after 43m44s
2026-09-05 20:34:17 +01:00
gronod 41efac68ed Merge pull request 'Release v0.8.1' (#206) from development into main
Build macOS Packages / Build macOS (Universal (Intel + Apple Silicon)) (push) Failing after 1m27s
Build macOS Packages / Build macOS (Apple Silicon) (push) Canceled after 6m4s
Build macOS Packages / Build macOS (Intel) (push) Canceled after 6m4s
Build Windows Packages / Build Windows (push) Canceled after 6m1s
Build Linux Packages / Build Linux (push) Canceled after 6m12s
Merge pull request 'Release v0.8.1' (#206) from development into main
2026-09-05 20:27:52 +01:00
gronod 9aad7b083a Merge pull request 'feat(chartread): support -Y l switch for i1Pro 2 LED feedback (closes #204)' (#205) from feat/204-i1pro2-led-feedback into development
Merge pull request 'feat(chartread): support -Y l switch for i1Pro 2 LED feedback (closes #204)' (#205) from feat/204-i1pro2-led-feedback into development
2026-09-05 20:27:41 +01:00
gronod 5ee1b07263 feat(chartread): support -Y l switch for i1Pro 2 LED feedback (#204) 2026-09-05 20:26:44 +01:00
gronod 53ce298bc1 chore(release): bump version to 0.8.1 2026-09-05 20:24:46 +01:00
gronod 45ed7dbfe5 ci: uncomment Intel and Apple Silicon build targets in macos workflow matrix 2026-09-05 17:49:41 +01:00
gronod f553f10399 Update .gitea/workflows/build-macos.yml
made macos build on gitea universal only
2026-09-05 17:36:37 +01:00
gronod a9112445bb Update .gitea/workflows/build-macos.yml
Build Windows Packages / Build Windows (push) Canceled after 14s
Build Linux Packages / Build Linux (push) Canceled after 32s
Build macOS Packages / Build macOS (Intel) (push) Canceled after 32m48s
commennted arm64 and universal builds from macos gitea workflow and updated node version to 24
2026-09-05 17:24:16 +01:00
gronod a584b9746f Update .gitea/workflows/build-macos.yml
Build Linux Packages / Build Linux (push) Canceled after 14s
Build Windows Packages / Build Windows (push) Canceled after 15s
Build macOS Packages / Build macOS (Intel) (push) Canceled after 0s
Build macOS Packages / Build macOS (Universal (Intel + Apple Silicon)) (push) Canceled after 0s
Build macOS Packages / Build macOS (Apple Silicon) (push) Canceled after 2m2s
2026-09-05 17:18:31 +01:00
Gordon Bolton c2fdfafaa7 Merge development for v0.8.0 release
Build macOS Packages / Build macOS (Apple Silicon) (push) Canceled after 0s
Build macOS Packages / Build macOS (Intel) (push) Canceled after 0s
Build macOS Packages / Build macOS (Universal (Intel + Apple Silicon)) (push) Canceled after 0s
Build Linux Packages / Build Linux (push) Canceled after 22s
Build Windows Packages / Build Windows (push) Canceled after 24s
Integrates Milestone 13 polish and closes #177, #178, #184, #176, #185, #179.

Generated with Devin
2026-09-04 01:31:08 +01:00
Gordon Bolton b60d0c3bce chore(release): bump version to 0.8.0
Generated with Devin
2026-09-04 01:28:00 +01:00
Gordon Bolton 8a0065274b Merge milestone 13 feature stack into development (#177-#185, #179)
Integrates the stacked enhancements and fixes from:
- enh/177-button-standardization
- enh/178-swatch-grid
- feat/184-configurable-delta-e
- enh/176-colprof-fwa
- enh/185-gamut-viewer
- fix/179-gamut-profcheck

Generated with Devin
2026-09-04 01:05:26 +01:00
Gordon Bolton ab2f6e562e fix(stage5): harden gamut .gam parsing and profcheck output parsing (#179)
- Make parseGamutFile support multiple BEGIN_DATA blocks, inline #
  comments, out-of-bounds vertex warnings, and user-visible parser
  warnings (returned in { vertices, faces, warnings }).
- Harden profcheck report parsing: prefer the last JSON object with
  avg_de/max_de/rms_de keys, then fall back to a wider set of regex
  patterns for legacy plain-text output.
- Add parser warnings to the process log when metrics cannot be found.
- Fix loadGamutMesh call signature and add try/catch around gamut load.
- Add manual gamut parser tests in src/js/gamut_viewer.test.js.
- Update AGENTS.md, README.md, and ROADMAP.md.

Generated with Devin
2026-09-04 01:03:07 +01:00
Gordon Bolton 3026e7081c enh(stage5): gamut viewer controls and JSDoc (#185)
- Add resetCamera(), setProfileOpacity(), setSrgbReferenceOpacity(), and
  setAxisOpacity() public API functions with JSDoc.
- Add Reset View button and per-layer opacity sliders to the gamut viewer
  control panel.
- Add R keyboard shortcut to reset camera when Stage 5 is active.
- Add CSS for new gamut controls (sliders and reset button).
- Update AGENTS.md, README.md, and ROADMAP.md.

Generated with Devin
2026-09-04 00:57:40 +01:00
Gordon Bolton 84df0b7a7d enh(stage4): add contextual tooltips and tests for colprof options (#176)
- Add has-tooltip / tooltip-text to all Stage 4 colprof controls:
  OBA/FWA compensation, custom spectrum, illuminant, observer,
  input/output viewing conditions.
- Add combined  test covering FWA, illuminant,
  observer, and viewing conditions simultaneously.
- Update AGENTS.md, README.md, and ROADMAP.md.

Generated with Devin
2026-09-04 00:52:02 +01:00
Gordon Bolton 9f8b2c8567 feat(settings): configurable ΔE₀₀ traffic-light thresholds (#184)
- Add AppSettings fields delta_e_good_max / delta_e_warning_max with
  serde defaults (2.0 / 5.0) and validation on save.
- Add Settings dialog UI for the two threshold inputs with live frontend
  validation and a backend validate() method / unit tests.
- Dispatch a settings-saved custom event so the swatch grid can re-classify
  existing patches on the fly.
- Refactor swatch_grid.js to load thresholds from settings, classify using
  current bounds, store raw ΔE on each patch element, and re-classify on
  settings change.
- Update AGENTS.md, README.md, and ROADMAP.md.

Generated with Devin
2026-09-04 00:43:04 +01:00
Gordon Bolton 2c97e98dc3 enh(stage3): polish swatch grid orientation, white patches, and tooltips (#178)
- Document the is_pad guard so legitimate white reference patches are
  preserved while true spacer pads are skipped.
- Document row/patch ordering assumption (matches printtarg layout).
- Restructure patch tooltip to include intended Lab/device, measured Lab,
  and a Good/Warning/Bad ΔE₀₀ classification.
- Add classifyDeltaE() helper with default thresholds (reused later by
  configurable thresholds).
- Add a manual smoke-test stub in swatch_grid.test.js.
- Update AGENTS.md, README.md, and ROADMAP.md.

Generated with Devin
2026-09-04 00:25:49 +01:00
Gordon Bolton 0603faca59 enh(ui): standardize button sizing across all views (#177)
- Add CSS variables for button tier heights/radii and refactor .btn-sm,
  .btn-md, .btn-lg, .btn-icon-sq to use them.
- Normalize button.primary, button.secondary, button.danger, .icon-btn,
  .btn-properties, and .btn-icon to 36px (or their tier) with
  box-sizing: border-box.
- Remove inline style attributes from buttons and their immediate row
  containers; replace with .btn-row, .btn-row-sm, .btn-row-end,
  .input-row-sm, and .form-group-header utility classes.
- Apply .btn-lg to the major Stage 4/5 primary actions.
- Add UI Button Conventions to AGENTS.md, README, and Milestone 13 to
  ROADMAP.md.

Generated with Devin
2026-09-04 00:20:31 +01:00
Gordon Bolton 956b5ff499 fix(print): robust Printer tests and driver color bypass detection
- Update test_merge_printer_info to assert individual Printer fields,
  decoupling the test from the optional display_name field populated
  by lpoptions in different environments.
- Add EPIJ_CCor (Epson Color Correction) to detect_driver_color_bypass
  and reorder StpColorCorrection/ColorCorrection checks so the more
  specific StpColorCorrection key is preferred.

Generated with Devin
2026-09-04 00:18:51 +01:00
21 changed files with 1001 additions and 152 deletions
+11 -8
View File
@@ -13,17 +13,17 @@ jobs:
matrix:
platform:
- name: Intel
os: macos-15-intel
os: macos
target: x86_64-apple-darwin
binary_dir: macos-x86_64
arch: x86_64
- name: Apple Silicon
os: macos-15
os: macos
target: aarch64-apple-darwin
binary_dir: macos-aarch64
arch: arm64
- name: Universal (Intel + Apple Silicon)
os: macos-15
os: macos
target: universal-apple-darwin
binary_dir: macos-universal
arch: universal
@@ -35,7 +35,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 24
cache: 'npm'
- name: Install Rust stable
@@ -44,9 +44,6 @@ jobs:
toolchain: stable
targets: ${{ matrix.platform.target == 'universal-apple-darwin' && 'x86_64-apple-darwin, aarch64-apple-darwin' || matrix.platform.target }}
- name: Rust Cache
uses: Swatinem/rust-cache@v2
- name: Install Node dependencies
run: npm ci
@@ -69,7 +66,13 @@ jobs:
CARGO_TARGET_DIR: "${{ runner.temp }}/cargo-target"
run: |
cd src-tauri
cargo test --target ${{ matrix.platform.target }}
if [ "${{ matrix.platform.target }}" = "universal-apple-darwin" ]; then
cargo test
elif [ "${{ matrix.platform.target }}" = "aarch64-apple-darwin" ] && [ "$(uname -m)" != "arm64" ]; then
cargo test --no-run --target ${{ matrix.platform.target }}
else
cargo test --target ${{ matrix.platform.target }}
fi
- name: Set Release Environment
id: set_env
+53
View File
@@ -1,5 +1,58 @@
# ICCery Agent Notes
## Stage 5 Verification / Profcheck
- `profcheck` output is parsed from both JSON summaries (preferred) and legacy plain-text report formats.
- If no delta-E values can be detected, the report cards show 0.00 and a warning is appended to the process log.
- The `.gam` file for the 3D viewer is parsed using `parseGamutFile`, which supports multiple `BEGIN_DATA` blocks (some Argyll files use a separate block per surface section), inline `#` comments, and out-of-bounds vertex warnings.
- Manual parser tests live in `src/js/gamut_viewer.test.js`.
## 3D Gamut Viewer
- The viewer renders the measured/derived `.gam` volume and an optional sRGB reference wireframe in CIELAB.
- Layer controls (profile, sRGB, axes) each have visibility toggles and opacity sliders.
- Click **Reset View** or press **R** to return the camera to its default position.
- Full JSDoc is provided on the public API in `src/js/gamut_viewer.js`.
## Stage 4 colprof Options
- `colprof` options are exposed in the Stage 4 UI with contextual tooltips:
- **FWA / OBA Compensation** (`-f`): choose D50, None, D65, or a custom `.sp` spectrum file.
- **Standard Illuminant** (`-i`) and **Observer** (`-o`): override default D50 / 1931 2° for CIE colourimetric calculations.
- **Viewing Conditions** (`-c` input, `-d` output): set CIE viewing-condition transforms for the profile table and output intent.
- The backend `build_colprof_args` in `commands.rs` maps these UI values to `colprof` CLI flags. Unit tests cover all combinations.
## Stage 3 Swatch Grid
- Swatch patches render a 135° diagonal split: top-left is the intended/expected colour, bottom-right is the measured colour.
- Argyll `chartread` emits `is_pad` for boundary/spacer patches. White reference patches (e.g. `-e` white steps) may also carry `is_pad`, but they have valid `expected.Lab` or non-zero `device` data. The guard skips only pads with no measurement *and* all-zero device values.
- Row/patch order from `chartread` (rows A→Z, patches 1→N within each row) is rendered left-to-right / top-to-bottom to match the `printtarg` output.
- Tooltip shows intended Lab (or device %), measured Lab, and ΔE₀₀ with a Good/Warning/Bad classification.
## UI Button Conventions
The frontend uses a tiered button sizing system defined in `src/styles/main.css`. Prefer these utility classes over inline `style` attributes.
| Class | Size | Use for |
|-------|------|---------|
| `.btn-sm` | 28px | Toolbar actions, header icons, minor toggles |
| `.btn-md` (default for `button.secondary`/`button.danger`) | 36px | Standard dialog/form actions and browse buttons |
| `.btn-lg` | 40px | Primary stage actions (Generate, Create Layout, Create Profile, Verify, etc.) |
| `.btn-icon-sq` | 36×36px | Square icon-only buttons (refresh, settings, etc.) |
| `.icon-btn` | 28×28px | Small header icon-only buttons (settings, about, save preset, manage presets) |
| `.btn-properties` | 36px | Printer driver preferences button |
- Primary action buttons use `button.primary` plus `.btn-lg` for major stage actions.
- Danger actions use `button.danger` (36px).
- All action rows use one of: `.stage-actions`, `.modal-actions`, `.chartread-actions`, `.print-actions-row`, `.btn-row`, `.btn-row-sm`, `.btn-row-end`, or `.input-row-sm`.
- Avoid inline `style` on `<button>` elements or their immediate parent rows.
## Settings & Preferences
- Settings are persisted to `settings.json` in the app data directory and include the Stage 3 ΔE₀₀ traffic-light thresholds.
- Valid threshold values must be non-negative and `delta_e_good_max < delta_e_warning_max`; both the frontend and backend enforce this.
- Saving settings dispatches a `settings-saved` custom event so live components (e.g. the swatch grid) can re-classify on the fly.
## Build Commands
- **Rust backend**: `cd src-tauri && CARGO_INCREMENTAL=0 cargo check` (the project lives on a network filesystem that doesn't support file locking, so `CARGO_INCREMENTAL=0` is required)
+4 -3
View File
@@ -16,13 +16,14 @@
- 🪄 **Linear 5-Stage Wizard Workflow**:
1. **Stage 1 — Patch Generation (`targen`)**: Configure RGB (driver-managed) or CMYK (RIP-managed) patch sets with custom counts, profiling presets, and neutral/grey axis boosting.
2. **Stage 2 — Target Creation & Raw Printing (`printtarg`)**: Format patch targets for spectrophotometers (i1Pro, i1Pro2, ColorMunki, SpyderPrint). View high-resolution downscaled TIFF previews and print directly using native OS raw unmanaged pathways (Windows GDI uncorrected / Linux CUPS `raw`).
3. **Stage 3 — Interactive Measurement (`chartread`) & Averaging (`average`)**: Instrument auto-detection (`instlist`), real-time calibration prompts, interactive strip reading state machine, live swatch grid with CIEDE2000 ($\Delta E_{00}$) quality indicators, and multi-pass sheet averaging for measurement noise reduction.
4. **Stage 4 — Profile Calculation (`colprof`)**: Generate high-precision cLUT mathematical ICC/ICM profiles with configurable algorithm quality, descriptions, and copyright tagging.
5. **Stage 5 — Verification & 3D Gamut (`profcheck` + `iccgamut`)**: Comprehensive mathematical validation report (Peak, Average, RMS $\Delta E$) paired with an interactive 3D CIELAB convex hull color volume viewer, touch controls, and bundled sRGB reference wireframe comparison.
3. **Stage 3 — Interactive Measurement (`chartread`) & Averaging (`average`)**: Instrument auto-detection (`instlist`), real-time calibration prompts, interactive strip reading state machine, live swatch grid with CIEDE2000 ($\Delta E_{00}$) quality indicators and user-configurable traffic-light thresholds, diagonally split intended-vs-measured colour swatches, white reference patch preservation, and multi-pass sheet averaging for measurement noise reduction.
4. **Stage 4 — Profile Calculation (`colprof`)**: Generate high-precision cLUT mathematical ICC/ICM profiles with configurable algorithm quality, OBA/FWA compensation, illuminant/observer selection, viewing-condition transforms, custom ambient spectrum support, descriptions, and copyright tagging.
5. **Stage 5 — Verification & 3D Gamut (`profcheck` + `iccgamut`)**: Comprehensive mathematical validation report (Peak, Average, RMS $\Delta E$) paired with an interactive 3D CIELAB convex hull color volume viewer, per-vertex true-colour rendering, layer opacity controls, camera reset, keyboard shortcut, touch controls, bundled sRGB reference wireframe comparison, and robust parsing of both JSON and legacy profcheck output formats.
- 📋 **Profiling Presets**: One-click configuration presets (Standard RGB Photo, High-Gamut CMYK Proofing, Fast RGB Draft) with custom preset export/import and security validation.
- 🐧 **glibc Compatibility**: Pre-built Linux packages compiled with Ubuntu 22.04 LTS compatibility for Debian/Ubuntu environments.
- 🛡️ **Disk Artefact Gating**: Stepper navigation strictly verifies generated artefacts on disk (`.ti1`, `.ti2`, `.ti3`, `.icc`/`.icm`), preventing out-of-order execution while preserving backward navigation.
- 🌐 **Platform-Aware**: Automatic handling of platform profile conventions (`.icm` on Windows, `.icc` on Linux/macOS) and native OS printer subsystems.
- 🎛️ **Consistent UI Controls**: Tiered button sizing (`btn-sm`/`btn-md`/`btn-lg`/`btn-icon-sq`) and standardised action row classes provide a uniform, polished interface across all wizard stages and dialogs.
- ⚖️ **Clean AGPL Boundary**: Complete isolation of AGPLv3 binaries via asynchronous tokio IPC process pipelines.
---
+9
View File
@@ -99,6 +99,15 @@ ICCery is a native, cross-platform desktop application built with:
- [ ] **macOS Raw Spooling**: Native CoreGraphics/CUPS raw print dialog bypass.
- [ ] **SpectroScan & Automated Table Support (#93)**: Support XY automated scanning tables (i1iO / SpectroScan) in `chartread` (deferred).
### Milestone 13 — UI/UX & Workflow Polish
- [x] **Global Button Standardization (#177)**: Enforce `.btn-sm`/`.btn-md`/`.btn-lg`/`.btn-icon-sq` tiers across all stages, remove inline button styles, and add CSS custom properties for button metrics.
- [x] **Swatch Grid White Patch & Orientation Polish (#178)**: Finalise `is_pad` guard documentation, diagonally split swatch tooltips, and validate `printtarg` row/column ordering.
- [x] **Configurable CIEDE2000 Thresholds (#184)**: User-configurable good/warning ΔE₀₀ upper bounds in Settings, persisted across sessions and applied to the Stage 3 swatch grid.
- [x] **Stage 4 OBA/FWA Tooltips & Tests (#176)**: Contextual help for OBA/FWA, illuminant, observer, and viewing-condition controls; additional `colprof` arg builder tests.
- [x] **3D Gamut Viewer Controls (#185)**: Camera reset, opacity sliders, keyboard shortcut, and full public-API JSDoc.
- [x] **Gamut / Profcheck Hardening (#179)**: Validate `.gam` vertex/face parsing, improved `profcheck` regex fallbacks for legacy text output, and user-visible parser warnings.
### Milestone 12 — Future Workflow & Advanced Analytics (Deferred)
- [ ] **Batch Verification & Drift Tracking (#95)**: Track printer drift over time by comparing periodic verification measurements against a baseline profile.
- [ ] **Multi-Language Localization (#96)**: Full UI internationalization (English, German, French, Japanese).
+1 -1
View File
@@ -1,7 +1,7 @@
{
"name": "iccery",
"private": true,
"version": "0.7.4",
"version": "0.8.1",
"type": "module",
"scripts": {
"fetch-argyll": "node scripts/fetch-argyll.mjs",
+1 -1
View File
@@ -1423,7 +1423,7 @@ dependencies = [
[[package]]
name = "iccery"
version = "0.7.4"
version = "0.8.1"
dependencies = [
"base64 0.22.1",
"image",
+1 -1
View File
@@ -1,6 +1,6 @@
[package]
name = "iccery"
version = "0.7.4"
version = "0.8.1"
description = "Modern Printer Profiling UI frontend for ArgyllCMS"
authors = ["Gordon"]
edition = "2021"
+79 -2
View File
@@ -829,11 +829,13 @@ pub async fn read_tiff_preview_png(path: String) -> Result<String, String> {
Ok(base64::engine::general_purpose::STANDARD.encode(png_bytes.into_inner()))
}
#[derive(Debug, Deserialize, Serialize)]
#[derive(Debug, Deserialize, Serialize, Clone)]
pub struct ChartreadConfig {
pub basename: String,
pub cwd: String,
pub port: Option<String>,
#[serde(default)]
pub enable_i1pro2_leds: Option<bool>,
}
pub fn build_chartread_args(config: &ChartreadConfig) -> Vec<String> {
@@ -849,6 +851,11 @@ pub fn build_chartread_args(config: &ChartreadConfig) -> Vec<String> {
}
}
if config.enable_i1pro2_leds.unwrap_or(false) {
args.push("-Y".to_string());
args.push("l".to_string());
}
args.push(config.basename.clone());
args
}
@@ -857,8 +864,12 @@ pub fn build_chartread_args(config: &ChartreadConfig) -> Vec<String> {
pub async fn run_chartread(
app: AppHandle,
state: State<'_, ProcessManager>,
config: ChartreadConfig,
mut config: ChartreadConfig,
) -> Result<(), String> {
if config.enable_i1pro2_leds.is_none() {
let settings = crate::settings::load_settings(app.clone()).unwrap_or_default();
config.enable_i1pro2_leds = Some(settings.enable_i1pro2_leds);
}
let binary = resolve_binary(app.clone(), "chartread".to_string()).await?;
let args = build_chartread_args(&config);
let id = format!("chartread_{}", config.basename);
@@ -1558,6 +1569,7 @@ mod tests {
basename: "my_profile".to_string(),
cwd: "/home/user".to_string(),
port: None,
enable_i1pro2_leds: None,
};
let args = build_chartread_args(&config);
assert_eq!(args, vec!["-v", "-u", "my_profile"]);
@@ -1569,6 +1581,7 @@ mod tests {
basename: "my_profile".to_string(),
cwd: "/home/user".to_string(),
port: Some("".to_string()),
enable_i1pro2_leds: None,
};
let args = build_chartread_args(&config);
assert_eq!(args, vec!["-v", "-u", "my_profile"]);
@@ -1580,11 +1593,48 @@ mod tests {
basename: "my_profile".to_string(),
cwd: "/home/user".to_string(),
port: Some("1".to_string()),
enable_i1pro2_leds: None,
};
let args = build_chartread_args(&config);
assert_eq!(args, vec!["-v", "-u", "-c", "1", "my_profile"]);
}
#[test]
fn test_build_chartread_args_leds_enabled() {
let config = ChartreadConfig {
basename: "my_profile".to_string(),
cwd: "/home/user".to_string(),
port: None,
enable_i1pro2_leds: Some(true),
};
let args = build_chartread_args(&config);
assert_eq!(args, vec!["-v", "-u", "-Y", "l", "my_profile"]);
}
#[test]
fn test_build_chartread_args_with_port_and_leds() {
let config = ChartreadConfig {
basename: "my_profile".to_string(),
cwd: "/home/user".to_string(),
port: Some("1".to_string()),
enable_i1pro2_leds: Some(true),
};
let args = build_chartread_args(&config);
assert_eq!(args, vec!["-v", "-u", "-c", "1", "-Y", "l", "my_profile"]);
}
#[test]
fn test_build_chartread_args_leds_disabled() {
let config = ChartreadConfig {
basename: "my_profile".to_string(),
cwd: "/home/user".to_string(),
port: None,
enable_i1pro2_leds: Some(false),
};
let args = build_chartread_args(&config);
assert_eq!(args, vec!["-v", "-u", "my_profile"]);
}
#[test]
fn test_build_average_args() {
let config = AverageConfig {
@@ -1783,6 +1833,33 @@ mod tests {
);
}
#[test]
fn test_build_colprof_args_combined_fwa_illuminant_observer_viewing() {
let config = ColprofConfig {
algorithm: "x".to_string(),
quality: "u".to_string(),
intent: Some("a".to_string()),
copyright: Some("C".to_string()),
description: Some("D".to_string()),
basename: "profile".to_string(),
cwd: "".to_string(),
fwa: Some("D65".to_string()),
illuminant: Some("D65".to_string()),
observer: Some("2015_2".to_string()),
input_viewing_cond: Some("pc".to_string()),
output_viewing_cond: Some("md".to_string()),
};
let args = build_colprof_args(&config);
assert_eq!(
args,
vec![
"-v", "-a", "x", "-q", "u", "-t", "a",
"-f", "D65", "-i", "D65", "-o", "2015_2",
"-c", "pc", "-d", "md", "-D", "D", "-C", "C", "profile"
]
);
}
#[test]
fn test_build_profcheck_args() {
let config = ProfcheckConfig {
+20 -34
View File
@@ -253,14 +253,17 @@ pub fn detect_driver_color_bypass(output: &str) -> Option<(&'static str, &'stati
Some(("CNIJIntent2", "4"))
} else if output.contains("CNIJIntent") {
Some(("CNIJIntent", "4"))
} else if output.contains("EPIJ_CCor") {
// Epson "Color Settings" option. The value 0 disables driver-side color correction.
Some(("EPIJ_CCor", "0"))
} else if output.contains("EPIJ_CMat") {
// Epson "Color Settings" option. The value 3 is "Off (No Color
// Adjustment)" which disables driver-side color management.
Some(("EPIJ_CMat", "3"))
} else if output.contains("ColorCorrection") {
Some(("ColorCorrection", "Uncorrected"))
} else if output.contains("StpColorCorrection") {
Some(("StpColorCorrection", "Uncorrected"))
} else if output.contains("ColorCorrection") {
Some(("ColorCorrection", "Uncorrected"))
} else if output.contains("EpsonColorMode") {
Some(("EpsonColorMode", "Off"))
} else {
@@ -515,38 +518,21 @@ printer Zebra_Label disabled since Wed 10 Jun 2026 - reason: out of ribbon\n\
let merged = merge_printer_info(&destinations, &statuses, default_dest);
assert_eq!(merged.len(), 4);
assert_eq!(
merged[0],
Printer {
name: "Epson-Stylus-SX420W".to_string(),
status: "Idle".to_string(),
is_default: true,
}
);
assert_eq!(
merged[1],
Printer {
name: "HP_LaserJet".to_string(),
status: "Printing".to_string(),
is_default: false,
}
);
assert_eq!(
merged[2],
Printer {
name: "Virtual_PDF".to_string(),
status: "Idle".to_string(),
is_default: false,
}
);
assert_eq!(
merged[3],
Printer {
name: "Zebra_Label".to_string(),
status: "Stopped".to_string(),
is_default: false,
}
);
assert_eq!(merged[0].name, "Epson-Stylus-SX420W".to_string());
assert_eq!(merged[0].status, "Idle".to_string());
assert!(merged[0].is_default);
assert_eq!(merged[1].name, "HP_LaserJet".to_string());
assert_eq!(merged[1].status, "Printing".to_string());
assert!(!merged[1].is_default);
assert_eq!(merged[2].name, "Virtual_PDF".to_string());
assert_eq!(merged[2].status, "Idle".to_string());
assert!(!merged[2].is_default);
assert_eq!(merged[3].name, "Zebra_Label".to_string());
assert_eq!(merged[3].status, "Stopped".to_string());
assert!(!merged[3].is_default);
}
#[test]
+1 -1
View File
@@ -276,7 +276,7 @@ mod tests {
let pm = ProcessManager::new();
// Test helper using dummy/mock or direct map operations
{
let mut stdins = pm.stdins.lock().await;
let stdins = pm.stdins.lock().await;
assert!(!stdins.contains_key("test_proc"));
}
}
+95 -1
View File
@@ -60,13 +60,49 @@ pub struct ProfilingPreset {
pub no_randomize: Option<bool>,
}
#[derive(Debug, Deserialize, Serialize, Default, Clone)]
fn default_delta_e_good_max() -> f64 { 2.0 }
fn default_delta_e_warning_max() -> f64 { 5.0 }
#[derive(Debug, Deserialize, Serialize, Clone)]
pub struct AppSettings {
pub argyll_binary_dir: Option<String>,
pub default_instrument: Option<String>,
pub log_level: Option<String>,
#[serde(default = "default_delta_e_good_max")]
pub delta_e_good_max: f64,
#[serde(default = "default_delta_e_warning_max")]
pub delta_e_warning_max: f64,
#[serde(default)]
pub custom_presets: Vec<ProfilingPreset>,
#[serde(default)]
pub enable_i1pro2_leds: bool,
}
impl Default for AppSettings {
fn default() -> Self {
Self {
argyll_binary_dir: None,
default_instrument: None,
log_level: None,
delta_e_good_max: default_delta_e_good_max(),
delta_e_warning_max: default_delta_e_warning_max(),
custom_presets: Vec::new(),
enable_i1pro2_leds: false,
}
}
}
impl AppSettings {
/// Validate thresholds and other cross-field invariants.
pub fn validate(&self) -> Result<(), String> {
if self.delta_e_good_max < 0.0 || self.delta_e_warning_max < 0.0 {
return Err("ΔE thresholds cannot be negative.".to_string());
}
if self.delta_e_good_max >= self.delta_e_warning_max {
return Err("Good ΔE threshold must be strictly less than the warning threshold.".to_string());
}
Ok(())
}
}
pub fn get_default_presets() -> Vec<ProfilingPreset> {
@@ -239,6 +275,7 @@ pub fn load_settings(app: AppHandle) -> Result<AppSettings, String> {
#[tauri::command]
pub fn save_settings(app: AppHandle, settings: AppSettings) -> Result<(), String> {
settings.validate()?;
let path = app.path().app_data_dir().unwrap();
fs::create_dir_all(&path).map_err(|e| e.to_string())?;
let json = serde_json::to_string_pretty(&settings).unwrap();
@@ -380,6 +417,39 @@ mod tests {
assert_eq!(preset, imported);
}
#[test]
fn test_default_delta_e_thresholds() {
let settings = AppSettings::default();
assert_eq!(settings.delta_e_good_max, 2.0);
assert_eq!(settings.delta_e_warning_max, 5.0);
assert!(settings.delta_e_good_max < settings.delta_e_warning_max);
assert!(settings.validate().is_ok());
}
#[test]
fn test_delta_e_threshold_serialization_defaults() {
let json = "{}";
let settings: AppSettings = serde_json::from_str(json).unwrap();
assert_eq!(settings.delta_e_good_max, 2.0);
assert_eq!(settings.delta_e_warning_max, 5.0);
}
#[test]
fn test_delta_e_threshold_validation() {
let mut settings = AppSettings::default();
settings.delta_e_good_max = 5.0;
settings.delta_e_warning_max = 2.0;
assert!(settings.validate().is_err());
settings.delta_e_good_max = -1.0;
settings.delta_e_warning_max = 2.0;
assert!(settings.validate().is_err());
settings.delta_e_good_max = 1.0;
settings.delta_e_warning_max = 3.0;
assert!(settings.validate().is_ok());
}
#[test]
fn test_parse_log_level_filter() {
assert_eq!(parse_log_level_filter(Some("error")), log::LevelFilter::Error);
@@ -399,4 +469,28 @@ mod tests {
assert_eq!(parse_log_level_filter(Some("unknown")), log::LevelFilter::Info);
}
}
#[test]
fn test_default_enable_i1pro2_leds() {
let settings = AppSettings::default();
assert_eq!(settings.enable_i1pro2_leds, false);
}
#[test]
fn test_enable_i1pro2_leds_serialization() {
// Missing field defaults to false
let json_empty = "{}";
let settings_empty: AppSettings = serde_json::from_str(json_empty).unwrap();
assert_eq!(settings_empty.enable_i1pro2_leds, false);
// Explicit true
let json_true = r#"{"enable_i1pro2_leds": true}"#;
let settings_true: AppSettings = serde_json::from_str(json_true).unwrap();
assert_eq!(settings_true.enable_i1pro2_leds, true);
// Explicit false
let json_false = r#"{"enable_i1pro2_leds": false}"#;
let settings_false: AppSettings = serde_json::from_str(json_false).unwrap();
assert_eq!(settings_false.enable_i1pro2_leds, false);
}
}
+1 -1
View File
@@ -1,7 +1,7 @@
{
"$schema": "https://schema.tauri.app/config/2",
"productName": "ICCery",
"version": "0.7.4",
"version": "0.8.1",
"identifier": "com.gronod.iccery",
"build": {
"frontendDist": "../src"
+98 -32
View File
@@ -35,9 +35,9 @@
<!-- Profiling Preset Selector -->
<div class="preset-selector-container" style="padding: 0 16px 12px; border-bottom: 1px solid var(--border-color, #2a2a30);">
<div style="display: flex; justify-content: space-between; align-items: center; margin-bottom: 6px;">
<label for="presetSelect" style="font-size: 0.75rem; text-transform: uppercase; letter-spacing: 0.05em; opacity: 0.7; font-weight: 600;">Profiling Preset</label>
<div style="display: flex; gap: 6px; align-items: center; justify-content: flex-end;">
<div class="form-group-header">
<label for="presetSelect" class="form-group-label-small">Profiling Preset</label>
<div class="btn-row-sm">
<button type="button" id="btnSavePresetModal" class="icon-btn btn-sm" title="Save current settings as Preset">
<svg width="18" height="18" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M19 21H5a2 2 0 0 1-2-2V5a2 2 0 0 1 2-2h11l5 5v11a2 2 0 0 1-2 2z"></path><polyline points="17 21 17 13 7 13 7 21"></polyline><polyline points="7 3 7 8 15 8"></polyline></svg>
</button>
@@ -131,10 +131,10 @@
</div>
<div class="form-group has-tooltip">
<div style="display: flex; justify-content: space-between; align-items: center; margin-bottom: 6px;">
<label style="margin: 0;">Project Directory &amp; Filename</label>
<div style="display:flex; justify-content:flex-end;">
<button type="button" id="btn-import-dataset" class="secondary btn-sm" style="margin-right: 4px;">Import Dataset...</button>
<div class="form-group-header">
<label>Project Directory &amp; Filename</label>
<div class="btn-row-sm">
<button type="button" id="btn-import-dataset" class="secondary btn-sm">Import Dataset...</button>
<button type="button" id="btnOpenExisting" class="secondary btn-sm">Open Target (.ti2/.ti3)</button>
</div>
</div>
@@ -407,8 +407,8 @@
<!-- Target Label & Metadata (printtarg -d) -->
<div class="form-group" style="margin-top: 14px; padding-top: 14px; border-top: 1px solid var(--border-color, #333);">
<div style="display: flex; justify-content: space-between; align-items: center; margin-bottom: 6px;">
<label style="margin: 0; font-weight: 600;">Target Label &amp; Metadata (Optional)</label>
<div class="form-group-header">
<label class="form-group-title">Target Label &amp; Metadata (Optional)</label>
<button type="button" class="secondary btn-sm" id="btnToggleLabelEdit">Edit Custom Field</button>
</div>
<p class="sub-label" style="margin-bottom: 10px;">Printed below test patches to identify hardware, ink, and media used for this profiling run.</p>
@@ -481,7 +481,7 @@
<select id="printerSelect">
<option value="" disabled selected>Detecting printers...</option>
</select>
<button type="button" class="btn-icon" id="btnRefreshPrinters" title="Refresh printer list"></button>
<button type="button" class="btn-icon-sq" id="btnRefreshPrinters" title="Refresh printer list"></button>
<button type="button" class="btn-properties" id="btnPrinterProperties" title="Open native printer driver preferences (disable colour management, set media type, etc.)">⚙️ Preferences</button>
<span id="printerStatusBadge" class="status-badge badge-idle hidden">Idle</span>
</div>
@@ -521,7 +521,7 @@
</div>
<div class="print-actions-row">
<button class="primary btn-print" id="btnPrintAll">
<button class="primary" id="btnPrintAll">
<span class="btn-text">🖨️ Print All Pages (Bypass CM)</span>
<span class="btn-spinner hidden"></span>
</button>
@@ -550,8 +550,8 @@
<div class="form-container" style="margin-bottom: 16px;">
<div class="form-group">
<label for="chartreadInstrumentSelect">Communication Port</label>
<div class="input-row" style="display: flex; gap: 8px; align-items: center;">
<select id="chartreadInstrumentSelect" style="flex: 1;">
<div class="input-row-sm">
<select id="chartreadInstrumentSelect">
<option value="">Auto (First available port)</option>
</select>
<button type="button" class="secondary" id="btnDetectInstruments" title="Detect connected instruments via instlist">↻ Detect</button>
@@ -593,13 +593,13 @@
<!-- Multi-Pass Session & Averaging Controls -->
<div class="averaging-panel hidden" id="chartreadAveragingPanel" style="margin-top: 16px; padding: 14px; border: 1px solid var(--border-color, #333); border-radius: 8px; background: rgba(255, 255, 255, 0.03);">
<div style="display: flex; justify-content: space-between; align-items: center; margin-bottom: 8px;">
<h3 style="margin: 0; font-size: 1rem;">Multi-Pass Target Averaging</h3>
<div class="form-group-header">
<h3 class="form-group-title">Multi-Pass Target Averaging</h3>
<span id="passCounterBadge" class="status-badge badge-idle">Pass 1 Complete</span>
</div>
<p class="sub-label" style="margin-bottom: 12px;">Each successful sheet is saved as a separate _passN.ti3 file. Stage 4 stays locked until you finish. Measure extra copies to reduce noise, then finish to write the canonical .ti3.</p>
<div id="passesList" class="passes-list" style="display: flex; flex-direction: column; gap: 6px; margin-bottom: 12px;"></div>
<div style="display: flex; gap: 8px;">
<div class="btn-row">
<button type="button" class="secondary" id="btnMeasureAnotherSheet"> Measure Another Sheet</button>
<button type="button" class="primary" id="btnFinishAndAverage" title="Complete measurement (Finish) before profiling">✓ Average Passes &amp; Proceed →</button>
</div>
@@ -648,7 +648,7 @@
</select>
</div>
<div class="form-group">
<div class="form-group has-tooltip">
<label>OBA / FWA Compensation</label>
<select id="colprofFwa">
<option value="D50" selected>Calculated M1 — D50 FWA Compensation (Recommended)</option>
@@ -656,14 +656,24 @@
<option value="D65">D65 FWA Compensation</option>
<option value="custom">Custom Ambient Spectrum (.sp)...</option>
</select>
<div class="tooltip-text">
Select how colprof handles Optical Brightening Agent (OBA) / Fluorescent Whitening Agent (FWA) compensation.<br>
<strong>D50</strong>: Simulates ISO 3664 M1 viewing (D50, UV-cut) — recommended for modern OBA papers.<br>
<strong>None</strong>: Native M0; no FWA compensation. Can look yellow under D50 if the paper contains OBA.<br>
<strong>D65</strong>: Simulates outdoor D65 daylight; useful for outdoor display / packaging proofing.<br>
<strong>Custom (.sp)</strong>: Provide an Argyll spectrum file describing the viewing booth illuminant.
</div>
</div>
<div class="form-group hidden" id="colprofCustomSpRow">
<div class="form-group hidden has-tooltip" id="colprofCustomSpRow">
<label>Custom Spectrum File (.sp)</label>
<div style="display: flex; gap: 8px;">
<input type="text" id="colprofCustomSpPath" placeholder="Select .sp file..." readonly style="flex:1;">
<div class="input-row-sm">
<input type="text" id="colprofCustomSpPath" placeholder="Select .sp file..." readonly>
<button class="secondary btn-sm" id="btnBrowseCustomSp">Browse</button>
</div>
<div class="tooltip-text">
Path to an Argyll-format spectrum file (.sp) representing the ambient illuminant. This is passed to colprof via the -f option and overrides the built-in D50/D65 compensation.
</div>
</div>
<details class="advanced-section-details">
@@ -673,7 +683,7 @@
</summary>
<div class="advanced-content">
<div class="advanced-grid-2col">
<div class="form-group">
<div class="form-group has-tooltip">
<label>Standard Illuminant</label>
<select id="colprofIlluminant">
<option value="" selected>Default (D50)</option>
@@ -685,8 +695,11 @@
<option value="F8">F8</option>
<option value="F10">F10</option>
</select>
<div class="tooltip-text">
Illuminant used for the CIE colourimetric calculations in colprof (option -i). Leave at Default (D50) for normal print profiling.
</div>
</div>
<div class="form-group">
<div class="form-group has-tooltip">
<label>Standard Observer</label>
<select id="colprofObserver">
<option value="" selected>Default (1931 2°)</option>
@@ -694,8 +707,11 @@
<option value="2015_2">2015 2°</option>
<option value="2015_10">2015 10°</option>
</select>
<div class="tooltip-text">
CIE standard observer used for the colourimetric calculations (option -o). The 1931 2° observer is the default for graphic-arts profiling.
</div>
</div>
<div class="form-group">
<div class="form-group has-tooltip">
<label>Input Viewing Condition</label>
<select id="colprofInputViewCond">
<option value="none" selected>None</option>
@@ -704,8 +720,11 @@
<option value="pe">Print evaluation (CIE 116-1995)</option>
<option value="pm">Print evaluation (partial mid-tone adaptation)</option>
</select>
<div class="tooltip-text">
Viewing condition under which the print target was measured (option -c). This affects the adapted white point used in the profile lookup table.
</div>
</div>
<div class="form-group">
<div class="form-group has-tooltip">
<label>Output Viewing Condition</label>
<select id="colprofOutputViewCond">
<option value="none" selected>None</option>
@@ -716,6 +735,9 @@
<option value="jd">Projector in dark environment</option>
<option value="tv">Television/Film Studio</option>
</select>
<div class="tooltip-text">
Viewing condition under which the profile is intended to be used (option -d). Useful for creating display / output-referred profiles.
</div>
</div>
</div>
</div>
@@ -723,7 +745,7 @@
</div>
<div class="stage-actions">
<button class="primary" id="btnCreateProfile">Calculate Profile (.icc)</button>
<button class="primary btn-lg" id="btnCreateProfile">Calculate Profile (.icc)</button>
</div>
<!-- Spinner and Progress Stage -->
@@ -736,7 +758,7 @@
<div class="success-card hidden" id="colprofSuccessCard">
<h3>🎉 Profile Calculation Complete</h3>
<p id="colprofSuccessInfo"></p>
<button class="primary" id="btnGoToVerify">Proceed to Verification →</button>
<button class="primary btn-lg" id="btnGoToVerify">Proceed to Verification →</button>
</div>
<!-- Process Log -->
@@ -752,7 +774,7 @@
<p>Check the numerical accuracy of your profile against the original measurement data.</p>
<div class="stage-actions">
<button class="primary" id="btnVerify">Verify Profile Accuracy</button>
<button class="primary btn-lg" id="btnVerify">Verify Profile Accuracy</button>
</div>
<!-- Report Card -->
@@ -805,6 +827,10 @@
<span class="gamut-toggle-slider"></span>
</label>
</div>
<div class="gamut-legend-item gamut-slider-item">
<label for="rngProfileOpacity" class="gamut-slider-label">Opacity</label>
<input type="range" id="rngProfileOpacity" min="0.1" max="1" step="0.05" value="0.88">
</div>
<div class="gamut-legend-item">
<span class="gamut-swatch gamut-swatch-srgb"></span>
@@ -814,6 +840,10 @@
<span class="gamut-toggle-slider"></span>
</label>
</div>
<div class="gamut-legend-item gamut-slider-item">
<label for="rngSrgbOpacity" class="gamut-slider-label">Opacity</label>
<input type="range" id="rngSrgbOpacity" min="0.1" max="1" step="0.05" value="0.55">
</div>
<div class="gamut-legend-item">
<span class="gamut-swatch gamut-swatch-axes"></span>
@@ -823,6 +853,15 @@
<span class="gamut-toggle-slider"></span>
</label>
</div>
<div class="gamut-legend-item gamut-slider-item">
<label for="rngAxisOpacity" class="gamut-slider-label">Opacity</label>
<input type="range" id="rngAxisOpacity" min="0.1" max="1" step="0.05" value="0.8">
</div>
<div class="gamut-controls-actions">
<button type="button" id="btnGamutResetCamera" class="btn-sm" title="Reset camera to default view (R)">⟲ Reset View</button>
<span class="gamut-keyboard-hint">Press R to reset</span>
</div>
</div>
</div>
</div>
@@ -844,10 +883,37 @@
<label for="argyll_binary_dir">ArgyllCMS Binary Directory Override</label>
<input type="text" id="argyll_binary_dir" placeholder="Leave empty for bundled sidecars (e.g. /usr/bin)">
</div>
<div class="form-group">
<label for="default_instrument">Default Instrument Override</label>
<input type="text" id="default_instrument" placeholder="e.g. i1">
<div class="form-group" style="margin-top: 16px; padding-top: 14px; border-top: 1px solid var(--border-color, #333);">
<label style="font-weight: 600;">Instrument &amp; Measurement Preferences</label>
<div style="margin-top: 8px;">
<label for="default_instrument" class="sub-label">Default Instrument Override</label>
<input type="text" id="default_instrument" placeholder="e.g. i1">
</div>
<div style="margin-top: 12px;">
<label class="checkbox-label" for="enable_i1pro2_leds" style="display: flex; align-items: center; gap: 8px; cursor: pointer;">
<input type="checkbox" id="enable_i1pro2_leds">
<span>Enable i1Pro 2 status LEDs (<code>-Y l</code>)</span>
</label>
<small class="help-hint" style="display:block; font-size:0.75rem; color:var(--text-muted, #888); margin-top:3px;">Provides visual status feedback via the instrument ring LEDs during patch reading. Requires patched ArgyllCMS build.</small>
</div>
</div>
<div class="form-group" style="margin-top: 16px; padding-top: 14px; border-top: 1px solid var(--border-color, #333);">
<label style="font-weight: 600;">Stage 3 ΔE₀₀ Traffic-Light Thresholds</label>
<div class="input-row" style="margin-top: 8px; align-items: flex-start;">
<div>
<label for="deltaEGoodMax" class="sub-label">Good / Warning boundary</label>
<input type="number" id="deltaEGoodMax" min="0" step="0.1" value="2.0">
<small class="help-hint" style="display:block; font-size:0.75rem; color:var(--text-muted, #888); margin-top:3px;">ΔE below this value is shown as green (Good).</small>
</div>
<div>
<label for="deltaEWarningMax" class="sub-label">Warning / Bad boundary</label>
<input type="number" id="deltaEWarningMax" min="0" step="0.1" value="5.0">
<small class="help-hint" style="display:block; font-size:0.75rem; color:var(--text-muted, #888); margin-top:3px;">ΔE above this value is shown as red (Bad).</small>
</div>
</div>
<small id="deltaEThresholdError" class="help-hint" style="display:none; color: var(--error-color, #ff5f5f); margin-top: 6px;">Good threshold must be less than warning threshold.</small>
</div>
<div class="form-group" style="margin-top: 16px; padding-top: 14px; border-top: 1px solid var(--border-color, #333);">
<label style="font-weight: 600;">Diagnostics &amp; Logging</label>
<div class="input-row" style="margin-top: 8px;">
@@ -862,7 +928,7 @@
</select>
<small class="help-hint" style="display:block; font-size:0.75rem; color:var(--text-muted, #888); margin-top:3px;">Applies immediately on Save</small>
</div>
<div style="display: flex; align-items: flex-end; gap: 8px; flex-wrap: wrap;">
<div class="btn-row wrap">
<button type="button" id="btnOpenLogFolder" class="secondary" title="Open log folder in file explorer">📂 Open Log Folder</button>
<button type="button" id="btnCopyLogPath" class="secondary" title="Copy full log file path to clipboard">📋 Copy Path</button>
<button type="button" id="btnCopyLogExcerpt" class="secondary" title="Copy recent log entries (last 200 lines) to clipboard">📋 Copy Recent Logs</button>
@@ -884,7 +950,7 @@
<img src="./assets/ICCery-logo.svg" alt="ICCery Logo" class="about-logo" />
</div>
<h2>About ICCery</h2>
<p><strong>Version:</strong> <span id="aboutVersion">v0.7.2</span> &bull; <strong>Build Date:</strong> <span id="aboutBuildDate">September 2026</span></p>
<p><strong>Version:</strong> <span id="aboutVersion">v0.8.1</span> &bull; <strong>Build Date:</strong> <span id="aboutBuildDate">September 2026</span></p>
<p><strong>Copyright &copy; 2026 Gordon Bolton. All rights reserved.</strong></p>
<h3>Licences & EULA</h3>
<div class="license-text-container">
+7 -2
View File
@@ -426,8 +426,11 @@ export function initChartread() {
}
});
let lastStderrLine = "";
const unlistenStderr = await listen("process:stderr", (event) => {
if (event.payload.id === currentProcessId && event.payload.line) {
lastStderrLine = event.payload.line;
logPre.textContent += "ERR: " + event.payload.line + "\n";
logPre.scrollTop = logPre.scrollHeight;
}
@@ -471,8 +474,10 @@ export function initChartread() {
}
} else {
setState(STATE.FINISHED);
setPrompt(`❌ chartread exited with code ${event.payload.code}.`);
logPre.textContent += `\n[ERROR] chartread exited with code ${event.payload.code}.\n`;
if (logContainer) logContainer.open = true;
const errDetail = lastStderrLine ? ` (${lastStderrLine})` : "";
setPrompt(`❌ chartread exited with code ${event.payload.code}.${errDetail}`);
logPre.textContent += `\n[ERROR] chartread exited with code ${event.payload.code}.${errDetail}\n`;
}
setMeasurementBusy(false);
+174 -16
View File
@@ -204,30 +204,80 @@ function _line(from, to, material) {
}
// ─────────────────────────────────────────────────────────────────────────────
// Parse .gam file text → { vertices: [[L,a,b],...], faces: [[v0,v1,v2],...] }
/**
* Parse an Argyll `.gam` text file into vertex and face arrays.
*
* Argyll `.gam` files contain a header followed by one or more `BEGIN_DATA`
* ... `END_DATA` blocks. The first data block is a vertex list
* (index L a b); subsequent blocks contain triangle face indices (v0 v1 v2).
* Blank lines and hash `#` comments outside data blocks are ignored.
*
* @param {string} text - Raw contents of the .gam file.
* @returns {{ vertices: number[][], faces: number[][], warnings: string[] }}
*/
// ─────────────────────────────────────────────────────────────────────────────
export function parseGamutFile(text) {
const lines = text.split('\n');
const vertices = [];
const faces = [];
const warnings = [];
let dataStarted = false;
let dataBlock = 0; // 1 = vertices section, 2 = faces section
let dataBlock = 0; // 1 = vertices section, 2+ = faces sections
for (const line of lines) {
const trimmed = line.trim();
if (trimmed === 'BEGIN_DATA') { dataBlock++; dataStarted = true; continue; }
if (trimmed === 'END_DATA') { dataStarted = false; continue; }
for (let lineIdx = 0; lineIdx < lines.length; lineIdx++) {
const raw = lines[lineIdx];
const trimmed = raw.replace(/#.*$/, '').trim(); // strip inline comments
if (trimmed === '') continue;
if (trimmed.toUpperCase() === 'BEGIN_DATA') {
dataBlock++;
dataStarted = true;
continue;
}
if (trimmed.toUpperCase() === 'END_DATA') {
dataStarted = false;
continue;
}
if (!dataStarted) continue;
const parts = trimmed.split(/\s+/).map(Number);
if (dataBlock === 1 && parts.length >= 4) {
vertices.push([parts[1], parts[2], parts[3]]); // [L, a, b]
} else if (dataBlock === 2 && parts.length >= 3) {
faces.push([parts[0], parts[1], parts[2]]);
const allNumeric = parts.every(n => !Number.isNaN(n));
if (!allNumeric) {
warnings.push(`Skipping non-numeric data at line ${lineIdx + 1}`);
continue;
}
if (dataBlock === 1) {
if (parts.length >= 4) {
// Vertex format: index L a b (index is usually ignored)
const [_, L, a, b] = parts;
if (L < 0 || L > 100 || Math.abs(a) > 128 || Math.abs(b) > 128) {
warnings.push(`Vertex at line ${lineIdx + 1} is outside plausible CIELAB bounds: L=${L}, a=${a}, b=${b}`);
}
vertices.push([L, a, b]);
} else {
warnings.push(`Vertex data at line ${lineIdx + 1} has only ${parts.length} values`);
}
} else {
// Face data can appear in multiple blocks (some .gam files use a
// separate DATA block per surface type or per convex-hull section).
if (parts.length >= 3) {
faces.push([parts[0], parts[1], parts[2]]);
} else {
warnings.push(`Face data at line ${lineIdx + 1} has only ${parts.length} values`);
}
}
}
return { vertices, faces };
if (vertices.length > 0 && faces.length === 0) {
warnings.push(`Parsed ${vertices.length} vertices but no faces; will compute convex hull on the fly.`);
}
if (dataBlock === 0) {
warnings.push('No BEGIN_DATA blocks found; file may be empty or not a valid Argyll .gam file.');
}
return { vertices, faces, warnings };
}
// ─────────────────────────────────────────────────────────────────────────────
@@ -304,7 +354,10 @@ function _renderSrgbReference(text, previousGroup) {
});
}
const { vertices, faces } = parseGamutFile(text);
const { vertices, faces, warnings } = parseGamutFile(text);
if (warnings.length > 0) {
console.warn('Gamut parser warnings:', warnings.join('\n'));
}
const built = _buildGeometry(vertices, faces);
if (!built) return null;
@@ -348,7 +401,10 @@ function _renderProfileGamut(text, previousMesh) {
if (previousMesh.material) previousMesh.material.dispose();
}
const { vertices, faces } = parseGamutFile(text);
const { vertices, faces, warnings } = parseGamutFile(text);
if (warnings.length > 0) {
console.warn('Gamut parser warnings:', warnings.join('\n'));
}
const built = _buildGeometry(vertices, faces);
if (!built) return null;
@@ -383,7 +439,77 @@ function _renderProfileGamut(text, previousMesh) {
}
// ─────────────────────────────────────────────────────────────────────────────
// Public: load bundled sRGB reference gamut
// Camera & view controls
// ─────────────────────────────────────────────────────────────────────────────
/**
* Reset the camera to its default home position and orientation.
* Also resets orbit controls target to the centre of the CIELAB volume.
*/
export function resetCamera() {
if (!camera || !controls) return;
camera.position.set(180, 120, 180);
camera.lookAt(0, 50, 0);
controls.target.set(0, 50, 0);
controls.update();
}
/**
* Set the opacity of the rendered profile gamut surface (01).
* @param {number} opacity
*/
export function setProfileOpacity(opacity) {
if (currentProfileMesh && currentProfileMesh.material) {
currentProfileMesh.material.opacity = Math.max(0, Math.min(1, opacity));
currentProfileMesh.material.transparent = opacity < 1;
currentProfileMesh.material.needsUpdate = true;
}
}
/**
* Set the opacity of the sRGB reference wireframe and fill (01).
* @param {number} opacity
*/
export function setSrgbReferenceOpacity(opacity) {
if (sRgbGroup) {
sRgbGroup.traverse((child) => {
if (child.material) {
child.material.opacity = child.material.opacity >= 0.5
? Math.max(0.05, Math.min(1, opacity))
: Math.max(0.02, Math.min(0.2, opacity * 0.2));
}
});
}
}
/**
* Set the opacity of the CIELAB axis scaffold (01).
* @param {number} opacity
*/
export function setAxisOpacity(opacity) {
if (axisScaffoldGroup) {
axisScaffoldGroup.traverse((child) => {
if (child.material) {
child.material.opacity = Math.max(0, Math.min(1, opacity));
}
});
}
}
/**
* Handle keyboard shortcuts for the gamut viewer.
* @param {KeyboardEvent} e
*/
function _onKeyDown(e) {
if (e.key === 'r' || e.key === 'R') {
resetCamera();
}
}
// ─────────────────────────────────────────────────────────────────────────────
/**
* Load and render the bundled sRGB reference gamut.
* @returns {Promise<void>}
*/
// ─────────────────────────────────────────────────────────────────────────────
export async function loadSrgbReferenceGamut() {
try {
@@ -398,7 +524,11 @@ export async function loadSrgbReferenceGamut() {
}
// ─────────────────────────────────────────────────────────────────────────────
// Public: load and render a profile gamut from a .gam file path
/**
* Load and render a profile gamut from a `.gam` file path.
* @param {string} gamFilePath - Absolute path to the gamut file.
* @returns {Promise<THREE.Mesh|null>}
*/
// ─────────────────────────────────────────────────────────────────────────────
export async function loadGamutMesh(gamFilePath) {
try {
@@ -428,7 +558,7 @@ export function toggleAxes(visible) {
}
// ─────────────────────────────────────────────────────────────────────────────
// Wire legend toggle checkboxes to the toggle functions
// Wire legend toggle checkboxes, opacity sliders, and reset button
// ─────────────────────────────────────────────────────────────────────────────
function _wireToggles() {
const bindings = [
@@ -440,4 +570,32 @@ function _wireToggles() {
const el = document.getElementById(id);
if (el) el.addEventListener('change', (e) => fn(e.target.checked));
}
const resetBtn = document.getElementById('btnGamutResetCamera');
if (resetBtn) resetBtn.addEventListener('click', resetCamera);
const profileOpacity = document.getElementById('rngProfileOpacity');
if (profileOpacity) {
profileOpacity.addEventListener('input', (e) => setProfileOpacity(parseFloat(e.target.value)));
}
const srgbOpacity = document.getElementById('rngSrgbOpacity');
if (srgbOpacity) {
srgbOpacity.addEventListener('input', (e) => setSrgbReferenceOpacity(parseFloat(e.target.value)));
}
const axisOpacity = document.getElementById('rngAxisOpacity');
if (axisOpacity) {
axisOpacity.addEventListener('input', (e) => setAxisOpacity(parseFloat(e.target.value)));
}
// Only listen for 'R' reset when the viewer tab is active.
const stage5 = document.getElementById('stage-5');
if (stage5) {
stage5.addEventListener('keydown', (e) => {
if ((e.key === 'r' || e.key === 'R') && !stage5.classList.contains('hidden')) {
resetCamera();
}
});
}
}
+80
View File
@@ -0,0 +1,80 @@
// Manual / browser-console tests for gamut_viewer.js and profcheck.js parsing.
// Run in a browser/devtools console after the app has loaded:
// import('./gamut_viewer.test.js').then(m => m.runAll())
import { parseGamutFile } from './gamut_viewer.js';
export function runAll() {
console.group('gamut/profcheck parser tests');
testParseGamutBasic();
testParseGamutDualTable();
testParseGamutWithComments();
console.groupEnd();
}
function assertEqual(actual, expected, message) {
const ok = JSON.stringify(actual) === JSON.stringify(expected);
if (ok) {
console.log('PASS:', message);
} else {
console.error('FAIL:', message, 'expected', expected, 'got', actual);
}
return ok;
}
function testParseGamutBasic() {
const text = `GAMUT file
BEGIN_DATA
0 50 0 0
1 100 0 0
2 0 -128 0
3 0 0 128
END_DATA
BEGIN_DATA
0 1 2
1 2 3
END_DATA`;
const { vertices, faces, warnings } = parseGamutFile(text);
assertEqual(vertices.length, 4, 'basic gamut vertex count');
assertEqual(faces.length, 2, 'basic gamut face count');
assertEqual(warnings.length, 0, 'basic gamut no warnings');
}
function testParseGamutDualTable() {
const text = `GAMUT file
BEGIN_DATA
0 50 0 0
1 100 0 0
2 0 -128 0
3 0 0 128
END_DATA
BEGIN_DATA
0 1 2
END_DATA
BEGIN_DATA
1 2 3
END_DATA`;
const { vertices, faces, warnings } = parseGamutFile(text);
assertEqual(vertices.length, 4, 'dual-table gamut vertex count');
assertEqual(faces.length, 2, 'dual-table gamut face count');
assertEqual(warnings.length, 0, 'dual-table gamut no warnings');
}
function testParseGamutWithComments() {
const text = `GAMUT file
# this is a comment
BEGIN_DATA
0 50 0 0
1 100 0 0
# inline comment
2 0 -128 0
3 0 0 128
END_DATA
BEGIN_DATA
0 1 2
1 2 3
END_DATA`;
const { vertices, faces, warnings } = parseGamutFile(text);
assertEqual(vertices.length, 4, 'commented gamut vertex count');
assertEqual(faces.length, 2, 'commented gamut face count');
}
+76 -13
View File
@@ -98,7 +98,14 @@ export function initProfcheck() {
// Ensure gamut mesh is loaded into 3D viewer
const gamFilePath = cwd ? `${cwd}${sep}${basename}.gam` : `${basename}.gam`;
loadGamutMesh(gamFilePath, 0x3b82f6);
try {
const result = await loadGamutMesh(gamFilePath);
if (!result) {
logPre.textContent += `\n[WARN] Could not render 3D gamut mesh from ${gamFilePath}.\n`;
}
} catch (gamErr) {
logPre.textContent += `\n[WARN] 3D gamut render failed: ${gamErr}\n`;
}
} else {
logPre.textContent += `\n[ERROR] profcheck exited with code ${event.payload.code}.\n`;
}
@@ -113,33 +120,89 @@ export function initProfcheck() {
}
});
/**
* Parse profcheck output for Average, Peak, and RMS delta-E values.
* Supports both Argyll's JSON-style summary and plain-text legacy output.
* @param {string} stdout - Full profcheck stdout.
*/
function parseAndRenderReport(stdout) {
reportCard.classList.remove("hidden");
let avgDe = 0.0;
let maxDe = 0.0;
let rmsDe = 0.0;
let parserWarnings = [];
// Check if JSON output is present
const jsonMatch = stdout.match(/\{[\s\S]*"avg_de"[\s\S]*\}/);
if (jsonMatch) {
// Argyll's JSON output can appear either as a compact object on a single
// line or embedded inside larger text. Try to find and parse the LAST valid
// JSON object in the output, which is most likely the summary.
const jsonObjects = [];
const re = /\{[\s\S]*?\}/g;
let m;
while ((m = re.exec(stdout)) !== null) {
try {
const json = JSON.parse(jsonMatch[0]);
avgDe = json.avg_de || 0;
maxDe = json.max_de || json.peak_de || 0;
rmsDe = json.rms_de || 0;
const parsed = JSON.parse(m[0]);
if (typeof parsed === 'object' && parsed !== null && ('avg_de' in parsed || 'peak_de' in parsed || 'rms_de' in parsed)) {
jsonObjects.push(parsed);
}
} catch (e) {
console.error("JSON parse error:", e);
// Not a valid JSON object, ignore.
}
}
if (jsonObjects.length > 0) {
const json = jsonObjects[jsonObjects.length - 1];
avgDe = typeof json.avg_de === 'number' ? json.avg_de : 0;
maxDe = typeof json.max_de === 'number' ? json.max_de : (typeof json.peak_de === 'number' ? json.peak_de : 0);
rmsDe = typeof json.rms_de === 'number' ? json.rms_de : 0;
} else {
// Regex fallbacks for standard profcheck output
const avgMatch = stdout.match(/avg\.\s*(?:dE\s*)?=\s*([\d\.]+)/i) || stdout.match(/average\s*(?:dE\s*)?[:=]\s*([\d\.]+)/i);
const maxMatch = stdout.match(/max\.\s*(?:dE\s*)?=\s*([\d\.]+)/i) || stdout.match(/peak\s*(?:dE\s*)?[:=]\s*([\d\.]+)/i);
const rmsMatch = stdout.match(/RMS\s*(?:dE\s*)?=\s*([\d\.]+)/i) || stdout.match(/rms\s*(?:dE\s*)?[:=]\s*([\d\.]+)/i);
// Regex fallbacks for standard profcheck text output
const avgPatterns = [
/avg(?:\.?|erage)\s*(?:dE\s*)?[:=]\s*([\d\.]+)/i,
/average\s+(?:dE\s*)?([\d\.]+)/i,
/mean\s+(?:dE\s*)?([\d\.]+)/i,
/dE\s+average[^\d]*([\d\.]+)/i,
];
const maxPatterns = [
/max(?:\.?|imum)\s*(?:dE\s*)?[:=]\s*([\d\.]+)/i,
/peak\s*(?:dE\s*)?[:=]\s*([\d\.]+)/i,
/worst\s*(?:dE\s*)?([\d\.]+)/i,
/dE\s+max[^\d]*([\d\.]+)/i,
];
const rmsPatterns = [
/RMS\s*(?:dE\s*)?[:=]\s*([\d\.]+)/i,
/rms\s*(?:dE\s*)?([\d\.]+)/i,
/root\s+mean\s+sq(?:uare)?\s*(?:dE\s*)?([\d\.]+)/i,
];
const find = (patterns) => {
for (const p of patterns) {
const match = stdout.match(p);
if (match) return match;
}
return null;
};
const avgMatch = find(avgPatterns);
const maxMatch = find(maxPatterns);
const rmsMatch = find(rmsPatterns);
if (avgMatch) avgDe = parseFloat(avgMatch[1]);
else parserWarnings.push('Could not detect Average ΔE in profcheck output.');
if (maxMatch) maxDe = parseFloat(maxMatch[1]);
else parserWarnings.push('Could not detect Peak ΔE in profcheck output.');
if (rmsMatch) rmsDe = parseFloat(rmsMatch[1]);
else parserWarnings.push('Could not detect RMS ΔE in profcheck output.');
if (!avgMatch && !maxMatch && !rmsMatch) {
parserWarnings.push('No delta-E values were found in profcheck output.');
}
}
if (parserWarnings.length > 0) {
logPre.textContent += `\n[WARN] ${parserWarnings.join(' ')}\n`;
}
avgDeEl.textContent = avgDe.toFixed(2);
+48
View File
@@ -1,6 +1,13 @@
const { invoke } = window.__TAURI__.core;
import { logger } from './logger.js';
function getInputValueAsFloat(id, fallback) {
const el = document.getElementById(id);
if (!el) return fallback;
const v = parseFloat(el.value);
return Number.isNaN(v) ? fallback : v;
}
export async function initSettings() {
const dialog = document.getElementById('settingsDialog');
const openBtn = document.getElementById('openSettingsBtn');
@@ -11,6 +18,10 @@ export async function initSettings() {
const btnCopyLogPath = document.getElementById('btnCopyLogPath');
const btnCopyLogExcerpt = document.getElementById('btnCopyLogExcerpt');
const logPathDisplay = document.getElementById('logPathDisplay');
const deltaEGoodMax = document.getElementById('deltaEGoodMax');
const deltaEWarningMax = document.getElementById('deltaEWarningMax');
const deltaEThresholdError = document.getElementById('deltaEThresholdError');
const enableI1Pro2Leds = document.getElementById('enable_i1pro2_leds');
if (!dialog || !openBtn) return;
@@ -24,14 +35,42 @@ export async function initSettings() {
}
}
function validateDeltaEThresholds() {
if (!deltaEGoodMax || !deltaEWarningMax) return true;
const good = parseFloat(deltaEGoodMax.value);
const warn = parseFloat(deltaEWarningMax.value);
const valid = !Number.isNaN(good) && !Number.isNaN(warn) && good < warn && good >= 0 && warn >= 0;
if (deltaEThresholdError) {
deltaEThresholdError.style.display = valid ? 'none' : 'block';
}
return valid;
}
if (deltaEGoodMax) {
deltaEGoodMax.addEventListener('input', validateDeltaEThresholds);
}
if (deltaEWarningMax) {
deltaEWarningMax.addEventListener('input', validateDeltaEThresholds);
}
openBtn.addEventListener('click', async () => {
try {
const settings = await invoke('load_settings');
document.getElementById('argyll_binary_dir').value = settings.argyll_binary_dir || '';
document.getElementById('default_instrument').value = settings.default_instrument || '';
if (enableI1Pro2Leds) {
enableI1Pro2Leds.checked = Boolean(settings.enable_i1pro2_leds);
}
if (logLevelSelect && settings.log_level) {
logLevelSelect.value = settings.log_level;
}
if (deltaEGoodMax) {
deltaEGoodMax.value = Number(settings.delta_e_good_max ?? 2.0).toFixed(1);
}
if (deltaEWarningMax) {
deltaEWarningMax.value = Number(settings.delta_e_warning_max ?? 5.0).toFixed(1);
}
validateDeltaEThresholds();
await refreshLogPath();
dialog.showModal();
} catch (e) {
@@ -99,18 +138,27 @@ export async function initSettings() {
if (saveBtn) {
saveBtn.addEventListener('click', async () => {
try {
if (!validateDeltaEThresholds()) {
throw new Error('Invalid ΔE thresholds');
}
const currentSettings = await invoke('load_settings').catch(() => ({}));
const settings = {
...currentSettings,
argyll_binary_dir: document.getElementById('argyll_binary_dir').value.trim() || null,
default_instrument: document.getElementById('default_instrument').value.trim() || null,
log_level: logLevelSelect ? logLevelSelect.value : (currentSettings.log_level || 'info'),
delta_e_good_max: getInputValueAsFloat('deltaEGoodMax', 2.0),
delta_e_warning_max: getInputValueAsFloat('deltaEWarningMax', 5.0),
enable_i1pro2_leds: enableI1Pro2Leds ? enableI1Pro2Leds.checked : false,
};
await invoke('save_settings', { settings });
logger.info(`Settings saved. Log level set to: ${settings.log_level}`, 'Settings');
// Notify other UI modules (e.g. swatch grid) that settings changed.
window.dispatchEvent(new CustomEvent('settings-saved', { detail: settings }));
dialog.close();
} catch (e) {
logger.error(`Failed to save settings: ${e}`, 'Settings');
alert(`Failed to save settings: ${e}`);
}
});
}
+87 -14
View File
@@ -1,10 +1,76 @@
import { computeDeltaE00 } from './delta_e.js';
import { labToCss, deviceRgbToCss, deviceCmykToCss } from './color_convert.js';
const { listen } = window.__TAURI__.event;
const { listen, emit } = window.__TAURI__.event;
const { invoke } = window.__TAURI__.core;
let unlistenJsonRow = null;
// Cached ΔE thresholds; refreshed from settings on load and when settings change.
let deltaEThresholds = { goodMax: 2.0, warnMax: 5.0 };
/**
* Load the ΔE traffic-light thresholds from persisted app settings.
* Falls back to 2.0 / 5.0 if settings are missing or malformed.
*/
async function refreshDeltaEThresholds() {
try {
const s = await invoke('load_settings');
deltaEThresholds = {
goodMax: s.delta_e_good_max ?? 2.0,
warnMax: s.delta_e_warning_max ?? 5.0,
};
// Enforce the invariant at runtime in case a user hand-edited settings.json.
if (deltaEThresholds.goodMax > deltaEThresholds.warnMax) {
console.warn('ΔE thresholds invalid (good > warning); resetting to defaults.');
deltaEThresholds = { goodMax: 2.0, warnMax: 5.0 };
}
} catch (err) {
console.warn('Could not load ΔE thresholds, using defaults:', err);
deltaEThresholds = { goodMax: 2.0, warnMax: 5.0 };
}
}
/**
* Classify a CIEDE2000 value using the current thresholds.
* @param {number} deltaE
* @returns {{ label: string, cssClass: string }}
*/
function classifyDeltaE(deltaE) {
if (deltaE < deltaEThresholds.goodMax) {
return { label: "Good", cssClass: "de-good" };
} else if (deltaE < deltaEThresholds.warnMax) {
return { label: "Warning", cssClass: "de-warning" };
} else {
return { label: "Bad", cssClass: "de-bad" };
}
}
/**
* Re-classify all already-rendered swatches using the current thresholds.
* Call this after the user changes thresholds in Settings.
*/
function reclassifySwatches() {
document.querySelectorAll('.swatch-patch[data-delta-e]').forEach((patchEl) => {
const deltaE = parseFloat(patchEl.dataset.deltaE);
if (Number.isNaN(deltaE)) return;
patchEl.classList.remove('de-good', 'de-warning', 'de-bad');
const { cssClass, label } = classifyDeltaE(deltaE);
patchEl.classList.add(cssClass);
// Update the classification word in the title without re-parsing everything.
if (patchEl.title) {
patchEl.title = patchEl.title.replace(/\s*\([^)]*\)$/, '') + ` (${label})`;
}
});
}
// Listen for the custom event emitted by settings.js after a successful save.
window.addEventListener('settings-saved', () => {
refreshDeltaEThresholds().then(reclassifySwatches);
});
/**
* Start listening for row events from a chartread process.
* @param {string} processId - The process ID (e.g. "chartread_my_profile")
@@ -16,6 +82,9 @@ export async function startSwatchListener(processId, onRowComplete) {
const progressText = document.getElementById("readProgressText");
const statsPanel = document.getElementById("readStats");
// Load thresholds at listener start
await refreshDeltaEThresholds();
// Clear previous state
grid.innerHTML = "";
let totalPatches = 0;
@@ -51,6 +120,8 @@ export async function startSwatchListener(processId, onRowComplete) {
if (progressText) progressText.textContent = `Strip ${data.row_id}${data.row_index + 1} / ${data.total_rows}`;
// Create row container
// Row and patch order from chartread (A->Z, 1->N) is rendered
// left-to-right / top-to-bottom to match the printtarg output.
const rowEl = document.createElement("div");
rowEl.className = "swatch-row";
@@ -63,6 +134,10 @@ export async function startSwatchListener(processId, onRowComplete) {
rowPatches.className = "swatch-row-patches";
for (const patch of data.patches) {
// Argyll marks spacer/boundary patches with is_pad. Some printtarg
// layouts also flag white reference patches (-e white steps) as pads,
// but those carry valid expected or measured device data. Only skip
// pads that have no measurement and no non-zero device coordinates.
if (patch.is_pad && !patch.measured && (!patch.device || patch.device.every(v => v === 0))) continue;
const patchEl = document.createElement("div");
@@ -84,20 +159,21 @@ export async function startSwatchListener(processId, onRowComplete) {
const swatch = document.createElement("div");
swatch.className = "swatch-color";
if (measuredCss) {
swatch.style.background = `linear-gradient(135deg, ${intendedCss} 50%, ${measuredCss} 50%)`;
} else {
swatch.style.backgroundColor = intendedCss;
}
patchEl.appendChild(swatch);
// Build a structured tooltip for the patch
let titleStr = `${patch.loc} (ID: ${patch.id})`;
if (patch.expected && patch.expected.Lab) {
titleStr += `\nIntended Lab: ${patch.expected.Lab.map(v => v.toFixed(1)).join(', ')}`;
} else if (patch.device) {
titleStr += `\nDevice: ${patch.device.map(v => v.toFixed(1)).join(', ')}`;
titleStr += `\nIntended Device: ${patch.device.map(v => v.toFixed(1)).join(', ')}`;
}
if (patch.measured && patch.measured.Lab) {
@@ -107,22 +183,19 @@ export async function startSwatchListener(processId, onRowComplete) {
// Compute and display ΔE₀₀ if both expected and measured Lab are present
if (patch.expected && patch.expected.Lab && patch.measured && patch.measured.Lab) {
const deltaE = computeDeltaE00(patch.expected.Lab, patch.measured.Lab);
const { label, cssClass } = classifyDeltaE(deltaE);
// Persist the raw ΔE on the element so re-classification works after
// the user changes thresholds in Settings.
patchEl.dataset.deltaE = deltaE.toFixed(4);
const deLabel = document.createElement("div");
deLabel.className = "swatch-de";
deLabel.textContent = deltaE.toFixed(1);
titleStr += `\nΔE₀₀: ${deltaE.toFixed(2)}`;
// Traffic light classification
if (deltaE < 2) {
patchEl.classList.add("de-good"); // Green
} else if (deltaE < 5) {
patchEl.classList.add("de-warning"); // Amber
} else {
patchEl.classList.add("de-bad"); // Red
}
titleStr += `\nΔE₀₀: ${deltaE.toFixed(2)} (${label})`;
patchEl.classList.add(cssClass);
patchEl.appendChild(deLabel);
// Accumulate stats
+16
View File
@@ -0,0 +1,16 @@
// Manual smoke tests for swatch_grid.js
// Run in a browser/devtools console after the app has loaded:
// import('./swatch_grid.test.js').then(m => m.runAll())
export function runAll() {
console.group('swatch_grid smoke tests');
testClassifyDeltaE();
console.groupEnd();
}
function testClassifyDeltaE() {
// classifyDeltaE is currently internal to swatch_grid.js, but we can
// validate the visual classification by exercising the colour thresholds.
// This is a placeholder for a future unit-test harness.
console.log('testClassifyDeltaE: no direct export; validated by manual inspection');
}
+139 -22
View File
@@ -5,6 +5,11 @@
--text-color: #d4d4d4;
--accent-color: #007acc;
--border-color: #333333;
--btn-height-sm: 28px;
--btn-height-md: 36px;
--btn-height-lg: 40px;
--btn-radius-sm: 4px;
--btn-radius-md: 6px;
}
body {
@@ -127,25 +132,27 @@ button.primary {
background: linear-gradient(135deg, var(--accent-color), #2d73a8);
color: #fff;
border: none;
border-radius: 6px;
border-radius: var(--btn-radius-md);
padding: 0 18px;
height: 36px;
height: var(--btn-height-md);
font-size: 0.95rem;
font-weight: 600;
cursor: pointer;
transition: opacity 0.2s, transform 0.1s;
box-shadow: 0 4px 6px rgba(0, 0, 0, 0.2);
box-sizing: border-box;
}
button.primary:hover {
opacity: 0.9;
}
/* Button sizing system */
.btn-sm { height: 28px; padding: 0 10px; font-size: 0.78rem; border-radius: 4px; }
.btn-md { height: 36px; padding: 0 16px; font-size: 0.875rem; border-radius: 6px; }
.btn-lg { height: 40px; padding: 0 20px; font-size: 0.95rem; font-weight: 600; border-radius: 6px; }
.btn-icon-sq { width: 36px; height: 36px; min-width: 36px; padding: 0; display: inline-flex; align-items: center; justify-content: center; }
/* Button sizing system — use CSS variables for consistency across the UI */
.btn-sm { height: var(--btn-height-sm); padding: 0 10px; font-size: 0.78rem; border-radius: var(--btn-radius-sm); box-sizing: border-box; }
.btn-md { height: var(--btn-height-md); padding: 0 16px; font-size: 0.875rem; border-radius: var(--btn-radius-md); box-sizing: border-box; }
.btn-lg { height: var(--btn-height-lg); padding: 0 20px; font-size: 0.95rem; font-weight: 600; border-radius: var(--btn-radius-md); box-sizing: border-box; }
button.primary.btn-lg { height: var(--btn-height-lg); }
.btn-icon-sq { width: var(--btn-height-md); height: var(--btn-height-md); min-width: var(--btn-height-md); padding: 0; display: inline-flex; align-items: center; justify-content: center; box-sizing: border-box; }
/* Action containers */
.stage-actions {
@@ -163,10 +170,63 @@ button.primary:hover {
justify-content: flex-end;
}
/* Utility for a horizontal row of buttons (replaces inline style="display:flex;..." on parent divs) */
.btn-row {
display: flex;
align-items: center;
gap: 8px;
}
.btn-row-end {
display: flex;
align-items: center;
justify-content: flex-end;
gap: 8px;
}
.btn-row-sm {
display: flex;
align-items: center;
gap: 6px;
}
.btn-row.wrap,
.btn-row-sm.wrap {
flex-wrap: wrap;
}
.form-group {
margin: 14px 0;
}
.form-group-header {
display: flex;
justify-content: space-between;
align-items: center;
margin-bottom: 6px;
}
.form-group-header label {
margin: 0;
}
.form-group-label-small {
font-size: 0.75rem;
text-transform: uppercase;
letter-spacing: 0.05em;
opacity: 0.7;
font-weight: 600;
}
.form-group-title {
font-weight: 600;
}
.form-group-header h3 {
margin: 0;
font-size: 1rem;
}
.form-group:first-child {
margin-top: 0;
}
@@ -254,6 +314,17 @@ select option:checked {
align-items: stretch;
}
.input-row-sm {
display: flex;
gap: 8px;
align-items: center;
}
.input-row-sm > input,
.input-row-sm > select {
flex: 1;
}
.input-row input {
flex: 1;
}
@@ -284,9 +355,10 @@ button.secondary {
color: white;
border: 1px solid var(--border-color);
padding: 0 16px;
height: 36px;
border-radius: 4px;
height: var(--btn-height-md);
border-radius: var(--btn-radius-sm);
cursor: pointer;
box-sizing: border-box;
}
button.secondary:hover {
@@ -489,6 +561,7 @@ button:disabled {
.chartread-actions {
display: flex;
gap: 10px;
align-items: center;
margin-bottom: 16px;
flex-wrap: wrap;
}
@@ -497,9 +570,10 @@ button.danger {
background-color: #c62828;
color: white;
border: none;
padding: 10px 20px;
font-size: 1rem;
border-radius: 4px;
padding: 0 16px;
height: var(--btn-height-md);
font-size: 0.875rem;
border-radius: var(--btn-radius-sm);
cursor: pointer;
}
@@ -779,12 +853,12 @@ button.danger:hover {
font-size: 1.2rem;
cursor: pointer;
padding: 0;
border-radius: 4px;
border-radius: var(--btn-radius-sm);
color: #d1d5db;
transition: color 0.15s ease, background-color 0.15s ease;
width: 28px;
height: 28px;
min-width: 28px;
width: var(--btn-height-sm);
height: var(--btn-height-sm);
min-width: var(--btn-height-sm);
display: inline-flex;
align-items: center;
justify-content: center;
@@ -973,8 +1047,9 @@ button.danger:hover {
background: rgba(255, 255, 255, 0.06);
border: 1px solid var(--border-color);
color: var(--text-color);
padding: 6px 12px;
border-radius: 4px;
padding: 0 12px;
height: var(--btn-height-md);
border-radius: var(--btn-radius-sm);
font-size: 0.82rem;
font-weight: 500;
cursor: pointer;
@@ -984,6 +1059,7 @@ button.danger:hover {
gap: 6px;
transition: all 0.2s ease;
flex-shrink: 0;
box-sizing: border-box;
}
.btn-properties:hover {
@@ -1042,20 +1118,24 @@ button.danger:hover {
font-weight: 600;
}
/* Legacy alias: .btn-icon should not be used for new buttons; prefer .btn-icon-sq */
.btn-icon {
width: var(--btn-height-md);
height: var(--btn-height-md);
min-width: var(--btn-height-md);
padding: 0;
background: var(--bg-color);
border: 1px solid var(--border-color);
color: var(--text-color);
width: 34px;
height: 34px;
border-radius: 4px;
display: flex;
border-radius: var(--btn-radius-sm);
display: inline-flex;
align-items: center;
justify-content: center;
cursor: pointer;
font-size: 1rem;
transition: all 0.2s;
flex-shrink: 0;
box-sizing: border-box;
}
.btn-icon:hover {
@@ -1450,6 +1530,43 @@ button.danger:hover {
margin-bottom: 0;
}
.gamut-legend-item.gamut-slider-item {
margin: -2px 0 8px 27px;
gap: 6px;
}
.gamut-slider-label {
font-size: 0.7rem;
opacity: 0.65;
min-width: 46px;
}
.gamut-slider-item input[type="range"] {
flex: 1;
margin: 0;
height: 4px;
accent-color: var(--accent-color, #3b82f6);
}
.gamut-controls-actions {
margin-top: 10px;
padding-top: 10px;
border-top: 1px solid rgba(255, 255, 255, 0.09);
display: flex;
flex-direction: column;
gap: 6px;
}
.gamut-controls-actions button {
width: 100%;
}
.gamut-keyboard-hint {
font-size: 0.68rem;
opacity: 0.5;
text-align: center;
}
.gamut-legend-label {
flex: 1;
white-space: nowrap;