Development

Merge pull request 'Development' (#217) from development into main

.gitea/workflows/build-macos.yml

@@ -71,6 +71,21 @@ jobs:
           test -x "src-tauri/argyll/${{ matrix.platform.binary_dir }}/instlist"
           test -x "src-tauri/argyll/${{ matrix.platform.binary_dir }}/targen"
 
+      - name: Run Rust tests
+        shell: bash
+        env:
+          CARGO_INCREMENTAL: "0"
+          CARGO_TARGET_DIR: "${{ runner.temp }}/cargo-target"
+        run: |
+          cd src-tauri
+          if [ "${{ matrix.platform.target }}" = "universal-apple-darwin" ]; then
+            cargo test
+          elif [ "${{ matrix.platform.target }}" = "aarch64-apple-darwin" ] && [ "$(uname -m)" != "arm64" ]; then
+            cargo test --no-run --target ${{ matrix.platform.target }}
+          else
+            cargo test --target ${{ matrix.platform.target }}
+          fi
+
       - name: Set Release Environment
         id: set_env
         shell: bash

AGENTS.md

@@ -163,9 +163,9 @@ The "Preferences" button opens the native macOS `NSPrintPanel` (not CUPS web UI
 - Defaults to `false` ensuring 100% out-of-the-box compatibility with stock upstream ArgyllCMS binaries.
 - Subprocess error diagnostics in `chartread.js` capture `lastStderrLine` from `process:stderr`, auto-expanding the Process Output `<details>` panel with the stderr explanation if an unpatched binary rejects `-Y l`.
 
-## CI & Cross-Compilation
+## CI & Cross-Compilation Testing
 
-- Release packaging workflows live under `.gitea/workflows/` (`build-macos.yml`, `build-linux.yml`, `build-windows.yml`).
-- Tag release builds focus exclusively on packaging via `npm run tauri build` without redundant debug-profile test compilations.
-- Local/CI cross-compilation test execution for Apple Silicon (`aarch64-apple-darwin`) on Intel hosts must use `cargo test --no-run --target aarch64-apple-darwin` to avoid executing ARM64 binaries on an x86_64 CPU (`Bad CPU type in executable (os error 86)`).
+- macOS CI workflow lives in `.gitea/workflows/build-macos.yml`.
+- On Intel runner hosts, cross-compiling for Apple Silicon (`aarch64-apple-darwin`) must use `cargo test --no-run --target aarch64-apple-darwin`. This validates sidecar packaging, compilation, and link correctness without attempting to execute ARM64 binaries on an Intel CPU (`Bad CPU type in executable (os error 86)`).
+- Universal and native Intel matrix jobs run and execute full tests natively.
 

README.md

@@ -2,7 +2,7 @@
 
 > Modern, cross-platform native desktop application for printer profiling, powered by ArgyllCMS.
 
-[![Release](https://img.shields.io/badge/version-v0.8.4-blue.svg)](https://git.i3omb.com/gronod/ICCery)
+[![Release](https://img.shields.io/badge/version-v0.8.3-blue.svg)](https://git.i3omb.com/gronod/ICCery)
 [![Platform](https://img.shields.io/badge/platform-Windows%20%7C%20macOS%20%7C%20Linux-lightgrey.svg)](https://git.i3omb.com/gronod/ICCery)
 [![Framework](https://img.shields.io/badge/framework-Tauri%20v2%20%2B%20Rust-orange.svg)](https://tauri.app)
 [![License](https://img.shields.io/badge/license-Proprietary%20%2F%20EULA-blue.svg)](LICENCE.md)

ROADMAP.md

@@ -14,7 +14,7 @@ ICCery is a native, cross-platform desktop application built with:
 - **Frontend**: Vanilla JS (ES Modules) + HTML5/CSS3 with a modern dark theme and responsive layout.
 - **Visualization**: Three.js WebGL engine for 3D CIELAB color gamut volumes and sRGB reference comparisons.
 - **Engine**: ArgyllCMS command-line utilities orchestrated over isolated standard stream IPC (`stdin`, `stdout`, `stderr`).
-- **Current Version**: `v0.8.4` (Production release).
+- **Current Version**: `v0.8.3` (Production release).
 
 ---
 
@@ -113,10 +113,6 @@ ICCery is a native, cross-platform desktop application built with:
 - [x] **Custom Spectrum File Picker Dialog (#210)**: Implemented native `select_spectrum_file` command wrapping Tauri file dialog with `.sp` filter for custom FWA/OBA spectrum selection in Stage 4 profile generation.
 - [x] **CGATS Dataset Import File Picker & State Synchronization (#211)**: Implemented native `select_dataset_file` command with `.ti3`, `.txt`, `.cgats`, and `.csv` filter, synchronized wizard target directory and basename upon import, and guarded against empty target states.
 
-### Maintenance & Reliability Release (`v0.8.4`)
-- [x] **Atomic Verification History Persistence (#213)**: Hardened `quality_store.rs` with atomic temporary file writes (`.tmp`), explicit flush/sync, and atomic rename to prevent historical drift data loss or corruption upon unexpected system crashes.
-- [x] **Frontend Unit Testing & CI Integration (#215)**: Added standard `npm test` script executing the 3 frontend test suites (`profcheck`, `chartread`, and `gamut_viewer`) and integrated automated frontend test validation into macOS, Linux, and Windows CI workflows.
-
 ---
 
 ## 3. Future Roadmap

package.json

@@ -1,7 +1,7 @@
 {
   "name": "iccery",
   "private": true,
-  "version": "0.8.4",
+  "version": "0.8.3",
   "type": "module",
   "scripts": {
     "fetch-argyll": "node scripts/fetch-argyll.mjs",

src-tauri/Cargo.lock

@@ -1423,7 +1423,7 @@ dependencies = [
 
 [[package]]
 name = "iccery"
-version = "0.8.4"
+version = "0.8.3"
 dependencies = [
  "base64 0.22.1",
  "image",

src-tauri/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "iccery"
-version = "0.8.4"
+version = "0.8.3"
 description = "Modern Printer Profiling UI frontend for ArgyllCMS"
 authors = ["Gordon"]
 edition = "2021"

src-tauri/src/quality_store.rs

@@ -100,21 +100,15 @@ pub fn load_history_file(path: &Path) -> Vec<VerificationRecord> {
     }
     let content = match fs::read_to_string(path) {
         Ok(c) => c,
-        Err(e) => {
-            log::warn!("Failed to read verification history at {}: {}", path.display(), e);
-            return Vec::new();
-        }
+        Err(_) => return Vec::new(),
     };
     match serde_json::from_str::<VerificationHistoryStore>(&content) {
         Ok(store) => store.records,
-        Err(e) => {
-            log::error!("Failed to parse verification history at {}: {}", path.display(), e);
-            Vec::new()
-        }
+        Err(_) => Vec::new(),
     }
 }
 
-/// Writes verification records to the specified JSON path atomically.
+/// Writes verification records to the specified JSON path.
 /// Automatically creates parent directories if needed.
 /// Evicts oldest records by timestamp if count exceeds HISTORY_CAP (1,000).
 pub fn write_history_file(path: &Path, records: &[VerificationRecord]) -> Result<(), String> {
@@ -138,33 +132,7 @@ pub fn write_history_file(path: &Path, records: &[VerificationRecord]) -> Result
 
     let json = serde_json::to_string_pretty(&store)
         .map_err(|e| format!("Failed to serialize verification history: {}", e))?;
-
-    let mut tmp_path = path.as_os_str().to_os_string();
-    tmp_path.push(".tmp");
-    let tmp_path = PathBuf::from(tmp_path);
-
-    // Write to temporary file with explicit flush and sync
-    {
-        use std::io::Write;
-        let mut file = fs::File::create(&tmp_path)
-            .map_err(|e| format!("Failed to create temp history file: {}", e))?;
-        file.write_all(json.as_bytes())
-            .map_err(|e| {
-                let _ = fs::remove_file(&tmp_path);
-                format!("Failed to write temp history file: {}", e)
-            })?;
-        file.sync_all()
-            .map_err(|e| {
-                let _ = fs::remove_file(&tmp_path);
-                format!("Failed to sync temp history file: {}", e)
-            })?;
-    }
-
-    // Atomically replace destination file
-    if let Err(e) = fs::rename(&tmp_path, path) {
-        let _ = fs::remove_file(&tmp_path);
-        return Err(format!("Failed to atomically replace verification history file: {}", e));
-    }
+    fs::write(path, json).map_err(|e| format!("Failed to write verification history: {}", e))?;
 
     Ok(())
 }
@@ -450,38 +418,4 @@ mod tests {
         assert_eq!(p2.extension().unwrap(), "csv");
         assert_eq!(p2.to_string_lossy(), "/tmp/history.csv");
     }
-
-    #[test]
-    fn test_atomic_write_preserves_data_and_cleans_tmp() {
-        let temp_dir = std::env::temp_dir().join("iccery_test_atomic_write");
-        let _ = fs::remove_dir_all(&temp_dir);
-        fs::create_dir_all(&temp_dir).unwrap();
-
-        let file_path = temp_dir.join("verification_history.json");
-        let mut tmp_file_path = file_path.as_os_str().to_os_string();
-        tmp_file_path.push(".tmp");
-        let tmp_file_path = std::path::PathBuf::from(tmp_file_path);
-
-        let rec = sample_record("vr-atom-1", "2026-09-06T12:00:00Z", 0.5);
-        write_history_file(&file_path, &[rec.clone()]).unwrap();
-
-        assert!(file_path.exists(), "Target file must exist");
-        assert!(!tmp_file_path.exists(), "Temporary file must not remain after successful atomic write");
-
-        let loaded = load_history_file(&file_path);
-        assert_eq!(loaded.len(), 1);
-        assert_eq!(loaded[0], rec);
-
-        // Overwrite with updated records to verify atomic replacement
-        let rec2 = sample_record("vr-atom-2", "2026-09-06T12:05:00Z", 1.2);
-        write_history_file(&file_path, &[rec.clone(), rec2.clone()]).unwrap();
-
-        assert!(!tmp_file_path.exists(), "Temporary file must not remain after overwrite");
-        let loaded2 = load_history_file(&file_path);
-        assert_eq!(loaded2.len(), 2);
-        assert_eq!(loaded2[0], rec);
-        assert_eq!(loaded2[1], rec2);
-
-        let _ = fs::remove_dir_all(&temp_dir);
-    }
 }

src-tauri/tauri.conf.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://schema.tauri.app/config/2",
   "productName": "ICCery",
-  "version": "0.8.4",
+  "version": "0.8.3",
   "identifier": "com.gronod.iccery",
   "build": {
     "frontendDist": "../src"