Compare commits
207
Commits
+391
@@ -0,0 +1,391 @@
|
||||
# Ensemble Codebase Intensive Audit Prompt
|
||||
|
||||
## Overview
|
||||
|
||||
You are tasked with conducting an intensive, comprehensive audit of the **Ensemble** Flutter application - a Music Assistant client for Android with multi-device synchronization, local playback, and Sendspin raw audio streaming capabilities.
|
||||
|
||||
**Codebase Statistics:**
|
||||
- 90 Dart files, ~40,583 lines of code
|
||||
- 18 screens, 27 services, 6 providers
|
||||
- Architecture: Provider pattern with ChangeNotifier
|
||||
- Audio: just_audio + flutter_pcm_sound + audio_service
|
||||
- Networking: WebSocket (JSON-RPC) + HTTP + Sendspin binary protocol
|
||||
|
||||
---
|
||||
|
||||
## Audit Scope
|
||||
|
||||
Perform a thorough audit covering ALL of the following areas. For each issue found, provide:
|
||||
1. **File path and line number(s)**
|
||||
2. **Severity**: CRITICAL / HIGH / MEDIUM / LOW
|
||||
3. **Description** of the issue
|
||||
4. **Impact** if left unfixed
|
||||
5. **Recommended fix** with code example where applicable
|
||||
|
||||
---
|
||||
|
||||
## SECTION 1: SECURITY AUDIT
|
||||
|
||||
### 1.1 Credential Storage (CRITICAL PRIORITY)
|
||||
Audit `/lib/services/settings_service.dart` for:
|
||||
- [ ] Plaintext password storage in SharedPreferences (lines 209-222)
|
||||
- [ ] Auth tokens stored without encryption
|
||||
- [ ] Serialized credentials in JSON format (lines 169-190)
|
||||
|
||||
**Expected Finding:** Credentials stored insecurely. Recommend flutter_secure_storage.
|
||||
|
||||
### 1.2 Certificate Validation
|
||||
Audit `/lib/services/auth/auth_manager.dart` for:
|
||||
- [ ] HTTPS redirect handling for local IPs
|
||||
- [ ] Certificate validation disabled scenarios
|
||||
- [ ] MITM vulnerability exposure
|
||||
|
||||
### 1.3 Authentication Strategies
|
||||
Audit all files in `/lib/services/auth/`:
|
||||
- [ ] `basic_auth_strategy.dart` - Base64 encoding (not encryption)
|
||||
- [ ] `authelia_strategy.dart` - Session cookie handling, timing attack (line 159)
|
||||
- [ ] `ma_auth_strategy.dart` - Token refresh mechanism
|
||||
- [ ] `no_auth_strategy.dart` - Public server exposure
|
||||
|
||||
### 1.4 Input Validation
|
||||
Audit `/lib/services/music_assistant_api.dart`:
|
||||
- [ ] URI construction without validation (lines 1346-1360)
|
||||
- [ ] Provider/itemId injection risks
|
||||
- [ ] WebSocket message validation
|
||||
|
||||
### 1.5 Information Disclosure
|
||||
- [ ] Debug logs exposing sensitive data (check all `_logger.log()` calls)
|
||||
- [ ] Server version exposure via `server_info`
|
||||
- [ ] Error messages leaking technical details
|
||||
|
||||
---
|
||||
|
||||
## SECTION 2: MEMORY MANAGEMENT AUDIT
|
||||
|
||||
### 2.1 Static Memory Leaks
|
||||
Audit `/lib/models/player.dart`:
|
||||
- [ ] `_playerCreationTimes` static map (lines 96-144) - grows unbounded
|
||||
- [ ] Cleanup only removes 50 of 100+ entries
|
||||
|
||||
### 2.2 Unbounded Caches
|
||||
Audit `/lib/services/cache_service.dart`:
|
||||
- [ ] `_albumTracksCache` - no size limit
|
||||
- [ ] `_artistAlbumsCache` - no TTL expiration
|
||||
- [ ] `_searchCache` - never evicted
|
||||
- [ ] `_playerTrackCache` - only cleared on disconnect
|
||||
|
||||
### 2.3 Stream/Timer Cleanup
|
||||
Audit `/lib/providers/music_assistant_provider.dart`:
|
||||
- [ ] `_playerStateTimer` disposal (line 4435-4445)
|
||||
- [ ] `_notificationPositionTimer` multiple creation paths (lines 2925-2940)
|
||||
- [ ] `_localPlayerEventSubscription` cleanup
|
||||
- [ ] `_playerUpdatedEventSubscription` cleanup
|
||||
- [ ] `_playerAddedEventSubscription` cleanup
|
||||
|
||||
Audit `/lib/services/hardware_volume_service.dart`:
|
||||
- [ ] `_volumeUpController` never closed (lines 74-85)
|
||||
- [ ] `_volumeDownController` never closed
|
||||
|
||||
### 2.4 Stream Subscription Leaks
|
||||
Audit `/lib/providers/music_assistant_provider.dart`:
|
||||
- [ ] `_api!.connectionState.listen()` - subscription not stored
|
||||
- [ ] Old subscriptions not cancelled before new API instance
|
||||
|
||||
---
|
||||
|
||||
## SECTION 3: RACE CONDITION AUDIT
|
||||
|
||||
### 3.1 Player State Dual Updates
|
||||
Audit `/lib/providers/music_assistant_provider.dart`:
|
||||
- [ ] Timer polling (every 5s) vs WebSocket events racing
|
||||
- [ ] `_updatePlayerState()` called from both paths
|
||||
- [ ] No mutex/lock protection
|
||||
|
||||
### 3.2 Async Method Reentrancy
|
||||
Audit `selectPlayer()` method:
|
||||
- [ ] `async` method without guard against concurrent calls
|
||||
- [ ] `_selectedPlayer` modified before and after `await`
|
||||
- [ ] State could change during await
|
||||
|
||||
### 3.3 Fire-and-Forget Operations
|
||||
Search for `unawaited(` and `() async {` patterns:
|
||||
- [ ] `_persistPlaybackState()` - database save not awaited
|
||||
- [ ] Pause operations fire-and-forget (lines 3876-3894)
|
||||
- [ ] Preload operations (line 2707)
|
||||
|
||||
### 3.4 PCM Player State Machine
|
||||
Audit `/lib/services/pcm_audio_player.dart`:
|
||||
- [ ] 9-state machine with complex transitions (lines 32-37)
|
||||
- [ ] Auto-recovery race condition (lines 215-229)
|
||||
- [ ] Feed loop during pause transition (lines 174-179)
|
||||
|
||||
---
|
||||
|
||||
## SECTION 4: ERROR HANDLING AUDIT
|
||||
|
||||
### 4.1 Silent Exception Handlers (CRITICAL)
|
||||
Find all instances of:
|
||||
```dart
|
||||
} catch (e) {}
|
||||
} catch (_) {}
|
||||
```
|
||||
|
||||
Known locations:
|
||||
- [ ] `music_assistant_provider.dart` (multiple)
|
||||
- [ ] `player_provider.dart` (3 instances)
|
||||
- [ ] `recently_played_service.dart`
|
||||
|
||||
### 4.2 Missing Error Recovery
|
||||
- [ ] No exponential backoff on connection retry
|
||||
- [ ] No retry logic for failed API calls
|
||||
- [ ] WebSocket timeout handling (30 seconds - too long?)
|
||||
|
||||
### 4.3 Null Safety Violations
|
||||
Find all `!` (null assertion) operators:
|
||||
- [ ] `search_screen.dart` (20+ instances)
|
||||
- [ ] `models/media_item.dart`
|
||||
- [ ] `models/player.dart`
|
||||
- [ ] `item.mediaItem! as Artist` patterns
|
||||
|
||||
---
|
||||
|
||||
## SECTION 5: ARCHITECTURAL ISSUES
|
||||
|
||||
### 5.1 God Class
|
||||
Audit `/lib/providers/music_assistant_provider.dart`:
|
||||
- [ ] 4,469 lines - violates Single Responsibility
|
||||
- [ ] 386 conditional branches
|
||||
- [ ] Mixing: connection, players, library, sync, audio, position tracking
|
||||
|
||||
**Recommend splitting into:**
|
||||
- ConnectionProvider (~500 LOC)
|
||||
- PlayerManager (~800 LOC)
|
||||
- LibraryProvider (~1000 LOC)
|
||||
- LocalPlaybackManager (~600 LOC)
|
||||
|
||||
### 5.2 Oversized Widget Files
|
||||
- [ ] `expandable_player.dart` - 2,485 lines (should be <500)
|
||||
- [ ] `global_player_overlay.dart` - 737 lines
|
||||
- [ ] `new_library_screen.dart` - 2,521 lines
|
||||
|
||||
### 5.3 Global Key Anti-Pattern
|
||||
Audit `/lib/widgets/global_player_overlay.dart`:
|
||||
- [ ] `globalPlayerKey` for state access
|
||||
- [ ] `_overlayStateKey` for overlay state
|
||||
- [ ] Should use Provider/context instead
|
||||
|
||||
### 5.4 Primitive Obsession
|
||||
- [ ] View modes as strings ('grid2', 'grid3', 'list')
|
||||
- [ ] Media types as strings ('track', 'album', 'artist')
|
||||
- [ ] Should be strongly-typed enums
|
||||
|
||||
---
|
||||
|
||||
## SECTION 6: CODE QUALITY ISSUES
|
||||
|
||||
### 6.1 Testing (CRITICAL)
|
||||
- [ ] **ZERO test files exist** - confirm this
|
||||
- [ ] No unit tests, widget tests, or integration tests
|
||||
- [ ] flutter_test dependency exists but unused
|
||||
|
||||
### 6.2 Hardcoded Values
|
||||
Find and document all:
|
||||
- [ ] Color hex codes (50+ instances of `Color(0xFF...`)
|
||||
- [ ] Duration values not using `Timings` constants
|
||||
- [ ] Magic numbers (16, 4, 5, 100, 50)
|
||||
- [ ] String literals for media types
|
||||
|
||||
### 6.3 Mixed Async Patterns
|
||||
- [ ] `.then()` chains alongside async/await
|
||||
- [ ] `.whenComplete()` usage
|
||||
- [ ] Consolidate to async/await
|
||||
|
||||
### 6.4 Dead Code
|
||||
- [ ] `@Deprecated` methods still implemented
|
||||
- [ ] `animation_debugger.dart` - dev-only?
|
||||
- [ ] Unused imports
|
||||
|
||||
### 6.5 TODO Comments
|
||||
Document all actionable TODOs:
|
||||
- [ ] `queue_screen.dart:214` - queue item removal
|
||||
- [ ] `audiobook_detail_screen.dart:261,312` - progress sync
|
||||
- [ ] `music_assistant_provider.dart:793,799` - playlist modification
|
||||
|
||||
---
|
||||
|
||||
## SECTION 7: UI/UX AUDIT
|
||||
|
||||
### 7.1 Accessibility (CRITICAL)
|
||||
Audit for missing:
|
||||
- [ ] `Semantics` widgets on interactive elements
|
||||
- [ ] `Tooltip` on icon buttons
|
||||
- [ ] Screen reader support
|
||||
- [ ] Touch target sizes (minimum 48dp)
|
||||
- [ ] Color contrast validation (WCAG AA)
|
||||
|
||||
### 7.2 Performance Issues
|
||||
Audit `/lib/widgets/expandable_player.dart`:
|
||||
- [ ] No `RepaintBoundary` wrappers
|
||||
- [ ] 55+ `setState()` calls
|
||||
- [ ] 3 AnimationControllers with multiple listeners
|
||||
- [ ] Title height cache invalidation (lines 118+)
|
||||
|
||||
### 7.3 Double Opacity Bug
|
||||
Audit `/lib/widgets/player/player_controls.dart`:
|
||||
```dart
|
||||
color: (shuffle == true ? primaryColor : textColor.withOpacity(0.5))
|
||||
.withOpacity(expandedElementsOpacity),
|
||||
```
|
||||
- [ ] Double `.withOpacity()` application
|
||||
|
||||
### 7.4 Missing Features
|
||||
- [ ] No landscape orientation support
|
||||
- [ ] No tablet layout optimization
|
||||
- [ ] No loading skeleton animations
|
||||
- [ ] No haptic feedback (except one location)
|
||||
|
||||
---
|
||||
|
||||
## SECTION 8: AUDIO PLAYBACK AUDIT
|
||||
|
||||
### 8.1 Position Interpolation
|
||||
Audit `/lib/services/position_tracker.dart`:
|
||||
- [ ] No timeout on anchor updates - unbounded drift possible
|
||||
- [ ] Duration interpolation can exceed track duration
|
||||
- [ ] Stale timestamp handling (>30 seconds)
|
||||
|
||||
### 8.2 Sendspin Protocol
|
||||
Audit `/lib/services/sendspin_service.dart`:
|
||||
- [ ] Proxy auth retry without deduplication (lines 188-209)
|
||||
- [ ] WebSocket binary frame parsing
|
||||
- [ ] Clock synchronization accuracy
|
||||
|
||||
### 8.3 Audio Resource Cleanup
|
||||
Audit `/lib/services/audio/massiv_audio_handler.dart`:
|
||||
- [ ] Audio session interrupt listeners not disposed
|
||||
- [ ] Audio focus not explicitly released
|
||||
|
||||
### 8.4 Mixed Playback Modes
|
||||
- [ ] just_audio initialized but unused during Sendspin
|
||||
- [ ] Resource allocation for unused player
|
||||
- [ ] Potential audio focus conflicts
|
||||
|
||||
---
|
||||
|
||||
## SECTION 9: NETWORKING AUDIT
|
||||
|
||||
### 9.1 WebSocket Lifecycle
|
||||
Audit `/lib/services/music_assistant_api.dart`:
|
||||
- [ ] Heartbeat interval (30s) - appropriate?
|
||||
- [ ] Reconnection logic and timing
|
||||
- [ ] Pending request cleanup on disconnect
|
||||
|
||||
### 9.2 Caching Strategy
|
||||
- [ ] No incremental/delta sync (full library every 5 minutes)
|
||||
- [ ] Cache staleness not communicated to UI
|
||||
- [ ] No query result pagination (fetches up to 5000 items)
|
||||
|
||||
### 9.3 Rate Limiting
|
||||
- [ ] No client-side rate limiting
|
||||
- [ ] Search requests not throttled
|
||||
- [ ] Could overload server
|
||||
|
||||
### 9.4 Offline Support
|
||||
Audit `/lib/services/offline_action_queue.dart`:
|
||||
- [ ] Queue execution not atomic (lines 118-130)
|
||||
- [ ] Action could execute twice on crash
|
||||
- [ ] Queue stored unencrypted
|
||||
|
||||
---
|
||||
|
||||
## SECTION 10: DATABASE AUDIT
|
||||
|
||||
### 10.1 Schema Review
|
||||
Audit `/lib/database/database.dart`:
|
||||
- [ ] Table indexes for query performance
|
||||
- [ ] Foreign key constraints
|
||||
- [ ] Migration strategy
|
||||
|
||||
### 10.2 Query Patterns
|
||||
- [ ] N+1 query prevention
|
||||
- [ ] Transaction usage for atomic operations
|
||||
- [ ] Connection pooling
|
||||
|
||||
### 10.3 Data Consistency
|
||||
- [ ] Tier 1 (DB) vs Tier 2 (API sync) race conditions
|
||||
- [ ] User modifications during background sync
|
||||
- [ ] Conflict resolution strategy
|
||||
|
||||
---
|
||||
|
||||
## Deliverables
|
||||
|
||||
After completing the audit, provide:
|
||||
|
||||
### 1. Executive Summary
|
||||
- Overall code quality score (1-10)
|
||||
- Top 5 critical issues requiring immediate attention
|
||||
- Estimated technical debt in developer-hours
|
||||
|
||||
### 2. Issue Tracker
|
||||
Create a prioritized list of all issues found:
|
||||
| ID | Severity | Category | File:Line | Description | Effort |
|
||||
|----|----------|----------|-----------|-------------|--------|
|
||||
|
||||
### 3. Recommended Roadmap
|
||||
Sprint-based plan to address findings:
|
||||
- Sprint 1 (Immediate): Security fixes, silent exception handlers
|
||||
- Sprint 2-3: God class decomposition, test infrastructure
|
||||
- Sprint 4-6: Memory leak fixes, accessibility
|
||||
- Long-term: Performance optimization, monitoring
|
||||
|
||||
### 4. Code Examples
|
||||
For each CRITICAL and HIGH severity issue, provide:
|
||||
- Current problematic code
|
||||
- Recommended refactored code
|
||||
- Migration steps
|
||||
|
||||
---
|
||||
|
||||
## Files to Prioritize
|
||||
|
||||
Start your audit with these critical files:
|
||||
|
||||
1. `/lib/providers/music_assistant_provider.dart` (4,469 LOC) - God class
|
||||
2. `/lib/services/settings_service.dart` - Credential storage
|
||||
3. `/lib/services/music_assistant_api.dart` (2,929 LOC) - Networking
|
||||
4. `/lib/widgets/expandable_player.dart` (2,485 LOC) - UI complexity
|
||||
5. `/lib/services/auth/` directory - Security
|
||||
6. `/lib/models/player.dart` - Memory leaks
|
||||
7. `/lib/services/cache_service.dart` - Unbounded caches
|
||||
8. `/lib/services/position_tracker.dart` - Audio sync issues
|
||||
|
||||
---
|
||||
|
||||
## Known Critical Issues (Pre-Identified)
|
||||
|
||||
These issues have been identified and MUST be verified and documented:
|
||||
|
||||
1. **CRITICAL: Plaintext credential storage** - SharedPreferences without encryption
|
||||
2. **CRITICAL: Zero test coverage** - No unit, widget, or integration tests
|
||||
3. **CRITICAL: 4,469 line god class** - MusicAssistantProvider violates SRP
|
||||
4. **CRITICAL: Silent exception handlers** - `catch (e) {}` patterns
|
||||
5. **HIGH: Static memory leak** - `_playerCreationTimes` unbounded growth
|
||||
6. **HIGH: Race conditions** - Player state polling vs events
|
||||
7. **HIGH: No accessibility** - Missing Semantics, screen reader support
|
||||
8. **HIGH: Certificate validation disabled** - MITM vulnerability for local IPs
|
||||
9. **MEDIUM: Double opacity bug** - `.withOpacity().withOpacity()` in player controls
|
||||
10. **MEDIUM: Position tracker drift** - No timeout on anchor updates
|
||||
|
||||
---
|
||||
|
||||
## Audit Execution Notes
|
||||
|
||||
- Use `Grep` tool to search for patterns across the codebase
|
||||
- Use `Read` tool to examine specific file sections
|
||||
- Document line numbers for all findings
|
||||
- Provide code snippets for context
|
||||
- Cross-reference related issues across files
|
||||
- Verify pre-identified issues exist and document their exact locations
|
||||
|
||||
**Total estimated audit time: 4-6 hours for thorough coverage**
|
||||
+419
@@ -0,0 +1,419 @@
|
||||
# Ensemble Codebase - Comprehensive Audit Report
|
||||
|
||||
**Audit Date:** 2026-01-01
|
||||
**Codebase:** Ensemble Flutter App (Music Assistant Client)
|
||||
**Version:** 2.7.3-beta+35
|
||||
**Total Lines of Code:** ~40,583 Dart
|
||||
**Files Analyzed:** 90 Dart files
|
||||
|
||||
---
|
||||
|
||||
## Executive Summary
|
||||
|
||||
### Overall Code Quality Score: 5.5/10
|
||||
|
||||
The Ensemble codebase demonstrates **strong architectural foundations** with a well-organized service layer, effective caching strategies, and sophisticated audio handling. However, the audit revealed **critical security vulnerabilities**, **zero test coverage**, and significant **technical debt** that must be addressed before production release.
|
||||
|
||||
### Critical Statistics
|
||||
|
||||
| Metric | Value | Status |
|
||||
|--------|-------|--------|
|
||||
| Test Coverage | 0% | CRITICAL |
|
||||
| God Class Size | 4,469 LOC | CRITICAL |
|
||||
| Silent Exception Handlers | 7 | CRITICAL |
|
||||
| Plaintext Credentials | 4 locations | CRITICAL |
|
||||
| Memory Leak Locations | 6 | HIGH |
|
||||
| Race Conditions | 4 | HIGH |
|
||||
| Accessibility (Semantics) | 0 widgets | CRITICAL |
|
||||
|
||||
---
|
||||
|
||||
## Issue Summary by Severity
|
||||
|
||||
| Severity | Count | Categories |
|
||||
|----------|-------|------------|
|
||||
| **CRITICAL** | 12 | Security, Testing, Architecture, Accessibility |
|
||||
| **HIGH** | 18 | Memory, Race Conditions, Networking, Audio |
|
||||
| **MEDIUM** | 22 | Error Handling, UI, Caching, Code Quality |
|
||||
| **LOW** | 14 | Naming, Documentation, Minor Improvements |
|
||||
|
||||
---
|
||||
|
||||
## CRITICAL ISSUES (Immediate Action Required)
|
||||
|
||||
### 1. Plaintext Credential Storage
|
||||
**File:** `/lib/services/settings_service.dart`
|
||||
**Lines:** 131-143, 147-159, 169-190, 209-222
|
||||
|
||||
Passwords and auth tokens stored in SharedPreferences without encryption.
|
||||
|
||||
```dart
|
||||
// VULNERABLE CODE
|
||||
static Future<void> setPassword(String? password) async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
await prefs.setString(_keyPassword, password); // PLAINTEXT!
|
||||
}
|
||||
```
|
||||
|
||||
**Fix:** Use `flutter_secure_storage` for all sensitive data.
|
||||
|
||||
---
|
||||
|
||||
### 2. Zero Test Coverage
|
||||
**Location:** Entire codebase
|
||||
|
||||
No unit tests, widget tests, or integration tests exist. The `flutter_test` dependency is unused.
|
||||
|
||||
**Impact:** Cannot safely refactor, high regression risk, no confidence in correctness.
|
||||
|
||||
**Fix:** Establish test infrastructure immediately. Start with:
|
||||
- Unit tests for `MusicAssistantAPI`, `CacheService`, `ErrorHandler`
|
||||
- Widget tests for player controls
|
||||
- Integration tests for playback flows
|
||||
|
||||
---
|
||||
|
||||
### 3. God Class - MusicAssistantProvider
|
||||
**File:** `/lib/providers/music_assistant_provider.dart`
|
||||
**Size:** 4,469 lines, ~140 methods, 744 conditional branches
|
||||
|
||||
Single class handles: connection, players, library, cache, audio, sync, offline queue.
|
||||
|
||||
**Fix:** Split into:
|
||||
- `ConnectionManager` (~500 LOC)
|
||||
- `PlayerManager` (~800 LOC)
|
||||
- `LibraryCacheService` (~600 LOC)
|
||||
- `SendspinManager` (~400 LOC)
|
||||
- `MusicAssistantProvider` - Facade composing above (~800 LOC)
|
||||
|
||||
---
|
||||
|
||||
### 4. Zero Accessibility Support
|
||||
**Files:** `/lib/widgets/`, `/lib/screens/` (all)
|
||||
|
||||
- **0** `Semantics` widgets
|
||||
- **0** `semanticLabel` properties
|
||||
- **1** `Tooltip` (entire app)
|
||||
- Screen readers cannot navigate the app
|
||||
|
||||
**Fix:** Add Semantics to all interactive elements:
|
||||
```dart
|
||||
Semantics(
|
||||
button: true,
|
||||
label: isPlaying ? 'Pause playback' : 'Play',
|
||||
child: IconButton(...)
|
||||
)
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
### 5. Silent Exception Handlers
|
||||
**Locations:** 7 instances across codebase
|
||||
|
||||
| File | Line | Code |
|
||||
|------|------|------|
|
||||
| player_provider.dart | 567, 575, 584 | `catch (e) {}` |
|
||||
| music_assistant_provider.dart | 2690 | `catch (e) {}` |
|
||||
| music_assistant_api.dart | 2542 | `catch (e) {}` |
|
||||
| recently_played_service.dart | 154, 206 | `catch (_) {}` |
|
||||
|
||||
**Fix:** Add logging or use `firstWhereOrNull` instead of try/catch around `firstWhere`.
|
||||
|
||||
---
|
||||
|
||||
### 6. Audio Session Listeners Not Disposed
|
||||
**File:** `/lib/services/audio/massiv_audio_handler.dart`
|
||||
**Lines:** 45-73
|
||||
|
||||
Stream subscriptions created but never cancelled - causes memory leaks and zombie listeners.
|
||||
|
||||
**Fix:** Store subscriptions and cancel in dispose():
|
||||
```dart
|
||||
StreamSubscription? _interruptionSubscription;
|
||||
_interruptionSubscription = session.interruptionEventStream.listen(...);
|
||||
|
||||
void dispose() {
|
||||
_interruptionSubscription?.cancel();
|
||||
}
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## HIGH SEVERITY ISSUES
|
||||
|
||||
### 7. Connection State Subscription Not Stored
|
||||
**File:** `/lib/providers/music_assistant_provider.dart:575-614`
|
||||
|
||||
The `connectionState.listen()` return value is not stored - causes listener accumulation on reconnect.
|
||||
|
||||
---
|
||||
|
||||
### 8. Player State Race Condition
|
||||
**File:** `/lib/providers/music_assistant_provider.dart`
|
||||
|
||||
Timer polling (every 5s) and WebSocket events can race to update `_selectedPlayer` and `_currentTrack` without mutex protection.
|
||||
|
||||
---
|
||||
|
||||
### 9. Async Method Reentrancy
|
||||
**File:** `/lib/providers/music_assistant_provider.dart:2713-2841`
|
||||
|
||||
`selectPlayer()` is `void async` with no guard against concurrent calls. Multiple rapid player switches can interleave.
|
||||
|
||||
---
|
||||
|
||||
### 10. Unbounded Search Cache
|
||||
**File:** `/lib/services/cache_service.dart:31-32`
|
||||
|
||||
`_searchCache` map has no size limit or proactive TTL eviction. Grows indefinitely with user searches.
|
||||
|
||||
---
|
||||
|
||||
### 11. Static Memory Leak
|
||||
**File:** `/lib/models/player.dart:96, 139-144`
|
||||
|
||||
`_playerCreationTimes` static map cleanup only removes 50 of 100+ entries, allowing unbounded growth.
|
||||
|
||||
---
|
||||
|
||||
### 12. No Database Indexes
|
||||
**File:** `/lib/database/database.dart`
|
||||
|
||||
No secondary indexes defined. Query performance degrades as database grows.
|
||||
|
||||
---
|
||||
|
||||
### 13. No Incremental Sync
|
||||
**File:** `/lib/services/sync_service.dart:150-165`
|
||||
|
||||
Full library fetch (up to 4000 items) on every sync instead of delta updates.
|
||||
|
||||
---
|
||||
|
||||
### 14. Offline Queue Not Atomic
|
||||
**File:** `/lib/services/offline_action_queue.dart:80-108`
|
||||
|
||||
Queue persistence happens after all processing - crash during processing loses successful actions.
|
||||
|
||||
---
|
||||
|
||||
### 15. Auth Retry Without Deduplication
|
||||
**File:** `/lib/services/sendspin_service.dart:189-209`
|
||||
|
||||
Multiple auth messages can be sent during rapid reconnection attempts.
|
||||
|
||||
---
|
||||
|
||||
### 16. Pending Requests Not Completed on Disconnect
|
||||
**File:** `/lib/services/music_assistant_api.dart:2911`
|
||||
|
||||
`_pendingRequests.clear()` abandons Completers without completing them with errors.
|
||||
|
||||
---
|
||||
|
||||
### 17. HTTP Fallback for Local IPs
|
||||
**File:** `/lib/services/auth/auth_manager.dart:51-58`
|
||||
|
||||
HTTPS failures silently fall back to HTTP on local networks - MITM vulnerability.
|
||||
|
||||
---
|
||||
|
||||
### 18. Certificate Validation Bypassed
|
||||
**File:** `/lib/services/auth/auth_manager.dart:210-236`
|
||||
|
||||
HTTPS redirects explicitly refused for local IPs due to expected certificate failures.
|
||||
|
||||
---
|
||||
|
||||
## MEDIUM SEVERITY ISSUES
|
||||
|
||||
### 19. Double Opacity Bug
|
||||
**File:** `/lib/widgets/player/player_controls.dart:62-63, 99-100`
|
||||
|
||||
```dart
|
||||
// BUG: .withOpacity(0.5).withOpacity(expandedElementsOpacity) compounds opacity
|
||||
color: (shuffle == true ? primaryColor : textColor.withOpacity(0.5))
|
||||
.withOpacity(expandedElementsOpacity),
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
### 20. Mixed Async Patterns
|
||||
**Locations:** 13 instances
|
||||
|
||||
`.then()` chains mixed with `async/await` throughout the codebase.
|
||||
|
||||
---
|
||||
|
||||
### 21. Hardcoded Colors
|
||||
**Locations:** 55 instances
|
||||
|
||||
`Color(0xFF604CEC)`, `Color(0xFF1a1a1a)` scattered across theme files and widgets.
|
||||
|
||||
---
|
||||
|
||||
### 22. View Modes as Strings
|
||||
**Locations:** 80+ instances
|
||||
|
||||
`'grid2'`, `'grid3'`, `'list'` should be enums.
|
||||
|
||||
---
|
||||
|
||||
### 23. Fire-and-Forget Pause Commands
|
||||
**File:** `/lib/providers/music_assistant_provider.dart:3875-3894`
|
||||
|
||||
Server pause command uses `unawaited()` - errors are silently lost.
|
||||
|
||||
---
|
||||
|
||||
### 24. Position Tracker Anchor Timeout Missing
|
||||
**File:** `/lib/services/position_tracker.dart:24-26`
|
||||
|
||||
No timeout on stale anchor - interpolation can drift indefinitely.
|
||||
|
||||
---
|
||||
|
||||
### 25. PCM Buffer No Overflow Protection
|
||||
**File:** `/lib/services/pcm_audio_player.dart:68, 236-247`
|
||||
|
||||
Audio buffer grows unbounded if data arrives faster than consumption.
|
||||
|
||||
---
|
||||
|
||||
### 26. No Client-Side Rate Limiting
|
||||
**Location:** App-wide
|
||||
|
||||
No throttling on API requests during rapid user interactions.
|
||||
|
||||
---
|
||||
|
||||
### 27. Portrait-Only Lock
|
||||
**File:** `/lib/main.dart:64-68`
|
||||
|
||||
No landscape orientation support.
|
||||
|
||||
---
|
||||
|
||||
### 28. Touch Targets Below 48dp
|
||||
**Files:** player_controls.dart, queue_panel.dart, player_card.dart
|
||||
|
||||
Multiple buttons at 28x28 and 44x44 instead of minimum 48x48.
|
||||
|
||||
---
|
||||
|
||||
### 29. WCAG Contrast Not Validated
|
||||
**File:** `/lib/theme/palette_helper.dart`
|
||||
|
||||
Uses 0.4 threshold instead of proper WCAG 4.5:1 contrast ratio calculation.
|
||||
|
||||
---
|
||||
|
||||
### 30. StreamControllers Not Closed
|
||||
**File:** `/lib/services/hardware_volume_service.dart:18-19, 74-85`
|
||||
|
||||
`_volumeUpController` and `_volumeDownController` never closed in dispose().
|
||||
|
||||
---
|
||||
|
||||
## LOW SEVERITY ISSUES
|
||||
|
||||
### 31-34. Naming Inconsistencies
|
||||
Mixed patterns: `_isLoading` vs `_isLoadingPlaylists`, various cache variable names.
|
||||
|
||||
### 35-38. Missing TODO Implementations
|
||||
6 actionable TODOs identified (queue removal, audiobook progress sync, playlist modification).
|
||||
|
||||
### 39-42. Dead/Unused Code
|
||||
- `@Deprecated` methods still implemented
|
||||
- `library_stats.dart` appears unused
|
||||
- `animation_debugger.dart` disabled by default
|
||||
|
||||
### 43-44. Minor Documentation Gaps
|
||||
Missing method documentation, no architecture diagram.
|
||||
|
||||
---
|
||||
|
||||
## Recommended Remediation Roadmap
|
||||
|
||||
### Sprint 1 (Week 1-2): Security & Critical Fixes
|
||||
1. Migrate credentials to `flutter_secure_storage`
|
||||
2. Add logging to all silent catch blocks
|
||||
3. Store connection state subscription
|
||||
4. Fix audio session listener disposal
|
||||
5. Add basic test infrastructure (10% coverage target)
|
||||
|
||||
### Sprint 2 (Week 3-4): Memory & Race Conditions
|
||||
6. Add mutex to player state updates
|
||||
7. Add reentrancy guard to `selectPlayer()`
|
||||
8. Implement bounded caches with LRU eviction
|
||||
9. Fix static memory leak in Player model
|
||||
10. Store and cancel all stream subscriptions
|
||||
|
||||
### Sprint 3 (Week 5-6): Architecture Refactoring
|
||||
11. Split `MusicAssistantProvider` into 5 smaller classes
|
||||
12. Split `expandable_player.dart` into component widgets
|
||||
13. Replace GlobalKey anti-patterns with Provider
|
||||
14. Convert string constants to enums
|
||||
15. Extract hardcoded colors to constants file
|
||||
|
||||
### Sprint 4 (Week 7-8): Accessibility & UI
|
||||
16. Add Semantics to all interactive elements
|
||||
17. Increase touch targets to 48dp minimum
|
||||
18. Implement WCAG contrast validation
|
||||
19. Fix double opacity bug
|
||||
20. Add landscape orientation support
|
||||
|
||||
### Sprint 5 (Week 9-10): Performance & Polish
|
||||
21. Add database indexes
|
||||
22. Implement incremental sync
|
||||
23. Add client-side rate limiting
|
||||
24. Fix atomic offline queue processing
|
||||
25. Achieve 30% test coverage target
|
||||
|
||||
---
|
||||
|
||||
## Files Requiring Most Attention
|
||||
|
||||
| File | LOC | Issues | Priority |
|
||||
|------|-----|--------|----------|
|
||||
| `music_assistant_provider.dart` | 4,469 | 12 | CRITICAL |
|
||||
| `settings_service.dart` | 811 | 4 | CRITICAL |
|
||||
| `expandable_player.dart` | 2,485 | 6 | HIGH |
|
||||
| `music_assistant_api.dart` | 2,929 | 5 | HIGH |
|
||||
| `cache_service.dart` | 370 | 4 | HIGH |
|
||||
| `massiv_audio_handler.dart` | 296 | 2 | CRITICAL |
|
||||
| `player.dart` | 422 | 2 | HIGH |
|
||||
| `auth_manager.dart` | 300 | 3 | HIGH |
|
||||
|
||||
---
|
||||
|
||||
## Estimated Technical Debt
|
||||
|
||||
| Category | Effort (Dev-Days) |
|
||||
|----------|-------------------|
|
||||
| Security Fixes | 3-5 |
|
||||
| Test Infrastructure | 10-15 |
|
||||
| Architecture Refactoring | 15-20 |
|
||||
| Memory Leak Fixes | 3-5 |
|
||||
| Accessibility | 5-8 |
|
||||
| UI/UX Polish | 3-5 |
|
||||
| Performance | 5-8 |
|
||||
| **Total** | **44-66 dev-days** |
|
||||
|
||||
---
|
||||
|
||||
## Conclusion
|
||||
|
||||
The Ensemble app has a solid foundation with well-designed patterns for caching, audio handling, and multi-device synchronization. However, **critical security vulnerabilities** (plaintext credentials), **zero test coverage**, and a **4,469-line god class** represent significant risks that must be addressed before any production deployment.
|
||||
|
||||
The most urgent priorities are:
|
||||
1. **Secure credential storage** - immediate security risk
|
||||
2. **Add test infrastructure** - enables safe refactoring
|
||||
3. **Split the god class** - enables maintainability
|
||||
4. **Add accessibility** - legal/compliance requirement
|
||||
|
||||
With focused effort over 8-10 weeks, the codebase can be brought to production-quality standards.
|
||||
|
||||
---
|
||||
|
||||
*Audit conducted using 6 parallel specialized sub-agents analyzing security, memory management, race conditions, architecture, UI/UX, and audio/networking.*
|
||||
@@ -0,0 +1,52 @@
|
||||
# Search Improvements
|
||||
|
||||
Branch: `feature/search-improvements`
|
||||
|
||||
## Completed
|
||||
|
||||
- [x] Add playlists and audiobooks to search results
|
||||
- Parse from MA API response
|
||||
- Filter chips for each type
|
||||
- Tile builders with navigation to detail screens
|
||||
|
||||
- [x] Unified Relevance-Based "All" Results
|
||||
- Scoring algorithm implemented:
|
||||
- Exact match: 100 points
|
||||
- Starts with query: 80 points
|
||||
- Contains query (word boundary): 60 points
|
||||
- Contains query (anywhere): 40 points
|
||||
- Fuzzy match: 20 points
|
||||
- Bonus for library items (albums): +10 points
|
||||
- Bonus for favorites: +5 points
|
||||
- Secondary field matching (artist name in albums/tracks)
|
||||
- Merged all results into single sorted list
|
||||
- Type indicators in subtitle (e.g., "Artist • Album")
|
||||
|
||||
- [x] Smart Cross-Referencing
|
||||
- Extracts unique artists from matched tracks/albums
|
||||
- Filters to artists whose name contains query words (min 3 chars)
|
||||
- Adds cross-referenced artists with lower relevance score (25)
|
||||
- Avoids duplicates with direct search results
|
||||
|
||||
- [x] Past Searches Row
|
||||
- Added SearchHistory table to database (schema v4)
|
||||
- Saves successful searches (deduplicated, max 10)
|
||||
- Displays as ActionChips in empty state
|
||||
- Clicking chip performs that search
|
||||
|
||||
## Remaining Ideas (Lower Priority)
|
||||
|
||||
- **Library-only toggle:** Add switch to filter search to library items only (MA API supports this)
|
||||
- **Voice search:** Add microphone button if platform supports speech recognition
|
||||
- **Search suggestions:** Typeahead from library as user types
|
||||
- **Quick actions:** Long-press result for play/queue options without navigating
|
||||
- **Clear history in settings:** Add option to clear search history
|
||||
|
||||
## Files Modified
|
||||
|
||||
| File | Changes |
|
||||
|------|---------|
|
||||
| `lib/database/database.dart` | Added SearchHistory table, schema v4 |
|
||||
| `lib/services/database_service.dart` | Added search history methods |
|
||||
| `lib/screens/search_screen.dart` | Relevance scoring, cross-refs, history UI |
|
||||
| `lib/l10n/app_en.arb` | Added localization strings |
|
||||
+326
-3
@@ -25,6 +25,8 @@ class Profiles extends Table {
|
||||
}
|
||||
|
||||
/// Recently played items - scoped by profile
|
||||
@TableIndex(name: 'idx_recently_played_profile', columns: {#profileUsername})
|
||||
@TableIndex(name: 'idx_recently_played_profile_played', columns: {#profileUsername, #playedAt})
|
||||
class RecentlyPlayed extends Table {
|
||||
/// Auto-incrementing ID
|
||||
IntColumn get id => integer().autoIncrement()();
|
||||
@@ -55,6 +57,8 @@ class RecentlyPlayed extends Table {
|
||||
}
|
||||
|
||||
/// Cached library items for fast startup
|
||||
@TableIndex(name: 'idx_library_cache_type', columns: {#itemType})
|
||||
@TableIndex(name: 'idx_library_cache_type_deleted', columns: {#itemType, #isDeleted})
|
||||
class LibraryCache extends Table {
|
||||
/// Composite key: provider + item_id
|
||||
TextColumn get cacheKey => text()();
|
||||
@@ -93,12 +97,101 @@ class SyncMetadata extends Table {
|
||||
Set<Column> get primaryKey => {syncType};
|
||||
}
|
||||
|
||||
@DriftDatabase(tables: [Profiles, RecentlyPlayed, LibraryCache, SyncMetadata])
|
||||
/// Persisted playback state - survives app restarts and disconnects
|
||||
class PlaybackState extends Table {
|
||||
/// Always 'current' - single row table
|
||||
TextColumn get id => text().withDefault(const Constant('current'))();
|
||||
|
||||
/// Selected player ID
|
||||
TextColumn get playerId => text().nullable()();
|
||||
|
||||
/// Selected player name (for display if player unavailable)
|
||||
TextColumn get playerName => text().nullable()();
|
||||
|
||||
/// Current track as JSON
|
||||
TextColumn get currentTrackJson => text().nullable()();
|
||||
|
||||
/// Current position in seconds
|
||||
RealColumn get positionSeconds => real().withDefault(const Constant(0.0))();
|
||||
|
||||
/// Whether playback was active
|
||||
BoolColumn get isPlaying => boolean().withDefault(const Constant(false))();
|
||||
|
||||
/// When this state was saved
|
||||
DateTimeColumn get savedAt => dateTime()();
|
||||
|
||||
@override
|
||||
Set<Column> get primaryKey => {id};
|
||||
}
|
||||
|
||||
/// Cached player list - for instant display on app resume
|
||||
class CachedPlayers extends Table {
|
||||
/// Player ID from Music Assistant
|
||||
TextColumn get playerId => text()();
|
||||
|
||||
/// Player data as JSON
|
||||
TextColumn get playerJson => text()();
|
||||
|
||||
/// Current track for this player as JSON (for mini player display)
|
||||
TextColumn get currentTrackJson => text().nullable()();
|
||||
|
||||
/// When this was last updated
|
||||
DateTimeColumn get lastUpdated => dateTime()();
|
||||
|
||||
@override
|
||||
Set<Column> get primaryKey => {playerId};
|
||||
}
|
||||
|
||||
/// Cached queue items for selected player
|
||||
@TableIndex(name: 'idx_cached_queue_player', columns: {#playerId})
|
||||
@TableIndex(name: 'idx_cached_queue_player_position', columns: {#playerId, #position})
|
||||
class CachedQueue extends Table {
|
||||
/// Auto-incrementing ID for ordering
|
||||
IntColumn get id => integer().autoIncrement()();
|
||||
|
||||
/// Player ID this queue belongs to
|
||||
TextColumn get playerId => text()();
|
||||
|
||||
/// Queue item as JSON
|
||||
TextColumn get itemJson => text()();
|
||||
|
||||
/// Position in queue
|
||||
IntColumn get position => integer()();
|
||||
}
|
||||
|
||||
/// Cached home row data for instant display on startup
|
||||
class HomeRowCache extends Table {
|
||||
/// Row type: 'recent_albums', 'discover_artists', 'discover_albums'
|
||||
TextColumn get rowType => text()();
|
||||
|
||||
/// Serialized list of items as JSON array
|
||||
TextColumn get itemsJson => text()();
|
||||
|
||||
/// When this was last updated
|
||||
DateTimeColumn get lastUpdated => dateTime()();
|
||||
|
||||
@override
|
||||
Set<Column> get primaryKey => {rowType};
|
||||
}
|
||||
|
||||
/// Search history for quick access to recent searches
|
||||
class SearchHistory extends Table {
|
||||
/// Auto-incrementing ID
|
||||
IntColumn get id => integer().autoIncrement()();
|
||||
|
||||
/// The search query
|
||||
TextColumn get query => text()();
|
||||
|
||||
/// When the search was performed
|
||||
DateTimeColumn get searchedAt => dateTime()();
|
||||
}
|
||||
|
||||
@DriftDatabase(tables: [Profiles, RecentlyPlayed, LibraryCache, SyncMetadata, PlaybackState, CachedPlayers, CachedQueue, HomeRowCache, SearchHistory])
|
||||
class AppDatabase extends _$AppDatabase {
|
||||
AppDatabase([QueryExecutor? executor]) : super(executor ?? _openConnection());
|
||||
|
||||
@override
|
||||
int get schemaVersion => 1;
|
||||
int get schemaVersion => 5;
|
||||
|
||||
@override
|
||||
MigrationStrategy get migration {
|
||||
@@ -107,7 +200,32 @@ class AppDatabase extends _$AppDatabase {
|
||||
await m.createAll();
|
||||
},
|
||||
onUpgrade: (Migrator m, int from, int to) async {
|
||||
// Future migrations will go here
|
||||
// Migration from v1 to v2: Add playback state, cached players, cached queue tables
|
||||
if (from < 2) {
|
||||
await m.createTable(playbackState);
|
||||
await m.createTable(cachedPlayers);
|
||||
await m.createTable(cachedQueue);
|
||||
}
|
||||
// Migration from v2 to v3: Add home row cache table
|
||||
if (from < 3) {
|
||||
await m.createTable(homeRowCache);
|
||||
}
|
||||
// Migration from v3 to v4: Add search history table
|
||||
if (from < 4) {
|
||||
await m.createTable(searchHistory);
|
||||
}
|
||||
// Migration from v4 to v5: Add indexes for query performance
|
||||
if (from < 5) {
|
||||
// RecentlyPlayed indexes
|
||||
await customStatement('CREATE INDEX IF NOT EXISTS idx_recently_played_profile ON recently_played (profile_username)');
|
||||
await customStatement('CREATE INDEX IF NOT EXISTS idx_recently_played_profile_played ON recently_played (profile_username, played_at)');
|
||||
// LibraryCache indexes
|
||||
await customStatement('CREATE INDEX IF NOT EXISTS idx_library_cache_type ON library_cache (item_type)');
|
||||
await customStatement('CREATE INDEX IF NOT EXISTS idx_library_cache_type_deleted ON library_cache (item_type, is_deleted)');
|
||||
// CachedQueue indexes
|
||||
await customStatement('CREATE INDEX IF NOT EXISTS idx_cached_queue_player ON cached_queue (player_id)');
|
||||
await customStatement('CREATE INDEX IF NOT EXISTS idx_cached_queue_player_position ON cached_queue (player_id, position)');
|
||||
}
|
||||
},
|
||||
);
|
||||
}
|
||||
@@ -327,4 +445,209 @@ class AppDatabase extends _$AppDatabase {
|
||||
if (lastSync == null) return true;
|
||||
return DateTime.now().difference(lastSync) > maxAge;
|
||||
}
|
||||
|
||||
// ============================================
|
||||
// Playback State Operations
|
||||
// ============================================
|
||||
|
||||
/// Save current playback state
|
||||
Future<void> savePlaybackState({
|
||||
String? playerId,
|
||||
String? playerName,
|
||||
String? currentTrackJson,
|
||||
double positionSeconds = 0.0,
|
||||
bool isPlaying = false,
|
||||
}) async {
|
||||
await into(playbackState).insertOnConflictUpdate(PlaybackStateCompanion.insert(
|
||||
id: const Value('current'),
|
||||
playerId: Value(playerId),
|
||||
playerName: Value(playerName),
|
||||
currentTrackJson: Value(currentTrackJson),
|
||||
positionSeconds: Value(positionSeconds),
|
||||
isPlaying: Value(isPlaying),
|
||||
savedAt: DateTime.now(),
|
||||
));
|
||||
}
|
||||
|
||||
/// Get saved playback state
|
||||
Future<PlaybackStateData?> getPlaybackState() async {
|
||||
return (select(playbackState)..where((p) => p.id.equals('current')))
|
||||
.getSingleOrNull();
|
||||
}
|
||||
|
||||
/// Clear playback state
|
||||
Future<void> clearPlaybackState() async {
|
||||
await delete(playbackState).go();
|
||||
}
|
||||
|
||||
// ============================================
|
||||
// Cached Players Operations
|
||||
// ============================================
|
||||
|
||||
/// Cache a player with its current track
|
||||
Future<void> cachePlayer({
|
||||
required String playerId,
|
||||
required String playerJson,
|
||||
String? currentTrackJson,
|
||||
}) async {
|
||||
await into(cachedPlayers).insertOnConflictUpdate(CachedPlayersCompanion.insert(
|
||||
playerId: playerId,
|
||||
playerJson: playerJson,
|
||||
currentTrackJson: Value(currentTrackJson),
|
||||
lastUpdated: DateTime.now(),
|
||||
));
|
||||
}
|
||||
|
||||
/// Cache multiple players at once
|
||||
Future<void> cachePlayers(List<Map<String, dynamic>> players) async {
|
||||
await transaction(() async {
|
||||
for (final player in players) {
|
||||
await into(cachedPlayers).insertOnConflictUpdate(CachedPlayersCompanion.insert(
|
||||
playerId: player['playerId'] as String,
|
||||
playerJson: player['playerJson'] as String,
|
||||
currentTrackJson: Value(player['currentTrackJson'] as String?),
|
||||
lastUpdated: DateTime.now(),
|
||||
));
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
/// Get all cached players
|
||||
Future<List<CachedPlayer>> getCachedPlayers() async {
|
||||
return (select(cachedPlayers)
|
||||
..orderBy([(p) => OrderingTerm.desc(p.lastUpdated)]))
|
||||
.get();
|
||||
}
|
||||
|
||||
/// Get a specific cached player
|
||||
Future<CachedPlayer?> getCachedPlayer(String playerId) async {
|
||||
return (select(cachedPlayers)..where((p) => p.playerId.equals(playerId)))
|
||||
.getSingleOrNull();
|
||||
}
|
||||
|
||||
/// Update cached track for a player
|
||||
Future<void> updateCachedPlayerTrack(String playerId, String? trackJson) async {
|
||||
await (update(cachedPlayers)..where((p) => p.playerId.equals(playerId)))
|
||||
.write(CachedPlayersCompanion(
|
||||
currentTrackJson: Value(trackJson),
|
||||
lastUpdated: Value(DateTime.now()),
|
||||
));
|
||||
}
|
||||
|
||||
/// Clear all cached players
|
||||
Future<void> clearCachedPlayers() async {
|
||||
await delete(cachedPlayers).go();
|
||||
}
|
||||
|
||||
// ============================================
|
||||
// Cached Queue Operations
|
||||
// ============================================
|
||||
|
||||
/// Save queue for a player
|
||||
Future<void> saveQueue(String playerId, List<String> itemJsonList) async {
|
||||
await transaction(() async {
|
||||
// Clear existing queue for this player
|
||||
await (delete(cachedQueue)..where((q) => q.playerId.equals(playerId))).go();
|
||||
|
||||
// Insert new queue items
|
||||
for (var i = 0; i < itemJsonList.length; i++) {
|
||||
await into(cachedQueue).insert(CachedQueueCompanion.insert(
|
||||
playerId: playerId,
|
||||
itemJson: itemJsonList[i],
|
||||
position: i,
|
||||
));
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
/// Get cached queue for a player
|
||||
Future<List<CachedQueueData>> getCachedQueue(String playerId) async {
|
||||
return (select(cachedQueue)
|
||||
..where((q) => q.playerId.equals(playerId))
|
||||
..orderBy([(q) => OrderingTerm.asc(q.position)]))
|
||||
.get();
|
||||
}
|
||||
|
||||
/// Clear queue for a player
|
||||
Future<void> clearCachedQueue(String playerId) async {
|
||||
await (delete(cachedQueue)..where((q) => q.playerId.equals(playerId))).go();
|
||||
}
|
||||
|
||||
/// Clear all cached queues
|
||||
Future<void> clearAllCachedQueues() async {
|
||||
await delete(cachedQueue).go();
|
||||
}
|
||||
|
||||
// ============================================
|
||||
// Home Row Cache Operations
|
||||
// ============================================
|
||||
|
||||
/// Save home row data
|
||||
Future<void> saveHomeRowCache(String rowType, String itemsJson) async {
|
||||
await into(homeRowCache).insertOnConflictUpdate(
|
||||
HomeRowCacheCompanion(
|
||||
rowType: Value(rowType),
|
||||
itemsJson: Value(itemsJson),
|
||||
lastUpdated: Value(DateTime.now()),
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
/// Get cached home row data
|
||||
Future<HomeRowCacheData?> getHomeRowCache(String rowType) async {
|
||||
return (select(homeRowCache)..where((h) => h.rowType.equals(rowType)))
|
||||
.getSingleOrNull();
|
||||
}
|
||||
|
||||
/// Clear all home row cache
|
||||
Future<void> clearHomeRowCache() async {
|
||||
await delete(homeRowCache).go();
|
||||
}
|
||||
|
||||
// ============================================
|
||||
// Search History Operations
|
||||
// ============================================
|
||||
|
||||
/// Save a search query to history (deduplicates and limits to 10)
|
||||
Future<void> saveSearchQuery(String query) async {
|
||||
final trimmedQuery = query.trim();
|
||||
if (trimmedQuery.isEmpty) return;
|
||||
|
||||
await transaction(() async {
|
||||
// Delete existing entry with same query (case-insensitive)
|
||||
await (delete(searchHistory)
|
||||
..where((s) => s.query.lower().equals(trimmedQuery.toLowerCase())))
|
||||
.go();
|
||||
|
||||
// Insert the new search
|
||||
await into(searchHistory).insert(SearchHistoryCompanion.insert(
|
||||
query: trimmedQuery,
|
||||
searchedAt: DateTime.now(),
|
||||
));
|
||||
|
||||
// Keep only the 10 most recent searches
|
||||
final allSearches = await (select(searchHistory)
|
||||
..orderBy([(s) => OrderingTerm.desc(s.searchedAt)]))
|
||||
.get();
|
||||
|
||||
if (allSearches.length > 10) {
|
||||
final toDelete = allSearches.skip(10).map((s) => s.id).toList();
|
||||
await (delete(searchHistory)..where((s) => s.id.isIn(toDelete))).go();
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
/// Get recent search queries (up to 10, most recent first)
|
||||
Future<List<String>> getRecentSearches() async {
|
||||
final searches = await (select(searchHistory)
|
||||
..orderBy([(s) => OrderingTerm.desc(s.searchedAt)])
|
||||
..limit(10))
|
||||
.get();
|
||||
return searches.map((s) => s.query).toList();
|
||||
}
|
||||
|
||||
/// Clear all search history
|
||||
Future<void> clearSearchHistory() async {
|
||||
await delete(searchHistory).go();
|
||||
}
|
||||
}
|
||||
|
||||
+17
-1
@@ -126,6 +126,7 @@
|
||||
|
||||
"playing": "Spiele {name}",
|
||||
"playingTrack": "Spiele Song",
|
||||
"nowPlaying": "Wird gespielt",
|
||||
|
||||
"markedAsFinished": "{name} als beendet markiert",
|
||||
"failedToMarkFinished": "Konnte nicht als beendet markieren: {error}",
|
||||
@@ -269,8 +270,23 @@
|
||||
"audiobookSingular": "Hörbuch",
|
||||
"trackCount": "{count} {count, plural, =1{Song} other{Songs}}",
|
||||
"materialYouDescription": "Systemfarben verwenden (Android 12+)",
|
||||
"accentColor": "Akzentfarbe",
|
||||
"players": "Geräte",
|
||||
"preferLocalPlayer": "Lokales Gerät bevorzugen",
|
||||
"preferLocalPlayerDescription": "Dieses Gerät immer zuerst auswählen, wenn verfügbar",
|
||||
"smartSortPlayers": "Intelligente Sortierung",
|
||||
"smartSortPlayersDescription": "Nach Status sortieren (spielt, an, aus) statt alphabetisch",
|
||||
"playerStateUnavailable": "Nicht verfügbar",
|
||||
"playerStateOff": "Aus",
|
||||
"playerStateIdle": "Inaktiv",
|
||||
"playerSelected": "Ausgewählt"
|
||||
"playerStateExternalSource": "Externe Quelle",
|
||||
"playerSelected": "Ausgewählt",
|
||||
"actionQueuedForSync": "Wird synchronisiert wenn online",
|
||||
"pendingOfflineActions": "{count} ausstehende Synchronisierung",
|
||||
"hintsAndTips": "Tipps & Hinweise",
|
||||
"showHints": "Hinweise anzeigen",
|
||||
"showHintsDescription": "Hilfreiche Tipps zum Entdecken von Funktionen anzeigen",
|
||||
"pullToSelectPlayers": "Ziehen um Geräte auszuwählen",
|
||||
"holdToSync": "Gedrückt halten zum Sync",
|
||||
"swipeToAdjustVolume": "Wischen für Lautstärke"
|
||||
}
|
||||
|
||||
+146
-1
@@ -261,6 +261,26 @@
|
||||
"description": "Search hint text"
|
||||
},
|
||||
|
||||
"recentSearches": "Recent Searches",
|
||||
"@recentSearches": {
|
||||
"description": "Label for recent search history section"
|
||||
},
|
||||
|
||||
"clearSearchHistory": "Clear Search History",
|
||||
"@clearSearchHistory": {
|
||||
"description": "Button to clear search history"
|
||||
},
|
||||
|
||||
"searchHistoryCleared": "Search history cleared",
|
||||
"@searchHistoryCleared": {
|
||||
"description": "Confirmation message after clearing search history"
|
||||
},
|
||||
|
||||
"libraryOnly": "Library only",
|
||||
"@libraryOnly": {
|
||||
"description": "Toggle to search only in library"
|
||||
},
|
||||
|
||||
"retry": "Retry",
|
||||
"@retry": {
|
||||
"description": "Retry button label"
|
||||
@@ -610,6 +630,11 @@
|
||||
"description": "Radio button label"
|
||||
},
|
||||
|
||||
"addedToQueue": "Added to queue",
|
||||
"@addedToQueue": {
|
||||
"description": "Confirmation when item added to queue"
|
||||
},
|
||||
|
||||
"inLibrary": "In Library",
|
||||
"@inLibrary": {
|
||||
"description": "In library section title"
|
||||
@@ -635,6 +660,11 @@
|
||||
"description": "Status when playing track"
|
||||
},
|
||||
|
||||
"nowPlaying": "Now playing",
|
||||
"@nowPlaying": {
|
||||
"description": "Label shown when device selector is open to indicate current player"
|
||||
},
|
||||
|
||||
"markedAsFinished": "{name} marked as finished",
|
||||
"@markedAsFinished": {
|
||||
"description": "Audiobook marked finished",
|
||||
@@ -1073,7 +1103,7 @@
|
||||
"description": "Hint for Last.fm API key field"
|
||||
},
|
||||
|
||||
"swipeToSwitchDevice": "Swipe to switch device",
|
||||
"swipeToSwitchDevice": "Swipe to change player",
|
||||
"@swipeToSwitchDevice": {
|
||||
"description": "Hint for device switching gesture"
|
||||
},
|
||||
@@ -1128,6 +1158,16 @@
|
||||
"description": "Singular form of audiobook"
|
||||
},
|
||||
|
||||
"albumSingular": "Album",
|
||||
"@albumSingular": {
|
||||
"description": "Singular form of album for search type indicator"
|
||||
},
|
||||
|
||||
"trackSingular": "Track",
|
||||
"@trackSingular": {
|
||||
"description": "Singular form of track for search type indicator"
|
||||
},
|
||||
|
||||
"trackCount": "{count} {count, plural, =1{track} other{tracks}}",
|
||||
"@trackCount": {
|
||||
"description": "Track count with plural",
|
||||
@@ -1143,6 +1183,36 @@
|
||||
"description": "Description for Material You theme option"
|
||||
},
|
||||
|
||||
"accentColor": "Accent Color",
|
||||
"@accentColor": {
|
||||
"description": "Accent color selection label"
|
||||
},
|
||||
|
||||
"players": "Players",
|
||||
"@players": {
|
||||
"description": "Players settings section title"
|
||||
},
|
||||
|
||||
"preferLocalPlayer": "Prefer Local Player",
|
||||
"@preferLocalPlayer": {
|
||||
"description": "Setting to always prefer local player"
|
||||
},
|
||||
|
||||
"preferLocalPlayerDescription": "Always select this device first when available",
|
||||
"@preferLocalPlayerDescription": {
|
||||
"description": "Description for prefer local player setting"
|
||||
},
|
||||
|
||||
"smartSortPlayers": "Smart Sort",
|
||||
"@smartSortPlayers": {
|
||||
"description": "Setting to sort players by status"
|
||||
},
|
||||
|
||||
"smartSortPlayersDescription": "Sort by status (playing, on, off) instead of alphabetically",
|
||||
"@smartSortPlayersDescription": {
|
||||
"description": "Description for smart sort players setting"
|
||||
},
|
||||
|
||||
"playerStateUnavailable": "Unavailable",
|
||||
"@playerStateUnavailable": {
|
||||
"description": "Player state when unavailable"
|
||||
@@ -1158,8 +1228,83 @@
|
||||
"description": "Player state when idle"
|
||||
},
|
||||
|
||||
"playerStateExternalSource": "External Source",
|
||||
"@playerStateExternalSource": {
|
||||
"description": "Player state when playing from external source (optical, Spotify, etc.)"
|
||||
},
|
||||
|
||||
"playerSelected": "Selected",
|
||||
"@playerSelected": {
|
||||
"description": "Label for selected player"
|
||||
},
|
||||
|
||||
"actionQueuedForSync": "Will sync when online",
|
||||
"@actionQueuedForSync": {
|
||||
"description": "Message when action is queued for sync while offline"
|
||||
},
|
||||
|
||||
"pendingOfflineActions": "{count} pending sync",
|
||||
"@pendingOfflineActions": {
|
||||
"description": "Shows number of pending offline actions",
|
||||
"placeholders": {
|
||||
"count": {
|
||||
"type": "int"
|
||||
}
|
||||
}
|
||||
},
|
||||
|
||||
"hintsAndTips": "Hints & Tips",
|
||||
"@hintsAndTips": {
|
||||
"description": "Settings section title for hints"
|
||||
},
|
||||
|
||||
"showHints": "Show Hints",
|
||||
"@showHints": {
|
||||
"description": "Toggle label for showing hints"
|
||||
},
|
||||
|
||||
"showHintsDescription": "Display helpful tips for discovering features",
|
||||
"@showHintsDescription": {
|
||||
"description": "Description for show hints toggle"
|
||||
},
|
||||
|
||||
"pullToSelectPlayers": "Pull to select players",
|
||||
"@pullToSelectPlayers": {
|
||||
"description": "Hint shown when mini player bounces"
|
||||
},
|
||||
|
||||
"holdToSync": "Long-press to sync",
|
||||
"@holdToSync": {
|
||||
"description": "Hint for long-press to sync players"
|
||||
},
|
||||
|
||||
"swipeToAdjustVolume": "Swipe to adjust volume",
|
||||
"@swipeToAdjustVolume": {
|
||||
"description": "Hint for swiping left/right to adjust player volume"
|
||||
},
|
||||
|
||||
"selectPlayerHint": "Choose a player, or dismiss by swiping down",
|
||||
"@selectPlayerHint": {
|
||||
"description": "First-time hint for selecting a player in device selector"
|
||||
},
|
||||
|
||||
"welcomeToEnsemble": "Welcome to Ensemble",
|
||||
"@welcomeToEnsemble": {
|
||||
"description": "Welcome message title for onboarding"
|
||||
},
|
||||
|
||||
"welcomeMessage": "By default your phone is the selected player.\nPull the mini player down to select another player.",
|
||||
"@welcomeMessage": {
|
||||
"description": "Welcome message body explaining how to select players"
|
||||
},
|
||||
|
||||
"skip": "Skip",
|
||||
"@skip": {
|
||||
"description": "Button to skip onboarding or hints"
|
||||
},
|
||||
|
||||
"dismissPlayerHint": "Swipe down, tap outside, or press back to return",
|
||||
"@dismissPlayerHint": {
|
||||
"description": "Hint explaining how to dismiss the player selector"
|
||||
}
|
||||
}
|
||||
|
||||
+18
-2
@@ -225,6 +225,7 @@
|
||||
}
|
||||
},
|
||||
"playingTrack": "Reproduciendo canción",
|
||||
"nowPlaying": "Reproduciendo ahora",
|
||||
"markedAsFinished": "{name} marcado como terminado",
|
||||
"@markedAsFinished": {
|
||||
"placeholders": {
|
||||
@@ -433,7 +434,7 @@
|
||||
"metadataApisDescription": "Las imágenes de artistas se obtienen automáticamente de Deezer. Añade claves API a continuación para biografías de artistas y descripciones de álbumes.",
|
||||
"lastFmApiKey": "Clave API de Last.fm",
|
||||
"lastFmApiKeyHint": "Obtén una clave gratuita en last.fm/api",
|
||||
"swipeToSwitchDevice": "Desliza para cambiar de dispositivo",
|
||||
"swipeToSwitchDevice": "Desliza para cambiar dispositivo",
|
||||
"chapterNumber": "Capítulo {number}",
|
||||
"@chapterNumber": {
|
||||
"placeholders": {
|
||||
@@ -465,8 +466,23 @@
|
||||
}
|
||||
},
|
||||
"materialYouDescription": "Usar colores del sistema (Android 12+)",
|
||||
"accentColor": "Color de acento",
|
||||
"players": "Dispositivos",
|
||||
"preferLocalPlayer": "Preferir dispositivo local",
|
||||
"preferLocalPlayerDescription": "Seleccionar siempre este dispositivo primero cuando esté disponible",
|
||||
"smartSortPlayers": "Orden inteligente",
|
||||
"smartSortPlayersDescription": "Ordenar por estado (reproduciendo, encendido, apagado) en lugar de alfabéticamente",
|
||||
"playerStateUnavailable": "No disponible",
|
||||
"playerStateOff": "Apagado",
|
||||
"playerStateIdle": "Inactivo",
|
||||
"playerSelected": "Seleccionado"
|
||||
"playerStateExternalSource": "Fuente Externa",
|
||||
"playerSelected": "Seleccionado",
|
||||
"actionQueuedForSync": "Se sincronizará cuando esté en línea",
|
||||
"pendingOfflineActions": "{count} sincronización pendiente",
|
||||
"hintsAndTips": "Consejos y Sugerencias",
|
||||
"showHints": "Mostrar Sugerencias",
|
||||
"showHintsDescription": "Mostrar consejos útiles para descubrir funciones",
|
||||
"pullToSelectPlayers": "Desliza para seleccionar dispositivos",
|
||||
"holdToSync": "Mantén presionado para sync",
|
||||
"swipeToAdjustVolume": "Desliza para ajustar volumen"
|
||||
}
|
||||
|
||||
+61
-8
@@ -40,6 +40,10 @@ Future<void> main() async {
|
||||
// Migrate existing ownerName to profile (one-time for existing users)
|
||||
await ProfileService.instance.migrateFromOwnerName();
|
||||
|
||||
// Migrate credentials to secure storage (one-time for existing users)
|
||||
await SettingsService.migrateToSecureStorage();
|
||||
_logger.log('🔐 Secure storage migration complete');
|
||||
|
||||
// Load library from cache for instant startup
|
||||
await SyncService.instance.loadFromCache();
|
||||
_logger.log('📦 Library cache loaded');
|
||||
@@ -230,9 +234,9 @@ class _MusicAssistantAppState extends State<MusicAssistantApp> with WidgetsBindi
|
||||
lightColorScheme = light;
|
||||
darkColorScheme = dark;
|
||||
} else {
|
||||
// Use brand color schemes
|
||||
lightColorScheme = brandLightColorScheme;
|
||||
darkColorScheme = brandDarkColorScheme;
|
||||
// Use custom color from theme provider
|
||||
lightColorScheme = generateLightColorScheme(themeProvider.customColor);
|
||||
darkColorScheme = generateDarkColorScheme(themeProvider.customColor);
|
||||
}
|
||||
|
||||
return SystemUIWrapper(
|
||||
@@ -348,7 +352,16 @@ class _SystemUIWrapperState extends State<SystemUIWrapper> {
|
||||
}
|
||||
}
|
||||
|
||||
/// Startup widget that checks if user is logged in and auto-connects
|
||||
/// Startup widget that checks if user is logged in and auto-connects.
|
||||
///
|
||||
/// CRITICAL: This widget is the single source of truth for the startup transition.
|
||||
/// It loads settings FIRST (before connection), then waits for the appropriate
|
||||
/// conditions before showing HomeScreen. This eliminates the race condition between
|
||||
/// AppStartup and GlobalPlayerOverlay that caused the home screen flash.
|
||||
///
|
||||
/// For first-time users: Holds dark screen until connected + player selected,
|
||||
/// so the welcome overlay can appear seamlessly.
|
||||
/// For returning users: Transitions as soon as connection is established.
|
||||
class AppStartup extends StatefulWidget {
|
||||
const AppStartup({super.key});
|
||||
|
||||
@@ -361,9 +374,32 @@ class _AppStartupState extends State<AppStartup> {
|
||||
String? _savedServerUrl;
|
||||
bool _connectionAttempted = false;
|
||||
|
||||
// Welcome system state - loaded FIRST before connection check
|
||||
bool _settingsLoaded = false;
|
||||
bool _hasCompletedOnboarding = true; // Default to true (no welcome needed)
|
||||
|
||||
@override
|
||||
void initState() {
|
||||
super.initState();
|
||||
_loadSettingsFirst();
|
||||
}
|
||||
|
||||
/// Load settings BEFORE checking connection.
|
||||
/// This ensures we know if this is a first-time user before transitioning.
|
||||
Future<void> _loadSettingsFirst() async {
|
||||
// Load onboarding state first - this is critical for determining
|
||||
// when to transition to HomeScreen
|
||||
_hasCompletedOnboarding = await SettingsService.getHasCompletedOnboarding();
|
||||
|
||||
if (!mounted) return;
|
||||
|
||||
setState(() {
|
||||
_settingsLoaded = true;
|
||||
});
|
||||
|
||||
_logger.log('🚀 AppStartup: Settings loaded, hasCompletedOnboarding=$_hasCompletedOnboarding');
|
||||
|
||||
// Now check connection
|
||||
_checkAndConnect();
|
||||
}
|
||||
|
||||
@@ -388,14 +424,30 @@ class _AppStartupState extends State<AppStartup> {
|
||||
// Just wait for it to complete or timeout
|
||||
_logger.log('🚀 AppStartup: Waiting for provider auto-connection to $serverUrl');
|
||||
|
||||
// For first-time users, we need to wait for both connection AND player selection
|
||||
// so the welcome overlay can appear immediately without home screen flash.
|
||||
// For returning users, just wait for connection.
|
||||
final needsWelcome = !_hasCompletedOnboarding;
|
||||
|
||||
// Give the provider time to connect (it restores credentials and connects in _initialize)
|
||||
// Check connection state periodically
|
||||
for (var i = 0; i < 20; i++) {
|
||||
await Future.delayed(const Duration(milliseconds: 250));
|
||||
if (provider.isConnected) {
|
||||
_logger.log('🚀 AppStartup: Connection established');
|
||||
break;
|
||||
|
||||
if (needsWelcome) {
|
||||
// First-time user: wait for connection + player selection
|
||||
if (provider.isConnected && provider.selectedPlayer != null) {
|
||||
_logger.log('🚀 AppStartup: First-time user ready (connected + player selected)');
|
||||
break;
|
||||
}
|
||||
} else {
|
||||
// Returning user: just wait for connection
|
||||
if (provider.isConnected) {
|
||||
_logger.log('🚀 AppStartup: Connection established');
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
if (provider.connectionState == MAConnectionState.error) {
|
||||
_logger.log('🚀 AppStartup: Connection failed with error');
|
||||
break;
|
||||
@@ -422,7 +474,8 @@ class _AppStartupState extends State<AppStartup> {
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
// Show loading while checking settings or connecting
|
||||
if (!_connectionAttempted || _isConnecting) {
|
||||
// CRITICAL: Don't transition until settings are loaded - this prevents the race
|
||||
if (!_settingsLoaded || !_connectionAttempted || _isConnecting) {
|
||||
return Scaffold(
|
||||
backgroundColor: const Color(0xFF1a1a1a),
|
||||
body: Center(
|
||||
|
||||
@@ -110,7 +110,8 @@ class MediaItem {
|
||||
'media_type': mediaType.name,
|
||||
if (sortName != null) 'sort_name': sortName,
|
||||
if (uri != null) 'uri': uri,
|
||||
if (providerMappings != null) 'provider_mappings': providerMappings,
|
||||
if (providerMappings != null)
|
||||
'provider_mappings': providerMappings!.map((m) => m.toJson()).toList(),
|
||||
if (metadata != null) 'metadata': metadata,
|
||||
if (favorite != null) 'favorite': favorite,
|
||||
if (position != null) 'position': position,
|
||||
|
||||
+123
-7
@@ -12,6 +12,11 @@ class Player {
|
||||
final bool? volumeMuted;
|
||||
final double? elapsedTime; // Seconds elapsed in current track
|
||||
final double? elapsedTimeLastUpdated; // Unix timestamp when elapsed_time was last updated
|
||||
final List<String>? groupMembers; // List of player IDs in sync group (includes self)
|
||||
final String? syncedTo; // Player ID this player is synced to (null if leader or not synced)
|
||||
final String? activeSource; // The currently active source for this player
|
||||
final bool isExternalSource; // True when an external source (optical, Spotify, etc.) is active
|
||||
final String? appId; // The app_id from MA - 'music_assistant' when MA is playing, else external source
|
||||
|
||||
Player({
|
||||
required this.playerId,
|
||||
@@ -25,6 +30,11 @@ class Player {
|
||||
this.volumeMuted,
|
||||
this.elapsedTime,
|
||||
this.elapsedTimeLastUpdated,
|
||||
this.groupMembers,
|
||||
this.syncedTo,
|
||||
this.activeSource,
|
||||
this.isExternalSource = false,
|
||||
this.appId,
|
||||
});
|
||||
|
||||
/// Create a copy of this Player with some fields replaced
|
||||
@@ -40,6 +50,11 @@ class Player {
|
||||
bool? volumeMuted,
|
||||
double? elapsedTime,
|
||||
double? elapsedTimeLastUpdated,
|
||||
List<String>? groupMembers,
|
||||
String? syncedTo,
|
||||
String? activeSource,
|
||||
bool? isExternalSource,
|
||||
String? appId,
|
||||
}) {
|
||||
return Player(
|
||||
playerId: playerId ?? this.playerId,
|
||||
@@ -53,6 +68,11 @@ class Player {
|
||||
volumeMuted: volumeMuted ?? this.volumeMuted,
|
||||
elapsedTime: elapsedTime ?? this.elapsedTime,
|
||||
elapsedTimeLastUpdated: elapsedTimeLastUpdated ?? this.elapsedTimeLastUpdated,
|
||||
groupMembers: groupMembers ?? this.groupMembers,
|
||||
syncedTo: syncedTo ?? this.syncedTo,
|
||||
activeSource: activeSource ?? this.activeSource,
|
||||
isExternalSource: isExternalSource ?? this.isExternalSource,
|
||||
appId: appId ?? this.appId,
|
||||
);
|
||||
}
|
||||
|
||||
@@ -61,8 +81,37 @@ class Player {
|
||||
bool get isMuted => volumeMuted ?? false;
|
||||
int get volume => volumeLevel ?? 0;
|
||||
|
||||
// Group properties
|
||||
// A player is grouped if it's a leader with members OR a child synced to another
|
||||
bool get isGrouped => (groupMembers != null && groupMembers!.length > 1) || syncedTo != null;
|
||||
bool get isGroupLeader => groupMembers != null && groupMembers!.length > 1 && syncedTo == null;
|
||||
bool get isGroupChild => syncedTo != null;
|
||||
|
||||
// A player is manually synced if it's synced TO another player (child of a sync group)
|
||||
// This excludes pre-configured MA speaker groups which have groupMembers but no syncedTo
|
||||
// Used for yellow border highlight - only shows for players the user manually synced
|
||||
bool get isManuallySynced => syncedTo != null;
|
||||
|
||||
// Track when this Player object was created (for local interpolation fallback)
|
||||
static final Map<String, double> _playerCreationTimes = {};
|
||||
static const int _maxCreationTimesEntries = 50;
|
||||
|
||||
/// Clean up old creation time entries using LRU eviction
|
||||
static void _cleanupCreationTimes() {
|
||||
if (_playerCreationTimes.length <= _maxCreationTimesEntries) return;
|
||||
|
||||
// Sort by timestamp value (oldest first) for true LRU eviction
|
||||
final sortedEntries = _playerCreationTimes.entries.toList()
|
||||
..sort((a, b) => a.value.compareTo(b.value));
|
||||
|
||||
// Remove oldest entries until we're at target size
|
||||
final entriesToRemove = sortedEntries.take(
|
||||
_playerCreationTimes.length - _maxCreationTimesEntries,
|
||||
);
|
||||
for (final entry in entriesToRemove) {
|
||||
_playerCreationTimes.remove(entry.key);
|
||||
}
|
||||
}
|
||||
|
||||
// Calculate current elapsed time (interpolated if playing)
|
||||
double get currentElapsedTime {
|
||||
@@ -104,13 +153,8 @@ class Player {
|
||||
if (!_playerCreationTimes.containsKey(creationKey)) {
|
||||
// First time seeing this elapsed_time - record when we saw it
|
||||
_playerCreationTimes[creationKey] = now;
|
||||
// Clean up old entries to prevent memory leak
|
||||
if (_playerCreationTimes.length > 100) {
|
||||
final keysToRemove = _playerCreationTimes.keys.take(50).toList();
|
||||
for (final key in keysToRemove) {
|
||||
_playerCreationTimes.remove(key);
|
||||
}
|
||||
}
|
||||
// Clean up old entries to prevent memory leak (LRU eviction)
|
||||
_cleanupCreationTimes();
|
||||
}
|
||||
|
||||
final creationTime = _playerCreationTimes[creationKey]!;
|
||||
@@ -164,6 +208,68 @@ class Player {
|
||||
elapsedTime ??= topLevelElapsedTime;
|
||||
elapsedTimeLastUpdated ??= topLevelLastUpdated;
|
||||
|
||||
// Parse group members - MA returns this as a list of player IDs
|
||||
final groupMembersList = json['group_members'] as List<dynamic>?;
|
||||
final groupMembers = groupMembersList?.map((e) => e.toString()).toList();
|
||||
|
||||
// Parse synced_to - the player ID this player is synced to
|
||||
final syncedTo = json['synced_to'] as String?;
|
||||
|
||||
// Parse active_source - the currently active source for this player
|
||||
final activeSource = json['active_source'] as String?;
|
||||
|
||||
// Detect external source (optical, Spotify, AirPlay, etc.)
|
||||
// Primary indicator: app_id - if not 'music_assistant', it's an external source
|
||||
// Secondary indicators: URI patterns and media_type
|
||||
bool isExternalSource = false;
|
||||
|
||||
// Check app_id first - this is the most reliable indicator for DLNA players
|
||||
// When MA is playing: app_id = 'music_assistant'
|
||||
// When external source: app_id = 'http', 'spotify', etc.
|
||||
final appId = json['app_id'] as String?;
|
||||
if (appId != null && appId.isNotEmpty && appId != 'music_assistant') {
|
||||
// app_id is set but not 'music_assistant' - external source is active
|
||||
isExternalSource = true;
|
||||
}
|
||||
|
||||
// Also check current_media for additional external source indicators
|
||||
if (!isExternalSource && json.containsKey('current_media')) {
|
||||
final currentMedia = json['current_media'] as Map<String, dynamic>?;
|
||||
if (currentMedia != null) {
|
||||
final uri = currentMedia['uri'] as String?;
|
||||
final mediaType = currentMedia['media_type'] as String?;
|
||||
|
||||
// External source indicators:
|
||||
// 1. URI is a simple identifier like 'optical', 'line_in', 'bluetooth', 'hdmi'
|
||||
// 2. URI starts with external protocols: 'spotify://', 'airplay://', etc.
|
||||
// 3. Media type is 'unknown' (MA doesn't recognize the source)
|
||||
if (uri != null) {
|
||||
final uriLower = uri.toLowerCase();
|
||||
// Simple external source identifiers (no :// or /)
|
||||
final isSimpleExternalId = !uri.contains('://') && !uri.contains('/') &&
|
||||
(uriLower == 'optical' || uriLower == 'line_in' || uriLower == 'bluetooth' ||
|
||||
uriLower == 'hdmi' || uriLower == 'tv' || uriLower == 'aux' ||
|
||||
uriLower == 'coaxial' || uriLower == 'toslink');
|
||||
// External streaming protocols
|
||||
final isExternalProtocol = uriLower.startsWith('spotify://') ||
|
||||
uriLower.startsWith('airplay://') ||
|
||||
uriLower.startsWith('cast://') ||
|
||||
uriLower.startsWith('bluetooth://');
|
||||
|
||||
isExternalSource = isSimpleExternalId || isExternalProtocol;
|
||||
}
|
||||
|
||||
// Also check media_type - 'unknown' often indicates external source
|
||||
if (!isExternalSource && mediaType == 'unknown') {
|
||||
// If media_type is unknown and URI doesn't look like MA content, it's external
|
||||
final uri = currentMedia['uri'] as String?;
|
||||
if (uri != null && !uri.startsWith('library://') && !uri.contains('://track/')) {
|
||||
isExternalSource = true;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return Player(
|
||||
playerId: json['player_id'] as String,
|
||||
name: json['name'] as String,
|
||||
@@ -176,6 +282,11 @@ class Player {
|
||||
volumeMuted: json['volume_muted'] as bool?,
|
||||
elapsedTime: elapsedTime,
|
||||
elapsedTimeLastUpdated: elapsedTimeLastUpdated,
|
||||
groupMembers: groupMembers,
|
||||
syncedTo: syncedTo,
|
||||
activeSource: activeSource,
|
||||
isExternalSource: isExternalSource,
|
||||
appId: appId,
|
||||
);
|
||||
}
|
||||
|
||||
@@ -192,6 +303,11 @@ class Player {
|
||||
if (volumeMuted != null) 'volume_muted': volumeMuted,
|
||||
if (elapsedTime != null) 'elapsed_time': elapsedTime,
|
||||
if (elapsedTimeLastUpdated != null) 'elapsed_time_last_updated': elapsedTimeLastUpdated,
|
||||
if (groupMembers != null) 'group_members': groupMembers,
|
||||
if (syncedTo != null) 'synced_to': syncedTo,
|
||||
if (activeSource != null) 'active_source': activeSource,
|
||||
'is_external_source': isExternalSource,
|
||||
if (appId != null) 'app_id': appId,
|
||||
};
|
||||
}
|
||||
}
|
||||
|
||||
@@ -189,7 +189,9 @@ class ConnectionProvider with ChangeNotifier {
|
||||
_logger.log('✅ MA authentication successful');
|
||||
onAuthenticated?.call();
|
||||
} else if (state == MAConnectionState.disconnected) {
|
||||
_cacheService.clearAll();
|
||||
// DON'T clear caches on disconnect - keep showing cached data
|
||||
// This allows instant UI display when app resumes or reconnects
|
||||
// Caches will be refreshed when connection is restored
|
||||
onDisconnected?.call();
|
||||
}
|
||||
},
|
||||
@@ -215,6 +217,12 @@ class ConnectionProvider with ChangeNotifier {
|
||||
Future<void> disconnect() async {
|
||||
await _api?.disconnect();
|
||||
_connectionState = MAConnectionState.disconnected;
|
||||
// DON'T clear caches on disconnect - keep showing cached data for instant reconnect
|
||||
notifyListeners();
|
||||
}
|
||||
|
||||
/// Clear all caches and state (for logout or server change)
|
||||
void clearCachesOnLogout() {
|
||||
_cacheService.clearAll();
|
||||
notifyListeners();
|
||||
}
|
||||
|
||||
File diff suppressed because it is too large
Load Diff
@@ -559,28 +559,28 @@ class PlayerProvider with ChangeNotifier {
|
||||
if (playerToSelect == null) {
|
||||
final lastSelectedPlayerId = await SettingsService.getLastSelectedPlayerId();
|
||||
|
||||
// Priority 1: Last selected player
|
||||
if (lastSelectedPlayerId != null) {
|
||||
try {
|
||||
playerToSelect = _availablePlayers.firstWhere(
|
||||
(p) => p.playerId == lastSelectedPlayerId && p.available,
|
||||
);
|
||||
} catch (e) {}
|
||||
playerToSelect = _availablePlayers.cast<Player?>().firstWhere(
|
||||
(p) => p!.playerId == lastSelectedPlayerId && p.available,
|
||||
orElse: () => null,
|
||||
);
|
||||
}
|
||||
|
||||
// Priority 2: Built-in (local) player
|
||||
if (playerToSelect == null && builtinPlayerId != null) {
|
||||
try {
|
||||
playerToSelect = _availablePlayers.firstWhere(
|
||||
(p) => p.playerId == builtinPlayerId && p.available,
|
||||
);
|
||||
} catch (e) {}
|
||||
playerToSelect = _availablePlayers.cast<Player?>().firstWhere(
|
||||
(p) => p!.playerId == builtinPlayerId && p.available,
|
||||
orElse: () => null,
|
||||
);
|
||||
}
|
||||
|
||||
// Priority 3: Currently playing player (exclude external sources - not playing MA content)
|
||||
if (playerToSelect == null) {
|
||||
try {
|
||||
playerToSelect = _availablePlayers.firstWhere(
|
||||
(p) => p.state == 'playing' && p.available,
|
||||
);
|
||||
} catch (e) {}
|
||||
playerToSelect = _availablePlayers.cast<Player?>().firstWhere(
|
||||
(p) => p!.state == 'playing' && p.available && !p.isExternalSource,
|
||||
orElse: () => null,
|
||||
);
|
||||
}
|
||||
|
||||
if (playerToSelect == null) {
|
||||
@@ -906,10 +906,10 @@ class PlayerProvider with ChangeNotifier {
|
||||
}
|
||||
}
|
||||
|
||||
Future<void> toggleShuffle(String queueId) async {
|
||||
Future<void> toggleShuffle(String queueId, bool shuffleEnabled) async {
|
||||
if (_api == null) return;
|
||||
try {
|
||||
await _api!.toggleShuffle(queueId);
|
||||
await _api!.toggleShuffle(queueId, shuffleEnabled);
|
||||
} catch (e) {
|
||||
ErrorHandler.logError('Toggle shuffle', e);
|
||||
rethrow;
|
||||
|
||||
@@ -10,17 +10,21 @@ import '../services/metadata_service.dart';
|
||||
import '../services/debug_logger.dart';
|
||||
import '../services/recently_played_service.dart';
|
||||
import '../widgets/global_player_overlay.dart';
|
||||
import '../widgets/player_picker_sheet.dart';
|
||||
import '../l10n/app_localizations.dart';
|
||||
import 'artist_details_screen.dart';
|
||||
|
||||
class AlbumDetailsScreen extends StatefulWidget {
|
||||
final Album album;
|
||||
final String? heroTagSuffix;
|
||||
/// Initial image URL from the source (e.g., AlbumCard) for seamless hero animation
|
||||
final String? initialImageUrl;
|
||||
|
||||
const AlbumDetailsScreen({
|
||||
super.key,
|
||||
required this.album,
|
||||
this.heroTagSuffix,
|
||||
this.initialImageUrl,
|
||||
});
|
||||
|
||||
@override
|
||||
@@ -37,6 +41,10 @@ class _AlbumDetailsScreenState extends State<AlbumDetailsScreen> with SingleTick
|
||||
int? _expandedTrackIndex;
|
||||
bool _isDescriptionExpanded = false;
|
||||
String? _albumDescription;
|
||||
Album? _freshAlbum; // Full album data with image metadata
|
||||
|
||||
/// Get the best album data available (fresh with images, or widget.album as fallback)
|
||||
Album get _displayAlbum => _freshAlbum ?? widget.album;
|
||||
|
||||
String get _heroTagSuffix => widget.heroTagSuffix != null ? '_${widget.heroTagSuffix}' : '';
|
||||
|
||||
@@ -46,29 +54,31 @@ class _AlbumDetailsScreenState extends State<AlbumDetailsScreen> with SingleTick
|
||||
_isFavorite = widget.album.favorite ?? false;
|
||||
_loadTracks();
|
||||
_loadAlbumDescription();
|
||||
_refreshFavoriteStatus();
|
||||
|
||||
// CRITICAL FIX: Defer color extraction until after the transition completes
|
||||
// This prevents expensive palette extraction during hero animation
|
||||
// Wait for the first frame to be painted, then extract colors
|
||||
// CRITICAL FIX: Defer both fresh data loading AND color extraction until
|
||||
// after the hero animation completes. This prevents:
|
||||
// 1. setState with new image URL during animation → grey icon flash
|
||||
// 2. Expensive palette extraction blocking animation frames
|
||||
WidgetsBinding.instance.addPostFrameCallback((_) {
|
||||
// Add small delay to ensure transition is complete
|
||||
// 350ms matches FadeSlidePageRoute duration (300ms) + buffer
|
||||
Future.delayed(const Duration(milliseconds: 350), () {
|
||||
if (mounted) {
|
||||
_loadFreshAlbumData();
|
||||
_extractColors();
|
||||
}
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
Future<void> _refreshFavoriteStatus() async {
|
||||
/// Load fresh album data from API to get full metadata including images
|
||||
Future<void> _loadFreshAlbumData() async {
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
if (maProvider.api == null) return;
|
||||
|
||||
// Need a URI to fetch fresh album data
|
||||
final albumUri = widget.album.uri;
|
||||
if (albumUri == null || albumUri.isEmpty) {
|
||||
_logger.log('Cannot refresh favorite status: album has no URI');
|
||||
_logger.log('Cannot load fresh album: album has no URI');
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -76,17 +86,20 @@ class _AlbumDetailsScreenState extends State<AlbumDetailsScreen> with SingleTick
|
||||
final freshAlbum = await maProvider.api!.getAlbumByUri(albumUri);
|
||||
if (freshAlbum != null && mounted) {
|
||||
setState(() {
|
||||
_freshAlbum = freshAlbum;
|
||||
_isFavorite = freshAlbum.favorite ?? false;
|
||||
});
|
||||
// Re-extract colors now that we have fresh album with images
|
||||
_extractColors();
|
||||
}
|
||||
} catch (e) {
|
||||
_logger.log('Error refreshing favorite status: $e');
|
||||
_logger.log('Error loading fresh album data: $e');
|
||||
}
|
||||
}
|
||||
|
||||
Future<void> _extractColors() async {
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
final imageUrl = maProvider.getImageUrl(widget.album, size: 512);
|
||||
final imageUrl = maProvider.getImageUrl(_displayAlbum, size: 512);
|
||||
|
||||
if (imageUrl == null) return;
|
||||
|
||||
@@ -108,10 +121,10 @@ class _AlbumDetailsScreenState extends State<AlbumDetailsScreen> with SingleTick
|
||||
|
||||
Future<void> _toggleFavorite() async {
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
if (maProvider.api == null) return;
|
||||
|
||||
try {
|
||||
final newState = !_isFavorite;
|
||||
bool success;
|
||||
|
||||
if (newState) {
|
||||
// For adding: use the actual provider and itemId from provider_mappings
|
||||
@@ -132,17 +145,18 @@ class _AlbumDetailsScreenState extends State<AlbumDetailsScreen> with SingleTick
|
||||
}
|
||||
|
||||
_logger.log('Adding to favorites: provider=$actualProvider, itemId=$actualItemId');
|
||||
await maProvider.api!.addToFavorites('album', actualItemId, actualProvider);
|
||||
success = await maProvider.addToFavorites(
|
||||
mediaType: 'album',
|
||||
itemId: actualItemId,
|
||||
provider: actualProvider,
|
||||
);
|
||||
} else {
|
||||
// For removing: need the library_item_id (numeric)
|
||||
// When provider is "library", itemId is the library ID as a string
|
||||
// Otherwise, we need to find it from provider_mappings
|
||||
int? libraryItemId;
|
||||
|
||||
if (widget.album.provider == 'library') {
|
||||
libraryItemId = int.tryParse(widget.album.itemId);
|
||||
} else if (widget.album.providerMappings != null) {
|
||||
// Find the library mapping
|
||||
final libraryMapping = widget.album.providerMappings!.firstWhere(
|
||||
(m) => m.providerInstance == 'library',
|
||||
orElse: () => widget.album.providerMappings!.first,
|
||||
@@ -158,25 +172,34 @@ class _AlbumDetailsScreenState extends State<AlbumDetailsScreen> with SingleTick
|
||||
}
|
||||
|
||||
_logger.log('Removing from favorites: libraryItemId=$libraryItemId');
|
||||
await maProvider.api!.removeFromFavorites('album', libraryItemId);
|
||||
success = await maProvider.removeFromFavorites(
|
||||
mediaType: 'album',
|
||||
libraryItemId: libraryItemId,
|
||||
);
|
||||
}
|
||||
|
||||
setState(() {
|
||||
_isFavorite = newState;
|
||||
});
|
||||
if (success) {
|
||||
// Optimistically update UI regardless of online/offline state
|
||||
setState(() {
|
||||
_isFavorite = newState;
|
||||
});
|
||||
|
||||
// Invalidate home cache so the home screen shows updated favorite status
|
||||
maProvider.invalidateHomeCache();
|
||||
// Invalidate home cache so the home screen shows updated favorite status
|
||||
maProvider.invalidateHomeCache();
|
||||
|
||||
if (mounted) {
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(
|
||||
content: Text(
|
||||
_isFavorite ? S.of(context)!.addedToFavorites : S.of(context)!.removedFromFavorites,
|
||||
if (mounted) {
|
||||
final isOffline = !maProvider.isConnected;
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(
|
||||
content: Text(
|
||||
isOffline
|
||||
? S.of(context)!.actionQueuedForSync
|
||||
: (_isFavorite ? S.of(context)!.addedToFavorites : S.of(context)!.removedFromFavorites),
|
||||
),
|
||||
duration: const Duration(seconds: 1),
|
||||
),
|
||||
duration: const Duration(seconds: 1),
|
||||
),
|
||||
);
|
||||
);
|
||||
}
|
||||
}
|
||||
} catch (e) {
|
||||
_logger.log('Error toggling favorite: $e');
|
||||
@@ -196,11 +219,11 @@ class _AlbumDetailsScreenState extends State<AlbumDetailsScreen> with SingleTick
|
||||
|
||||
final track = _tracks[trackIndex];
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
if (maProvider.api == null) return;
|
||||
|
||||
final currentFavorite = track.favorite ?? false;
|
||||
|
||||
try {
|
||||
bool success;
|
||||
|
||||
if (currentFavorite) {
|
||||
// Remove from favorites - need library_item_id
|
||||
int? libraryItemId;
|
||||
@@ -217,7 +240,12 @@ class _AlbumDetailsScreenState extends State<AlbumDetailsScreen> with SingleTick
|
||||
}
|
||||
|
||||
if (libraryItemId != null) {
|
||||
await maProvider.api!.removeFromFavorites('track', libraryItemId);
|
||||
success = await maProvider.removeFromFavorites(
|
||||
mediaType: 'track',
|
||||
libraryItemId: libraryItemId,
|
||||
);
|
||||
} else {
|
||||
success = false;
|
||||
}
|
||||
} else {
|
||||
// Add to favorites
|
||||
@@ -236,33 +264,42 @@ class _AlbumDetailsScreenState extends State<AlbumDetailsScreen> with SingleTick
|
||||
actualItemId = mapping.itemId;
|
||||
}
|
||||
|
||||
await maProvider.api!.addToFavorites('track', actualItemId, actualProvider);
|
||||
success = await maProvider.addToFavorites(
|
||||
mediaType: 'track',
|
||||
itemId: actualItemId,
|
||||
provider: actualProvider,
|
||||
);
|
||||
}
|
||||
|
||||
// Update local state - create new track with toggled favorite
|
||||
setState(() {
|
||||
_tracks[trackIndex] = Track(
|
||||
itemId: track.itemId,
|
||||
provider: track.provider,
|
||||
name: track.name,
|
||||
uri: track.uri,
|
||||
favorite: !currentFavorite,
|
||||
artists: track.artists,
|
||||
album: track.album,
|
||||
duration: track.duration,
|
||||
providerMappings: track.providerMappings,
|
||||
);
|
||||
});
|
||||
if (success) {
|
||||
// Optimistically update local state
|
||||
setState(() {
|
||||
_tracks[trackIndex] = Track(
|
||||
itemId: track.itemId,
|
||||
provider: track.provider,
|
||||
name: track.name,
|
||||
uri: track.uri,
|
||||
favorite: !currentFavorite,
|
||||
artists: track.artists,
|
||||
album: track.album,
|
||||
duration: track.duration,
|
||||
providerMappings: track.providerMappings,
|
||||
);
|
||||
});
|
||||
|
||||
if (mounted) {
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(
|
||||
content: Text(
|
||||
!currentFavorite ? S.of(context)!.addedToFavorites : S.of(context)!.removedFromFavorites,
|
||||
if (mounted) {
|
||||
final isOffline = !maProvider.isConnected;
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(
|
||||
content: Text(
|
||||
isOffline
|
||||
? S.of(context)!.actionQueuedForSync
|
||||
: (!currentFavorite ? S.of(context)!.addedToFavorites : S.of(context)!.removedFromFavorites),
|
||||
),
|
||||
duration: const Duration(seconds: 1),
|
||||
),
|
||||
duration: const Duration(seconds: 1),
|
||||
),
|
||||
);
|
||||
);
|
||||
}
|
||||
}
|
||||
} catch (e) {
|
||||
_logger.log('Error toggling track favorite: $e');
|
||||
@@ -279,16 +316,46 @@ class _AlbumDetailsScreenState extends State<AlbumDetailsScreen> with SingleTick
|
||||
|
||||
Future<void> _loadTracks() async {
|
||||
final provider = context.read<MusicAssistantProvider>();
|
||||
final tracks = await provider.getAlbumTracksWithCache(
|
||||
widget.album.provider,
|
||||
widget.album.itemId,
|
||||
);
|
||||
final cacheKey = '${widget.album.provider}_${widget.album.itemId}';
|
||||
|
||||
if (mounted) {
|
||||
setState(() {
|
||||
_tracks = tracks;
|
||||
_isLoading = false;
|
||||
});
|
||||
// 1. Show cached data immediately (if available)
|
||||
final cachedTracks = provider.getCachedAlbumTracks(cacheKey);
|
||||
if (cachedTracks != null && cachedTracks.isNotEmpty) {
|
||||
if (mounted) {
|
||||
setState(() {
|
||||
_tracks = cachedTracks;
|
||||
_isLoading = false;
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
// 2. Fetch fresh data in background (silent refresh)
|
||||
try {
|
||||
final freshTracks = await provider.getAlbumTracksWithCache(
|
||||
widget.album.provider,
|
||||
widget.album.itemId,
|
||||
forceRefresh: cachedTracks != null, // Force refresh if we had cache
|
||||
);
|
||||
|
||||
// 3. Update if we got different data
|
||||
if (mounted && freshTracks.isNotEmpty) {
|
||||
final tracksChanged = _tracks.length != freshTracks.length ||
|
||||
(_tracks.isNotEmpty && freshTracks.isNotEmpty &&
|
||||
_tracks.first.itemId != freshTracks.first.itemId);
|
||||
if (tracksChanged || _tracks.isEmpty) {
|
||||
setState(() {
|
||||
_tracks = freshTracks;
|
||||
_isLoading = false;
|
||||
});
|
||||
}
|
||||
}
|
||||
} catch (e) {
|
||||
_logger.log('⚠️ Background refresh failed: $e');
|
||||
}
|
||||
|
||||
// Ensure loading is false even if everything failed
|
||||
if (mounted && _isLoading) {
|
||||
setState(() => _isLoading = false);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -492,7 +559,7 @@ class _AlbumDetailsScreenState extends State<AlbumDetailsScreen> with SingleTick
|
||||
},
|
||||
),
|
||||
),
|
||||
const SizedBox(height: 16),
|
||||
SizedBox(height: MediaQuery.of(context).padding.bottom + 16),
|
||||
],
|
||||
),
|
||||
),
|
||||
@@ -595,9 +662,12 @@ class _AlbumDetailsScreenState extends State<AlbumDetailsScreen> with SingleTick
|
||||
Widget build(BuildContext context) {
|
||||
// CRITICAL FIX: Use select() instead of watch() to reduce rebuilds
|
||||
// Only rebuild when specific properties change, not on every provider update
|
||||
final imageUrl = context.select<MusicAssistantProvider, String?>(
|
||||
(provider) => provider.getImageUrl(widget.album, size: 512),
|
||||
// Use _displayAlbum which has fresh data with images if available
|
||||
final providerImageUrl = context.select<MusicAssistantProvider, String?>(
|
||||
(provider) => provider.getImageUrl(_displayAlbum, size: 512),
|
||||
);
|
||||
// Use initialImageUrl as fallback for seamless hero animation
|
||||
final imageUrl = providerImageUrl ?? widget.initialImageUrl;
|
||||
final adaptiveTheme = context.select<ThemeProvider, bool>(
|
||||
(provider) => provider.adaptiveTheme,
|
||||
);
|
||||
@@ -634,10 +704,16 @@ class _AlbumDetailsScreenState extends State<AlbumDetailsScreen> with SingleTick
|
||||
},
|
||||
child: Scaffold(
|
||||
backgroundColor: colorScheme.background,
|
||||
body: CustomScrollView(
|
||||
body: LayoutBuilder(
|
||||
builder: (context, constraints) {
|
||||
// Responsive cover size: 50% of screen width, clamped between 200-320
|
||||
final coverSize = (constraints.maxWidth * 0.5).clamp(200.0, 320.0);
|
||||
final expandedHeight = coverSize + 70;
|
||||
|
||||
return CustomScrollView(
|
||||
slivers: [
|
||||
SliverAppBar(
|
||||
expandedHeight: 350, // Increased height for bigger art
|
||||
expandedHeight: expandedHeight,
|
||||
pinned: true,
|
||||
backgroundColor: colorScheme.background,
|
||||
leading: IconButton(
|
||||
@@ -658,11 +734,11 @@ class _AlbumDetailsScreenState extends State<AlbumDetailsScreen> with SingleTick
|
||||
child: Hero(
|
||||
tag: HeroTags.albumCover + (widget.album.uri ?? widget.album.itemId) + _heroTagSuffix,
|
||||
child: Container(
|
||||
width: 280, // Increased size
|
||||
height: 280,
|
||||
width: coverSize,
|
||||
height: coverSize,
|
||||
decoration: BoxDecoration(
|
||||
color: colorScheme.surfaceVariant,
|
||||
borderRadius: BorderRadius.circular(16), // Slightly more rounded
|
||||
borderRadius: BorderRadius.circular(16),
|
||||
boxShadow: [
|
||||
BoxShadow(
|
||||
color: Colors.black.withOpacity(0.3),
|
||||
@@ -680,7 +756,7 @@ class _AlbumDetailsScreenState extends State<AlbumDetailsScreen> with SingleTick
|
||||
child: imageUrl == null
|
||||
? Icon(
|
||||
Icons.album_rounded,
|
||||
size: 120,
|
||||
size: coverSize * 0.43,
|
||||
color: colorScheme.onSurfaceVariant,
|
||||
)
|
||||
: null,
|
||||
@@ -837,14 +913,6 @@ class _AlbumDetailsScreenState extends State<AlbumDetailsScreen> with SingleTick
|
||||
],
|
||||
),
|
||||
const SizedBox(height: 24),
|
||||
Text(
|
||||
S.of(context)!.tracks,
|
||||
style: textTheme.titleLarge?.copyWith(
|
||||
color: colorScheme.onBackground,
|
||||
fontWeight: FontWeight.bold,
|
||||
),
|
||||
),
|
||||
const SizedBox(height: 12),
|
||||
],
|
||||
),
|
||||
),
|
||||
@@ -1011,118 +1079,71 @@ class _AlbumDetailsScreenState extends State<AlbumDetailsScreen> with SingleTick
|
||||
),
|
||||
const SliverToBoxAdapter(child: SizedBox(height: 164)), // Space for bottom nav + mini player
|
||||
],
|
||||
),
|
||||
);
|
||||
},
|
||||
),
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
void _showPlayAlbumFromHereMenu(BuildContext context, int startIndex) {
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
final players = maProvider.availablePlayers;
|
||||
|
||||
_showPlayOnSheet(
|
||||
context,
|
||||
players,
|
||||
onPlayerSelected: (player) {
|
||||
GlobalPlayerOverlay.hidePlayer();
|
||||
|
||||
showPlayerPickerSheet(
|
||||
context: context,
|
||||
title: S.of(context)!.playOn,
|
||||
players: maProvider.availablePlayers,
|
||||
selectedPlayer: maProvider.selectedPlayer,
|
||||
onPlayerSelected: (player) async {
|
||||
maProvider.selectPlayer(player);
|
||||
maProvider.playTracks(
|
||||
await maProvider.playTracks(
|
||||
player.playerId,
|
||||
_tracks,
|
||||
startIndex: startIndex,
|
||||
);
|
||||
},
|
||||
);
|
||||
).whenComplete(() {
|
||||
GlobalPlayerOverlay.showPlayer();
|
||||
});
|
||||
}
|
||||
|
||||
void _showPlayRadioMenu(BuildContext context, int trackIndex) {
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
final players = maProvider.availablePlayers;
|
||||
final track = _tracks[trackIndex];
|
||||
|
||||
_showPlayOnSheet(
|
||||
context,
|
||||
players,
|
||||
onPlayerSelected: (player) {
|
||||
GlobalPlayerOverlay.hidePlayer();
|
||||
|
||||
showPlayerPickerSheet(
|
||||
context: context,
|
||||
title: S.of(context)!.playOn,
|
||||
players: maProvider.availablePlayers,
|
||||
selectedPlayer: maProvider.selectedPlayer,
|
||||
onPlayerSelected: (player) async {
|
||||
maProvider.selectPlayer(player);
|
||||
maProvider.playRadio(player.playerId, track);
|
||||
await maProvider.playRadio(player.playerId, track);
|
||||
},
|
||||
);
|
||||
).whenComplete(() {
|
||||
GlobalPlayerOverlay.showPlayer();
|
||||
});
|
||||
}
|
||||
|
||||
void _showPlayOnMenu(BuildContext context) {
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
final players = maProvider.availablePlayers;
|
||||
|
||||
_showPlayOnSheet(
|
||||
context,
|
||||
players,
|
||||
onPlayerSelected: (player) {
|
||||
maProvider.selectPlayer(player);
|
||||
maProvider.playTracks(player.playerId, _tracks);
|
||||
},
|
||||
);
|
||||
}
|
||||
|
||||
/// Shared "Play on..." bottom sheet with fixed height and scrollable list
|
||||
void _showPlayOnSheet(
|
||||
BuildContext context,
|
||||
List players, {
|
||||
required void Function(dynamic player) onPlayerSelected,
|
||||
}) {
|
||||
// Slide mini player down out of the way
|
||||
GlobalPlayerOverlay.hidePlayer();
|
||||
|
||||
final screenHeight = MediaQuery.of(context).size.height;
|
||||
final bottomPadding = MediaQuery.of(context).padding.bottom;
|
||||
final sheetHeight = (screenHeight * 0.45) + bottomPadding; // Fixed 45% + safe area
|
||||
|
||||
showModalBottomSheet(
|
||||
showPlayerPickerSheet(
|
||||
context: context,
|
||||
backgroundColor: Colors.transparent,
|
||||
isScrollControlled: true,
|
||||
builder: (context) => Container(
|
||||
height: sheetHeight,
|
||||
decoration: BoxDecoration(
|
||||
color: Theme.of(context).colorScheme.surface,
|
||||
borderRadius: const BorderRadius.vertical(top: Radius.circular(20)),
|
||||
),
|
||||
child: Column(
|
||||
children: [
|
||||
const SizedBox(height: 16),
|
||||
Text(
|
||||
S.of(context)!.playOn,
|
||||
style: Theme.of(context).textTheme.titleLarge,
|
||||
),
|
||||
const SizedBox(height: 16),
|
||||
Expanded(
|
||||
child: players.isEmpty
|
||||
? Center(
|
||||
child: Text(S.of(context)!.noPlayersAvailable),
|
||||
)
|
||||
: ListView.builder(
|
||||
padding: EdgeInsets.only(bottom: bottomPadding + 16),
|
||||
itemCount: players.length,
|
||||
itemBuilder: (context, index) {
|
||||
final player = players[index];
|
||||
return ListTile(
|
||||
leading: Icon(
|
||||
Icons.speaker,
|
||||
color: Theme.of(context).colorScheme.onSurface,
|
||||
),
|
||||
title: Text(player.name),
|
||||
onTap: () {
|
||||
Navigator.pop(context);
|
||||
onPlayerSelected(player);
|
||||
},
|
||||
);
|
||||
},
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
title: S.of(context)!.playOn,
|
||||
players: maProvider.availablePlayers,
|
||||
selectedPlayer: maProvider.selectedPlayer,
|
||||
onPlayerSelected: (player) async {
|
||||
maProvider.selectPlayer(player);
|
||||
await maProvider.playTracks(player.playerId, _tracks);
|
||||
},
|
||||
).whenComplete(() {
|
||||
// Slide mini player back up when sheet is dismissed
|
||||
GlobalPlayerOverlay.showPlayer();
|
||||
});
|
||||
}
|
||||
|
||||
@@ -155,10 +155,10 @@ class _ArtistDetailsScreenState extends State<ArtistDetailsScreen> {
|
||||
|
||||
Future<void> _toggleFavorite() async {
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
if (maProvider.api == null) return;
|
||||
|
||||
try {
|
||||
final newState = !_isFavorite;
|
||||
bool success;
|
||||
|
||||
if (newState) {
|
||||
String actualProvider = widget.artist.provider;
|
||||
@@ -177,7 +177,11 @@ class _ArtistDetailsScreenState extends State<ArtistDetailsScreen> {
|
||||
}
|
||||
|
||||
_logger.log('Adding artist to favorites: provider=$actualProvider, itemId=$actualItemId');
|
||||
await maProvider.api!.addToFavorites('artist', actualItemId, actualProvider);
|
||||
success = await maProvider.addToFavorites(
|
||||
mediaType: 'artist',
|
||||
itemId: actualItemId,
|
||||
provider: actualProvider,
|
||||
);
|
||||
} else {
|
||||
int? libraryItemId;
|
||||
|
||||
@@ -199,24 +203,32 @@ class _ArtistDetailsScreenState extends State<ArtistDetailsScreen> {
|
||||
}
|
||||
|
||||
_logger.log('Removing artist from favorites: libraryItemId=$libraryItemId');
|
||||
await maProvider.api!.removeFromFavorites('artist', libraryItemId);
|
||||
success = await maProvider.removeFromFavorites(
|
||||
mediaType: 'artist',
|
||||
libraryItemId: libraryItemId,
|
||||
);
|
||||
}
|
||||
|
||||
setState(() {
|
||||
_isFavorite = newState;
|
||||
});
|
||||
if (success) {
|
||||
setState(() {
|
||||
_isFavorite = newState;
|
||||
});
|
||||
|
||||
maProvider.invalidateHomeCache();
|
||||
maProvider.invalidateHomeCache();
|
||||
|
||||
if (mounted) {
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(
|
||||
content: Text(
|
||||
_isFavorite ? S.of(context)!.addedToFavorites : S.of(context)!.removedFromFavorites,
|
||||
if (mounted) {
|
||||
final isOffline = !maProvider.isConnected;
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(
|
||||
content: Text(
|
||||
isOffline
|
||||
? S.of(context)!.actionQueuedForSync
|
||||
: (_isFavorite ? S.of(context)!.addedToFavorites : S.of(context)!.removedFromFavorites),
|
||||
),
|
||||
duration: const Duration(seconds: 1),
|
||||
),
|
||||
duration: const Duration(seconds: 1),
|
||||
),
|
||||
);
|
||||
);
|
||||
}
|
||||
}
|
||||
} catch (e) {
|
||||
_logger.log('Error toggling artist favorite: $e');
|
||||
@@ -231,57 +243,25 @@ class _ArtistDetailsScreenState extends State<ArtistDetailsScreen> {
|
||||
}
|
||||
}
|
||||
|
||||
Future<void> _startArtistRadio() async {
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
final selectedPlayer = maProvider.selectedPlayer;
|
||||
|
||||
if (selectedPlayer == null) {
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(content: Text(S.of(context)!.noPlayerSelected)),
|
||||
);
|
||||
return;
|
||||
}
|
||||
|
||||
try {
|
||||
await maProvider.playArtistRadio(selectedPlayer.playerId, widget.artist);
|
||||
if (mounted) {
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(
|
||||
content: Text(S.of(context)!.startingRadio(widget.artist.name)),
|
||||
duration: const Duration(seconds: 1),
|
||||
),
|
||||
);
|
||||
}
|
||||
} catch (e) {
|
||||
_logger.log('Error starting artist radio: $e');
|
||||
if (mounted) {
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(
|
||||
content: Text(S.of(context)!.failedToStartRadio(e.toString())),
|
||||
backgroundColor: Colors.red,
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
void _showPlayOnMenu(BuildContext context) {
|
||||
void _showRadioMenu(BuildContext context) {
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
final players = maProvider.availablePlayers;
|
||||
final colorScheme = Theme.of(context).colorScheme;
|
||||
|
||||
// Slide mini player down out of the way
|
||||
GlobalPlayerOverlay.hidePlayer();
|
||||
|
||||
showModalBottomSheet(
|
||||
context: context,
|
||||
backgroundColor: colorScheme.surface,
|
||||
shape: const RoundedRectangleBorder(
|
||||
borderRadius: BorderRadius.vertical(top: Radius.circular(20)),
|
||||
),
|
||||
builder: (context) => Padding(
|
||||
padding: const EdgeInsets.all(16.0),
|
||||
backgroundColor: Colors.transparent,
|
||||
builder: (context) => Container(
|
||||
decoration: BoxDecoration(
|
||||
color: Theme.of(context).colorScheme.surface,
|
||||
borderRadius: const BorderRadius.vertical(top: Radius.circular(20)),
|
||||
),
|
||||
child: Column(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
children: [
|
||||
const SizedBox(height: 16),
|
||||
Text(
|
||||
S.of(context)!.startRadioOn(widget.artist.name),
|
||||
style: Theme.of(context).textTheme.titleLarge,
|
||||
@@ -302,7 +282,7 @@ class _ArtistDetailsScreenState extends State<ArtistDetailsScreen> {
|
||||
return ListTile(
|
||||
leading: Icon(
|
||||
Icons.speaker,
|
||||
color: colorScheme.onSurface,
|
||||
color: Theme.of(context).colorScheme.onSurface,
|
||||
),
|
||||
title: Text(player.name),
|
||||
onTap: () async {
|
||||
@@ -333,46 +313,103 @@ class _ArtistDetailsScreenState extends State<ArtistDetailsScreen> {
|
||||
},
|
||||
),
|
||||
),
|
||||
const SizedBox(height: 16),
|
||||
SizedBox(height: MediaQuery.of(context).padding.bottom + 16),
|
||||
],
|
||||
),
|
||||
),
|
||||
);
|
||||
).whenComplete(() {
|
||||
// Slide mini player back up when sheet is dismissed
|
||||
GlobalPlayerOverlay.showPlayer();
|
||||
});
|
||||
}
|
||||
|
||||
Future<void> _addArtistRadioToQueue() async {
|
||||
void _showAddToQueueMenu(BuildContext context) {
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
final selectedPlayer = maProvider.selectedPlayer;
|
||||
final players = maProvider.availablePlayers;
|
||||
|
||||
if (selectedPlayer == null) {
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(content: Text(S.of(context)!.noPlayerSelected)),
|
||||
);
|
||||
return;
|
||||
}
|
||||
// Slide mini player down out of the way
|
||||
GlobalPlayerOverlay.hidePlayer();
|
||||
|
||||
try {
|
||||
// For adding to queue with radio mode, we use radio_mode but with 'add' option
|
||||
await maProvider.api?.playArtistRadioToQueue(selectedPlayer.playerId, widget.artist);
|
||||
if (mounted) {
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(
|
||||
content: Text(S.of(context)!.addedRadioToQueue(widget.artist.name)),
|
||||
duration: const Duration(seconds: 1),
|
||||
),
|
||||
);
|
||||
}
|
||||
} catch (e) {
|
||||
_logger.log('Error adding artist radio to queue: $e');
|
||||
if (mounted) {
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(
|
||||
content: Text(S.of(context)!.failedToAddToQueue(e.toString())),
|
||||
backgroundColor: Colors.red,
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
showModalBottomSheet(
|
||||
context: context,
|
||||
backgroundColor: Colors.transparent,
|
||||
builder: (context) => Container(
|
||||
decoration: BoxDecoration(
|
||||
color: Theme.of(context).colorScheme.surface,
|
||||
borderRadius: const BorderRadius.vertical(top: Radius.circular(20)),
|
||||
),
|
||||
child: Column(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
const SizedBox(height: 16),
|
||||
Text(
|
||||
S.of(context)!.addToQueueOn,
|
||||
style: Theme.of(context).textTheme.titleLarge,
|
||||
),
|
||||
const SizedBox(height: 16),
|
||||
if (players.isEmpty)
|
||||
Padding(
|
||||
padding: const EdgeInsets.all(32.0),
|
||||
child: Text(S.of(context)!.noPlayersAvailable),
|
||||
)
|
||||
else
|
||||
Flexible(
|
||||
child: ListView.builder(
|
||||
shrinkWrap: true,
|
||||
itemCount: players.length,
|
||||
itemBuilder: (context, index) {
|
||||
final player = players[index];
|
||||
return ListTile(
|
||||
leading: Icon(
|
||||
Icons.speaker,
|
||||
color: Theme.of(context).colorScheme.onSurface,
|
||||
),
|
||||
title: Text(player.name),
|
||||
onTap: () async {
|
||||
Navigator.pop(context);
|
||||
final api = maProvider.api;
|
||||
if (api == null) {
|
||||
if (mounted) {
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(content: Text(S.of(context)!.notConnected)),
|
||||
);
|
||||
}
|
||||
return;
|
||||
}
|
||||
try {
|
||||
await api.playArtistRadioToQueue(player.playerId, widget.artist);
|
||||
if (mounted) {
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(
|
||||
content: Text(S.of(context)!.addedRadioToQueue(widget.artist.name)),
|
||||
duration: const Duration(seconds: 1),
|
||||
),
|
||||
);
|
||||
}
|
||||
} catch (e) {
|
||||
_logger.log('Error adding artist radio to queue: $e');
|
||||
if (mounted) {
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(
|
||||
content: Text(S.of(context)!.failedToAddToQueue(e.toString())),
|
||||
backgroundColor: Colors.red,
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
},
|
||||
);
|
||||
},
|
||||
),
|
||||
),
|
||||
SizedBox(height: MediaQuery.of(context).padding.bottom + 16),
|
||||
],
|
||||
),
|
||||
),
|
||||
).whenComplete(() {
|
||||
// Slide mini player back up when sheet is dismissed
|
||||
GlobalPlayerOverlay.showPlayer();
|
||||
});
|
||||
}
|
||||
|
||||
Future<void> _loadArtistImage() async {
|
||||
@@ -427,20 +464,51 @@ class _ArtistDetailsScreenState extends State<ArtistDetailsScreen> {
|
||||
Future<void> _loadArtistAlbums() async {
|
||||
final provider = context.read<MusicAssistantProvider>();
|
||||
|
||||
// Use cached artist albums method
|
||||
final allAlbums = await provider.getArtistAlbumsWithCache(widget.artist.name);
|
||||
// 1. Show cached data immediately (if available)
|
||||
final cachedAlbums = provider.getCachedArtistAlbums(widget.artist.name);
|
||||
if (cachedAlbums != null && cachedAlbums.isNotEmpty) {
|
||||
final libraryAlbums = cachedAlbums.where((a) => a.inLibrary).toList();
|
||||
final providerOnlyAlbums = cachedAlbums.where((a) => !a.inLibrary).toList();
|
||||
|
||||
if (mounted) {
|
||||
// Separate library albums from provider-only albums
|
||||
final libraryAlbums = allAlbums.where((a) => a.inLibrary).toList();
|
||||
final providerOnlyAlbums = allAlbums.where((a) => !a.inLibrary).toList();
|
||||
if (mounted) {
|
||||
setState(() {
|
||||
_albums = libraryAlbums;
|
||||
_providerAlbums = providerOnlyAlbums;
|
||||
_sortAlbums();
|
||||
_isLoading = false;
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
setState(() {
|
||||
_albums = libraryAlbums;
|
||||
_providerAlbums = providerOnlyAlbums;
|
||||
_sortAlbums(); // Apply saved sort order
|
||||
_isLoading = false;
|
||||
});
|
||||
// 2. Fetch fresh data in background (silent refresh)
|
||||
try {
|
||||
final allAlbums = await provider.getArtistAlbumsWithCache(
|
||||
widget.artist.name,
|
||||
forceRefresh: cachedAlbums != null,
|
||||
);
|
||||
|
||||
if (mounted && allAlbums.isNotEmpty) {
|
||||
// Check if data actually changed
|
||||
final albumsChanged = _albums.length != allAlbums.where((a) => a.inLibrary).length;
|
||||
|
||||
if (albumsChanged || _albums.isEmpty) {
|
||||
final libraryAlbums = allAlbums.where((a) => a.inLibrary).toList();
|
||||
final providerOnlyAlbums = allAlbums.where((a) => !a.inLibrary).toList();
|
||||
|
||||
setState(() {
|
||||
_albums = libraryAlbums;
|
||||
_providerAlbums = providerOnlyAlbums;
|
||||
_sortAlbums();
|
||||
_isLoading = false;
|
||||
});
|
||||
}
|
||||
}
|
||||
} catch (e) {
|
||||
// Silent failure - keep showing cached data
|
||||
}
|
||||
|
||||
if (mounted && _isLoading) {
|
||||
setState(() => _isLoading = false);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -483,10 +551,16 @@ class _ArtistDetailsScreenState extends State<ArtistDetailsScreen> {
|
||||
},
|
||||
child: Scaffold(
|
||||
backgroundColor: colorScheme.background,
|
||||
body: CustomScrollView(
|
||||
body: LayoutBuilder(
|
||||
builder: (context, constraints) {
|
||||
// Responsive cover size: 40% of screen width, clamped between 160-280 (smaller for circular artist image)
|
||||
final coverSize = (constraints.maxWidth * 0.4).clamp(160.0, 280.0);
|
||||
final expandedHeight = coverSize + 100;
|
||||
|
||||
return CustomScrollView(
|
||||
slivers: [
|
||||
SliverAppBar(
|
||||
expandedHeight: 300,
|
||||
expandedHeight: expandedHeight,
|
||||
pinned: true,
|
||||
backgroundColor: colorScheme.background,
|
||||
leading: IconButton(
|
||||
@@ -506,22 +580,24 @@ class _ArtistDetailsScreenState extends State<ArtistDetailsScreen> {
|
||||
tag: HeroTags.artistImage + (widget.artist.uri ?? widget.artist.itemId) + _heroTagSuffix,
|
||||
child: ClipOval(
|
||||
child: Container(
|
||||
width: 200,
|
||||
height: 200,
|
||||
width: coverSize,
|
||||
height: coverSize,
|
||||
color: colorScheme.surfaceVariant,
|
||||
child: imageUrl != null
|
||||
? Image.network(
|
||||
imageUrl,
|
||||
? CachedNetworkImage(
|
||||
imageUrl: imageUrl,
|
||||
fit: BoxFit.cover,
|
||||
errorBuilder: (_, __, ___) => Icon(
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
errorWidget: (_, __, ___) => Icon(
|
||||
Icons.person_rounded,
|
||||
size: 100,
|
||||
size: coverSize * 0.5,
|
||||
color: colorScheme.onSurfaceVariant,
|
||||
),
|
||||
)
|
||||
: Icon(
|
||||
Icons.person_rounded,
|
||||
size: 100,
|
||||
size: coverSize * 0.5,
|
||||
color: colorScheme.onSurfaceVariant,
|
||||
),
|
||||
),
|
||||
@@ -582,7 +658,7 @@ class _ArtistDetailsScreenState extends State<ArtistDetailsScreen> {
|
||||
child: SizedBox(
|
||||
height: 50,
|
||||
child: ElevatedButton.icon(
|
||||
onPressed: _startArtistRadio,
|
||||
onPressed: () => _showRadioMenu(context),
|
||||
icon: const Icon(Icons.radio),
|
||||
label: Text(S.of(context)!.radio),
|
||||
style: ElevatedButton.styleFrom(
|
||||
@@ -595,23 +671,6 @@ class _ArtistDetailsScreenState extends State<ArtistDetailsScreen> {
|
||||
),
|
||||
),
|
||||
),
|
||||
const SizedBox(width: 12),
|
||||
|
||||
// "Play on..." Button (Square)
|
||||
SizedBox(
|
||||
height: 50,
|
||||
width: 50,
|
||||
child: FilledButton.tonal(
|
||||
onPressed: () => _showPlayOnMenu(context),
|
||||
style: FilledButton.styleFrom(
|
||||
padding: EdgeInsets.zero,
|
||||
shape: RoundedRectangleBorder(
|
||||
borderRadius: BorderRadius.circular(12),
|
||||
),
|
||||
),
|
||||
child: const Icon(Icons.speaker_group_outlined),
|
||||
),
|
||||
),
|
||||
|
||||
const SizedBox(width: 12),
|
||||
|
||||
@@ -620,7 +679,7 @@ class _ArtistDetailsScreenState extends State<ArtistDetailsScreen> {
|
||||
height: 50,
|
||||
width: 50,
|
||||
child: FilledButton.tonal(
|
||||
onPressed: _addArtistRadioToQueue,
|
||||
onPressed: () => _showAddToQueueMenu(context),
|
||||
style: FilledButton.styleFrom(
|
||||
padding: EdgeInsets.zero,
|
||||
shape: RoundedRectangleBorder(
|
||||
@@ -794,6 +853,8 @@ class _ArtistDetailsScreenState extends State<ArtistDetailsScreen> {
|
||||
],
|
||||
],
|
||||
],
|
||||
);
|
||||
},
|
||||
),
|
||||
),
|
||||
);
|
||||
@@ -817,6 +878,7 @@ class _ArtistDetailsScreenState extends State<ArtistDetailsScreen> {
|
||||
child: AlbumDetailsScreen(
|
||||
album: album,
|
||||
heroTagSuffix: heroSuffix,
|
||||
initialImageUrl: imageUrl,
|
||||
),
|
||||
),
|
||||
);
|
||||
@@ -833,12 +895,14 @@ class _ArtistDetailsScreenState extends State<ArtistDetailsScreen> {
|
||||
child: Container(
|
||||
color: colorScheme.surfaceVariant,
|
||||
child: imageUrl != null
|
||||
? Image.network(
|
||||
imageUrl,
|
||||
? CachedNetworkImage(
|
||||
imageUrl: imageUrl,
|
||||
fit: BoxFit.cover,
|
||||
width: double.infinity,
|
||||
height: double.infinity,
|
||||
errorBuilder: (_, __, ___) => Center(
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
errorWidget: (_, __, ___) => Center(
|
||||
child: Icon(
|
||||
Icons.album_rounded,
|
||||
size: 64,
|
||||
@@ -940,10 +1004,12 @@ class _ArtistDetailsScreenState extends State<ArtistDetailsScreen> {
|
||||
height: 56,
|
||||
color: colorScheme.surfaceVariant,
|
||||
child: imageUrl != null
|
||||
? Image.network(
|
||||
imageUrl,
|
||||
? CachedNetworkImage(
|
||||
imageUrl: imageUrl,
|
||||
fit: BoxFit.cover,
|
||||
errorBuilder: (_, __, ___) => Icon(
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
errorWidget: (_, __, ___) => Icon(
|
||||
Icons.album_rounded,
|
||||
color: colorScheme.onSurfaceVariant,
|
||||
),
|
||||
@@ -979,6 +1045,7 @@ class _ArtistDetailsScreenState extends State<ArtistDetailsScreen> {
|
||||
child: AlbumDetailsScreen(
|
||||
album: album,
|
||||
heroTagSuffix: 'artist_albums',
|
||||
initialImageUrl: imageUrl,
|
||||
),
|
||||
),
|
||||
);
|
||||
|
||||
@@ -19,12 +19,14 @@ class AudiobookAuthorScreen extends StatefulWidget {
|
||||
final String authorName;
|
||||
final List<Audiobook> audiobooks;
|
||||
final String? heroTagSuffix;
|
||||
final String? initialAuthorImageUrl;
|
||||
|
||||
const AudiobookAuthorScreen({
|
||||
super.key,
|
||||
required this.authorName,
|
||||
required this.audiobooks,
|
||||
this.heroTagSuffix,
|
||||
this.initialAuthorImageUrl,
|
||||
});
|
||||
|
||||
@override
|
||||
@@ -48,6 +50,8 @@ class _AudiobookAuthorScreenState extends State<AudiobookAuthorScreen> {
|
||||
void initState() {
|
||||
super.initState();
|
||||
_audiobooks = List.from(widget.audiobooks);
|
||||
// Use initial image URL immediately for smooth hero animation
|
||||
_authorImageUrl = widget.initialAuthorImageUrl;
|
||||
_loadViewPreferences();
|
||||
_sortAudiobooks();
|
||||
_loadAuthorImage();
|
||||
@@ -181,6 +185,8 @@ class _AudiobookAuthorScreenState extends State<AudiobookAuthorScreen> {
|
||||
fit: BoxFit.cover,
|
||||
width: 200,
|
||||
height: 200,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (_, __) => Icon(
|
||||
MdiIcons.accountOutline,
|
||||
size: 100,
|
||||
@@ -329,7 +335,7 @@ class _AudiobookAuthorScreenState extends State<AudiobookAuthorScreen> {
|
||||
final heroSuffix = 'author${_heroTagSuffix}';
|
||||
|
||||
return InkWell(
|
||||
onTap: () => _navigateToAudiobook(book, heroTagSuffix: heroSuffix),
|
||||
onTap: () => _navigateToAudiobook(book, heroTagSuffix: heroSuffix, initialImageUrl: imageUrl),
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
children: [
|
||||
@@ -349,6 +355,8 @@ class _AudiobookAuthorScreenState extends State<AudiobookAuthorScreen> {
|
||||
fit: BoxFit.cover,
|
||||
width: double.infinity,
|
||||
height: double.infinity,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (_, __) => Center(
|
||||
child: Icon(
|
||||
MdiIcons.bookOutline,
|
||||
@@ -443,6 +451,8 @@ class _AudiobookAuthorScreenState extends State<AudiobookAuthorScreen> {
|
||||
? CachedNetworkImage(
|
||||
imageUrl: imageUrl,
|
||||
fit: BoxFit.cover,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (_, __) => Icon(
|
||||
MdiIcons.bookOutline,
|
||||
color: colorScheme.onSurfaceVariant,
|
||||
@@ -508,17 +518,18 @@ class _AudiobookAuthorScreenState extends State<AudiobookAuthorScreen> {
|
||||
),
|
||||
)
|
||||
: null,
|
||||
onTap: () => _navigateToAudiobook(book, heroTagSuffix: heroSuffix),
|
||||
onTap: () => _navigateToAudiobook(book, heroTagSuffix: heroSuffix, initialImageUrl: imageUrl),
|
||||
);
|
||||
}
|
||||
|
||||
void _navigateToAudiobook(Audiobook book, {String? heroTagSuffix}) {
|
||||
void _navigateToAudiobook(Audiobook book, {String? heroTagSuffix, String? initialImageUrl}) {
|
||||
Navigator.push(
|
||||
context,
|
||||
FadeSlidePageRoute(
|
||||
child: AudiobookDetailScreen(
|
||||
audiobook: book,
|
||||
heroTagSuffix: heroTagSuffix,
|
||||
initialImageUrl: initialImageUrl,
|
||||
),
|
||||
),
|
||||
);
|
||||
|
||||
@@ -5,6 +5,7 @@ import 'package:material_design_icons_flutter/material_design_icons_flutter.dart
|
||||
import '../models/media_item.dart';
|
||||
import '../providers/music_assistant_provider.dart';
|
||||
import '../widgets/global_player_overlay.dart';
|
||||
import '../widgets/player_picker_sheet.dart';
|
||||
import '../theme/palette_helper.dart';
|
||||
import '../theme/theme_provider.dart';
|
||||
import '../services/debug_logger.dart';
|
||||
@@ -15,11 +16,14 @@ import '../l10n/app_localizations.dart';
|
||||
class AudiobookDetailScreen extends StatefulWidget {
|
||||
final Audiobook audiobook;
|
||||
final String? heroTagSuffix;
|
||||
/// Initial image URL from the source for seamless hero animation
|
||||
final String? initialImageUrl;
|
||||
|
||||
const AudiobookDetailScreen({
|
||||
super.key,
|
||||
required this.audiobook,
|
||||
this.heroTagSuffix,
|
||||
this.initialImageUrl,
|
||||
});
|
||||
|
||||
@override
|
||||
@@ -119,10 +123,10 @@ class _AudiobookDetailScreenState extends State<AudiobookDetailScreen> {
|
||||
|
||||
Future<void> _toggleFavorite() async {
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
if (maProvider.api == null) return;
|
||||
|
||||
try {
|
||||
final newState = !_isFavorite;
|
||||
bool success;
|
||||
|
||||
if (newState) {
|
||||
String actualProvider = widget.audiobook.provider;
|
||||
@@ -141,7 +145,11 @@ class _AudiobookDetailScreenState extends State<AudiobookDetailScreen> {
|
||||
}
|
||||
|
||||
_logger.log('Adding audiobook to favorites: provider=$actualProvider, itemId=$actualItemId');
|
||||
await maProvider.api!.addToFavorites('audiobook', actualItemId, actualProvider);
|
||||
success = await maProvider.addToFavorites(
|
||||
mediaType: 'audiobook',
|
||||
itemId: actualItemId,
|
||||
provider: actualProvider,
|
||||
);
|
||||
} else {
|
||||
int? libraryItemId;
|
||||
|
||||
@@ -162,22 +170,30 @@ class _AudiobookDetailScreenState extends State<AudiobookDetailScreen> {
|
||||
}
|
||||
|
||||
_logger.log('Removing audiobook from favorites: libraryItemId=$libraryItemId');
|
||||
await maProvider.api!.removeFromFavorites('audiobook', libraryItemId);
|
||||
success = await maProvider.removeFromFavorites(
|
||||
mediaType: 'audiobook',
|
||||
libraryItemId: libraryItemId,
|
||||
);
|
||||
}
|
||||
|
||||
setState(() {
|
||||
_isFavorite = newState;
|
||||
});
|
||||
if (success) {
|
||||
setState(() {
|
||||
_isFavorite = newState;
|
||||
});
|
||||
|
||||
if (mounted) {
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(
|
||||
content: Text(
|
||||
_isFavorite ? S.of(context)!.addedToFavorites : S.of(context)!.removedFromFavorites,
|
||||
if (mounted) {
|
||||
final isOffline = !maProvider.isConnected;
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(
|
||||
content: Text(
|
||||
isOffline
|
||||
? S.of(context)!.actionQueuedForSync
|
||||
: (_isFavorite ? S.of(context)!.addedToFavorites : S.of(context)!.removedFromFavorites),
|
||||
),
|
||||
duration: const Duration(seconds: 1),
|
||||
),
|
||||
duration: const Duration(seconds: 1),
|
||||
),
|
||||
);
|
||||
);
|
||||
}
|
||||
}
|
||||
} catch (e) {
|
||||
_logger.log('Error toggling audiobook favorite: $e');
|
||||
@@ -194,62 +210,22 @@ class _AudiobookDetailScreenState extends State<AudiobookDetailScreen> {
|
||||
|
||||
void _showPlayOnMenu(BuildContext context) {
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
final players = maProvider.availablePlayers;
|
||||
|
||||
GlobalPlayerOverlay.hidePlayer();
|
||||
|
||||
final screenHeight = MediaQuery.of(context).size.height;
|
||||
final bottomPadding = MediaQuery.of(context).padding.bottom;
|
||||
final sheetHeight = (screenHeight * 0.45) + bottomPadding;
|
||||
|
||||
showModalBottomSheet(
|
||||
showPlayerPickerSheet(
|
||||
context: context,
|
||||
backgroundColor: Colors.transparent,
|
||||
isScrollControlled: true,
|
||||
builder: (context) => Container(
|
||||
height: sheetHeight,
|
||||
decoration: BoxDecoration(
|
||||
color: Theme.of(context).colorScheme.surface,
|
||||
borderRadius: const BorderRadius.vertical(top: Radius.circular(20)),
|
||||
),
|
||||
child: Column(
|
||||
children: [
|
||||
const SizedBox(height: 16),
|
||||
Text(
|
||||
S.of(context)!.playOn,
|
||||
style: Theme.of(context).textTheme.titleLarge,
|
||||
),
|
||||
const SizedBox(height: 16),
|
||||
Expanded(
|
||||
child: players.isEmpty
|
||||
? Center(child: Text(S.of(context)!.noPlayersAvailable))
|
||||
: ListView.builder(
|
||||
padding: EdgeInsets.only(bottom: bottomPadding + 16),
|
||||
itemCount: players.length,
|
||||
itemBuilder: (context, index) {
|
||||
final player = players[index];
|
||||
return ListTile(
|
||||
leading: Icon(
|
||||
Icons.speaker,
|
||||
color: Theme.of(context).colorScheme.onSurface,
|
||||
),
|
||||
title: Text(player.name),
|
||||
onTap: () async {
|
||||
Navigator.pop(context);
|
||||
maProvider.selectPlayer(player);
|
||||
maProvider.setCurrentAudiobook(_audiobook);
|
||||
await maProvider.api?.playAudiobook(
|
||||
player.playerId,
|
||||
widget.audiobook,
|
||||
);
|
||||
},
|
||||
);
|
||||
},
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
title: S.of(context)!.playOn,
|
||||
players: maProvider.availablePlayers,
|
||||
selectedPlayer: maProvider.selectedPlayer,
|
||||
onPlayerSelected: (player) async {
|
||||
maProvider.selectPlayer(player);
|
||||
maProvider.setCurrentAudiobook(_audiobook);
|
||||
await maProvider.api?.playAudiobook(
|
||||
player.playerId,
|
||||
widget.audiobook,
|
||||
);
|
||||
},
|
||||
).whenComplete(() {
|
||||
GlobalPlayerOverlay.showPlayer();
|
||||
});
|
||||
@@ -414,7 +390,9 @@ class _AudiobookDetailScreenState extends State<AudiobookDetailScreen> {
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
final imageUrl = maProvider.getImageUrl(widget.audiobook, size: 512);
|
||||
final providerImageUrl = maProvider.getImageUrl(widget.audiobook, size: 512);
|
||||
// Use initialImageUrl as fallback for seamless hero animation
|
||||
final imageUrl = providerImageUrl ?? widget.initialImageUrl;
|
||||
|
||||
final adaptiveTheme = context.select<ThemeProvider, bool>(
|
||||
(provider) => provider.adaptiveTheme,
|
||||
@@ -449,10 +427,16 @@ class _AudiobookDetailScreenState extends State<AudiobookDetailScreen> {
|
||||
},
|
||||
child: Scaffold(
|
||||
backgroundColor: colorScheme.surface,
|
||||
body: CustomScrollView(
|
||||
body: LayoutBuilder(
|
||||
builder: (context, constraints) {
|
||||
// Responsive cover size: 50% of screen width, clamped between 200-320
|
||||
final coverSize = (constraints.maxWidth * 0.5).clamp(200.0, 320.0);
|
||||
final expandedHeight = coverSize + 70;
|
||||
|
||||
return CustomScrollView(
|
||||
slivers: [
|
||||
SliverAppBar(
|
||||
expandedHeight: 350,
|
||||
expandedHeight: expandedHeight,
|
||||
pinned: true,
|
||||
backgroundColor: colorScheme.surface,
|
||||
leading: IconButton(
|
||||
@@ -521,24 +505,26 @@ class _AudiobookDetailScreenState extends State<AudiobookDetailScreen> {
|
||||
child: ClipRRect(
|
||||
borderRadius: BorderRadius.circular(8),
|
||||
child: Container(
|
||||
width: 280,
|
||||
height: 280,
|
||||
width: coverSize,
|
||||
height: coverSize,
|
||||
color: colorScheme.surfaceContainerHighest,
|
||||
child: imageUrl != null
|
||||
? CachedNetworkImage(
|
||||
imageUrl: imageUrl,
|
||||
fit: BoxFit.cover,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (_, __) => Center(
|
||||
child: Icon(
|
||||
MdiIcons.bookOutline,
|
||||
size: 120,
|
||||
size: coverSize * 0.43,
|
||||
color: colorScheme.onSurfaceVariant,
|
||||
),
|
||||
),
|
||||
errorWidget: (_, __, ___) => Center(
|
||||
child: Icon(
|
||||
MdiIcons.bookOutline,
|
||||
size: 120,
|
||||
size: coverSize * 0.43,
|
||||
color: colorScheme.onSurfaceVariant,
|
||||
),
|
||||
),
|
||||
@@ -546,7 +532,7 @@ class _AudiobookDetailScreenState extends State<AudiobookDetailScreen> {
|
||||
: Center(
|
||||
child: Icon(
|
||||
MdiIcons.bookOutline,
|
||||
size: 120,
|
||||
size: coverSize * 0.43,
|
||||
color: colorScheme.onSurfaceVariant,
|
||||
),
|
||||
),
|
||||
@@ -790,6 +776,8 @@ class _AudiobookDetailScreenState extends State<AudiobookDetailScreen> {
|
||||
|
||||
const SliverToBoxAdapter(child: SizedBox(height: 140)),
|
||||
],
|
||||
);
|
||||
},
|
||||
),
|
||||
),
|
||||
);
|
||||
|
||||
@@ -275,11 +275,17 @@ class _AudiobookSeriesScreenState extends State<AudiobookSeriesScreen> {
|
||||
|
||||
return Scaffold(
|
||||
backgroundColor: colorScheme.surface,
|
||||
body: CustomScrollView(
|
||||
body: LayoutBuilder(
|
||||
builder: (context, constraints) {
|
||||
// Responsive cover size: 50% of screen width, clamped between 200-320
|
||||
final coverSize = (constraints.maxWidth * 0.5).clamp(200.0, 320.0);
|
||||
final expandedHeight = coverSize + 70;
|
||||
|
||||
return CustomScrollView(
|
||||
slivers: [
|
||||
// App bar with series cover collage (matches audiobook detail screen)
|
||||
SliverAppBar(
|
||||
expandedHeight: 350,
|
||||
expandedHeight: expandedHeight,
|
||||
pinned: true,
|
||||
backgroundColor: colorScheme.surface,
|
||||
leading: IconButton(
|
||||
@@ -292,12 +298,12 @@ class _AudiobookSeriesScreenState extends State<AudiobookSeriesScreen> {
|
||||
mainAxisAlignment: MainAxisAlignment.center,
|
||||
children: [
|
||||
const SizedBox(height: 60),
|
||||
// Series cover collage - same size as audiobook detail cover
|
||||
// Series cover collage - responsive size
|
||||
Hero(
|
||||
tag: widget.heroTag ?? 'series_cover_${widget.series.id}',
|
||||
child: Container(
|
||||
width: 280,
|
||||
height: 280,
|
||||
width: coverSize,
|
||||
height: coverSize,
|
||||
decoration: BoxDecoration(
|
||||
color: colorScheme.surfaceContainerHighest,
|
||||
borderRadius: BorderRadius.circular(12),
|
||||
@@ -445,10 +451,12 @@ class _AudiobookSeriesScreenState extends State<AudiobookSeriesScreen> {
|
||||
_buildAudiobookSliver(maProvider),
|
||||
|
||||
// Bottom padding for mini player
|
||||
const SliverToBoxAdapter(
|
||||
SliverToBoxAdapter(
|
||||
child: SizedBox(height: BottomSpacing.withMiniPlayer),
|
||||
),
|
||||
],
|
||||
);
|
||||
},
|
||||
),
|
||||
);
|
||||
}
|
||||
@@ -517,6 +525,8 @@ class _AudiobookSeriesScreenState extends State<AudiobookSeriesScreen> {
|
||||
? CachedNetworkImage(
|
||||
imageUrl: coverUrl,
|
||||
fit: BoxFit.cover,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (_, __) => Container(
|
||||
color: colorScheme.surfaceContainerHighest,
|
||||
),
|
||||
@@ -633,7 +643,7 @@ class _AudiobookSeriesScreenState extends State<AudiobookSeriesScreen> {
|
||||
final heroSuffix = 'series_${widget.series.id}';
|
||||
|
||||
return InkWell(
|
||||
onTap: () => _navigateToAudiobook(book, heroTagSuffix: heroSuffix),
|
||||
onTap: () => _navigateToAudiobook(book, heroTagSuffix: heroSuffix, initialImageUrl: imageUrl),
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
children: [
|
||||
@@ -653,6 +663,8 @@ class _AudiobookSeriesScreenState extends State<AudiobookSeriesScreen> {
|
||||
fit: BoxFit.cover,
|
||||
width: double.infinity,
|
||||
height: double.infinity,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (_, __) => Center(
|
||||
child: Icon(
|
||||
MdiIcons.bookOutline,
|
||||
@@ -746,6 +758,8 @@ class _AudiobookSeriesScreenState extends State<AudiobookSeriesScreen> {
|
||||
? CachedNetworkImage(
|
||||
imageUrl: imageUrl,
|
||||
fit: BoxFit.cover,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (_, __) => Icon(
|
||||
MdiIcons.bookOutline,
|
||||
color: colorScheme.onSurfaceVariant,
|
||||
@@ -811,17 +825,18 @@ class _AudiobookSeriesScreenState extends State<AudiobookSeriesScreen> {
|
||||
),
|
||||
)
|
||||
: null,
|
||||
onTap: () => _navigateToAudiobook(book, heroTagSuffix: heroSuffix),
|
||||
onTap: () => _navigateToAudiobook(book, heroTagSuffix: heroSuffix, initialImageUrl: imageUrl),
|
||||
);
|
||||
}
|
||||
|
||||
void _navigateToAudiobook(Audiobook book, {String? heroTagSuffix}) {
|
||||
void _navigateToAudiobook(Audiobook book, {String? heroTagSuffix, String? initialImageUrl}) {
|
||||
Navigator.push(
|
||||
context,
|
||||
FadeSlidePageRoute(
|
||||
child: AudiobookDetailScreen(
|
||||
audiobook: book,
|
||||
heroTagSuffix: heroTagSuffix,
|
||||
initialImageUrl: initialImageUrl,
|
||||
),
|
||||
),
|
||||
);
|
||||
|
||||
@@ -47,7 +47,9 @@ class LibraryAlbumsScreen extends StatelessWidget {
|
||||
Widget _buildAlbumsList(BuildContext context, List<Album> albums, bool isLoading) {
|
||||
final colorScheme = Theme.of(context).colorScheme;
|
||||
|
||||
if (isLoading) {
|
||||
// Show cached data immediately if available, even while loading
|
||||
// Only show spinner if we have no data at all AND we're loading
|
||||
if (albums.isEmpty && isLoading) {
|
||||
return Center(
|
||||
child: CircularProgressIndicator(color: colorScheme.primary),
|
||||
);
|
||||
|
||||
@@ -49,7 +49,9 @@ class LibraryArtistsScreen extends StatelessWidget {
|
||||
Widget _buildArtistsList(BuildContext context, List<Artist> artists, bool isLoading) {
|
||||
final colorScheme = Theme.of(context).colorScheme;
|
||||
|
||||
if (isLoading) {
|
||||
// Show cached data immediately if available, even while loading
|
||||
// Only show spinner if we have no data at all AND we're loading
|
||||
if (artists.isEmpty && isLoading) {
|
||||
return Center(
|
||||
child: CircularProgressIndicator(color: colorScheme.primary),
|
||||
);
|
||||
|
||||
@@ -75,7 +75,9 @@ class _LibraryPlaylistsScreenState extends State<LibraryPlaylistsScreen> {
|
||||
Widget _buildPlaylistsList(BuildContext context, MusicAssistantProvider provider) {
|
||||
final colorScheme = Theme.of(context).colorScheme;
|
||||
|
||||
if (_isLoading) {
|
||||
// Show cached data immediately if available, even while loading
|
||||
// Only show spinner if we have no data at all AND we're loading
|
||||
if (_playlists.isEmpty && _isLoading) {
|
||||
return Center(
|
||||
child: CircularProgressIndicator(color: colorScheme.primary),
|
||||
);
|
||||
|
||||
@@ -42,7 +42,9 @@ class LibraryTracksScreen extends StatelessWidget {
|
||||
BuildContext context, MusicAssistantProvider provider) {
|
||||
final colorScheme = Theme.of(context).colorScheme;
|
||||
|
||||
if (provider.isLoading) {
|
||||
// Show cached data immediately if available, even while loading
|
||||
// Only show spinner if we have no data at all AND we're loading
|
||||
if (provider.tracks.isEmpty && provider.isLoading) {
|
||||
return Center(
|
||||
child: CircularProgressIndicator(color: colorScheme.primary),
|
||||
);
|
||||
|
||||
@@ -443,6 +443,18 @@ class _LoginScreenState extends State<LoginScreen> {
|
||||
}
|
||||
|
||||
if (provider.isConnected) {
|
||||
// For first-time users, wait for player selection so the welcome
|
||||
// overlay can appear immediately without home screen flash.
|
||||
// This matches the logic in AppStartup._checkAndConnect().
|
||||
final hasCompletedOnboarding = await SettingsService.getHasCompletedOnboarding();
|
||||
if (!hasCompletedOnboarding) {
|
||||
// First-time user: wait for connection + player selection
|
||||
for (int i = 0; i < 20; i++) {
|
||||
await Future.delayed(const Duration(milliseconds: 250));
|
||||
if (provider.selectedPlayer != null) break;
|
||||
}
|
||||
}
|
||||
|
||||
// Navigate to home screen
|
||||
if (mounted) {
|
||||
// Ensure keyboard is closed before navigating
|
||||
|
||||
@@ -304,6 +304,7 @@ class _NewHomeScreenState extends State<NewHomeScreen> with AutomaticKeepAliveCl
|
||||
key: const ValueKey('recent-albums'),
|
||||
title: S.of(context)!.recentlyPlayed,
|
||||
loadAlbums: () => provider.getRecentAlbumsWithCache(),
|
||||
getCachedAlbums: () => provider.getCachedRecentAlbums(),
|
||||
rowHeight: rowHeight,
|
||||
);
|
||||
case 'discover-artists':
|
||||
@@ -312,6 +313,7 @@ class _NewHomeScreenState extends State<NewHomeScreen> with AutomaticKeepAliveCl
|
||||
key: const ValueKey('discover-artists'),
|
||||
title: S.of(context)!.discoverArtists,
|
||||
loadArtists: () => provider.getDiscoverArtistsWithCache(),
|
||||
getCachedArtists: () => provider.getCachedDiscoverArtists(),
|
||||
rowHeight: rowHeight,
|
||||
);
|
||||
case 'discover-albums':
|
||||
@@ -320,6 +322,7 @@ class _NewHomeScreenState extends State<NewHomeScreen> with AutomaticKeepAliveCl
|
||||
key: const ValueKey('discover-albums'),
|
||||
title: S.of(context)!.discoverAlbums,
|
||||
loadAlbums: () => provider.getDiscoverAlbumsWithCache(),
|
||||
getCachedAlbums: () => provider.getCachedDiscoverAlbums(),
|
||||
rowHeight: rowHeight,
|
||||
);
|
||||
case 'continue-listening':
|
||||
|
||||
@@ -1005,6 +1005,8 @@ class _NewLibraryScreenState extends State<NewLibraryScreen>
|
||||
fit: BoxFit.cover,
|
||||
width: 48,
|
||||
height: 48,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (_, __) => Text(
|
||||
authorName.isNotEmpty ? authorName[0].toUpperCase() : '?',
|
||||
style: TextStyle(
|
||||
@@ -1047,7 +1049,7 @@ class _NewLibraryScreenState extends State<NewLibraryScreen>
|
||||
color: colorScheme.onSurface.withOpacity(0.6),
|
||||
),
|
||||
),
|
||||
onTap: () => _navigateToAuthor(authorName, books, heroTagSuffix: 'library$heroSuffix'),
|
||||
onTap: () => _navigateToAuthor(authorName, books, heroTagSuffix: 'library$heroSuffix', initialAuthorImageUrl: authorImageUrl),
|
||||
);
|
||||
}
|
||||
|
||||
@@ -1059,7 +1061,7 @@ class _NewLibraryScreenState extends State<NewLibraryScreen>
|
||||
|
||||
// Match music artist card layout
|
||||
return GestureDetector(
|
||||
onTap: () => _navigateToAuthor(authorName, books, heroTagSuffix: 'library$heroSuffix'),
|
||||
onTap: () => _navigateToAuthor(authorName, books, heroTagSuffix: 'library$heroSuffix', initialAuthorImageUrl: authorImageUrl),
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.center,
|
||||
children: [
|
||||
@@ -1088,6 +1090,8 @@ class _NewLibraryScreenState extends State<NewLibraryScreen>
|
||||
fit: BoxFit.cover,
|
||||
width: size,
|
||||
height: size,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (_, __) => Center(
|
||||
child: Text(
|
||||
authorName.isNotEmpty ? authorName[0].toUpperCase() : '?',
|
||||
@@ -1142,7 +1146,7 @@ class _NewLibraryScreenState extends State<NewLibraryScreen>
|
||||
);
|
||||
}
|
||||
|
||||
void _navigateToAuthor(String authorName, List<Audiobook> books, {String? heroTagSuffix}) {
|
||||
void _navigateToAuthor(String authorName, List<Audiobook> books, {String? heroTagSuffix, String? initialAuthorImageUrl}) {
|
||||
Navigator.push(
|
||||
context,
|
||||
FadeSlidePageRoute(
|
||||
@@ -1150,6 +1154,7 @@ class _NewLibraryScreenState extends State<NewLibraryScreen>
|
||||
authorName: authorName,
|
||||
audiobooks: books,
|
||||
heroTagSuffix: heroTagSuffix,
|
||||
initialAuthorImageUrl: initialAuthorImageUrl,
|
||||
),
|
||||
),
|
||||
);
|
||||
@@ -1222,17 +1227,18 @@ class _NewLibraryScreenState extends State<NewLibraryScreen>
|
||||
),
|
||||
)
|
||||
: null,
|
||||
onTap: () => _navigateToAudiobook(book, heroTagSuffix: 'library$heroSuffix'),
|
||||
onTap: () => _navigateToAudiobook(book, heroTagSuffix: 'library$heroSuffix', initialImageUrl: imageUrl),
|
||||
);
|
||||
}
|
||||
|
||||
void _navigateToAudiobook(Audiobook book, {String? heroTagSuffix}) {
|
||||
void _navigateToAudiobook(Audiobook book, {String? heroTagSuffix, String? initialImageUrl}) {
|
||||
Navigator.push(
|
||||
context,
|
||||
FadeSlidePageRoute(
|
||||
child: AudiobookDetailScreen(
|
||||
audiobook: book,
|
||||
heroTagSuffix: heroTagSuffix,
|
||||
initialImageUrl: initialImageUrl,
|
||||
),
|
||||
),
|
||||
);
|
||||
@@ -1325,7 +1331,7 @@ class _NewLibraryScreenState extends State<NewLibraryScreen>
|
||||
final heroSuffix = _showFavoritesOnly ? '_fav' : '';
|
||||
|
||||
return GestureDetector(
|
||||
onTap: () => _navigateToAudiobook(book, heroTagSuffix: 'library$heroSuffix'),
|
||||
onTap: () => _navigateToAudiobook(book, heroTagSuffix: 'library$heroSuffix', initialImageUrl: imageUrl),
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
children: [
|
||||
@@ -1346,6 +1352,8 @@ class _NewLibraryScreenState extends State<NewLibraryScreen>
|
||||
? CachedNetworkImage(
|
||||
imageUrl: imageUrl,
|
||||
fit: BoxFit.cover,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (_, __) => const SizedBox(),
|
||||
errorWidget: (_, __, ___) => Center(
|
||||
child: Icon(
|
||||
@@ -2188,7 +2196,10 @@ class _NewLibraryScreenState extends State<NewLibraryScreen>
|
||||
Navigator.push(
|
||||
context,
|
||||
FadeSlidePageRoute(
|
||||
child: AlbumDetailsScreen(album: album),
|
||||
child: AlbumDetailsScreen(
|
||||
album: album,
|
||||
initialImageUrl: imageUrl,
|
||||
),
|
||||
),
|
||||
);
|
||||
},
|
||||
|
||||
@@ -35,21 +35,48 @@ class _PlaylistDetailsScreenState extends State<PlaylistDetailsScreen> {
|
||||
}
|
||||
|
||||
Future<void> _loadTracks() async {
|
||||
setState(() {
|
||||
_isLoading = true;
|
||||
});
|
||||
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
final tracks = await maProvider.getPlaylistTracksWithCache(
|
||||
widget.provider,
|
||||
widget.itemId,
|
||||
);
|
||||
final cacheKey = '${widget.provider}_${widget.itemId}';
|
||||
|
||||
if (mounted) {
|
||||
setState(() {
|
||||
_tracks = tracks;
|
||||
_isLoading = false;
|
||||
});
|
||||
// 1. Show cached data immediately (if available)
|
||||
final cachedTracks = maProvider.getCachedPlaylistTracks(cacheKey);
|
||||
if (cachedTracks != null && cachedTracks.isNotEmpty) {
|
||||
if (mounted) {
|
||||
setState(() {
|
||||
_tracks = cachedTracks;
|
||||
_isLoading = false;
|
||||
});
|
||||
}
|
||||
} else {
|
||||
setState(() => _isLoading = true);
|
||||
}
|
||||
|
||||
// 2. Fetch fresh data in background (silent refresh)
|
||||
try {
|
||||
final freshTracks = await maProvider.getPlaylistTracksWithCache(
|
||||
widget.provider,
|
||||
widget.itemId,
|
||||
forceRefresh: cachedTracks != null,
|
||||
);
|
||||
|
||||
// 3. Update if we got different data
|
||||
if (mounted && freshTracks.isNotEmpty) {
|
||||
final tracksChanged = _tracks.length != freshTracks.length ||
|
||||
(_tracks.isNotEmpty && freshTracks.isNotEmpty &&
|
||||
_tracks.first.itemId != freshTracks.first.itemId);
|
||||
if (tracksChanged || _tracks.isEmpty) {
|
||||
setState(() {
|
||||
_tracks = freshTracks;
|
||||
_isLoading = false;
|
||||
});
|
||||
}
|
||||
}
|
||||
} catch (e) {
|
||||
// Silent failure - keep showing cached data
|
||||
}
|
||||
|
||||
if (mounted && _isLoading) {
|
||||
setState(() => _isLoading = false);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
+1184
-217
File diff suppressed because it is too large
Load Diff
@@ -6,6 +6,7 @@ import '../providers/music_assistant_provider.dart';
|
||||
import '../services/music_assistant_api.dart';
|
||||
import '../services/settings_service.dart';
|
||||
import '../theme/theme_provider.dart';
|
||||
import '../theme/app_theme.dart';
|
||||
import '../widgets/global_player_overlay.dart';
|
||||
import 'debug_log_screen.dart';
|
||||
import 'login_screen.dart';
|
||||
@@ -37,6 +38,11 @@ class _SettingsScreenState extends State<SettingsScreen> {
|
||||
// Audiobook libraries
|
||||
List<Map<String, String>> _discoveredLibraries = [];
|
||||
Map<String, bool> _libraryEnabled = {};
|
||||
// Player settings
|
||||
bool _preferLocalPlayer = false;
|
||||
bool _smartSortPlayers = false;
|
||||
// Hint settings
|
||||
bool _showHints = true;
|
||||
|
||||
@override
|
||||
void initState() {
|
||||
@@ -81,6 +87,13 @@ class _SettingsScreenState extends State<SettingsScreen> {
|
||||
libraryEnabled[path] = enabled == null || enabled.contains(path);
|
||||
}
|
||||
|
||||
// Load player settings
|
||||
final preferLocal = await SettingsService.getPreferLocalPlayer();
|
||||
final smartSort = await SettingsService.getSmartSortPlayers();
|
||||
|
||||
// Load hint settings
|
||||
final showHints = await SettingsService.getShowHints();
|
||||
|
||||
if (mounted) {
|
||||
setState(() {
|
||||
_showRecentAlbums = showRecent;
|
||||
@@ -95,6 +108,9 @@ class _SettingsScreenState extends State<SettingsScreen> {
|
||||
_homeRowOrder = rowOrder;
|
||||
_discoveredLibraries = discovered;
|
||||
_libraryEnabled = libraryEnabled;
|
||||
_preferLocalPlayer = preferLocal;
|
||||
_smartSortPlayers = smartSort;
|
||||
_showHints = showHints;
|
||||
});
|
||||
}
|
||||
}
|
||||
@@ -410,7 +426,137 @@ class _SettingsScreenState extends State<SettingsScreen> {
|
||||
|
||||
const SizedBox(height: 16),
|
||||
|
||||
// Language picker
|
||||
// Accent color picker
|
||||
Consumer<ThemeProvider>(
|
||||
builder: (context, themeProvider, _) {
|
||||
final isDisabled = themeProvider.useMaterialTheme;
|
||||
return Container(
|
||||
padding: const EdgeInsets.all(16),
|
||||
decoration: BoxDecoration(
|
||||
color: colorScheme.surfaceVariant.withOpacity(0.3),
|
||||
borderRadius: BorderRadius.circular(12),
|
||||
),
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
children: [
|
||||
Text(
|
||||
S.of(context)!.accentColor,
|
||||
style: TextStyle(
|
||||
color: isDisabled
|
||||
? colorScheme.onSurface.withOpacity(0.4)
|
||||
: colorScheme.onSurface,
|
||||
fontWeight: FontWeight.w500,
|
||||
),
|
||||
),
|
||||
const SizedBox(height: 12),
|
||||
Row(
|
||||
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
|
||||
children: accentColorOptions.map((color) {
|
||||
final isSelected = themeProvider.customColor.value == color.value;
|
||||
return GestureDetector(
|
||||
onTap: isDisabled ? null : () {
|
||||
themeProvider.setCustomColor(color);
|
||||
},
|
||||
child: AnimatedContainer(
|
||||
duration: const Duration(milliseconds: 200),
|
||||
curve: Curves.easeInOut,
|
||||
width: 40,
|
||||
height: 40,
|
||||
decoration: BoxDecoration(
|
||||
color: isDisabled ? color.withOpacity(0.3) : color,
|
||||
shape: BoxShape.circle,
|
||||
border: isSelected && !isDisabled
|
||||
? Border.all(color: colorScheme.onSurface, width: 3)
|
||||
: null,
|
||||
boxShadow: isSelected && !isDisabled
|
||||
? [BoxShadow(color: color.withOpacity(0.5), blurRadius: 8, spreadRadius: 2)]
|
||||
: null,
|
||||
),
|
||||
child: isSelected && !isDisabled
|
||||
? Icon(Icons.check, color: Colors.white, size: 20)
|
||||
: null,
|
||||
),
|
||||
);
|
||||
}).toList(),
|
||||
),
|
||||
],
|
||||
),
|
||||
);
|
||||
},
|
||||
),
|
||||
|
||||
const SizedBox(height: 16),
|
||||
|
||||
Consumer<ThemeProvider>(
|
||||
builder: (context, themeProvider, _) {
|
||||
return Container(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 8),
|
||||
decoration: BoxDecoration(
|
||||
color: colorScheme.surfaceVariant.withOpacity(0.3),
|
||||
borderRadius: BorderRadius.circular(12),
|
||||
),
|
||||
child: SwitchListTile(
|
||||
title: Text(
|
||||
S.of(context)!.materialYou,
|
||||
style: TextStyle(color: colorScheme.onSurface),
|
||||
),
|
||||
subtitle: Text(
|
||||
S.of(context)!.materialYouDescription,
|
||||
style: TextStyle(color: colorScheme.onSurface.withOpacity(0.6), fontSize: 12),
|
||||
),
|
||||
value: themeProvider.useMaterialTheme,
|
||||
onChanged: (value) {
|
||||
themeProvider.setUseMaterialTheme(value);
|
||||
},
|
||||
activeColor: colorScheme.primary,
|
||||
contentPadding: EdgeInsets.zero,
|
||||
),
|
||||
);
|
||||
},
|
||||
),
|
||||
|
||||
const SizedBox(height: 16),
|
||||
|
||||
Consumer<ThemeProvider>(
|
||||
builder: (context, themeProvider, _) {
|
||||
return Container(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 8),
|
||||
decoration: BoxDecoration(
|
||||
color: colorScheme.surfaceVariant.withOpacity(0.3),
|
||||
borderRadius: BorderRadius.circular(12),
|
||||
),
|
||||
child: SwitchListTile(
|
||||
title: Text(
|
||||
S.of(context)!.adaptiveTheme,
|
||||
style: TextStyle(color: colorScheme.onSurface),
|
||||
),
|
||||
subtitle: Text(
|
||||
S.of(context)!.extractColorsFromArtwork,
|
||||
style: TextStyle(color: colorScheme.onSurface.withOpacity(0.6), fontSize: 12),
|
||||
),
|
||||
value: themeProvider.adaptiveTheme,
|
||||
onChanged: (value) {
|
||||
themeProvider.setAdaptiveTheme(value);
|
||||
},
|
||||
activeColor: colorScheme.primary,
|
||||
contentPadding: EdgeInsets.zero,
|
||||
),
|
||||
);
|
||||
},
|
||||
),
|
||||
|
||||
const SizedBox(height: 32),
|
||||
|
||||
// Language section
|
||||
Text(
|
||||
S.of(context)!.language,
|
||||
style: textTheme.titleMedium?.copyWith(
|
||||
color: colorScheme.onBackground,
|
||||
fontWeight: FontWeight.bold,
|
||||
),
|
||||
),
|
||||
const SizedBox(height: 16),
|
||||
|
||||
Consumer<LocaleProvider>(
|
||||
builder: (context, localeProvider, _) {
|
||||
String getLanguageName(String? code) {
|
||||
@@ -493,64 +639,108 @@ class _SettingsScreenState extends State<SettingsScreen> {
|
||||
},
|
||||
),
|
||||
|
||||
const SizedBox(height: 32),
|
||||
|
||||
// Player section
|
||||
Text(
|
||||
S.of(context)!.players,
|
||||
style: textTheme.titleMedium?.copyWith(
|
||||
color: colorScheme.onBackground,
|
||||
fontWeight: FontWeight.bold,
|
||||
),
|
||||
),
|
||||
const SizedBox(height: 16),
|
||||
|
||||
Consumer<ThemeProvider>(
|
||||
builder: (context, themeProvider, _) {
|
||||
return Container(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 8),
|
||||
decoration: BoxDecoration(
|
||||
color: colorScheme.surfaceVariant.withOpacity(0.3),
|
||||
borderRadius: BorderRadius.circular(12),
|
||||
),
|
||||
child: SwitchListTile(
|
||||
title: Text(
|
||||
S.of(context)!.materialYou,
|
||||
style: TextStyle(color: colorScheme.onSurface),
|
||||
),
|
||||
subtitle: Text(
|
||||
S.of(context)!.materialYouDescription,
|
||||
style: TextStyle(color: colorScheme.onSurface.withOpacity(0.6), fontSize: 12),
|
||||
),
|
||||
value: themeProvider.useMaterialTheme,
|
||||
onChanged: (value) {
|
||||
themeProvider.setUseMaterialTheme(value);
|
||||
},
|
||||
activeColor: colorScheme.primary,
|
||||
contentPadding: EdgeInsets.zero,
|
||||
),
|
||||
);
|
||||
},
|
||||
Container(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 8),
|
||||
decoration: BoxDecoration(
|
||||
color: colorScheme.surfaceVariant.withOpacity(0.3),
|
||||
borderRadius: BorderRadius.circular(12),
|
||||
),
|
||||
child: SwitchListTile(
|
||||
title: Text(
|
||||
S.of(context)!.preferLocalPlayer,
|
||||
style: TextStyle(color: colorScheme.onSurface),
|
||||
),
|
||||
subtitle: Text(
|
||||
S.of(context)!.preferLocalPlayerDescription,
|
||||
style: TextStyle(color: colorScheme.onSurface.withOpacity(0.6), fontSize: 12),
|
||||
),
|
||||
value: _preferLocalPlayer,
|
||||
onChanged: (value) {
|
||||
setState(() => _preferLocalPlayer = value);
|
||||
SettingsService.setPreferLocalPlayer(value);
|
||||
},
|
||||
activeColor: colorScheme.primary,
|
||||
contentPadding: EdgeInsets.zero,
|
||||
),
|
||||
),
|
||||
|
||||
const SizedBox(height: 16),
|
||||
|
||||
Consumer<ThemeProvider>(
|
||||
builder: (context, themeProvider, _) {
|
||||
return Container(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 8),
|
||||
decoration: BoxDecoration(
|
||||
color: colorScheme.surfaceVariant.withOpacity(0.3),
|
||||
borderRadius: BorderRadius.circular(12),
|
||||
),
|
||||
child: SwitchListTile(
|
||||
title: Text(
|
||||
S.of(context)!.adaptiveTheme,
|
||||
style: TextStyle(color: colorScheme.onSurface),
|
||||
),
|
||||
subtitle: Text(
|
||||
S.of(context)!.extractColorsFromArtwork,
|
||||
style: TextStyle(color: colorScheme.onSurface.withOpacity(0.6), fontSize: 12),
|
||||
),
|
||||
value: themeProvider.adaptiveTheme,
|
||||
onChanged: (value) {
|
||||
themeProvider.setAdaptiveTheme(value);
|
||||
},
|
||||
activeColor: colorScheme.primary,
|
||||
contentPadding: EdgeInsets.zero,
|
||||
),
|
||||
);
|
||||
},
|
||||
Container(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 8),
|
||||
decoration: BoxDecoration(
|
||||
color: colorScheme.surfaceVariant.withOpacity(0.3),
|
||||
borderRadius: BorderRadius.circular(12),
|
||||
),
|
||||
child: SwitchListTile(
|
||||
title: Text(
|
||||
S.of(context)!.smartSortPlayers,
|
||||
style: TextStyle(color: colorScheme.onSurface),
|
||||
),
|
||||
subtitle: Text(
|
||||
S.of(context)!.smartSortPlayersDescription,
|
||||
style: TextStyle(color: colorScheme.onSurface.withOpacity(0.6), fontSize: 12),
|
||||
),
|
||||
value: _smartSortPlayers,
|
||||
onChanged: (value) {
|
||||
setState(() => _smartSortPlayers = value);
|
||||
SettingsService.setSmartSortPlayers(value);
|
||||
},
|
||||
activeColor: colorScheme.primary,
|
||||
contentPadding: EdgeInsets.zero,
|
||||
),
|
||||
),
|
||||
|
||||
const SizedBox(height: 32),
|
||||
|
||||
// Hints & Tips section
|
||||
Text(
|
||||
S.of(context)!.hintsAndTips,
|
||||
style: textTheme.titleMedium?.copyWith(
|
||||
color: colorScheme.onBackground,
|
||||
fontWeight: FontWeight.bold,
|
||||
),
|
||||
),
|
||||
const SizedBox(height: 8),
|
||||
Text(
|
||||
S.of(context)!.showHintsDescription,
|
||||
style: textTheme.bodySmall?.copyWith(
|
||||
color: colorScheme.onBackground.withOpacity(0.6),
|
||||
),
|
||||
),
|
||||
const SizedBox(height: 16),
|
||||
|
||||
Container(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 8),
|
||||
decoration: BoxDecoration(
|
||||
color: colorScheme.surfaceVariant.withOpacity(0.3),
|
||||
borderRadius: BorderRadius.circular(12),
|
||||
),
|
||||
child: SwitchListTile(
|
||||
title: Text(
|
||||
S.of(context)!.showHints,
|
||||
style: TextStyle(color: colorScheme.onSurface),
|
||||
),
|
||||
value: _showHints,
|
||||
onChanged: (value) {
|
||||
setState(() => _showHints = value);
|
||||
SettingsService.setShowHints(value);
|
||||
},
|
||||
activeColor: colorScheme.primary,
|
||||
contentPadding: EdgeInsets.zero,
|
||||
),
|
||||
),
|
||||
|
||||
const SizedBox(height: 32),
|
||||
|
||||
@@ -1,3 +1,4 @@
|
||||
import 'dart:async';
|
||||
import 'package:audio_service/audio_service.dart';
|
||||
import 'package:audio_session/audio_session.dart';
|
||||
import 'package:just_audio/just_audio.dart';
|
||||
@@ -11,6 +12,12 @@ class MassivAudioHandler extends BaseAudioHandler with SeekHandler {
|
||||
final AuthManager authManager;
|
||||
final _logger = DebugLogger();
|
||||
|
||||
// Stream subscriptions for proper cleanup
|
||||
StreamSubscription? _interruptionSubscription;
|
||||
StreamSubscription? _becomingNoisySubscription;
|
||||
StreamSubscription? _playbackEventSubscription;
|
||||
StreamSubscription? _currentIndexSubscription;
|
||||
|
||||
// Track current metadata separately from what's in the notification
|
||||
// This allows us to update the notification when metadata arrives late
|
||||
MediaItem? _currentMediaItem;
|
||||
@@ -42,7 +49,7 @@ class MassivAudioHandler extends BaseAudioHandler with SeekHandler {
|
||||
await session.configure(const AudioSessionConfiguration.music());
|
||||
|
||||
// Handle audio interruptions
|
||||
session.interruptionEventStream.listen((event) {
|
||||
_interruptionSubscription = session.interruptionEventStream.listen((event) {
|
||||
if (event.begin) {
|
||||
switch (event.type) {
|
||||
case AudioInterruptionType.duck:
|
||||
@@ -68,15 +75,15 @@ class MassivAudioHandler extends BaseAudioHandler with SeekHandler {
|
||||
});
|
||||
|
||||
// Handle becoming noisy (headphones unplugged)
|
||||
session.becomingNoisyEventStream.listen((_) {
|
||||
_becomingNoisySubscription = session.becomingNoisyEventStream.listen((_) {
|
||||
pause();
|
||||
});
|
||||
|
||||
// Broadcast playback state changes
|
||||
_player.playbackEventStream.listen(_broadcastState);
|
||||
_playbackEventSubscription = _player.playbackEventStream.listen(_broadcastState);
|
||||
|
||||
// Broadcast current media item changes
|
||||
_player.currentIndexStream.listen((_) {
|
||||
_currentIndexSubscription = _player.currentIndexStream.listen((_) {
|
||||
if (_currentMediaItem != null) {
|
||||
mediaItem.add(_currentMediaItem);
|
||||
}
|
||||
@@ -293,4 +300,13 @@ class MassivAudioHandler extends BaseAudioHandler with SeekHandler {
|
||||
Stream<Duration?> get durationStream => _player.durationStream;
|
||||
|
||||
MediaItem? get currentMediaItem => _currentMediaItem;
|
||||
|
||||
/// Dispose of resources and cancel all subscriptions
|
||||
Future<void> dispose() async {
|
||||
await _interruptionSubscription?.cancel();
|
||||
await _becomingNoisySubscription?.cancel();
|
||||
await _playbackEventSubscription?.cancel();
|
||||
await _currentIndexSubscription?.cancel();
|
||||
await _player.dispose();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,12 +1,20 @@
|
||||
import 'dart:convert';
|
||||
import '../models/media_item.dart';
|
||||
import '../models/player.dart';
|
||||
import '../services/debug_logger.dart';
|
||||
import '../services/database_service.dart';
|
||||
import '../constants/timings.dart';
|
||||
|
||||
/// Centralized cache service for all app data caching
|
||||
/// This is a non-notifying service - it just stores and retrieves cached data
|
||||
class CacheService {
|
||||
final DebugLogger _logger = DebugLogger();
|
||||
bool _homeRowsLoaded = false;
|
||||
|
||||
// Cache size limits to prevent unbounded memory growth
|
||||
static const int _maxDetailCacheSize = 50; // Max albums/playlists/artists cached
|
||||
static const int _maxSearchCacheSize = 20; // Max search queries cached
|
||||
static const int _maxPlayerTrackCacheSize = 30; // Max player track associations
|
||||
|
||||
// Home screen row caching
|
||||
List<Album>? _cachedRecentAlbums;
|
||||
@@ -35,6 +43,7 @@ class CacheService {
|
||||
|
||||
// Player track cache (for smooth swipe transitions)
|
||||
final Map<String, Track?> _playerTrackCache = {};
|
||||
final Map<String, DateTime> _playerTrackCacheTime = {};
|
||||
|
||||
// ============================================================================
|
||||
// HOME SCREEN ROW CACHING
|
||||
@@ -57,6 +66,8 @@ class CacheService {
|
||||
_cachedRecentAlbums = albums;
|
||||
_recentAlbumsLastFetched = DateTime.now();
|
||||
_logger.log('✅ Cached ${albums.length} recent albums');
|
||||
// Persist to database for instant load on next launch
|
||||
_persistHomeRowToDatabase('recent_albums', albums.map((a) => a.toJson()).toList());
|
||||
}
|
||||
|
||||
/// Check if discover artists cache is valid
|
||||
@@ -76,6 +87,8 @@ class CacheService {
|
||||
_cachedDiscoverArtists = artists;
|
||||
_discoverArtistsLastFetched = DateTime.now();
|
||||
_logger.log('✅ Cached ${artists.length} discover artists');
|
||||
// Persist to database for instant load on next launch
|
||||
_persistHomeRowToDatabase('discover_artists', artists.map((a) => a.toJson()).toList());
|
||||
}
|
||||
|
||||
/// Check if discover albums cache is valid
|
||||
@@ -95,6 +108,8 @@ class CacheService {
|
||||
_cachedDiscoverAlbums = albums;
|
||||
_discoverAlbumsLastFetched = DateTime.now();
|
||||
_logger.log('✅ Cached ${albums.length} discover albums');
|
||||
// Persist to database for instant load on next launch
|
||||
_persistHomeRowToDatabase('discover_albums', albums.map((a) => a.toJson()).toList());
|
||||
}
|
||||
|
||||
/// Invalidate home screen cache (call on pull-to-refresh)
|
||||
@@ -126,6 +141,7 @@ class CacheService {
|
||||
void setCachedAlbumTracks(String cacheKey, List<Track> tracks) {
|
||||
_albumTracksCache[cacheKey] = tracks;
|
||||
_albumTracksCacheTime[cacheKey] = DateTime.now();
|
||||
_evictOldestEntries(_albumTracksCache, _albumTracksCacheTime, _maxDetailCacheSize);
|
||||
_logger.log('✅ Cached ${tracks.length} tracks for album $cacheKey');
|
||||
}
|
||||
|
||||
@@ -152,6 +168,7 @@ class CacheService {
|
||||
void setCachedPlaylistTracks(String cacheKey, List<Track> tracks) {
|
||||
_playlistTracksCache[cacheKey] = tracks;
|
||||
_playlistTracksCacheTime[cacheKey] = DateTime.now();
|
||||
_evictOldestEntries(_playlistTracksCache, _playlistTracksCacheTime, _maxDetailCacheSize);
|
||||
_logger.log('✅ Cached ${tracks.length} tracks for playlist $cacheKey');
|
||||
}
|
||||
|
||||
@@ -178,6 +195,7 @@ class CacheService {
|
||||
void setCachedArtistAlbums(String cacheKey, List<Album> albums) {
|
||||
_artistAlbumsCache[cacheKey] = albums;
|
||||
_artistAlbumsCacheTime[cacheKey] = DateTime.now();
|
||||
_evictOldestEntries(_artistAlbumsCache, _artistAlbumsCacheTime, _maxDetailCacheSize);
|
||||
_logger.log('✅ Cached ${albums.length} albums for artist $cacheKey');
|
||||
}
|
||||
|
||||
@@ -202,6 +220,7 @@ class CacheService {
|
||||
void setCachedSearchResults(String cacheKey, Map<String, List<MediaItem>> results) {
|
||||
_searchCache[cacheKey] = results;
|
||||
_searchCacheTime[cacheKey] = DateTime.now();
|
||||
_evictOldestEntries(_searchCache, _searchCacheTime, _maxSearchCacheSize);
|
||||
_logger.log('✅ Cached search results for "$cacheKey"');
|
||||
}
|
||||
|
||||
@@ -245,9 +264,20 @@ class CacheService {
|
||||
/// Get cached track for a player (used for smooth swipe transitions)
|
||||
Track? getCachedTrackForPlayer(String playerId) => _playerTrackCache[playerId];
|
||||
|
||||
/// Get all player IDs that have cached tracks
|
||||
Iterable<String> getAllCachedPlayerIds() => _playerTrackCache.keys;
|
||||
|
||||
/// Set cached track for a player
|
||||
void setCachedTrackForPlayer(String playerId, Track? track) {
|
||||
_playerTrackCache[playerId] = track;
|
||||
_playerTrackCacheTime[playerId] = DateTime.now();
|
||||
_evictOldestEntries(_playerTrackCache, _playerTrackCacheTime, _maxPlayerTrackCacheSize);
|
||||
}
|
||||
|
||||
/// Clear cached track for a player (e.g., when external source is active)
|
||||
void clearCachedTrackForPlayer(String playerId) {
|
||||
_playerTrackCache.remove(playerId);
|
||||
_playerTrackCacheTime.remove(playerId);
|
||||
}
|
||||
|
||||
// ============================================================================
|
||||
@@ -265,6 +295,7 @@ class CacheService {
|
||||
_searchCache.clear();
|
||||
_searchCacheTime.clear();
|
||||
_playerTrackCache.clear();
|
||||
_playerTrackCacheTime.clear();
|
||||
_logger.log('🗑️ All detail caches cleared');
|
||||
}
|
||||
|
||||
@@ -276,4 +307,108 @@ class CacheService {
|
||||
_cachedSelectedPlayer = null;
|
||||
_playersLastFetched = null;
|
||||
}
|
||||
|
||||
// ============================================================================
|
||||
// DATABASE PERSISTENCE FOR HOME ROWS
|
||||
// ============================================================================
|
||||
|
||||
/// Load home row data from database for instant display on startup
|
||||
Future<void> loadHomeRowsFromDatabase() async {
|
||||
if (_homeRowsLoaded) return;
|
||||
_homeRowsLoaded = true;
|
||||
|
||||
try {
|
||||
if (!DatabaseService.instance.isInitialized) return;
|
||||
|
||||
// Load recent albums
|
||||
final recentData = await DatabaseService.instance.getHomeRowCache('recent_albums');
|
||||
if (recentData != null) {
|
||||
try {
|
||||
final items = (jsonDecode(recentData.itemsJson) as List)
|
||||
.map((json) => Album.fromJson(json as Map<String, dynamic>))
|
||||
.toList();
|
||||
_cachedRecentAlbums = items;
|
||||
_recentAlbumsLastFetched = recentData.lastUpdated;
|
||||
_logger.log('📦 Loaded ${items.length} recent albums from database');
|
||||
} catch (e) {
|
||||
_logger.log('⚠️ Failed to parse recent albums: $e');
|
||||
}
|
||||
}
|
||||
|
||||
// Load discover artists
|
||||
final artistsData = await DatabaseService.instance.getHomeRowCache('discover_artists');
|
||||
if (artistsData != null) {
|
||||
try {
|
||||
final items = (jsonDecode(artistsData.itemsJson) as List)
|
||||
.map((json) => Artist.fromJson(json as Map<String, dynamic>))
|
||||
.toList();
|
||||
_cachedDiscoverArtists = items;
|
||||
_discoverArtistsLastFetched = artistsData.lastUpdated;
|
||||
_logger.log('📦 Loaded ${items.length} discover artists from database');
|
||||
} catch (e) {
|
||||
_logger.log('⚠️ Failed to parse discover artists: $e');
|
||||
}
|
||||
}
|
||||
|
||||
// Load discover albums
|
||||
final albumsData = await DatabaseService.instance.getHomeRowCache('discover_albums');
|
||||
if (albumsData != null) {
|
||||
try {
|
||||
final items = (jsonDecode(albumsData.itemsJson) as List)
|
||||
.map((json) => Album.fromJson(json as Map<String, dynamic>))
|
||||
.toList();
|
||||
_cachedDiscoverAlbums = items;
|
||||
_discoverAlbumsLastFetched = albumsData.lastUpdated;
|
||||
_logger.log('📦 Loaded ${items.length} discover albums from database');
|
||||
} catch (e) {
|
||||
_logger.log('⚠️ Failed to parse discover albums: $e');
|
||||
}
|
||||
}
|
||||
} catch (e) {
|
||||
_logger.log('⚠️ Error loading home rows from database: $e');
|
||||
}
|
||||
}
|
||||
|
||||
/// Persist home row data to database (fire-and-forget)
|
||||
void _persistHomeRowToDatabase(String rowType, List<Map<String, dynamic>> items) {
|
||||
() async {
|
||||
try {
|
||||
if (!DatabaseService.instance.isInitialized) return;
|
||||
await DatabaseService.instance.saveHomeRowCache(rowType, jsonEncode(items));
|
||||
_logger.log('💾 Persisted $rowType to database');
|
||||
} catch (e) {
|
||||
_logger.log('⚠️ Failed to persist $rowType: $e');
|
||||
}
|
||||
}();
|
||||
}
|
||||
|
||||
// ============================================================================
|
||||
// LRU CACHE EVICTION
|
||||
// ============================================================================
|
||||
|
||||
/// Evict oldest entries from cache maps to enforce size limit (LRU eviction)
|
||||
/// Uses the timestamp map to determine which entries are oldest
|
||||
void _evictOldestEntries<K, V>(
|
||||
Map<K, V> cache,
|
||||
Map<K, DateTime> cacheTime,
|
||||
int maxSize,
|
||||
) {
|
||||
if (cache.length <= maxSize) return;
|
||||
|
||||
// Sort keys by timestamp (oldest first)
|
||||
final sortedKeys = cacheTime.keys.toList()
|
||||
..sort((a, b) => (cacheTime[a] ?? DateTime.now())
|
||||
.compareTo(cacheTime[b] ?? DateTime.now()));
|
||||
|
||||
// Remove oldest entries until we're at maxSize
|
||||
final keysToRemove = sortedKeys.take(cache.length - maxSize);
|
||||
for (final key in keysToRemove) {
|
||||
cache.remove(key);
|
||||
cacheTime.remove(key);
|
||||
}
|
||||
|
||||
if (keysToRemove.isNotEmpty) {
|
||||
_logger.log('🗑️ LRU evicted ${keysToRemove.length} cache entries');
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -156,4 +156,149 @@ class DatabaseService {
|
||||
|
||||
/// Clear all cached data (useful for logout)
|
||||
Future<void> clearAllCache() => db.clearAllCache();
|
||||
|
||||
// ============================================
|
||||
// Player Cache Convenience Methods
|
||||
// ============================================
|
||||
|
||||
/// Save playback state for instant resume
|
||||
Future<void> savePlaybackState({
|
||||
String? playerId,
|
||||
String? playerName,
|
||||
String? currentTrackJson,
|
||||
double positionSeconds = 0.0,
|
||||
bool isPlaying = false,
|
||||
}) {
|
||||
return db.savePlaybackState(
|
||||
playerId: playerId,
|
||||
playerName: playerName,
|
||||
currentTrackJson: currentTrackJson,
|
||||
positionSeconds: positionSeconds,
|
||||
isPlaying: isPlaying,
|
||||
);
|
||||
}
|
||||
|
||||
/// Get saved playback state
|
||||
Future<PlaybackStateData?> getPlaybackState() => db.getPlaybackState();
|
||||
|
||||
/// Cache a player with optional track info
|
||||
Future<void> cachePlayer({
|
||||
required String playerId,
|
||||
required String playerJson,
|
||||
String? currentTrackJson,
|
||||
}) {
|
||||
return db.cachePlayer(
|
||||
playerId: playerId,
|
||||
playerJson: playerJson,
|
||||
currentTrackJson: currentTrackJson,
|
||||
);
|
||||
}
|
||||
|
||||
/// Cache multiple players at once
|
||||
Future<void> cachePlayers(List<Map<String, dynamic>> players) {
|
||||
return db.cachePlayers(players);
|
||||
}
|
||||
|
||||
/// Get all cached players
|
||||
Future<List<CachedPlayer>> getCachedPlayers() => db.getCachedPlayers();
|
||||
|
||||
/// Update cached track for a player
|
||||
Future<void> updateCachedPlayerTrack(String playerId, String? trackJson) {
|
||||
return db.updateCachedPlayerTrack(playerId, trackJson);
|
||||
}
|
||||
|
||||
/// Clear all cached players
|
||||
Future<void> clearCachedPlayers() => db.clearCachedPlayers();
|
||||
|
||||
/// Save queue for a player
|
||||
Future<void> saveQueue(String playerId, List<String> itemJsonList) {
|
||||
return db.saveQueue(playerId, itemJsonList);
|
||||
}
|
||||
|
||||
/// Get cached queue for a player
|
||||
Future<List<CachedQueueData>> getCachedQueue(String playerId) {
|
||||
return db.getCachedQueue(playerId);
|
||||
}
|
||||
|
||||
/// Clear queue for a player
|
||||
Future<void> clearCachedQueue(String playerId) => db.clearCachedQueue(playerId);
|
||||
|
||||
// ============================================
|
||||
// Home Row Cache Convenience Methods
|
||||
// ============================================
|
||||
|
||||
/// Save home row data (recent albums, discover artists, etc.)
|
||||
Future<void> saveHomeRowCache(String rowType, String itemsJson) {
|
||||
return db.saveHomeRowCache(rowType, itemsJson);
|
||||
}
|
||||
|
||||
/// Get cached home row data
|
||||
Future<HomeRowCacheData?> getHomeRowCache(String rowType) {
|
||||
return db.getHomeRowCache(rowType);
|
||||
}
|
||||
|
||||
/// Clear all home row cache
|
||||
Future<void> clearHomeRowCache() => db.clearHomeRowCache();
|
||||
|
||||
// ============================================
|
||||
// Search History Convenience Methods
|
||||
// ============================================
|
||||
|
||||
/// Save a search query to history
|
||||
Future<void> saveSearchQuery(String query) => db.saveSearchQuery(query);
|
||||
|
||||
/// Get recent search queries (up to 10)
|
||||
Future<List<String>> getRecentSearches() => db.getRecentSearches();
|
||||
|
||||
/// Clear all search history
|
||||
Future<void> clearSearchHistory() => db.clearSearchHistory();
|
||||
|
||||
// ============================================
|
||||
// Cast-to-Sendspin Mapping Methods
|
||||
// ============================================
|
||||
|
||||
static const String _sendspinMappingType = 'cast_sendspin_mapping';
|
||||
|
||||
/// Save a Cast UUID to Sendspin ID mapping
|
||||
Future<void> saveCastToSendspinMapping(String castId, String sendspinId) {
|
||||
_logger.log('💾 Persisting Cast->Sendspin mapping: $castId -> $sendspinId');
|
||||
return db.cacheItem(
|
||||
itemType: _sendspinMappingType,
|
||||
itemId: castId,
|
||||
data: jsonEncode({'sendspinId': sendspinId}),
|
||||
);
|
||||
}
|
||||
|
||||
/// Get persisted Sendspin ID for a Cast UUID
|
||||
Future<String?> getSendspinIdForCast(String castId) async {
|
||||
final item = await db.getCachedItem(_sendspinMappingType, castId);
|
||||
if (item == null) return null;
|
||||
try {
|
||||
final data = jsonDecode(item.data) as Map<String, dynamic>;
|
||||
return data['sendspinId'] as String?;
|
||||
} catch (e) {
|
||||
_logger.log('Error decoding Sendspin mapping: $e');
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
||||
/// Load all persisted Cast-to-Sendspin mappings
|
||||
Future<Map<String, String>> getAllCastToSendspinMappings() async {
|
||||
final items = await db.getCachedItems(_sendspinMappingType);
|
||||
final mappings = <String, String>{};
|
||||
for (final item in items) {
|
||||
try {
|
||||
final data = jsonDecode(item.data) as Map<String, dynamic>;
|
||||
final sendspinId = data['sendspinId'] as String?;
|
||||
if (sendspinId != null) {
|
||||
// The itemId is the Cast UUID
|
||||
mappings[item.itemId] = sendspinId;
|
||||
}
|
||||
} catch (e) {
|
||||
_logger.log('Error decoding Sendspin mapping: $e');
|
||||
}
|
||||
}
|
||||
_logger.log('📦 Loaded ${mappings.length} Cast->Sendspin mappings from database');
|
||||
return mappings;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,36 +1,99 @@
|
||||
import 'dart:io';
|
||||
import 'dart:ui' as ui;
|
||||
import 'package:device_info_plus/device_info_plus.dart';
|
||||
import 'package:shared_preferences/shared_preferences.dart';
|
||||
import 'package:uuid/uuid.dart';
|
||||
import 'debug_logger.dart';
|
||||
import 'settings_service.dart';
|
||||
|
||||
/// Service to generate unique per-installation player IDs
|
||||
/// Simplified to match KMP client pattern: single storage key, lazy generation
|
||||
/// This prevents the critical bug where multiple devices of the same model
|
||||
/// would share the same player ID and trigger playback on all devices
|
||||
/// Service to generate unique per-device player IDs
|
||||
/// Uses stable device identifiers (ANDROID_ID) combined with MA username
|
||||
/// to create persistent player IDs that survive storage wipes and support
|
||||
/// multiple devices per account
|
||||
class DeviceIdService {
|
||||
static const String _keyLocalPlayerId = 'local_player_id';
|
||||
static final _logger = DebugLogger();
|
||||
static const _uuid = Uuid();
|
||||
|
||||
/// Get or generate a unique player ID for this installation
|
||||
/// ID is generated once and persisted across app restarts
|
||||
/// Format: ensemble_<uuid>
|
||||
///
|
||||
/// This matches the KMP client pattern: generate on first access, store once
|
||||
static Future<String> getOrCreateDevicePlayerId() async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
// Cache stable device ID to avoid repeated platform calls
|
||||
static String? _cachedStableDeviceId;
|
||||
|
||||
// Single source of truth - no complex migration logic
|
||||
final existingId = prefs.getString(_keyLocalPlayerId);
|
||||
if (existingId != null && existingId.startsWith('ensemble_')) {
|
||||
_logger.log('Using existing player ID: $existingId');
|
||||
return existingId;
|
||||
/// Get stable device identifier that persists across storage wipes
|
||||
/// - Android: Uses ANDROID_ID (persists until factory reset)
|
||||
/// - iOS: Uses identifierForVendor (persists until app reinstall)
|
||||
static Future<String> _getStableDeviceId() async {
|
||||
if (_cachedStableDeviceId != null) {
|
||||
return _cachedStableDeviceId!;
|
||||
}
|
||||
|
||||
// Generate new ID on first access
|
||||
final playerId = 'ensemble_${_uuid.v4()}';
|
||||
await prefs.setString(_keyLocalPlayerId, playerId);
|
||||
_logger.log('Generated new player ID: $playerId');
|
||||
return playerId;
|
||||
final deviceInfo = DeviceInfoPlugin();
|
||||
|
||||
if (Platform.isAndroid) {
|
||||
final android = await deviceInfo.androidInfo;
|
||||
// ANDROID_ID is unique per device+user combo, persists across storage wipes
|
||||
// Only resets on factory reset
|
||||
_cachedStableDeviceId = android.id;
|
||||
} else if (Platform.isIOS) {
|
||||
final ios = await deviceInfo.iosInfo;
|
||||
// identifierForVendor persists across app updates but resets on reinstall
|
||||
_cachedStableDeviceId = ios.identifierForVendor ?? 'unknown_ios';
|
||||
} else {
|
||||
// Fallback for other platforms (web, desktop)
|
||||
_cachedStableDeviceId = 'unknown_platform';
|
||||
}
|
||||
|
||||
return _cachedStableDeviceId!;
|
||||
}
|
||||
|
||||
/// Detect if device is a tablet based on screen size
|
||||
/// Uses the standard 600dp threshold (shortest side >= 600 = tablet)
|
||||
static bool get isTablet {
|
||||
try {
|
||||
final view = ui.PlatformDispatcher.instance.views.first;
|
||||
final size = view.physicalSize / view.devicePixelRatio;
|
||||
return size.shortestSide >= 600;
|
||||
} catch (e) {
|
||||
_logger.log('Failed to detect device type: $e');
|
||||
return false; // Default to phone if detection fails
|
||||
}
|
||||
}
|
||||
|
||||
/// Get or generate a unique player ID for this device
|
||||
/// Format: ensemble_{username}_{deviceId} or ensemble_{deviceId}
|
||||
///
|
||||
/// Key behaviors:
|
||||
/// - Uses stable device ID that survives storage wipes
|
||||
/// - Includes MA username to support multiple devices per account
|
||||
/// - Regenerates if username changes (user logged in with different account)
|
||||
static Future<String> getOrCreateDevicePlayerId() async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
final stableDeviceId = await _getStableDeviceId();
|
||||
final maUsername = await SettingsService.getUsername();
|
||||
|
||||
// Generate expected ID based on current username and device
|
||||
// Use shorter device ID suffix (first 8 chars) to keep ID reasonable length
|
||||
final deviceIdSuffix = stableDeviceId.length > 8
|
||||
? stableDeviceId.substring(0, 8)
|
||||
: stableDeviceId;
|
||||
|
||||
final expectedId = maUsername != null && maUsername.isNotEmpty
|
||||
? 'ensemble_${maUsername}_$deviceIdSuffix'
|
||||
: 'ensemble_$deviceIdSuffix';
|
||||
|
||||
// Check if we already have the correct ID
|
||||
final existingId = prefs.getString(_keyLocalPlayerId);
|
||||
if (existingId == expectedId) {
|
||||
_logger.log('Using existing player ID: $expectedId');
|
||||
return expectedId;
|
||||
}
|
||||
|
||||
// ID needs to be updated (first login, username changed, or migration)
|
||||
if (existingId != null) {
|
||||
_logger.log('Updating player ID from $existingId to $expectedId');
|
||||
} else {
|
||||
_logger.log('Generated new player ID: $expectedId');
|
||||
}
|
||||
|
||||
await prefs.setString(_keyLocalPlayerId, expectedId);
|
||||
return expectedId;
|
||||
}
|
||||
|
||||
/// Adopt an existing player ID (used when claiming a ghost player)
|
||||
@@ -45,4 +108,12 @@ class DeviceIdService {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
return prefs.getString(_keyLocalPlayerId) == null;
|
||||
}
|
||||
|
||||
/// Force regeneration of player ID on next call
|
||||
/// Useful after login/logout to ensure ID matches current user
|
||||
static Future<void> invalidateCachedId() async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
await prefs.remove(_keyLocalPlayerId);
|
||||
_logger.log('Invalidated cached player ID');
|
||||
}
|
||||
}
|
||||
|
||||
@@ -82,5 +82,9 @@ class HardwareVolumeService {
|
||||
} catch (e) {
|
||||
_logger.error('Failed to stop volume button listening', context: 'VolumeService', error: e);
|
||||
}
|
||||
|
||||
// Close StreamControllers to prevent memory leaks
|
||||
await _volumeUpController.close();
|
||||
await _volumeDownController.close();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1069,16 +1069,14 @@ class MusicAssistantAPI {
|
||||
return [];
|
||||
}
|
||||
|
||||
// Batch fetch track details using parallel requests (max 5 concurrent)
|
||||
final seenAlbumIds = <String>{};
|
||||
final albums = <Album>[];
|
||||
// Step 1: Fetch tracks in batches and collect unique album URIs
|
||||
final seenAlbumUris = <String>{};
|
||||
final albumUris = <String>[];
|
||||
|
||||
// Process in batches to avoid overwhelming the server
|
||||
const batchSize = LibraryConstants.recentAlbumsBatchSize;
|
||||
for (var i = 0; i < trackUris.length && albums.length < limit; i += batchSize) {
|
||||
for (var i = 0; i < trackUris.length && albumUris.length < limit; i += batchSize) {
|
||||
final batch = trackUris.skip(i).take(batchSize).toList();
|
||||
|
||||
// Fetch batch in parallel
|
||||
final futures = batch.map((uri) => _sendCommand(
|
||||
'music/item_by_uri',
|
||||
args: {'uri': uri},
|
||||
@@ -1087,27 +1085,52 @@ class MusicAssistantAPI {
|
||||
final results = await Future.wait(futures, eagerError: false);
|
||||
|
||||
for (final trackResponse in results) {
|
||||
if (albums.length >= limit) break;
|
||||
if (albumUris.length >= limit) break;
|
||||
|
||||
try {
|
||||
final fullTrack = trackResponse['result'] as Map<String, dynamic>?;
|
||||
final albumData = fullTrack?['album'] as Map<String, dynamic>?;
|
||||
final albumUri = albumData?['uri'] as String?;
|
||||
|
||||
if (albumData != null) {
|
||||
final albumId = albumData['item_id']?.toString() ?? albumData['uri']?.toString();
|
||||
if (albumId != null && !seenAlbumIds.contains(albumId)) {
|
||||
seenAlbumIds.add(albumId);
|
||||
albums.add(Album.fromJson(albumData));
|
||||
}
|
||||
if (albumUri != null && !seenAlbumUris.contains(albumUri)) {
|
||||
seenAlbumUris.add(albumUri);
|
||||
albumUris.add(albumUri);
|
||||
}
|
||||
} catch (_) {
|
||||
// Skip tracks that fail to parse
|
||||
continue;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
_logger.log('📚 Fetched ${albums.length} recent albums using ${(trackUris.length / batchSize).ceil()} batch requests');
|
||||
if (albumUris.isEmpty) {
|
||||
return [];
|
||||
}
|
||||
|
||||
// Step 2: Fetch full album details (with images) for each album URI
|
||||
final albums = <Album>[];
|
||||
for (var i = 0; i < albumUris.length; i += batchSize) {
|
||||
final batch = albumUris.skip(i).take(batchSize).toList();
|
||||
|
||||
final futures = batch.map((uri) => _sendCommand(
|
||||
'music/item_by_uri',
|
||||
args: {'uri': uri},
|
||||
).timeout(const Duration(seconds: 5), onTimeout: () => <String, dynamic>{'result': null}));
|
||||
|
||||
final results = await Future.wait(futures, eagerError: false);
|
||||
|
||||
for (final albumResponse in results) {
|
||||
try {
|
||||
final albumData = albumResponse['result'] as Map<String, dynamic>?;
|
||||
if (albumData != null) {
|
||||
albums.add(Album.fromJson(albumData));
|
||||
}
|
||||
} catch (_) {
|
||||
continue;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
_logger.log('📚 Fetched ${albums.length} recent albums with full details');
|
||||
return albums;
|
||||
} catch (e) {
|
||||
_logger.log('❌ Error getting recent albums: $e');
|
||||
@@ -1376,7 +1399,7 @@ class MusicAssistantAPI {
|
||||
|
||||
final result = searchResponse['result'] as Map<String, dynamic>?;
|
||||
if (result == null) {
|
||||
return <String, List<MediaItem>>{'artists': [], 'albums': [], 'tracks': []};
|
||||
return <String, List<MediaItem>>{'artists': [], 'albums': [], 'tracks': [], 'playlists': [], 'audiobooks': []};
|
||||
}
|
||||
|
||||
// Parse results from the search response
|
||||
@@ -1395,6 +1418,16 @@ class MusicAssistantAPI {
|
||||
.toList() ??
|
||||
[];
|
||||
|
||||
final playlists = (result['playlists'] as List<dynamic>?)
|
||||
?.map((item) => Playlist.fromJson(item as Map<String, dynamic>))
|
||||
.toList() ??
|
||||
[];
|
||||
|
||||
final audiobooks = (result['audiobooks'] as List<dynamic>?)
|
||||
?.map((item) => Audiobook.fromJson(item as Map<String, dynamic>))
|
||||
.toList() ??
|
||||
[];
|
||||
|
||||
// Deduplicate results by name
|
||||
// MA returns both library items and provider items for the same content
|
||||
// Prefer library items (provider='library') as they have all provider mappings
|
||||
@@ -1402,15 +1435,17 @@ class MusicAssistantAPI {
|
||||
'artists': _deduplicateResults(artists),
|
||||
'albums': _deduplicateResults(albums),
|
||||
'tracks': _deduplicateResults(tracks),
|
||||
'playlists': _deduplicateResults(playlists),
|
||||
'audiobooks': _deduplicateResults(audiobooks),
|
||||
};
|
||||
} catch (e) {
|
||||
_logger.log('Error searching: $e');
|
||||
return <String, List<MediaItem>>{'artists': [], 'albums': [], 'tracks': []};
|
||||
return <String, List<MediaItem>>{'artists': [], 'albums': [], 'tracks': [], 'playlists': [], 'audiobooks': []};
|
||||
}
|
||||
},
|
||||
).catchError((e) {
|
||||
_logger.log('Error searching after retries: $e');
|
||||
return <String, List<MediaItem>>{'artists': [], 'albums': [], 'tracks': []};
|
||||
return <String, List<MediaItem>>{'artists': [], 'albums': [], 'tracks': [], 'playlists': [], 'audiobooks': []};
|
||||
});
|
||||
}
|
||||
|
||||
@@ -1493,6 +1528,7 @@ class MusicAssistantAPI {
|
||||
currentIndex = queueResult['current_index'] as int?;
|
||||
shuffleEnabled = queueResult['shuffle_enabled'] as bool?;
|
||||
repeatMode = queueResult['repeat_mode'] as String?;
|
||||
_logger.log('🔀 Queue metadata: shuffle_enabled=$shuffleEnabled, repeat_mode=$repeatMode');
|
||||
|
||||
final currentItemData = queueResult['current_item'] as Map<String, dynamic>?;
|
||||
final currentItemName = currentItemData?['name'] as String?;
|
||||
@@ -1579,6 +1615,25 @@ class MusicAssistantAPI {
|
||||
}
|
||||
}
|
||||
|
||||
/// Add a single track to the queue without starting playback
|
||||
Future<void> addTrackToQueue(String playerId, Track track) async {
|
||||
try {
|
||||
final uri = _buildTrackUri(track);
|
||||
|
||||
await _sendCommand(
|
||||
'player_queues/play_media',
|
||||
args: {
|
||||
'queue_id': playerId,
|
||||
'media': [uri],
|
||||
'option': 'add', // Add to queue without starting
|
||||
},
|
||||
);
|
||||
} catch (e) {
|
||||
_logger.log('Error adding track to queue: $e');
|
||||
rethrow;
|
||||
}
|
||||
}
|
||||
|
||||
/// Play multiple tracks via queue
|
||||
/// If clearQueue is true, replaces the queue (default behavior)
|
||||
/// If startIndex is provided, only tracks from that index onwards will be queued
|
||||
@@ -1973,12 +2028,51 @@ class MusicAssistantAPI {
|
||||
}
|
||||
}
|
||||
|
||||
/// Sync a player to a leader/group (temporary group)
|
||||
/// The player will join the leader's sync group and play the same audio
|
||||
Future<void> syncPlayerToLeader(String playerId, String leaderPlayerId) async {
|
||||
try {
|
||||
_logger.log('🔗 API syncPlayerToLeader called');
|
||||
_logger.log('🔗 player_id: $playerId');
|
||||
_logger.log('🔗 target_player: $leaderPlayerId');
|
||||
|
||||
final response = await _sendCommand(
|
||||
'players/cmd/group',
|
||||
args: {
|
||||
'player_id': playerId,
|
||||
'target_player': leaderPlayerId,
|
||||
},
|
||||
);
|
||||
_logger.log('✅ Player synced successfully, response: $response');
|
||||
} catch (e) {
|
||||
_logger.log('❌ Error syncing player: $e');
|
||||
rethrow;
|
||||
}
|
||||
}
|
||||
|
||||
/// Remove a player from its sync group
|
||||
Future<void> unsyncPlayer(String playerId) async {
|
||||
try {
|
||||
_logger.log('🔓 Unsyncing player: $playerId');
|
||||
await _sendCommand(
|
||||
'players/cmd/ungroup',
|
||||
args: {
|
||||
'player_id': playerId,
|
||||
},
|
||||
);
|
||||
_logger.log('✅ Player unsynced successfully');
|
||||
} catch (e) {
|
||||
_logger.log('Error unsyncing player: $e');
|
||||
rethrow;
|
||||
}
|
||||
}
|
||||
|
||||
/// Toggle shuffle mode for queue
|
||||
Future<void> toggleShuffle(String queueId) async {
|
||||
Future<void> toggleShuffle(String queueId, bool shuffleEnabled) async {
|
||||
try {
|
||||
await _sendCommand(
|
||||
'player_queues/shuffle',
|
||||
args: {'queue_id': queueId},
|
||||
args: {'queue_id': queueId, 'shuffle_enabled': shuffleEnabled},
|
||||
);
|
||||
} catch (e) {
|
||||
_logger.log('Error toggling shuffle: $e');
|
||||
@@ -2446,6 +2540,7 @@ class MusicAssistantAPI {
|
||||
}
|
||||
}
|
||||
} catch (e) {
|
||||
_logger.log('⚠️ Error parsing stream URI "$uri": $e');
|
||||
}
|
||||
}
|
||||
|
||||
@@ -2814,6 +2909,17 @@ class MusicAssistantAPI {
|
||||
_updateConnectionState(MAConnectionState.disconnected);
|
||||
await _channel?.sink.close();
|
||||
_channel = null;
|
||||
// Complete all pending requests with an error before clearing
|
||||
_cancelPendingRequests('Connection disconnected');
|
||||
}
|
||||
|
||||
/// Cancel all pending requests with an error message
|
||||
void _cancelPendingRequests(String reason) {
|
||||
for (final entry in _pendingRequests.entries) {
|
||||
if (!entry.value.isCompleted) {
|
||||
entry.value.completeError(Exception(reason));
|
||||
}
|
||||
}
|
||||
_pendingRequests.clear();
|
||||
}
|
||||
|
||||
|
||||
@@ -0,0 +1,138 @@
|
||||
import 'dart:convert';
|
||||
import 'package:shared_preferences/shared_preferences.dart';
|
||||
import 'debug_logger.dart';
|
||||
|
||||
/// Represents a queued action that will be executed when connection is restored
|
||||
class QueuedAction {
|
||||
final String type;
|
||||
final Map<String, dynamic> params;
|
||||
final DateTime queuedAt;
|
||||
|
||||
QueuedAction({
|
||||
required this.type,
|
||||
required this.params,
|
||||
required this.queuedAt,
|
||||
});
|
||||
|
||||
Map<String, dynamic> toJson() => {
|
||||
'type': type,
|
||||
'params': params,
|
||||
'queuedAt': queuedAt.toIso8601String(),
|
||||
};
|
||||
|
||||
factory QueuedAction.fromJson(Map<String, dynamic> json) => QueuedAction(
|
||||
type: json['type'] as String,
|
||||
params: json['params'] as Map<String, dynamic>,
|
||||
queuedAt: DateTime.parse(json['queuedAt'] as String),
|
||||
);
|
||||
}
|
||||
|
||||
/// Service for queuing actions when offline and executing them when back online
|
||||
class OfflineActionQueue {
|
||||
static OfflineActionQueue? _instance;
|
||||
static OfflineActionQueue get instance => _instance ??= OfflineActionQueue._();
|
||||
|
||||
OfflineActionQueue._();
|
||||
|
||||
final _logger = DebugLogger();
|
||||
static const _prefsKey = 'offline_action_queue';
|
||||
|
||||
List<QueuedAction> _queue = [];
|
||||
bool _isProcessing = false;
|
||||
|
||||
/// Get the current queue (for display)
|
||||
List<QueuedAction> get queue => List.unmodifiable(_queue);
|
||||
|
||||
/// Check if there are pending actions
|
||||
bool get hasPendingActions => _queue.isNotEmpty;
|
||||
|
||||
/// Number of pending actions
|
||||
int get pendingCount => _queue.length;
|
||||
|
||||
/// Initialize and load persisted queue
|
||||
Future<void> initialize() async {
|
||||
try {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
final queueJson = prefs.getString(_prefsKey);
|
||||
if (queueJson != null) {
|
||||
final List<dynamic> decoded = jsonDecode(queueJson);
|
||||
_queue = decoded.map((j) => QueuedAction.fromJson(j as Map<String, dynamic>)).toList();
|
||||
_logger.log('📋 Loaded ${_queue.length} offline actions from storage');
|
||||
}
|
||||
} catch (e) {
|
||||
_logger.log('⚠️ Error loading offline action queue: $e');
|
||||
}
|
||||
}
|
||||
|
||||
/// Queue an action for later execution
|
||||
Future<void> queueAction(String type, Map<String, dynamic> params) async {
|
||||
final action = QueuedAction(
|
||||
type: type,
|
||||
params: params,
|
||||
queuedAt: DateTime.now(),
|
||||
);
|
||||
_queue.add(action);
|
||||
await _persistQueue();
|
||||
_logger.log('📋 Queued offline action: $type');
|
||||
}
|
||||
|
||||
/// Process all queued actions (call when connection is restored)
|
||||
Future<void> processQueue(Future<bool> Function(QueuedAction action) executor) async {
|
||||
if (_isProcessing || _queue.isEmpty) return;
|
||||
|
||||
_isProcessing = true;
|
||||
_logger.log('🔄 Processing ${_queue.length} offline actions...');
|
||||
|
||||
final processed = <QueuedAction>[];
|
||||
|
||||
for (final action in _queue) {
|
||||
try {
|
||||
final success = await executor(action);
|
||||
if (success) {
|
||||
processed.add(action);
|
||||
_logger.log('✅ Processed offline action: ${action.type}');
|
||||
} else {
|
||||
_logger.log('⚠️ Failed to process offline action: ${action.type}');
|
||||
}
|
||||
} catch (e) {
|
||||
_logger.log('❌ Error processing offline action: $e');
|
||||
}
|
||||
}
|
||||
|
||||
// Remove processed actions
|
||||
_queue.removeWhere((a) => processed.contains(a));
|
||||
await _persistQueue();
|
||||
|
||||
_isProcessing = false;
|
||||
_logger.log('📋 ${processed.length} actions processed, ${_queue.length} remaining');
|
||||
}
|
||||
|
||||
/// Clear all queued actions
|
||||
Future<void> clearQueue() async {
|
||||
_queue.clear();
|
||||
await _persistQueue();
|
||||
_logger.log('🗑️ Offline action queue cleared');
|
||||
}
|
||||
|
||||
/// Persist queue to storage
|
||||
Future<void> _persistQueue() async {
|
||||
try {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
if (_queue.isEmpty) {
|
||||
await prefs.remove(_prefsKey);
|
||||
} else {
|
||||
final queueJson = jsonEncode(_queue.map((a) => a.toJson()).toList());
|
||||
await prefs.setString(_prefsKey, queueJson);
|
||||
}
|
||||
} catch (e) {
|
||||
_logger.log('⚠️ Error persisting offline action queue: $e');
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// Action types for offline queuing
|
||||
class OfflineActionTypes {
|
||||
static const String toggleFavorite = 'toggle_favorite';
|
||||
static const String addToPlaylist = 'add_to_playlist';
|
||||
static const String removeFromPlaylist = 'remove_from_playlist';
|
||||
}
|
||||
@@ -83,6 +83,11 @@ class PcmAudioPlayer {
|
||||
// Reduced from 8000 to 5000 frames (~104ms vs ~166ms) for faster response
|
||||
static const int _feedThreshold = 5000;
|
||||
|
||||
// Maximum buffer size to prevent memory overflow (~10 seconds of audio)
|
||||
// At 48kHz stereo 16-bit: 192KB/sec, so ~2MB for 10 seconds
|
||||
// Each chunk is ~4KB, so max ~500 chunks
|
||||
static const int _maxBufferChunks = 500;
|
||||
|
||||
// Stats
|
||||
int _framesPlayed = 0;
|
||||
int _bytesPlayed = 0;
|
||||
@@ -201,6 +206,16 @@ class PcmAudioPlayer {
|
||||
return true;
|
||||
}
|
||||
|
||||
/// Safely add audio data to buffer with overflow protection
|
||||
void _addToBuffer(Uint8List audioData) {
|
||||
// If buffer is full, drop oldest chunks to make room
|
||||
while (_audioBuffer.length >= _maxBufferChunks) {
|
||||
_audioBuffer.removeAt(0);
|
||||
_logger.log('⚠️ PcmAudioPlayer: Buffer overflow - dropping oldest chunk');
|
||||
}
|
||||
_audioBuffer.add(audioData);
|
||||
}
|
||||
|
||||
/// Handle incoming audio data from the stream
|
||||
void _onAudioData(Uint8List audioData) {
|
||||
// Ignore data if in error state
|
||||
@@ -215,7 +230,7 @@ class PcmAudioPlayer {
|
||||
if (_state == PcmPlayerState.paused && !_isAutoRecovering) {
|
||||
_logger.log('PcmAudioPlayer: Audio arriving while paused - initiating auto-recovery');
|
||||
_isAutoRecovering = true;
|
||||
_audioBuffer.add(audioData);
|
||||
_addToBuffer(audioData);
|
||||
|
||||
// Trigger async recovery
|
||||
_autoRecoverFromPause();
|
||||
@@ -224,7 +239,7 @@ class PcmAudioPlayer {
|
||||
|
||||
// If already recovering or in transitional state, buffer the data
|
||||
if (_isAutoRecovering) {
|
||||
_audioBuffer.add(audioData);
|
||||
_addToBuffer(audioData);
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -232,8 +247,8 @@ class PcmAudioPlayer {
|
||||
return;
|
||||
}
|
||||
|
||||
// Add to buffer
|
||||
_audioBuffer.add(audioData);
|
||||
// Add to buffer with overflow protection
|
||||
_addToBuffer(audioData);
|
||||
|
||||
// Start playback if not already started
|
||||
if (!_isStarted && _state == PcmPlayerState.ready) {
|
||||
|
||||
@@ -24,6 +24,10 @@ class PositionTracker {
|
||||
double _anchorPosition = 0.0; // Position in seconds at anchor time
|
||||
DateTime _anchorTime = DateTime.now(); // When we set the anchor
|
||||
|
||||
// Maximum time to interpolate from a stale anchor before capping
|
||||
// After this, we stop adding time to prevent indefinite drift
|
||||
static const Duration _maxAnchorAge = Duration(seconds: 30);
|
||||
|
||||
// Interpolation timer
|
||||
Timer? _interpolationTimer;
|
||||
|
||||
@@ -43,7 +47,13 @@ class PositionTracker {
|
||||
}
|
||||
|
||||
final now = DateTime.now();
|
||||
final elapsed = now.difference(_anchorTime).inMilliseconds / 1000.0;
|
||||
final anchorAge = now.difference(_anchorTime);
|
||||
|
||||
// Cap interpolation at max anchor age to prevent indefinite drift
|
||||
// If anchor is stale, return last known position (anchor + max age)
|
||||
final elapsed = anchorAge > _maxAnchorAge
|
||||
? _maxAnchorAge.inMilliseconds / 1000.0
|
||||
: anchorAge.inMilliseconds / 1000.0;
|
||||
final interpolated = _anchorPosition + elapsed;
|
||||
|
||||
// Cap at duration to prevent overflow
|
||||
@@ -61,7 +71,12 @@ class PositionTracker {
|
||||
}
|
||||
|
||||
final now = DateTime.now();
|
||||
final elapsed = now.difference(_anchorTime).inMilliseconds / 1000.0;
|
||||
final anchorAge = now.difference(_anchorTime);
|
||||
|
||||
// Cap interpolation at max anchor age to prevent indefinite drift
|
||||
final elapsed = anchorAge > _maxAnchorAge
|
||||
? _maxAnchorAge.inMilliseconds / 1000.0
|
||||
: anchorAge.inMilliseconds / 1000.0;
|
||||
final interpolated = _anchorPosition + elapsed;
|
||||
|
||||
// Cap at duration
|
||||
|
||||
@@ -25,6 +25,8 @@ class RecentlyPlayedService {
|
||||
if (!_db.isInitialized) return;
|
||||
|
||||
try {
|
||||
// Store images metadata for instant artwork display
|
||||
final images = album.metadata?['images'];
|
||||
await _db.addRecentlyPlayed(
|
||||
mediaId: album.itemId,
|
||||
mediaType: 'album',
|
||||
@@ -33,6 +35,7 @@ class RecentlyPlayedService {
|
||||
metadata: {
|
||||
'provider': album.provider,
|
||||
'uri': album.uri,
|
||||
if (images != null) 'images': images,
|
||||
},
|
||||
);
|
||||
_logger.log('📝 Recorded album play: ${album.name}');
|
||||
@@ -148,7 +151,16 @@ class RecentlyPlayedService {
|
||||
if (item.metadata != null) {
|
||||
try {
|
||||
metadata = jsonDecode(item.metadata!) as Map<String, dynamic>;
|
||||
} catch (_) {}
|
||||
} catch (e) {
|
||||
// Corrupted metadata JSON - log and continue with null metadata
|
||||
_logger.log('⚠️ Error parsing album metadata for ${item.mediaId}: $e');
|
||||
}
|
||||
}
|
||||
|
||||
// Build metadata with images if available (for instant artwork display)
|
||||
Map<String, dynamic>? albumMetadata;
|
||||
if (metadata?['images'] != null) {
|
||||
albumMetadata = {'images': metadata!['images']};
|
||||
}
|
||||
|
||||
albums.add(Album(
|
||||
@@ -160,6 +172,7 @@ class RecentlyPlayedService {
|
||||
artists: item.artistName != null
|
||||
? [Artist(itemId: '', provider: '', name: item.artistName!)]
|
||||
: null,
|
||||
metadata: albumMetadata,
|
||||
));
|
||||
|
||||
if (albums.length >= limit) break;
|
||||
@@ -193,7 +206,10 @@ class RecentlyPlayedService {
|
||||
if (item.metadata != null) {
|
||||
try {
|
||||
metadata = jsonDecode(item.metadata!) as Map<String, dynamic>;
|
||||
} catch (_) {}
|
||||
} catch (e) {
|
||||
// Corrupted metadata JSON - log and continue with null metadata
|
||||
_logger.log('⚠️ Error parsing audiobook metadata for ${item.mediaId}: $e');
|
||||
}
|
||||
}
|
||||
|
||||
audiobooks.add(Audiobook(
|
||||
|
||||
@@ -0,0 +1,148 @@
|
||||
import 'package:flutter_secure_storage/flutter_secure_storage.dart';
|
||||
import 'package:shared_preferences/shared_preferences.dart';
|
||||
import 'dart:convert';
|
||||
|
||||
/// Service for securely storing sensitive data like passwords and tokens.
|
||||
/// Uses platform-specific secure storage (Keychain on iOS, EncryptedSharedPreferences on Android).
|
||||
class SecureStorageService {
|
||||
static const _storage = FlutterSecureStorage(
|
||||
aOptions: AndroidOptions(
|
||||
encryptedSharedPreferences: true,
|
||||
),
|
||||
);
|
||||
|
||||
// Keys for secure storage
|
||||
static const String _keyAuthToken = 'secure_auth_token';
|
||||
static const String _keyMaAuthToken = 'secure_ma_auth_token';
|
||||
static const String _keyAuthCredentials = 'secure_auth_credentials';
|
||||
static const String _keyPassword = 'secure_password';
|
||||
static const String _keyAbsApiToken = 'secure_abs_api_token';
|
||||
|
||||
// Auth Token (for stream requests)
|
||||
static Future<String?> getAuthToken() async {
|
||||
return await _storage.read(key: _keyAuthToken);
|
||||
}
|
||||
|
||||
static Future<void> setAuthToken(String? token) async {
|
||||
if (token == null || token.isEmpty) {
|
||||
await _storage.delete(key: _keyAuthToken);
|
||||
} else {
|
||||
await _storage.write(key: _keyAuthToken, value: token);
|
||||
}
|
||||
}
|
||||
|
||||
// Music Assistant Native Auth Token (long-lived token)
|
||||
static Future<String?> getMaAuthToken() async {
|
||||
return await _storage.read(key: _keyMaAuthToken);
|
||||
}
|
||||
|
||||
static Future<void> setMaAuthToken(String? token) async {
|
||||
if (token == null || token.isEmpty) {
|
||||
await _storage.delete(key: _keyMaAuthToken);
|
||||
} else {
|
||||
await _storage.write(key: _keyMaAuthToken, value: token);
|
||||
}
|
||||
}
|
||||
|
||||
static Future<void> clearMaAuthToken() async {
|
||||
await _storage.delete(key: _keyMaAuthToken);
|
||||
}
|
||||
|
||||
// Auth Credentials (serialized auth strategy credentials)
|
||||
static Future<Map<String, dynamic>?> getAuthCredentials() async {
|
||||
final json = await _storage.read(key: _keyAuthCredentials);
|
||||
if (json == null) return null;
|
||||
try {
|
||||
return jsonDecode(json) as Map<String, dynamic>;
|
||||
} catch (e) {
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
||||
static Future<void> setAuthCredentials(Map<String, dynamic> credentials) async {
|
||||
await _storage.write(key: _keyAuthCredentials, value: jsonEncode(credentials));
|
||||
}
|
||||
|
||||
static Future<void> clearAuthCredentials() async {
|
||||
await _storage.delete(key: _keyAuthCredentials);
|
||||
}
|
||||
|
||||
// Password
|
||||
static Future<String?> getPassword() async {
|
||||
return await _storage.read(key: _keyPassword);
|
||||
}
|
||||
|
||||
static Future<void> setPassword(String? password) async {
|
||||
if (password == null || password.isEmpty) {
|
||||
await _storage.delete(key: _keyPassword);
|
||||
} else {
|
||||
await _storage.write(key: _keyPassword, value: password);
|
||||
}
|
||||
}
|
||||
|
||||
// Audiobookshelf API Token
|
||||
static Future<String?> getAbsApiToken() async {
|
||||
return await _storage.read(key: _keyAbsApiToken);
|
||||
}
|
||||
|
||||
static Future<void> setAbsApiToken(String? token) async {
|
||||
if (token == null || token.isEmpty) {
|
||||
await _storage.delete(key: _keyAbsApiToken);
|
||||
} else {
|
||||
await _storage.write(key: _keyAbsApiToken, value: token);
|
||||
}
|
||||
}
|
||||
|
||||
/// Clear all secure storage (used during logout)
|
||||
static Future<void> clearAll() async {
|
||||
await _storage.deleteAll();
|
||||
}
|
||||
|
||||
/// Migrate credentials from SharedPreferences to secure storage.
|
||||
/// Call this once during app upgrade to migrate existing users.
|
||||
static Future<void> migrateFromSharedPreferences() async {
|
||||
// Import SharedPreferences for migration
|
||||
final SharedPreferences prefs = await SharedPreferences.getInstance();
|
||||
|
||||
// Migrate auth token
|
||||
final authToken = prefs.getString('auth_token');
|
||||
if (authToken != null && authToken.isNotEmpty) {
|
||||
await setAuthToken(authToken);
|
||||
await prefs.remove('auth_token');
|
||||
}
|
||||
|
||||
// Migrate MA auth token
|
||||
final maAuthToken = prefs.getString('ma_auth_token');
|
||||
if (maAuthToken != null && maAuthToken.isNotEmpty) {
|
||||
await setMaAuthToken(maAuthToken);
|
||||
await prefs.remove('ma_auth_token');
|
||||
}
|
||||
|
||||
// Migrate auth credentials
|
||||
final authCredentials = prefs.getString('auth_credentials');
|
||||
if (authCredentials != null && authCredentials.isNotEmpty) {
|
||||
try {
|
||||
final decoded = jsonDecode(authCredentials) as Map<String, dynamic>;
|
||||
await setAuthCredentials(decoded);
|
||||
await prefs.remove('auth_credentials');
|
||||
} catch (_) {
|
||||
// Invalid JSON, just remove it
|
||||
await prefs.remove('auth_credentials');
|
||||
}
|
||||
}
|
||||
|
||||
// Migrate password
|
||||
final password = prefs.getString('password');
|
||||
if (password != null && password.isNotEmpty) {
|
||||
await setPassword(password);
|
||||
await prefs.remove('password');
|
||||
}
|
||||
|
||||
// Migrate ABS API token
|
||||
final absApiToken = prefs.getString('abs_api_token');
|
||||
if (absApiToken != null && absApiToken.isNotEmpty) {
|
||||
await setAbsApiToken(absApiToken);
|
||||
await prefs.remove('abs_api_token');
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -87,6 +87,9 @@ class SendspinService {
|
||||
// Auth token for proxy authentication (MA 2.7.1+)
|
||||
String? _authToken;
|
||||
|
||||
// Connection deduplication guard - prevents multiple concurrent auth attempts
|
||||
Completer<bool>? _connectionInProgress;
|
||||
|
||||
SendspinService(this.serverUrl);
|
||||
|
||||
/// Set the MA auth token for proxy authentication
|
||||
@@ -100,6 +103,13 @@ class SendspinService {
|
||||
if (_isDisposed) return false;
|
||||
if (_state == SendspinConnectionState.connected) return true;
|
||||
|
||||
// Deduplicate concurrent connection attempts
|
||||
if (_connectionInProgress != null) {
|
||||
_logger.log('Sendspin: Connection already in progress, waiting...');
|
||||
return _connectionInProgress!.future;
|
||||
}
|
||||
_connectionInProgress = Completer<bool>();
|
||||
|
||||
_updateState(SendspinConnectionState.connecting);
|
||||
|
||||
try {
|
||||
@@ -126,13 +136,19 @@ class SendspinService {
|
||||
if (!connected) {
|
||||
_logger.log('Sendspin: External proxy connection failed');
|
||||
_updateState(SendspinConnectionState.error);
|
||||
_connectionInProgress?.complete(false);
|
||||
_connectionInProgress = null;
|
||||
return false;
|
||||
}
|
||||
|
||||
_connectionInProgress?.complete(true);
|
||||
_connectionInProgress = null;
|
||||
return true;
|
||||
} catch (e) {
|
||||
_logger.log('Sendspin: Connection error: $e');
|
||||
_updateState(SendspinConnectionState.error);
|
||||
_connectionInProgress?.complete(false);
|
||||
_connectionInProgress = null;
|
||||
return false;
|
||||
}
|
||||
}
|
||||
@@ -142,6 +158,13 @@ class SendspinService {
|
||||
if (_isDisposed) return false;
|
||||
if (_state == SendspinConnectionState.connected) return true;
|
||||
|
||||
// Deduplicate concurrent connection attempts
|
||||
if (_connectionInProgress != null) {
|
||||
_logger.log('Sendspin: Connection already in progress, waiting...');
|
||||
return _connectionInProgress!.future;
|
||||
}
|
||||
_connectionInProgress = Completer<bool>();
|
||||
|
||||
_updateState(SendspinConnectionState.connecting);
|
||||
|
||||
try {
|
||||
@@ -154,13 +177,19 @@ class SendspinService {
|
||||
|
||||
if (!connected) {
|
||||
_updateState(SendspinConnectionState.error);
|
||||
_connectionInProgress?.complete(false);
|
||||
_connectionInProgress = null;
|
||||
return false;
|
||||
}
|
||||
|
||||
_connectionInProgress?.complete(true);
|
||||
_connectionInProgress = null;
|
||||
return true;
|
||||
} catch (e) {
|
||||
_logger.log('Sendspin: Connection error: $e');
|
||||
_updateState(SendspinConnectionState.error);
|
||||
_connectionInProgress?.complete(false);
|
||||
_connectionInProgress = null;
|
||||
return false;
|
||||
}
|
||||
}
|
||||
@@ -518,8 +547,9 @@ class SendspinService {
|
||||
if (muted != null) _isMuted = muted;
|
||||
|
||||
// Determine player state for Sendspin protocol
|
||||
// 'synchronized' = ready/playing, 'idle' = not playing
|
||||
final playerState = _isPlaying || _isPaused ? 'synchronized' : 'idle';
|
||||
// Valid values: 'synchronized', 'error', 'external_source'
|
||||
// When connected, we're always synchronized (ready to receive audio)
|
||||
const playerState = 'synchronized';
|
||||
|
||||
_sendMessage({
|
||||
'type': 'client/state',
|
||||
@@ -580,7 +610,7 @@ class SendspinService {
|
||||
_sendMessage({
|
||||
'type': 'client/time',
|
||||
'payload': {
|
||||
'timestamp': timestampMicroseconds,
|
||||
'client_transmitted': timestampMicroseconds,
|
||||
},
|
||||
}, allowDuringHandshake: allowDuringHandshake);
|
||||
}
|
||||
|
||||
@@ -1,5 +1,7 @@
|
||||
import 'package:shared_preferences/shared_preferences.dart';
|
||||
import 'dart:convert';
|
||||
import 'device_id_service.dart';
|
||||
import 'secure_storage_service.dart';
|
||||
|
||||
class SettingsService {
|
||||
static const String _keyServerUrl = 'server_url';
|
||||
@@ -22,6 +24,8 @@ class SettingsService {
|
||||
static const String _keyLocalPlayerName = 'local_player_name';
|
||||
static const String _keyOwnerName = 'owner_name';
|
||||
static const String _keyLastSelectedPlayerId = 'last_selected_player_id';
|
||||
static const String _keyPreferLocalPlayer = 'prefer_local_player';
|
||||
static const String _keySmartSortPlayers = 'smart_sort_players';
|
||||
static const String _keyShowRecentAlbums = 'show_recent_albums';
|
||||
static const String _keyShowDiscoverArtists = 'show_discover_artists';
|
||||
static const String _keyShowDiscoverAlbums = 'show_discover_albums';
|
||||
@@ -72,6 +76,11 @@ class SettingsService {
|
||||
static const String _keyEnabledAbsLibraries = 'enabled_abs_libraries'; // JSON list of library paths
|
||||
static const String _keyDiscoveredAbsLibraries = 'discovered_abs_libraries'; // JSON list of {path, name}
|
||||
|
||||
// Hint System Settings
|
||||
static const String _keyShowHints = 'show_hints'; // Master toggle for hints
|
||||
static const String _keyHasUsedPlayerReveal = 'has_used_player_reveal'; // Track if user has pulled to reveal players
|
||||
static const String _keyHasCompletedOnboarding = 'has_completed_onboarding'; // Track if user has seen welcome screen
|
||||
|
||||
static Future<String?> getServerUrl() async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
return prefs.getString(_keyServerUrl);
|
||||
@@ -119,66 +128,44 @@ class SettingsService {
|
||||
}
|
||||
}
|
||||
|
||||
// Get authentication token for stream requests
|
||||
// Get authentication token for stream requests (securely stored)
|
||||
static Future<String?> getAuthToken() async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
return prefs.getString(_keyAuthToken);
|
||||
return await SecureStorageService.getAuthToken();
|
||||
}
|
||||
|
||||
// Set authentication token for stream requests
|
||||
// Set authentication token for stream requests (securely stored)
|
||||
static Future<void> setAuthToken(String? token) async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
if (token == null || token.isEmpty) {
|
||||
await prefs.remove(_keyAuthToken);
|
||||
} else {
|
||||
await prefs.setString(_keyAuthToken, token);
|
||||
}
|
||||
await SecureStorageService.setAuthToken(token);
|
||||
}
|
||||
|
||||
// Get Music Assistant native auth token (long-lived token)
|
||||
// Get Music Assistant native auth token (long-lived token, securely stored)
|
||||
static Future<String?> getMaAuthToken() async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
return prefs.getString(_keyMaAuthToken);
|
||||
return await SecureStorageService.getMaAuthToken();
|
||||
}
|
||||
|
||||
// Set Music Assistant native auth token (long-lived token)
|
||||
// Set Music Assistant native auth token (long-lived token, securely stored)
|
||||
static Future<void> setMaAuthToken(String? token) async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
if (token == null || token.isEmpty) {
|
||||
await prefs.remove(_keyMaAuthToken);
|
||||
} else {
|
||||
await prefs.setString(_keyMaAuthToken, token);
|
||||
}
|
||||
await SecureStorageService.setMaAuthToken(token);
|
||||
}
|
||||
|
||||
// Clear Music Assistant native auth token
|
||||
static Future<void> clearMaAuthToken() async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
await prefs.remove(_keyMaAuthToken);
|
||||
await SecureStorageService.clearMaAuthToken();
|
||||
}
|
||||
|
||||
// Get authentication credentials (serialized auth strategy credentials)
|
||||
// Get authentication credentials (serialized auth strategy credentials, securely stored)
|
||||
static Future<Map<String, dynamic>?> getAuthCredentials() async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
final json = prefs.getString(_keyAuthCredentials);
|
||||
if (json == null) return null;
|
||||
try {
|
||||
return jsonDecode(json) as Map<String, dynamic>;
|
||||
} catch (e) {
|
||||
return null;
|
||||
}
|
||||
return await SecureStorageService.getAuthCredentials();
|
||||
}
|
||||
|
||||
// Set authentication credentials (serialized auth strategy credentials)
|
||||
// Set authentication credentials (serialized auth strategy credentials, securely stored)
|
||||
static Future<void> setAuthCredentials(Map<String, dynamic> credentials) async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
await prefs.setString(_keyAuthCredentials, jsonEncode(credentials));
|
||||
await SecureStorageService.setAuthCredentials(credentials);
|
||||
}
|
||||
|
||||
// Clear authentication credentials
|
||||
static Future<void> clearAuthCredentials() async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
await prefs.remove(_keyAuthCredentials);
|
||||
await SecureStorageService.clearAuthCredentials();
|
||||
}
|
||||
|
||||
// Get username for authentication
|
||||
@@ -197,20 +184,14 @@ class SettingsService {
|
||||
}
|
||||
}
|
||||
|
||||
// Get password for authentication
|
||||
// Get password for authentication (securely stored)
|
||||
static Future<String?> getPassword() async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
return prefs.getString(_keyPassword);
|
||||
return await SecureStorageService.getPassword();
|
||||
}
|
||||
|
||||
// Set password for authentication
|
||||
// Set password for authentication (securely stored)
|
||||
static Future<void> setPassword(String? password) async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
if (password == null || password.isEmpty) {
|
||||
await prefs.remove(_keyPassword);
|
||||
} else {
|
||||
await prefs.setString(_keyPassword, password);
|
||||
}
|
||||
await SecureStorageService.setPassword(password);
|
||||
}
|
||||
|
||||
// Get built-in player ID (persistent UUID for this device)
|
||||
@@ -364,19 +345,50 @@ class SettingsService {
|
||||
}
|
||||
}
|
||||
|
||||
// Prefer Local Player - always select local player first when available
|
||||
static Future<bool> getPreferLocalPlayer() async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
return prefs.getBool(_keyPreferLocalPlayer) ?? false;
|
||||
}
|
||||
|
||||
static Future<void> setPreferLocalPlayer(bool prefer) async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
await prefs.setBool(_keyPreferLocalPlayer, prefer);
|
||||
}
|
||||
|
||||
// Smart Sort Players - sort by status (playing > on > off) instead of alphabetically
|
||||
static Future<bool> getSmartSortPlayers() async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
return prefs.getBool(_keySmartSortPlayers) ?? false;
|
||||
}
|
||||
|
||||
static Future<void> setSmartSortPlayers(bool smartSort) async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
await prefs.setBool(_keySmartSortPlayers, smartSort);
|
||||
}
|
||||
|
||||
// Helper to create player name with possessive apostrophe
|
||||
// Automatically detects Phone vs Tablet based on screen size
|
||||
static String _makePlayerName(String ownerName) {
|
||||
// Handle possessive: "Chris" -> "Chris' Phone", "Mom" -> "Mom's Phone"
|
||||
final deviceType = DeviceIdService.isTablet ? 'Tablet' : 'Phone';
|
||||
// Handle possessive: "Chris" -> "Chris' Tablet", "Mom" -> "Mom's Phone"
|
||||
if (ownerName.toLowerCase().endsWith('s')) {
|
||||
return "$ownerName' Phone";
|
||||
return "$ownerName' $deviceType";
|
||||
} else {
|
||||
return "$ownerName's Phone";
|
||||
return "$ownerName's $deviceType";
|
||||
}
|
||||
}
|
||||
|
||||
static Future<void> clearSettings() async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
await prefs.clear();
|
||||
await SecureStorageService.clearAll(); // Also clear secure storage
|
||||
}
|
||||
|
||||
/// Migrate credentials from old SharedPreferences storage to secure storage.
|
||||
/// Should be called once during app startup for existing users.
|
||||
static Future<void> migrateToSecureStorage() async {
|
||||
await SecureStorageService.migrateFromSharedPreferences();
|
||||
}
|
||||
|
||||
// Home Screen Row Settings (Main rows - default on)
|
||||
@@ -642,13 +654,11 @@ class SettingsService {
|
||||
}
|
||||
|
||||
static Future<String?> getAbsApiToken() async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
return prefs.getString(_keyAbsApiToken);
|
||||
return await SecureStorageService.getAbsApiToken();
|
||||
}
|
||||
|
||||
static Future<void> setAbsApiToken(String token) async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
await prefs.setString(_keyAbsApiToken, token);
|
||||
await SecureStorageService.setAbsApiToken(token);
|
||||
}
|
||||
|
||||
static Future<bool> getAbsEnabled() async {
|
||||
@@ -664,8 +674,8 @@ class SettingsService {
|
||||
static Future<void> clearAbsSettings() async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
await prefs.remove(_keyAbsServerUrl);
|
||||
await prefs.remove(_keyAbsApiToken);
|
||||
await prefs.remove(_keyAbsEnabled);
|
||||
await SecureStorageService.setAbsApiToken(null); // Clear from secure storage
|
||||
}
|
||||
|
||||
// Audiobookshelf Library Settings (via MA browse API)
|
||||
@@ -738,4 +748,42 @@ class SettingsService {
|
||||
|
||||
await setEnabledAbsLibraries(enabled);
|
||||
}
|
||||
|
||||
// Hint System Settings
|
||||
|
||||
/// Get whether hints are enabled (default: true)
|
||||
static Future<bool> getShowHints() async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
return prefs.getBool(_keyShowHints) ?? true;
|
||||
}
|
||||
|
||||
/// Set whether hints are enabled
|
||||
static Future<void> setShowHints(bool show) async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
await prefs.setBool(_keyShowHints, show);
|
||||
}
|
||||
|
||||
/// Check if user has ever used the player reveal gesture
|
||||
static Future<bool> getHasUsedPlayerReveal() async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
return prefs.getBool(_keyHasUsedPlayerReveal) ?? false;
|
||||
}
|
||||
|
||||
/// Mark that user has used the player reveal gesture
|
||||
static Future<void> setHasUsedPlayerReveal(bool hasUsed) async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
await prefs.setBool(_keyHasUsedPlayerReveal, hasUsed);
|
||||
}
|
||||
|
||||
/// Check if user has completed onboarding (seen welcome screen)
|
||||
static Future<bool> getHasCompletedOnboarding() async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
return prefs.getBool(_keyHasCompletedOnboarding) ?? false;
|
||||
}
|
||||
|
||||
/// Mark that user has completed onboarding
|
||||
static Future<void> setHasCompletedOnboarding(bool completed) async {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
await prefs.setBool(_keyHasCompletedOnboarding, completed);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -4,7 +4,17 @@ import 'package:flutter/material.dart';
|
||||
const Color brandPrimaryColor = Color(0xFF1a1a1a);
|
||||
const Color brandAccentColor = Color(0xFF604CEC);
|
||||
|
||||
// Brand color schemes
|
||||
// Predefined accent colors for custom theme selection
|
||||
const List<Color> accentColorOptions = [
|
||||
Color(0xFF604CEC), // Purple (default)
|
||||
Color(0xFF2196F3), // Blue
|
||||
Color(0xFF009688), // Teal
|
||||
Color(0xFFFF5722), // Deep Orange
|
||||
Color(0xFFE91E63), // Pink
|
||||
Color(0xFF4CAF50), // Green
|
||||
];
|
||||
|
||||
// Brand color schemes (default)
|
||||
final ColorScheme brandLightColorScheme = ColorScheme.fromSeed(
|
||||
seedColor: brandAccentColor,
|
||||
brightness: Brightness.light,
|
||||
@@ -21,6 +31,27 @@ final ColorScheme brandDarkColorScheme = ColorScheme.fromSeed(
|
||||
background: const Color(0xFF1a1a1a),
|
||||
);
|
||||
|
||||
// Generate color schemes from a custom seed color
|
||||
ColorScheme generateLightColorScheme(Color seedColor) {
|
||||
return ColorScheme.fromSeed(
|
||||
seedColor: seedColor,
|
||||
brightness: Brightness.light,
|
||||
background: const Color(0xFFFAFAFA),
|
||||
onBackground: const Color(0xFF1a1a1a),
|
||||
surface: const Color(0xFFFFFFFF),
|
||||
onSurface: const Color(0xFF1a1a1a),
|
||||
);
|
||||
}
|
||||
|
||||
ColorScheme generateDarkColorScheme(Color seedColor) {
|
||||
return ColorScheme.fromSeed(
|
||||
seedColor: seedColor,
|
||||
brightness: Brightness.dark,
|
||||
surface: const Color(0xFF2a2a2a),
|
||||
background: const Color(0xFF1a1a1a),
|
||||
);
|
||||
}
|
||||
|
||||
class AppTheme {
|
||||
// Generate light theme
|
||||
static ThemeData lightTheme({ColorScheme? colorScheme}) {
|
||||
|
||||
@@ -97,6 +97,7 @@ class _AlbumCardState extends State<AlbumCard> {
|
||||
child: AlbumDetailsScreen(
|
||||
album: widget.album,
|
||||
heroTagSuffix: widget.heroTagSuffix,
|
||||
initialImageUrl: imageUrl,
|
||||
),
|
||||
),
|
||||
);
|
||||
@@ -119,7 +120,8 @@ class _AlbumCardState extends State<AlbumCard> {
|
||||
fit: BoxFit.cover,
|
||||
memCacheWidth: 256,
|
||||
memCacheHeight: 256,
|
||||
fadeInDuration: const Duration(milliseconds: 150),
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (context, url) => const SizedBox(),
|
||||
errorWidget: (context, url, error) {
|
||||
// Try fallback on error (only for MA URLs, not fallback URLs)
|
||||
|
||||
+111
-69
@@ -1,5 +1,6 @@
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:provider/provider.dart';
|
||||
import 'package:cached_network_image/cached_network_image.dart';
|
||||
import '../models/media_item.dart';
|
||||
import '../providers/music_assistant_provider.dart';
|
||||
import '../services/debug_logger.dart';
|
||||
@@ -10,6 +11,8 @@ class AlbumRow extends StatefulWidget {
|
||||
final Future<List<Album>> Function() loadAlbums;
|
||||
final String? heroTagSuffix;
|
||||
final double? rowHeight;
|
||||
/// Optional: synchronous getter for cached data (for instant display)
|
||||
final List<Album>? Function()? getCachedAlbums;
|
||||
|
||||
const AlbumRow({
|
||||
super.key,
|
||||
@@ -17,6 +20,7 @@ class AlbumRow extends StatefulWidget {
|
||||
required this.loadAlbums,
|
||||
this.heroTagSuffix,
|
||||
this.rowHeight,
|
||||
this.getCachedAlbums,
|
||||
});
|
||||
|
||||
@override
|
||||
@@ -24,8 +28,8 @@ class AlbumRow extends StatefulWidget {
|
||||
}
|
||||
|
||||
class _AlbumRowState extends State<AlbumRow> with AutomaticKeepAliveClientMixin {
|
||||
late Future<List<Album>> _albumsFuture;
|
||||
List<Album>? _cachedAlbums; // Keep last loaded data to prevent flash
|
||||
List<Album> _albums = [];
|
||||
bool _isLoading = true;
|
||||
bool _hasLoaded = false;
|
||||
|
||||
@override
|
||||
@@ -34,21 +38,117 @@ class _AlbumRowState extends State<AlbumRow> with AutomaticKeepAliveClientMixin
|
||||
@override
|
||||
void initState() {
|
||||
super.initState();
|
||||
_loadAlbumsOnce();
|
||||
_loadAlbums();
|
||||
}
|
||||
|
||||
void _loadAlbumsOnce() {
|
||||
if (!_hasLoaded) {
|
||||
_albumsFuture = widget.loadAlbums().then((albums) {
|
||||
_cachedAlbums = albums;
|
||||
return albums;
|
||||
});
|
||||
_hasLoaded = true;
|
||||
Future<void> _loadAlbums() async {
|
||||
if (_hasLoaded) return;
|
||||
_hasLoaded = true;
|
||||
|
||||
// 1. Try to get cached data synchronously for instant display
|
||||
final cachedAlbums = widget.getCachedAlbums?.call();
|
||||
if (cachedAlbums != null && cachedAlbums.isNotEmpty) {
|
||||
if (mounted) {
|
||||
setState(() {
|
||||
_albums = cachedAlbums;
|
||||
_isLoading = false;
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
// 2. Load fresh data (always update - fresh data may have images that cached data lacks)
|
||||
try {
|
||||
final freshAlbums = await widget.loadAlbums();
|
||||
if (mounted && freshAlbums.isNotEmpty) {
|
||||
setState(() {
|
||||
_albums = freshAlbums;
|
||||
_isLoading = false;
|
||||
});
|
||||
// Pre-cache images for smooth hero animations
|
||||
_precacheAlbumImages(freshAlbums);
|
||||
}
|
||||
} catch (e) {
|
||||
// Silent failure - keep showing cached data
|
||||
}
|
||||
|
||||
if (mounted && _isLoading) {
|
||||
setState(() => _isLoading = false);
|
||||
}
|
||||
}
|
||||
|
||||
/// Pre-cache album images so hero animations are smooth on first tap
|
||||
void _precacheAlbumImages(List<Album> albums) {
|
||||
if (!mounted) return;
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
|
||||
// Only precache first ~10 visible items to avoid excessive network/memory use
|
||||
final albumsToCache = albums.take(10);
|
||||
|
||||
for (final album in albumsToCache) {
|
||||
final imageUrl = maProvider.api?.getImageUrl(album, size: 256);
|
||||
if (imageUrl != null) {
|
||||
// Use CachedNetworkImageProvider to warm the cache
|
||||
precacheImage(
|
||||
CachedNetworkImageProvider(imageUrl),
|
||||
context,
|
||||
).catchError((_) {
|
||||
// Silently ignore precache errors
|
||||
return false;
|
||||
});
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
static final _logger = DebugLogger();
|
||||
|
||||
Widget _buildContent(double contentHeight, ColorScheme colorScheme) {
|
||||
// Only show loading if we have no data at all
|
||||
if (_albums.isEmpty && _isLoading) {
|
||||
return const Center(child: CircularProgressIndicator());
|
||||
}
|
||||
|
||||
if (_albums.isEmpty) {
|
||||
return Center(
|
||||
child: Text(
|
||||
'No albums found',
|
||||
style: TextStyle(color: colorScheme.onSurface.withOpacity(0.5)),
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
// Card layout: square artwork + text below
|
||||
// Text area: 8px gap + ~18px title + ~18px artist = ~44px
|
||||
const textAreaHeight = 44.0;
|
||||
final artworkSize = contentHeight - textAreaHeight;
|
||||
final cardWidth = artworkSize; // Card width = artwork width (square)
|
||||
final itemExtent = cardWidth + 12; // width + horizontal margins
|
||||
|
||||
return ScrollConfiguration(
|
||||
behavior: const _StretchScrollBehavior(),
|
||||
child: ListView.builder(
|
||||
scrollDirection: Axis.horizontal,
|
||||
padding: const EdgeInsets.symmetric(horizontal: 12.0),
|
||||
itemCount: _albums.length,
|
||||
itemExtent: itemExtent,
|
||||
cacheExtent: 500, // Preload ~3 items ahead for smoother scrolling
|
||||
addAutomaticKeepAlives: false, // Row already uses AutomaticKeepAliveClientMixin
|
||||
addRepaintBoundaries: false, // Cards already have RepaintBoundary
|
||||
itemBuilder: (context, index) {
|
||||
final album = _albums[index];
|
||||
return Container(
|
||||
key: ValueKey(album.uri ?? album.itemId),
|
||||
width: cardWidth,
|
||||
margin: const EdgeInsets.symmetric(horizontal: 6.0),
|
||||
child: AlbumCard(
|
||||
album: album,
|
||||
heroTagSuffix: widget.heroTagSuffix,
|
||||
),
|
||||
);
|
||||
},
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
_logger.startBuild('AlbumRow:${widget.title}');
|
||||
@@ -78,65 +178,7 @@ class _AlbumRowState extends State<AlbumRow> with AutomaticKeepAliveClientMixin
|
||||
),
|
||||
),
|
||||
Expanded(
|
||||
child: FutureBuilder<List<Album>>(
|
||||
future: _albumsFuture,
|
||||
builder: (context, snapshot) {
|
||||
// Use cached data immediately if available (prevents flash on rebuild)
|
||||
final albums = snapshot.data ?? _cachedAlbums;
|
||||
|
||||
// Only show loading if we have no data at all
|
||||
if (albums == null && snapshot.connectionState == ConnectionState.waiting) {
|
||||
return const Center(child: CircularProgressIndicator());
|
||||
}
|
||||
|
||||
if (snapshot.hasError && albums == null) {
|
||||
return Center(
|
||||
child: Text('Error: ${snapshot.error}'),
|
||||
);
|
||||
}
|
||||
|
||||
if (albums == null || albums.isEmpty) {
|
||||
return Center(
|
||||
child: Text(
|
||||
'No albums found',
|
||||
style: TextStyle(color: colorScheme.onSurface.withOpacity(0.5)),
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
// Card layout: square artwork + text below
|
||||
// Text area: 8px gap + ~18px title + ~18px artist = ~44px
|
||||
const textAreaHeight = 44.0;
|
||||
final artworkSize = contentHeight - textAreaHeight;
|
||||
final cardWidth = artworkSize; // Card width = artwork width (square)
|
||||
final itemExtent = cardWidth + 12; // width + horizontal margins
|
||||
|
||||
return ScrollConfiguration(
|
||||
behavior: const _StretchScrollBehavior(),
|
||||
child: ListView.builder(
|
||||
scrollDirection: Axis.horizontal,
|
||||
padding: const EdgeInsets.symmetric(horizontal: 12.0),
|
||||
itemCount: albums.length,
|
||||
itemExtent: itemExtent,
|
||||
cacheExtent: 500, // Preload ~3 items ahead for smoother scrolling
|
||||
addAutomaticKeepAlives: false, // Row already uses AutomaticKeepAliveClientMixin
|
||||
addRepaintBoundaries: false, // Cards already have RepaintBoundary
|
||||
itemBuilder: (context, index) {
|
||||
final album = albums[index];
|
||||
return Container(
|
||||
key: ValueKey(album.uri ?? album.itemId),
|
||||
width: cardWidth,
|
||||
margin: const EdgeInsets.symmetric(horizontal: 6.0),
|
||||
child: AlbumCard(
|
||||
album: album,
|
||||
heroTagSuffix: widget.heroTagSuffix,
|
||||
),
|
||||
);
|
||||
},
|
||||
),
|
||||
);
|
||||
},
|
||||
),
|
||||
child: _buildContent(contentHeight, colorScheme),
|
||||
),
|
||||
],
|
||||
),
|
||||
|
||||
@@ -100,6 +100,8 @@ class _ArtistAvatarState extends State<ArtistAvatar> {
|
||||
width: widget.radius * 2,
|
||||
height: widget.radius * 2,
|
||||
fit: BoxFit.cover,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (context, url) => Container(
|
||||
color: colorScheme.surfaceVariant,
|
||||
child: Icon(Icons.person_rounded, color: colorScheme.onSurfaceVariant),
|
||||
|
||||
@@ -100,49 +100,50 @@ class _ArtistCardState extends State<ArtistCard> {
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.center,
|
||||
children: [
|
||||
// Artist image - circular, constrained to be a proper circle
|
||||
Expanded(
|
||||
child: Center(
|
||||
child: LayoutBuilder(
|
||||
builder: (context, constraints) {
|
||||
// Use the smaller dimension to ensure a circle
|
||||
final size = constraints.maxWidth < constraints.maxHeight
|
||||
? constraints.maxWidth
|
||||
: constraints.maxHeight;
|
||||
return Hero(
|
||||
tag: HeroTags.artistImage + (widget.artist.uri ?? widget.artist.itemId) + suffix,
|
||||
child: ClipOval(
|
||||
child: Container(
|
||||
width: size,
|
||||
height: size,
|
||||
color: colorScheme.surfaceVariant,
|
||||
child: imageUrl != null
|
||||
? CachedNetworkImage(
|
||||
imageUrl: imageUrl,
|
||||
fit: BoxFit.cover,
|
||||
memCacheWidth: 256,
|
||||
memCacheHeight: 256,
|
||||
fadeInDuration: const Duration(milliseconds: 150),
|
||||
placeholder: (context, url) => const SizedBox(),
|
||||
errorWidget: (context, url, error) {
|
||||
// Try fallback on error (only for MA URLs, not fallback URLs)
|
||||
if (!_maImageFailed && url == maImageUrl) {
|
||||
WidgetsBinding.instance.addPostFrameCallback((_) {
|
||||
_onImageError();
|
||||
});
|
||||
}
|
||||
return Icon(
|
||||
Icons.person_rounded,
|
||||
size: size * 0.55,
|
||||
color: colorScheme.onSurfaceVariant,
|
||||
);
|
||||
},
|
||||
)
|
||||
: Icon(Icons.person_rounded, size: size * 0.55, color: colorScheme.onSurfaceVariant),
|
||||
),
|
||||
),
|
||||
);
|
||||
},
|
||||
// Artist image - circular
|
||||
// PERF: Use AspectRatio instead of LayoutBuilder to provide fixed geometry
|
||||
// before Hero animation starts. This prevents grey icon flash caused by
|
||||
// dynamic sizing inside the Hero widget.
|
||||
AspectRatio(
|
||||
aspectRatio: 1.0,
|
||||
child: Hero(
|
||||
tag: HeroTags.artistImage + (widget.artist.uri ?? widget.artist.itemId) + suffix,
|
||||
child: ClipOval(
|
||||
child: Container(
|
||||
color: colorScheme.surfaceVariant,
|
||||
child: imageUrl != null
|
||||
? CachedNetworkImage(
|
||||
imageUrl: imageUrl,
|
||||
fit: BoxFit.cover,
|
||||
memCacheWidth: 256,
|
||||
memCacheHeight: 256,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (context, url) => const SizedBox(),
|
||||
errorWidget: (context, url, error) {
|
||||
// Try fallback on error (only for MA URLs, not fallback URLs)
|
||||
if (!_maImageFailed && url == maImageUrl) {
|
||||
WidgetsBinding.instance.addPostFrameCallback((_) {
|
||||
_onImageError();
|
||||
});
|
||||
}
|
||||
return Center(
|
||||
child: Icon(
|
||||
Icons.person_rounded,
|
||||
size: 64,
|
||||
color: colorScheme.onSurfaceVariant,
|
||||
),
|
||||
);
|
||||
},
|
||||
)
|
||||
: Center(
|
||||
child: Icon(
|
||||
Icons.person_rounded,
|
||||
size: 64,
|
||||
color: colorScheme.onSurfaceVariant,
|
||||
),
|
||||
),
|
||||
),
|
||||
),
|
||||
),
|
||||
),
|
||||
|
||||
+111
-69
@@ -1,5 +1,6 @@
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:provider/provider.dart';
|
||||
import 'package:cached_network_image/cached_network_image.dart';
|
||||
import '../models/media_item.dart';
|
||||
import '../providers/music_assistant_provider.dart';
|
||||
import '../services/debug_logger.dart';
|
||||
@@ -10,6 +11,8 @@ class ArtistRow extends StatefulWidget {
|
||||
final Future<List<Artist>> Function() loadArtists;
|
||||
final String? heroTagSuffix;
|
||||
final double? rowHeight;
|
||||
/// Optional: synchronous getter for cached data (for instant display)
|
||||
final List<Artist>? Function()? getCachedArtists;
|
||||
|
||||
const ArtistRow({
|
||||
super.key,
|
||||
@@ -17,6 +20,7 @@ class ArtistRow extends StatefulWidget {
|
||||
required this.loadArtists,
|
||||
this.heroTagSuffix,
|
||||
this.rowHeight,
|
||||
this.getCachedArtists,
|
||||
});
|
||||
|
||||
@override
|
||||
@@ -24,8 +28,8 @@ class ArtistRow extends StatefulWidget {
|
||||
}
|
||||
|
||||
class _ArtistRowState extends State<ArtistRow> with AutomaticKeepAliveClientMixin {
|
||||
late Future<List<Artist>> _artistsFuture;
|
||||
List<Artist>? _cachedArtists; // Keep last loaded data to prevent flash
|
||||
List<Artist> _artists = [];
|
||||
bool _isLoading = true;
|
||||
bool _hasLoaded = false;
|
||||
|
||||
@override
|
||||
@@ -34,21 +38,117 @@ class _ArtistRowState extends State<ArtistRow> with AutomaticKeepAliveClientMixi
|
||||
@override
|
||||
void initState() {
|
||||
super.initState();
|
||||
_loadArtistsOnce();
|
||||
_loadArtists();
|
||||
}
|
||||
|
||||
void _loadArtistsOnce() {
|
||||
if (!_hasLoaded) {
|
||||
_artistsFuture = widget.loadArtists().then((artists) {
|
||||
_cachedArtists = artists;
|
||||
return artists;
|
||||
});
|
||||
_hasLoaded = true;
|
||||
Future<void> _loadArtists() async {
|
||||
if (_hasLoaded) return;
|
||||
_hasLoaded = true;
|
||||
|
||||
// 1. Try to get cached data synchronously for instant display
|
||||
final cachedArtists = widget.getCachedArtists?.call();
|
||||
if (cachedArtists != null && cachedArtists.isNotEmpty) {
|
||||
if (mounted) {
|
||||
setState(() {
|
||||
_artists = cachedArtists;
|
||||
_isLoading = false;
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
// 2. Load fresh data (always update - fresh data may have images that cached data lacks)
|
||||
try {
|
||||
final freshArtists = await widget.loadArtists();
|
||||
if (mounted && freshArtists.isNotEmpty) {
|
||||
setState(() {
|
||||
_artists = freshArtists;
|
||||
_isLoading = false;
|
||||
});
|
||||
// Pre-cache images for smooth hero animations
|
||||
_precacheArtistImages(freshArtists);
|
||||
}
|
||||
} catch (e) {
|
||||
// Silent failure - keep showing cached data
|
||||
}
|
||||
|
||||
if (mounted && _isLoading) {
|
||||
setState(() => _isLoading = false);
|
||||
}
|
||||
}
|
||||
|
||||
/// Pre-cache artist images so hero animations are smooth on first tap
|
||||
void _precacheArtistImages(List<Artist> artists) {
|
||||
if (!mounted) return;
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
|
||||
// Only precache first ~10 visible items to avoid excessive network/memory use
|
||||
final artistsToCache = artists.take(10);
|
||||
|
||||
for (final artist in artistsToCache) {
|
||||
final imageUrl = maProvider.api?.getImageUrl(artist, size: 256);
|
||||
if (imageUrl != null) {
|
||||
// Use CachedNetworkImageProvider to warm the cache
|
||||
precacheImage(
|
||||
CachedNetworkImageProvider(imageUrl),
|
||||
context,
|
||||
).catchError((_) {
|
||||
// Silently ignore precache errors
|
||||
return false;
|
||||
});
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
static final _logger = DebugLogger();
|
||||
|
||||
Widget _buildContent(double contentHeight, ColorScheme colorScheme) {
|
||||
// Only show loading if we have no data at all
|
||||
if (_artists.isEmpty && _isLoading) {
|
||||
return const Center(child: CircularProgressIndicator());
|
||||
}
|
||||
|
||||
if (_artists.isEmpty) {
|
||||
return Center(
|
||||
child: Text(
|
||||
'No artists found',
|
||||
style: TextStyle(color: colorScheme.onSurface.withOpacity(0.5)),
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
// Card layout: circle image + name below
|
||||
// Text area: 8px gap + ~36px for 2-line name = ~44px
|
||||
const textAreaHeight = 44.0;
|
||||
final imageSize = contentHeight - textAreaHeight;
|
||||
final cardWidth = imageSize; // Card width = image width (circle)
|
||||
final itemExtent = cardWidth + 16; // width + horizontal margins
|
||||
|
||||
return ScrollConfiguration(
|
||||
behavior: const _StretchScrollBehavior(),
|
||||
child: ListView.builder(
|
||||
scrollDirection: Axis.horizontal,
|
||||
padding: const EdgeInsets.symmetric(horizontal: 12.0),
|
||||
itemCount: _artists.length,
|
||||
itemExtent: itemExtent,
|
||||
cacheExtent: 500, // Preload ~3 items ahead for smoother scrolling
|
||||
addAutomaticKeepAlives: false, // Row already uses AutomaticKeepAliveClientMixin
|
||||
addRepaintBoundaries: false, // Cards already have RepaintBoundary
|
||||
itemBuilder: (context, index) {
|
||||
final artist = _artists[index];
|
||||
return Container(
|
||||
key: ValueKey(artist.uri ?? artist.itemId),
|
||||
width: cardWidth,
|
||||
margin: const EdgeInsets.symmetric(horizontal: 8.0),
|
||||
child: ArtistCard(
|
||||
artist: artist,
|
||||
heroTagSuffix: widget.heroTagSuffix,
|
||||
),
|
||||
);
|
||||
},
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
_logger.startBuild('ArtistRow:${widget.title}');
|
||||
@@ -78,65 +178,7 @@ class _ArtistRowState extends State<ArtistRow> with AutomaticKeepAliveClientMixi
|
||||
),
|
||||
),
|
||||
Expanded(
|
||||
child: FutureBuilder<List<Artist>>(
|
||||
future: _artistsFuture,
|
||||
builder: (context, snapshot) {
|
||||
// Use cached data immediately if available (prevents flash on rebuild)
|
||||
final artists = snapshot.data ?? _cachedArtists;
|
||||
|
||||
// Only show loading if we have no data at all
|
||||
if (artists == null && snapshot.connectionState == ConnectionState.waiting) {
|
||||
return const Center(child: CircularProgressIndicator());
|
||||
}
|
||||
|
||||
if (snapshot.hasError && artists == null) {
|
||||
return Center(
|
||||
child: Text('Error: ${snapshot.error}'),
|
||||
);
|
||||
}
|
||||
|
||||
if (artists == null || artists.isEmpty) {
|
||||
return Center(
|
||||
child: Text(
|
||||
'No artists found',
|
||||
style: TextStyle(color: colorScheme.onSurface.withOpacity(0.5)),
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
// Card layout: circle image + name below
|
||||
// Text area: 8px gap + ~36px for 2-line name = ~44px
|
||||
const textAreaHeight = 44.0;
|
||||
final imageSize = contentHeight - textAreaHeight;
|
||||
final cardWidth = imageSize; // Card width = image width (circle)
|
||||
final itemExtent = cardWidth + 16; // width + horizontal margins
|
||||
|
||||
return ScrollConfiguration(
|
||||
behavior: const _StretchScrollBehavior(),
|
||||
child: ListView.builder(
|
||||
scrollDirection: Axis.horizontal,
|
||||
padding: const EdgeInsets.symmetric(horizontal: 12.0),
|
||||
itemCount: artists.length,
|
||||
itemExtent: itemExtent,
|
||||
cacheExtent: 500, // Preload ~3 items ahead for smoother scrolling
|
||||
addAutomaticKeepAlives: false, // Row already uses AutomaticKeepAliveClientMixin
|
||||
addRepaintBoundaries: false, // Cards already have RepaintBoundary
|
||||
itemBuilder: (context, index) {
|
||||
final artist = artists[index];
|
||||
return Container(
|
||||
key: ValueKey(artist.uri ?? artist.itemId),
|
||||
width: cardWidth,
|
||||
margin: const EdgeInsets.symmetric(horizontal: 8.0),
|
||||
child: ArtistCard(
|
||||
artist: artist,
|
||||
heroTagSuffix: widget.heroTagSuffix,
|
||||
),
|
||||
);
|
||||
},
|
||||
),
|
||||
);
|
||||
},
|
||||
),
|
||||
child: _buildContent(contentHeight, colorScheme),
|
||||
),
|
||||
],
|
||||
),
|
||||
|
||||
@@ -173,6 +173,7 @@ class _AudiobookCard extends StatelessWidget {
|
||||
child: AudiobookDetailScreen(
|
||||
audiobook: audiobook,
|
||||
heroTagSuffix: heroTagSuffix,
|
||||
initialImageUrl: imageUrl,
|
||||
),
|
||||
),
|
||||
);
|
||||
@@ -195,6 +196,11 @@ class _AudiobookCard extends StatelessWidget {
|
||||
? CachedNetworkImage(
|
||||
imageUrl: imageUrl,
|
||||
fit: BoxFit.cover,
|
||||
// PERF: Duration.zero for hero-wrapped images
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
memCacheWidth: 256,
|
||||
memCacheHeight: 256,
|
||||
placeholder: (_, __) => Center(
|
||||
child: Icon(
|
||||
MdiIcons.bookOutline,
|
||||
|
||||
+432
-209
@@ -15,6 +15,7 @@ import 'animated_icon_button.dart';
|
||||
import 'global_player_overlay.dart';
|
||||
import 'volume_control.dart';
|
||||
import 'player/player_widgets.dart';
|
||||
import 'player/mini_player_content.dart';
|
||||
|
||||
/// A unified player widget that seamlessly expands from mini to full-screen.
|
||||
///
|
||||
@@ -31,11 +32,21 @@ class ExpandablePlayer extends StatefulWidget {
|
||||
/// Callback when swipe-down gesture triggers player reveal
|
||||
final VoidCallback? onRevealPlayers;
|
||||
|
||||
/// Whether the device reveal overlay is currently visible
|
||||
/// When true, shows player name instead of track name in collapsed state
|
||||
final bool isDeviceRevealVisible;
|
||||
|
||||
/// Whether the hint text should be shown
|
||||
/// When true, shows "Pull to select players" instead of track info
|
||||
final bool isHintVisible;
|
||||
|
||||
const ExpandablePlayer({
|
||||
super.key,
|
||||
this.slideOffset = 0.0,
|
||||
this.bounceOffset = 0.0,
|
||||
this.onRevealPlayers,
|
||||
this.isDeviceRevealVisible = false,
|
||||
this.isHintVisible = false,
|
||||
});
|
||||
|
||||
@override
|
||||
@@ -66,13 +77,16 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
final ValueNotifier<double?> _seekPositionNotifier = ValueNotifier<double?>(null);
|
||||
|
||||
// Dimensions
|
||||
static const double _collapsedHeight = 64.0;
|
||||
static double get _collapsedHeight => MiniPlayerLayout.height;
|
||||
static const double _collapsedMargin = 12.0; // Increased from 8 to 12 (4px more gap above nav bar)
|
||||
static const double _collapsedBorderRadius = 16.0;
|
||||
static const double _collapsedArtSize = 64.0;
|
||||
static double get _collapsedArtSize => MiniPlayerLayout.artSize;
|
||||
static const double _bottomNavHeight = 56.0;
|
||||
static const double _edgeDeadZone = 40.0; // Dead zone for Android back gesture
|
||||
|
||||
// Pastel yellow for grouped players (matches PlayerCard.groupBorderColor)
|
||||
static const Color _groupBorderColor = Color(0xFFFFF59D);
|
||||
|
||||
// Track horizontal drag start position
|
||||
double? _horizontalDragStartX;
|
||||
|
||||
@@ -90,6 +104,12 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
// When true, we hide main content and show peek content at center
|
||||
bool _inTransition = false;
|
||||
|
||||
// Volume swipe state (only active when device reveal is visible)
|
||||
bool _isDraggingVolume = false;
|
||||
double _dragVolumeLevel = 0.0;
|
||||
int _lastVolumeUpdateTime = 0;
|
||||
static const int _volumeThrottleMs = 150; // Only send volume updates every 150ms
|
||||
|
||||
// Track favorite state for current track
|
||||
bool _isCurrentTrackFavorite = false;
|
||||
String? _lastTrackUri; // Track which track we last checked favorite status for
|
||||
@@ -150,7 +170,9 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
);
|
||||
|
||||
_controller.addStatusListener((status) {
|
||||
if (status == AnimationStatus.forward) {
|
||||
// PERF: Load queue after animation completes, not during
|
||||
// This prevents network I/O from competing with animation frames
|
||||
if (status == AnimationStatus.completed) {
|
||||
_loadQueue();
|
||||
} else if (status == AnimationStatus.dismissed) {
|
||||
// Close queue panel when player collapses
|
||||
@@ -320,24 +342,69 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
Future<void> _loadQueue() async {
|
||||
if (_isLoadingQueue) return;
|
||||
|
||||
setState(() => _isLoadingQueue = true);
|
||||
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
final player = maProvider.selectedPlayer;
|
||||
|
||||
if (player != null && maProvider.api != null) {
|
||||
final queue = await maProvider.api!.getQueue(player.playerId);
|
||||
if (mounted) {
|
||||
if (player == null) {
|
||||
if (mounted) setState(() => _isLoadingQueue = false);
|
||||
return;
|
||||
}
|
||||
|
||||
// 1. Show cached queue immediately (if available)
|
||||
// Only load from cache if we don't already have a queue (preserves optimistic updates)
|
||||
if (_queue == null) {
|
||||
final cachedQueue = await maProvider.getCachedQueue(player.playerId);
|
||||
if (cachedQueue != null && cachedQueue.items.isNotEmpty && mounted) {
|
||||
setState(() {
|
||||
_queue = queue;
|
||||
_queue = cachedQueue;
|
||||
_isLoadingQueue = false;
|
||||
});
|
||||
} else {
|
||||
setState(() => _isLoadingQueue = true);
|
||||
}
|
||||
} else {
|
||||
if (mounted) {
|
||||
setState(() => _isLoadingQueue = false);
|
||||
}
|
||||
|
||||
// 2. Fetch fresh queue in background
|
||||
if (maProvider.api != null) {
|
||||
try {
|
||||
final freshQueue = await maProvider.getQueue(player.playerId);
|
||||
if (mounted && freshQueue != null) {
|
||||
debugPrint('🔀 Queue loaded: shuffle=${freshQueue.shuffle}, shuffleEnabled=${freshQueue.shuffleEnabled}');
|
||||
// Check if queue items were reordered by comparing first few item IDs
|
||||
bool itemsReordered = false;
|
||||
if (_queue != null && _queue!.items.isNotEmpty && freshQueue.items.isNotEmpty) {
|
||||
// Compare first 3 items to detect reordering (shuffle changes item order)
|
||||
final maxCheck = (_queue!.items.length < 3 ? _queue!.items.length : 3).clamp(1, freshQueue.items.length);
|
||||
for (int i = 0; i < maxCheck; i++) {
|
||||
if (_queue!.items[i].queueItemId != freshQueue.items[i].queueItemId) {
|
||||
itemsReordered = true;
|
||||
debugPrint('🔀 Queue items reordered detected at position $i');
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
// Update if queue metadata or item order changed
|
||||
final queueChanged = _queue == null ||
|
||||
_queue!.items.length != freshQueue.items.length ||
|
||||
_queue!.currentIndex != freshQueue.currentIndex ||
|
||||
_queue!.shuffle != freshQueue.shuffle ||
|
||||
itemsReordered;
|
||||
if (queueChanged) {
|
||||
debugPrint('🔀 Queue changed, updating UI (reordered=$itemsReordered)');
|
||||
setState(() {
|
||||
_queue = freshQueue;
|
||||
_isLoadingQueue = false;
|
||||
});
|
||||
}
|
||||
}
|
||||
} catch (e) {
|
||||
// Silent failure - keep showing cached queue
|
||||
}
|
||||
}
|
||||
|
||||
if (mounted && _isLoadingQueue) {
|
||||
setState(() => _isLoadingQueue = false);
|
||||
}
|
||||
}
|
||||
|
||||
Future<void> _extractColors(String imageUrl) async {
|
||||
@@ -365,16 +432,69 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
}
|
||||
|
||||
Future<void> _toggleShuffle() async {
|
||||
if (_queue == null) return;
|
||||
debugPrint('🔀 Shuffle button pressed');
|
||||
if (_queue == null) {
|
||||
debugPrint('🔀 Shuffle: _queue is null, returning');
|
||||
return;
|
||||
}
|
||||
final newShuffleState = !_queue!.shuffle;
|
||||
debugPrint('🔀 Shuffle: current=${_queue!.shuffle}, toggling to $newShuffleState');
|
||||
|
||||
// Optimistically update local state for immediate visual feedback
|
||||
setState(() {
|
||||
_queue = PlayerQueue(
|
||||
playerId: _queue!.playerId,
|
||||
items: _queue!.items,
|
||||
currentIndex: _queue!.currentIndex,
|
||||
shuffleEnabled: newShuffleState,
|
||||
repeatMode: _queue!.repeatMode,
|
||||
);
|
||||
});
|
||||
debugPrint('🔀 Shuffle: optimistic update applied, shuffleEnabled=$newShuffleState');
|
||||
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
await maProvider.toggleShuffle(_queue!.playerId);
|
||||
// Toggle: if currently shuffled, disable; if not shuffled, enable
|
||||
await maProvider.toggleShuffle(_queue!.playerId, newShuffleState);
|
||||
debugPrint('🔀 Shuffle: command sent, waiting for server to reorder queue');
|
||||
// Small delay to allow server to finish reordering queue items
|
||||
await Future.delayed(const Duration(milliseconds: 150));
|
||||
debugPrint('🔀 Shuffle: reloading queue');
|
||||
await _loadQueue();
|
||||
}
|
||||
|
||||
Future<void> _cycleRepeat() async {
|
||||
if (_queue == null) return;
|
||||
|
||||
// Calculate next repeat mode: off -> all -> one -> off
|
||||
String nextMode;
|
||||
switch (_queue!.repeatMode) {
|
||||
case 'off':
|
||||
case null:
|
||||
nextMode = 'all';
|
||||
break;
|
||||
case 'all':
|
||||
nextMode = 'one';
|
||||
break;
|
||||
case 'one':
|
||||
nextMode = 'off';
|
||||
break;
|
||||
default:
|
||||
nextMode = 'off';
|
||||
}
|
||||
|
||||
// Optimistically update local state for immediate visual feedback
|
||||
setState(() {
|
||||
_queue = PlayerQueue(
|
||||
playerId: _queue!.playerId,
|
||||
items: _queue!.items,
|
||||
currentIndex: _queue!.currentIndex,
|
||||
shuffleEnabled: _queue!.shuffleEnabled,
|
||||
repeatMode: nextMode,
|
||||
);
|
||||
});
|
||||
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
await maProvider.cycleRepeatMode(_queue!.playerId, _queue!.repeatMode);
|
||||
await maProvider.setRepeatMode(_queue!.playerId, nextMode);
|
||||
await _loadQueue();
|
||||
}
|
||||
|
||||
@@ -417,14 +537,15 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
}
|
||||
}
|
||||
|
||||
/// Toggle favorite status for current track
|
||||
/// Toggle favorite status for current track (with offline queuing support)
|
||||
Future<void> _toggleCurrentTrackFavorite(dynamic currentTrack) async {
|
||||
if (currentTrack == null) return;
|
||||
|
||||
final maProvider = context.read<MusicAssistantProvider>();
|
||||
if (maProvider.api == null) return;
|
||||
|
||||
try {
|
||||
bool success;
|
||||
|
||||
if (_isCurrentTrackFavorite) {
|
||||
// Remove from favorites - need library_item_id (numeric)
|
||||
int? libraryItemId;
|
||||
@@ -446,7 +567,10 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
}
|
||||
|
||||
if (libraryItemId != null) {
|
||||
await maProvider.api!.removeFromFavorites('track', libraryItemId);
|
||||
success = await maProvider.removeFromFavorites(
|
||||
mediaType: 'track',
|
||||
libraryItemId: libraryItemId,
|
||||
);
|
||||
} else {
|
||||
throw Exception('Could not determine library ID for this track');
|
||||
}
|
||||
@@ -479,16 +603,37 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
}
|
||||
}
|
||||
|
||||
await maProvider.api!.addToFavorites('track', actualItemId, actualProvider);
|
||||
success = await maProvider.addToFavorites(
|
||||
mediaType: 'track',
|
||||
itemId: actualItemId,
|
||||
provider: actualProvider,
|
||||
);
|
||||
}
|
||||
|
||||
// Toggle local state
|
||||
setState(() {
|
||||
_isCurrentTrackFavorite = !_isCurrentTrackFavorite;
|
||||
});
|
||||
if (success) {
|
||||
// Toggle local state
|
||||
setState(() {
|
||||
_isCurrentTrackFavorite = !_isCurrentTrackFavorite;
|
||||
});
|
||||
|
||||
// Invalidate home cache so favorites are updated
|
||||
maProvider.invalidateHomeCache();
|
||||
// Invalidate home cache so favorites are updated
|
||||
maProvider.invalidateHomeCache();
|
||||
|
||||
// Show feedback (different message if offline)
|
||||
if (mounted) {
|
||||
final isOffline = !maProvider.isConnected;
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(
|
||||
content: Text(
|
||||
isOffline
|
||||
? S.of(context)!.actionQueuedForSync
|
||||
: (_isCurrentTrackFavorite ? S.of(context)!.addedToFavorites : S.of(context)!.removedFromFavorites),
|
||||
),
|
||||
duration: const Duration(seconds: 1),
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
} catch (e) {
|
||||
// Show error feedback
|
||||
if (mounted) {
|
||||
@@ -956,6 +1101,8 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
right: _collapsedMargin,
|
||||
bottom: adjustedBottomOffset,
|
||||
child: GestureDetector(
|
||||
// Tap to dismiss player reveal (matching _buildMorphingPlayer behavior)
|
||||
onTap: widget.isDeviceRevealVisible ? GlobalPlayerOverlay.dismissPlayerReveal : null,
|
||||
onVerticalDragUpdate: (details) {
|
||||
if (details.primaryDelta! > 5 && widget.onRevealPlayers != null) {
|
||||
widget.onRevealPlayers!();
|
||||
@@ -1097,27 +1244,22 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
final expandedArtLeft = (screenSize.width - expandedArtSize) / 2;
|
||||
final artLeft = _lerpDouble(collapsedArtLeft, expandedArtLeft, t);
|
||||
|
||||
final collapsedArtTop = 0.0;
|
||||
final collapsedArtTop = (_collapsedHeight - _collapsedArtSize) / 2; // Center vertically
|
||||
final expandedArtTop = topPadding + headerHeight + 16;
|
||||
final artTop = _lerpDouble(collapsedArtTop, expandedArtTop, t);
|
||||
|
||||
// Typography - clear hierarchy
|
||||
// Title: bold, prominent (24px)
|
||||
// Artist: medium weight, secondary (18px expanded, was 16px)
|
||||
// Album: light, tertiary (15px expanded, was 13px)
|
||||
final titleFontSize = _lerpDouble(16.0, 24.0, t);
|
||||
final artistFontSize = _lerpDouble(14.0, 18.0, t); // 14px collapsed, 18px expanded
|
||||
// Typography - uses shared MiniPlayerLayout constants for collapsed state
|
||||
final titleFontSize = _lerpDouble(MiniPlayerLayout.primaryFontSize, 24.0, t);
|
||||
final artistFontSize = _lerpDouble(MiniPlayerLayout.secondaryFontSize, 18.0, t);
|
||||
|
||||
final collapsedTitleLeft = _collapsedArtSize + 8; // Reduced from 12 to 8 (4px less)
|
||||
final expandedTitleLeft = contentPadding;
|
||||
final titleLeft = _lerpDouble(collapsedTitleLeft, expandedTitleLeft, t);
|
||||
final titleLeft = _lerpDouble(MiniPlayerLayout.textLeft, expandedTitleLeft, t);
|
||||
|
||||
final collapsedTitleTop = (_collapsedHeight - 36) / 2; // Centered vertically (adjusted for increased track/artist gap)
|
||||
final collapsedTitleTop = MiniPlayerLayout.primaryTop;
|
||||
|
||||
// Controls: 36 (prev) + 34 (play) + 36 (next) + 8 (right margin) = 114px from widget right
|
||||
// For 8px gap: text ends at widgetWidth - 114 - 8 = widgetWidth - 122
|
||||
// Note: collapsedWidth = screenSize.width - 24 (12px margin each side)
|
||||
final collapsedTitleWidth = collapsedWidth - collapsedTitleLeft - 122;
|
||||
final collapsedTitleWidth = collapsedWidth - MiniPlayerLayout.textLeft - 122;
|
||||
final expandedTitleWidth = screenSize.width - (contentPadding * 2);
|
||||
final titleWidth = _lerpDouble(collapsedTitleWidth, expandedTitleWidth, t);
|
||||
|
||||
@@ -1174,10 +1316,13 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
final titleTop = _lerpDouble(collapsedTitleTop, expandedTitleTop, t);
|
||||
|
||||
// Artist positioned dynamically based on actual title height
|
||||
final collapsedArtistTop = collapsedTitleTop + 22; // Increased gap from 18 to 22
|
||||
final collapsedArtistTop = MiniPlayerLayout.secondaryTop;
|
||||
final expandedArtistTop = expandedTitleTop + expandedTitleHeight + titleToArtistGap;
|
||||
final artistTop = _lerpDouble(collapsedArtistTop, expandedArtistTop, t);
|
||||
|
||||
// Player name - only visible when collapsed (third line)
|
||||
final playerNameTop = MiniPlayerLayout.tertiaryTop;
|
||||
|
||||
// Album - subtle, below artist
|
||||
final expandedAlbumTop = expandedArtistTop + artistHeight + artistToAlbumGap;
|
||||
|
||||
@@ -1216,8 +1361,8 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
child: GestureDetector(
|
||||
// Use translucent to allow child widgets (like buttons) to receive taps
|
||||
behavior: HitTestBehavior.translucent,
|
||||
// Only handle tap when collapsed - when expanded, let children handle their own taps
|
||||
onTap: isExpanded ? null : expand,
|
||||
// Handle tap: when device list is visible, dismiss it; when collapsed, expand
|
||||
onTap: isExpanded ? null : (widget.isDeviceRevealVisible ? GlobalPlayerOverlay.dismissPlayerReveal : expand),
|
||||
onVerticalDragStart: (details) {
|
||||
// For expanded player or queue panel: start tracking immediately
|
||||
// For collapsed player: defer decision until we know swipe direction
|
||||
@@ -1261,9 +1406,39 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
},
|
||||
onHorizontalDragStart: (details) {
|
||||
_horizontalDragStartX = details.globalPosition.dx;
|
||||
// Start volume drag if device reveal is visible
|
||||
if (widget.isDeviceRevealVisible && !isExpanded) {
|
||||
final currentVolume = (selectedPlayer.volumeLevel ?? 0).toDouble() / 100.0;
|
||||
setState(() {
|
||||
_isDraggingVolume = true;
|
||||
_dragVolumeLevel = currentVolume;
|
||||
});
|
||||
HapticFeedback.lightImpact();
|
||||
}
|
||||
},
|
||||
onHorizontalDragUpdate: (details) {
|
||||
// Only handle in collapsed mode with multiple players
|
||||
// Volume swipe when device reveal is visible
|
||||
if (widget.isDeviceRevealVisible && _isDraggingVolume && !isExpanded) {
|
||||
// Directional volume: drag right = increase, drag left = decrease
|
||||
// Multiple swipes accumulate - each starts from current volume
|
||||
final dragDelta = details.delta.dx;
|
||||
final volumeDelta = dragDelta / collapsedWidth;
|
||||
final newVolume = (_dragVolumeLevel + volumeDelta).clamp(0.0, 1.0);
|
||||
if ((newVolume - _dragVolumeLevel).abs() > 0.001) {
|
||||
setState(() {
|
||||
_dragVolumeLevel = newVolume;
|
||||
});
|
||||
// Throttle API calls to prevent flooding
|
||||
final now = DateTime.now().millisecondsSinceEpoch;
|
||||
if (now - _lastVolumeUpdateTime >= _volumeThrottleMs) {
|
||||
_lastVolumeUpdateTime = now;
|
||||
maProvider.setVolume(selectedPlayer.playerId, (newVolume * 100).round());
|
||||
}
|
||||
}
|
||||
return;
|
||||
}
|
||||
|
||||
// Only handle player swipe in collapsed mode with multiple players
|
||||
if (isExpanded || !hasMultiplePlayers) return;
|
||||
|
||||
// Ignore drags that started in the edge dead zone
|
||||
@@ -1276,6 +1451,18 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
_handleHorizontalDragUpdate(details, maProvider, collapsedWidth);
|
||||
},
|
||||
onHorizontalDragEnd: (details) {
|
||||
// End volume drag
|
||||
if (_isDraggingVolume) {
|
||||
// Send final volume on release
|
||||
maProvider.setVolume(selectedPlayer.playerId, (_dragVolumeLevel * 100).round());
|
||||
setState(() {
|
||||
_isDraggingVolume = false;
|
||||
});
|
||||
HapticFeedback.lightImpact();
|
||||
_horizontalDragStartX = null;
|
||||
return;
|
||||
}
|
||||
|
||||
// Ignore swipes that started near the edges (Android back gesture zone)
|
||||
final screenWidth = MediaQuery.of(context).size.width;
|
||||
final startedInDeadZone = _horizontalDragStartX != null &&
|
||||
@@ -1299,13 +1486,22 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
_handleHorizontalDragEnd(details, maProvider);
|
||||
}
|
||||
},
|
||||
child: Material(
|
||||
color: backgroundColor,
|
||||
borderRadius: BorderRadius.circular(borderRadius),
|
||||
elevation: _lerpDouble(4, 0, t),
|
||||
shadowColor: Colors.black.withOpacity(0.3),
|
||||
clipBehavior: Clip.antiAlias,
|
||||
child: SizedBox(
|
||||
child: Container(
|
||||
// Use foregroundDecoration for border so it renders ON TOP of content
|
||||
// This prevents the album art from clipping the yellow synced border
|
||||
foregroundDecoration: maProvider.isPlayerManuallySynced(selectedPlayer.playerId) && t < 0.5
|
||||
? BoxDecoration(
|
||||
borderRadius: BorderRadius.circular(borderRadius),
|
||||
border: Border.all(color: _groupBorderColor, width: 1.5),
|
||||
)
|
||||
: null,
|
||||
child: Material(
|
||||
color: backgroundColor,
|
||||
borderRadius: BorderRadius.circular(borderRadius),
|
||||
elevation: _lerpDouble(4, 0, t),
|
||||
shadowColor: Colors.black.withOpacity(0.3),
|
||||
clipBehavior: Clip.antiAlias,
|
||||
child: SizedBox(
|
||||
width: width,
|
||||
height: height,
|
||||
child: Stack(
|
||||
@@ -1315,41 +1511,41 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
// Shows played portion with brighter color, unplayed with darker
|
||||
// Starts after album art so progress is visible
|
||||
// Slides with content during swipe, hidden during transition if peek available
|
||||
// GPU PERF: Use conditional rendering + color alpha instead of Opacity
|
||||
// to avoid double saveLayer (Opacity + ClipRRect)
|
||||
if (t < 0.5 && currentTrack?.duration != null && !(_inTransition && t < 0.1 && _peekPlayer != null))
|
||||
Positioned(
|
||||
left: _collapsedArtSize + miniPlayerSlideOffset,
|
||||
top: 0,
|
||||
width: width - _collapsedArtSize,
|
||||
bottom: 0,
|
||||
child: ValueListenableBuilder<int>(
|
||||
valueListenable: _progressNotifier,
|
||||
builder: (context, elapsedSeconds, _) {
|
||||
final totalSeconds = currentTrack!.duration!.inSeconds;
|
||||
if (totalSeconds <= 0) return const SizedBox.shrink();
|
||||
final progress = (elapsedSeconds / totalSeconds).clamp(0.0, 1.0);
|
||||
// Fade out as we expand
|
||||
final progressOpacity = (1.0 - (t / 0.5)).clamp(0.0, 1.0);
|
||||
final progressAreaWidth = width - _collapsedArtSize;
|
||||
return Opacity(
|
||||
opacity: progressOpacity,
|
||||
child: ClipRRect(
|
||||
left: _collapsedArtSize + miniPlayerSlideOffset,
|
||||
top: 0,
|
||||
width: width - _collapsedArtSize,
|
||||
bottom: 0,
|
||||
child: ValueListenableBuilder<int>(
|
||||
valueListenable: _progressNotifier,
|
||||
builder: (context, elapsedSeconds, _) {
|
||||
final totalSeconds = currentTrack!.duration!.inSeconds;
|
||||
if (totalSeconds <= 0) return const SizedBox.shrink();
|
||||
final progress = (elapsedSeconds / totalSeconds).clamp(0.0, 1.0);
|
||||
// Fade out as we expand - use color alpha instead of Opacity widget
|
||||
final progressOpacity = (1.0 - (t / 0.5)).clamp(0.0, 1.0);
|
||||
final progressAreaWidth = width - _collapsedArtSize;
|
||||
return ClipRRect(
|
||||
borderRadius: BorderRadius.only(
|
||||
topRight: Radius.circular(borderRadius),
|
||||
bottomRight: Radius.circular(borderRadius),
|
||||
),
|
||||
clipBehavior: Clip.hardEdge,
|
||||
child: Align(
|
||||
alignment: Alignment.centerLeft,
|
||||
child: Container(
|
||||
width: progressAreaWidth * progress,
|
||||
height: height,
|
||||
color: collapsedBg,
|
||||
color: collapsedBg.withOpacity(progressOpacity),
|
||||
),
|
||||
),
|
||||
),
|
||||
);
|
||||
},
|
||||
);
|
||||
},
|
||||
),
|
||||
),
|
||||
),
|
||||
|
||||
// Peek player content (shows when dragging OR during transition)
|
||||
// Show when: actively dragging (slideOffset != 0) OR in transition state
|
||||
@@ -1357,20 +1553,12 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
if (t < 0.1 && _peekPlayer != null && (_slideOffset.abs() > 0.01 || _inTransition))
|
||||
_buildPeekContent(
|
||||
context: context,
|
||||
maProvider: maProvider,
|
||||
peekPlayer: _peekPlayer,
|
||||
peekImageUrl: _peekImageUrl,
|
||||
slideOffset: _slideOffset,
|
||||
containerWidth: collapsedWidth,
|
||||
artSize: _collapsedArtSize,
|
||||
titleLeft: collapsedTitleLeft,
|
||||
titleTop: collapsedTitleTop,
|
||||
titleWidth: collapsedTitleWidth,
|
||||
artistTop: collapsedArtistTop,
|
||||
titleFontSize: 16.0,
|
||||
artistFontSize: 14.0,
|
||||
backgroundColor: collapsedBg,
|
||||
textColor: textColor,
|
||||
colorScheme: colorScheme,
|
||||
),
|
||||
|
||||
// Album art - with slide animation when collapsed
|
||||
@@ -1428,10 +1616,48 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
),
|
||||
|
||||
// Track title - with slide animation when collapsed
|
||||
// When hint is visible, show lightbulb icon + "Pull to select players"
|
||||
// When device reveal is visible, show player name instead of track name
|
||||
// Hidden during transition to prevent flash
|
||||
// FALLBACK: Show if transition active but no peek content available
|
||||
// GPU PERF: Use conditional instead of Opacity to avoid saveLayer
|
||||
if (!(_inTransition && t < 0.1 && _peekPlayer != null))
|
||||
// Hint text - vertically centered in mini player
|
||||
if (widget.isHintVisible && t < 0.5 && !(_inTransition && t < 0.1 && _peekPlayer != null))
|
||||
Positioned(
|
||||
left: titleLeft + miniPlayerSlideOffset,
|
||||
// Center vertically: (64 - ~20) / 2 = 22
|
||||
top: (MiniPlayerLayout.height - 20) / 2,
|
||||
child: SizedBox(
|
||||
width: titleWidth,
|
||||
child: Row(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
Icon(
|
||||
Icons.lightbulb_outline,
|
||||
size: 16,
|
||||
color: textColor,
|
||||
),
|
||||
const SizedBox(width: 6),
|
||||
Flexible(
|
||||
child: Text(
|
||||
S.of(context)!.pullToSelectPlayers,
|
||||
style: TextStyle(
|
||||
color: textColor,
|
||||
fontSize: titleFontSize,
|
||||
fontWeight: MiniPlayerLayout.primaryFontWeight,
|
||||
),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
|
||||
// Track title - with slide animation when collapsed
|
||||
// Hidden when hint is visible
|
||||
if (!(widget.isHintVisible && t < 0.5) && !(_inTransition && t < 0.1 && _peekPlayer != null))
|
||||
Positioned(
|
||||
left: titleLeft + miniPlayerSlideOffset,
|
||||
top: titleTop,
|
||||
@@ -1442,9 +1668,9 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
style: TextStyle(
|
||||
color: textColor,
|
||||
fontSize: titleFontSize,
|
||||
fontWeight: t > 0.5 ? FontWeight.w600 : FontWeight.w500,
|
||||
fontWeight: t > 0.5 ? FontWeight.w600 : MiniPlayerLayout.primaryFontWeight,
|
||||
letterSpacing: t > 0.5 ? -0.5 : 0,
|
||||
height: 1.2,
|
||||
height: t > 0.5 ? 1.2 : null, // Only use line height when expanded
|
||||
),
|
||||
textAlign: t > 0.5 ? TextAlign.center : TextAlign.left,
|
||||
maxLines: t > 0.5 ? 2 : 1,
|
||||
@@ -1455,22 +1681,25 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
),
|
||||
|
||||
// Artist/Author name - with slide animation when collapsed
|
||||
// When hint is visible, show blank line
|
||||
// When device reveal is visible, show "Now Playing" hint
|
||||
// For audiobooks: show author from audiobook context
|
||||
// Hidden during transition to prevent flash
|
||||
// FALLBACK: Show if transition active but no peek content available
|
||||
// GPU PERF: Use conditional instead of Opacity to avoid saveLayer
|
||||
if (!(_inTransition && t < 0.1 && _peekPlayer != null))
|
||||
if (!(_inTransition && t < 0.1 && _peekPlayer != null) && !(widget.isHintVisible && t < 0.5))
|
||||
Positioned(
|
||||
left: titleLeft + miniPlayerSlideOffset,
|
||||
top: artistTop,
|
||||
child: SizedBox(
|
||||
width: titleWidth,
|
||||
child: Text(
|
||||
// Always show artist/author (was showing "Now Playing" when device reveal visible)
|
||||
maProvider.isPlayingAudiobook
|
||||
? (maProvider.currentAudiobook?.authorsString ?? S.of(context)!.unknownAuthor)
|
||||
: currentTrack.artistsString,
|
||||
style: TextStyle(
|
||||
color: textColor.withOpacity(t > 0.5 ? 0.7 : 0.6),
|
||||
color: textColor.withOpacity(t > 0.5 ? 0.7 : MiniPlayerLayout.secondaryTextOpacity),
|
||||
fontSize: artistFontSize,
|
||||
fontWeight: t > 0.5 ? FontWeight.w400 : FontWeight.normal,
|
||||
),
|
||||
@@ -1482,6 +1711,26 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
),
|
||||
),
|
||||
|
||||
// Player name - third line, only visible when collapsed
|
||||
// Same size as artist, same color as track
|
||||
if (t < 0.5 && !(_inTransition && t < 0.1 && _peekPlayer != null) && !(widget.isHintVisible && t < 0.5))
|
||||
Positioned(
|
||||
left: titleLeft + miniPlayerSlideOffset,
|
||||
top: playerNameTop,
|
||||
child: SizedBox(
|
||||
width: titleWidth,
|
||||
child: Text(
|
||||
selectedPlayer.name,
|
||||
style: TextStyle(
|
||||
color: textColor.withOpacity(1.0 - t * 2), // Fade out as expanding
|
||||
fontSize: MiniPlayerLayout.tertiaryFontSize,
|
||||
),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
),
|
||||
),
|
||||
|
||||
// Album name OR Chapter name (expanded only)
|
||||
// GPU PERF: Use color alpha instead of Opacity widget
|
||||
// For audiobooks: show current chapter; for music: show album
|
||||
@@ -1651,7 +1900,60 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
t: t,
|
||||
expandedElementsOpacity: expandedElementsOpacity,
|
||||
)
|
||||
: Row(
|
||||
// When device reveal is visible (player list shown), use compact controls
|
||||
// like PlayerCard: Play, Next, Power - matching other players in the list
|
||||
: widget.isDeviceRevealVisible && t < 0.5
|
||||
? Row(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
mainAxisAlignment: MainAxisAlignment.end,
|
||||
children: [
|
||||
// Play/Pause - compact like PlayerCard
|
||||
// Touch target increased to 44dp for accessibility
|
||||
Transform.translate(
|
||||
offset: const Offset(3, 0),
|
||||
child: SizedBox(
|
||||
width: 44,
|
||||
height: 44,
|
||||
child: IconButton(
|
||||
icon: Icon(
|
||||
selectedPlayer.isPlaying ? Icons.pause_rounded : Icons.play_arrow_rounded,
|
||||
color: textColor,
|
||||
size: 28,
|
||||
),
|
||||
onPressed: () => maProvider.playPauseSelectedPlayer(),
|
||||
padding: EdgeInsets.zero,
|
||||
),
|
||||
),
|
||||
),
|
||||
// Skip next - nudged right like PlayerCard
|
||||
Transform.translate(
|
||||
offset: const Offset(6, 0),
|
||||
child: IconButton(
|
||||
icon: Icon(
|
||||
Icons.skip_next_rounded,
|
||||
color: textColor,
|
||||
size: 28,
|
||||
),
|
||||
onPressed: () => maProvider.nextTrackSelectedPlayer(),
|
||||
padding: EdgeInsets.zero,
|
||||
constraints: const BoxConstraints(),
|
||||
),
|
||||
),
|
||||
// Power button - smallest, like PlayerCard
|
||||
IconButton(
|
||||
icon: Icon(
|
||||
Icons.power_settings_new_rounded,
|
||||
color: selectedPlayer.powered ? textColor : textColor.withOpacity(0.5),
|
||||
size: 20,
|
||||
),
|
||||
onPressed: () => maProvider.togglePower(selectedPlayer.playerId),
|
||||
padding: EdgeInsets.zero,
|
||||
constraints: const BoxConstraints(),
|
||||
),
|
||||
const SizedBox(width: 4),
|
||||
],
|
||||
)
|
||||
: Row(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
mainAxisAlignment: t > 0.5 ? MainAxisAlignment.center : MainAxisAlignment.end,
|
||||
children: [
|
||||
@@ -1842,167 +2144,88 @@ class ExpandablePlayerState extends State<ExpandablePlayer>
|
||||
),
|
||||
),
|
||||
),
|
||||
|
||||
// Volume swipe overlay (covers entire mini player when dragging volume)
|
||||
// Only visible when device reveal is open and user is dragging
|
||||
// Positioned last in Stack so it renders ON TOP of all content
|
||||
if (_isDraggingVolume && t < 0.5)
|
||||
Positioned.fill(
|
||||
child: ClipRRect(
|
||||
borderRadius: BorderRadius.circular(borderRadius),
|
||||
child: Stack(
|
||||
children: [
|
||||
// Unfilled (darker) background
|
||||
Container(color: collapsedBgUnplayed),
|
||||
// Filled (lighter) portion based on volume
|
||||
Align(
|
||||
alignment: Alignment.centerLeft,
|
||||
child: FractionallySizedBox(
|
||||
widthFactor: _dragVolumeLevel.clamp(0.0, 1.0),
|
||||
heightFactor: 1.0,
|
||||
child: Container(color: collapsedBg),
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
),
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
/// Build the peek player content that slides in from the edge during drag
|
||||
/// Uses shared MiniPlayerContent for consistency
|
||||
Widget _buildPeekContent({
|
||||
required BuildContext context,
|
||||
required MusicAssistantProvider maProvider,
|
||||
required dynamic peekPlayer,
|
||||
required String? peekImageUrl,
|
||||
required double slideOffset,
|
||||
required double containerWidth,
|
||||
required double artSize,
|
||||
required double titleLeft,
|
||||
required double titleTop,
|
||||
required double titleWidth,
|
||||
required double artistTop,
|
||||
required double titleFontSize,
|
||||
required double artistFontSize,
|
||||
required Color backgroundColor,
|
||||
required Color textColor,
|
||||
required ColorScheme colorScheme,
|
||||
}) {
|
||||
// Calculate sliding position
|
||||
// During transition (_inTransition = true), peek should be at center (offset 0)
|
||||
// When sliding left (negative offset), peek comes from right
|
||||
// When sliding right (positive offset), peek comes from left
|
||||
|
||||
double peekBaseOffset;
|
||||
|
||||
if (_inTransition && slideOffset.abs() < 0.01) {
|
||||
// During transition with slideOffset at 0, show peek at center
|
||||
peekBaseOffset = 0.0;
|
||||
} else {
|
||||
final isFromRight = slideOffset < 0;
|
||||
final peekProgress = slideOffset.abs();
|
||||
|
||||
// Position calculation:
|
||||
// From right: starts at containerWidth (off right edge), moves to 0 as progress increases
|
||||
// From left: starts at -containerWidth (off left edge), moves to 0 as progress increases
|
||||
peekBaseOffset = isFromRight
|
||||
? containerWidth * (1 - peekProgress) // Slides in from right
|
||||
: -containerWidth * (1 - peekProgress); // Slides in from left
|
||||
? containerWidth * (1 - peekProgress)
|
||||
: -containerWidth * (1 - peekProgress);
|
||||
}
|
||||
|
||||
// Check if peek player has a track - if not, show device info instead
|
||||
// Check if peek player has a track
|
||||
final hasTrack = _peekTrack != null && peekImageUrl != null;
|
||||
final peekTrackName = hasTrack ? _peekTrack!.name : (peekPlayer?.name ?? S.of(context)!.unknown);
|
||||
final peekArtistName = hasTrack ? (_peekTrack!.artistsString ?? '') : S.of(context)!.swipeToSwitchDevice;
|
||||
// Show player name as third line only when playing
|
||||
final peekPlayerName = hasTrack ? (peekPlayer?.name ?? '') : null;
|
||||
|
||||
return Stack(
|
||||
children: [
|
||||
// Peek album art / device icon
|
||||
Positioned(
|
||||
left: peekBaseOffset,
|
||||
top: 0,
|
||||
child: Container(
|
||||
width: artSize,
|
||||
height: artSize,
|
||||
decoration: BoxDecoration(
|
||||
color: colorScheme.surfaceContainerHighest,
|
||||
),
|
||||
child: hasTrack
|
||||
? CachedNetworkImage(
|
||||
imageUrl: peekImageUrl!,
|
||||
fit: BoxFit.cover,
|
||||
memCacheWidth: 256,
|
||||
memCacheHeight: 256,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholderFadeInDuration: Duration.zero,
|
||||
placeholder: (_, __) => _buildMiniPlaceholderArt(colorScheme),
|
||||
errorWidget: (_, __, ___) => _buildMiniPlaceholderArt(colorScheme),
|
||||
)
|
||||
: _buildDeviceIcon(peekPlayer?.name ?? '', artSize, colorScheme),
|
||||
),
|
||||
),
|
||||
|
||||
// Peek track title / device name
|
||||
Positioned(
|
||||
left: titleLeft + peekBaseOffset,
|
||||
top: titleTop,
|
||||
child: SizedBox(
|
||||
width: titleWidth,
|
||||
child: Text(
|
||||
peekTrackName,
|
||||
style: TextStyle(
|
||||
color: textColor,
|
||||
fontSize: titleFontSize,
|
||||
fontWeight: FontWeight.w500,
|
||||
height: 1.2,
|
||||
),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
),
|
||||
),
|
||||
|
||||
// Peek artist name / device hint
|
||||
Positioned(
|
||||
left: titleLeft + peekBaseOffset,
|
||||
top: artistTop,
|
||||
child: SizedBox(
|
||||
width: titleWidth,
|
||||
child: Text(
|
||||
peekArtistName,
|
||||
style: TextStyle(
|
||||
color: textColor.withOpacity(0.6),
|
||||
fontSize: artistFontSize,
|
||||
),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
),
|
||||
),
|
||||
],
|
||||
);
|
||||
}
|
||||
|
||||
/// Build device icon for non-playing peek player
|
||||
Widget _buildDeviceIcon(String playerName, double size, ColorScheme colorScheme) {
|
||||
final nameLower = playerName.toLowerCase();
|
||||
IconData icon;
|
||||
if (nameLower.contains('phone') || nameLower.contains('ensemble')) {
|
||||
icon = Icons.phone_android_rounded;
|
||||
} else if (nameLower.contains('group') || nameLower.contains('all')) {
|
||||
icon = Icons.speaker_group_rounded;
|
||||
} else if (nameLower.contains('tv') || nameLower.contains('television')) {
|
||||
icon = Icons.tv_rounded;
|
||||
} else if (nameLower.contains('cast') || nameLower.contains('chromecast')) {
|
||||
icon = Icons.cast_rounded;
|
||||
} else {
|
||||
icon = Icons.speaker_rounded;
|
||||
}
|
||||
|
||||
return Container(
|
||||
color: colorScheme.surfaceContainerHighest,
|
||||
child: Center(
|
||||
child: Icon(
|
||||
icon,
|
||||
color: colorScheme.onSurfaceVariant,
|
||||
size: size * 0.5,
|
||||
),
|
||||
return Transform.translate(
|
||||
offset: Offset(peekBaseOffset, 0),
|
||||
child: MiniPlayerContent(
|
||||
primaryText: peekTrackName,
|
||||
secondaryText: peekArtistName,
|
||||
tertiaryText: peekPlayerName,
|
||||
imageUrl: hasTrack ? peekImageUrl : null,
|
||||
playerName: peekPlayer?.name ?? '',
|
||||
backgroundColor: backgroundColor,
|
||||
textColor: textColor,
|
||||
width: containerWidth,
|
||||
slideOffset: 0, // Transform handles positioning
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
/// Simplified placeholder for mini player peek
|
||||
Widget _buildMiniPlaceholderArt(ColorScheme colorScheme) {
|
||||
return Container(
|
||||
color: colorScheme.surfaceContainerHighest,
|
||||
child: Icon(
|
||||
Icons.music_note_rounded,
|
||||
color: colorScheme.onSurfaceVariant,
|
||||
size: 24,
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
/// Build peek player progress bar that slides in during swipe
|
||||
Widget _buildPeekProgressBar({
|
||||
|
||||
@@ -1,11 +1,15 @@
|
||||
import 'dart:async';
|
||||
import 'dart:ui';
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter/services.dart';
|
||||
import 'package:provider/provider.dart';
|
||||
import '../l10n/app_localizations.dart';
|
||||
import '../providers/music_assistant_provider.dart';
|
||||
import '../providers/navigation_provider.dart';
|
||||
import '../services/settings_service.dart';
|
||||
import '../theme/theme_provider.dart';
|
||||
import 'expandable_player.dart';
|
||||
import 'player/mini_player_content.dart' show MiniPlayerLayout;
|
||||
import 'player/player_reveal_overlay.dart';
|
||||
|
||||
/// Cached color with contrast adjustment
|
||||
@@ -53,14 +57,14 @@ class BottomSpacing {
|
||||
/// Height of the bottom navigation bar
|
||||
static const double navBarHeight = 56.0;
|
||||
|
||||
/// Height of mini player when visible (64px height + 12px margin)
|
||||
static const double miniPlayerHeight = 76.0;
|
||||
/// Height of mini player when visible (height + 12px margin)
|
||||
static double get miniPlayerHeight => MiniPlayerLayout.height + 12.0;
|
||||
|
||||
/// Space needed when only nav bar is visible (with some extra padding)
|
||||
static const double navBarOnly = navBarHeight + 16.0;
|
||||
|
||||
/// Space needed when mini player is also visible
|
||||
static const double withMiniPlayer = navBarHeight + miniPlayerHeight + 22.0;
|
||||
static double get withMiniPlayer => navBarHeight + miniPlayerHeight + 22.0;
|
||||
}
|
||||
|
||||
/// ValueNotifier for player expansion progress (0.0 to 1.0) and background color
|
||||
@@ -129,7 +133,7 @@ class GlobalPlayerOverlay extends StatefulWidget {
|
||||
_overlayStateKey.currentState?._dismissPlayerReveal();
|
||||
}
|
||||
|
||||
/// Trigger the bounce animation on mini player (called when overlay dismiss starts)
|
||||
/// Trigger single bounce on mini player (called when device selector collapses)
|
||||
static void triggerBounce() {
|
||||
_overlayStateKey.currentState?._triggerBounce();
|
||||
}
|
||||
@@ -144,13 +148,39 @@ class _GlobalPlayerOverlayState extends State<GlobalPlayerOverlay>
|
||||
late AnimationController _slideController;
|
||||
late Animation<double> _slideAnimation;
|
||||
|
||||
// Controller for player reveal animation with bounce
|
||||
late AnimationController _bounceController;
|
||||
late Animation<double> _bounceAnimation;
|
||||
// Single bounce controller for device selector expand/collapse
|
||||
late AnimationController _singleBounceController;
|
||||
|
||||
// Double bounce controller for hint
|
||||
late AnimationController _doubleBounceController;
|
||||
|
||||
// State for player reveal overlay
|
||||
bool _isRevealVisible = false;
|
||||
double _bounceOffset = 0.0;
|
||||
|
||||
// State for interactive hint mode (blur backdrop + wait for user action)
|
||||
bool _isHintModeActive = false;
|
||||
Timer? _hintBounceTimer;
|
||||
|
||||
// Track if player reveal was triggered from onboarding (for showing extra hints)
|
||||
bool _isOnboardingReveal = false;
|
||||
|
||||
// Bounce offset for mini player (used by both single and double bounce)
|
||||
final _bounceOffsetNotifier = ValueNotifier<double>(0.0);
|
||||
|
||||
// Hint system state
|
||||
// NOTE: AppStartup now handles the settings loading gate. It waits for:
|
||||
// - First-time users: connected + player selected before showing HomeScreen
|
||||
// - Returning users: connected before showing HomeScreen
|
||||
// This eliminates the race condition that caused home screen flash.
|
||||
bool _showHints = true;
|
||||
bool _hasCompletedOnboarding = false; // First-use welcome screen
|
||||
bool _hintTriggered = false; // Prevent multiple triggers per session
|
||||
bool _settingsLoaded = false; // True once settings have been loaded from storage
|
||||
bool _miniPlayerHintsReady = false; // True once connected with player (can show hints)
|
||||
final _hintOpacityNotifier = ValueNotifier<double>(0.0);
|
||||
|
||||
// Welcome content fade-in animation
|
||||
late AnimationController _welcomeFadeController;
|
||||
|
||||
// Key for the reveal overlay
|
||||
final _revealKey = GlobalKey<PlayerRevealOverlayState>();
|
||||
@@ -168,30 +198,134 @@ class _GlobalPlayerOverlayState extends State<GlobalPlayerOverlay>
|
||||
reverseCurve: Curves.easeInCubic,
|
||||
);
|
||||
|
||||
// Bounce animation - quick dip down then back up
|
||||
_bounceController = AnimationController(
|
||||
duration: const Duration(milliseconds: 200),
|
||||
// Single bounce for device selector expand/collapse
|
||||
_singleBounceController = AnimationController(
|
||||
duration: const Duration(milliseconds: 400),
|
||||
vsync: this,
|
||||
);
|
||||
_bounceAnimation = CurvedAnimation(
|
||||
parent: _bounceController,
|
||||
curve: Curves.easeOut,
|
||||
_singleBounceController.addListener(() {
|
||||
final t = Curves.easeOut.transform(_singleBounceController.value);
|
||||
// Single bounce: up to 10px then back to 0
|
||||
if (t < 0.5) {
|
||||
_bounceOffsetNotifier.value = 10.0 * (t * 2); // 0 -> 10
|
||||
} else {
|
||||
_bounceOffsetNotifier.value = 10.0 * ((1.0 - t) * 2); // 10 -> 0
|
||||
}
|
||||
});
|
||||
|
||||
// Hint bounce - single gentle bounce to draw attention
|
||||
_doubleBounceController = AnimationController(
|
||||
duration: const Duration(milliseconds: 600),
|
||||
vsync: this,
|
||||
);
|
||||
_doubleBounceController.addListener(() {
|
||||
final t = Curves.easeOut.transform(_doubleBounceController.value);
|
||||
// Single bounce: up 20px then back down
|
||||
if (t < 0.5) {
|
||||
_bounceOffsetNotifier.value = 20.0 * (t * 2); // 0 -> 20
|
||||
} else {
|
||||
_bounceOffsetNotifier.value = 20.0 * ((1.0 - t) * 2); // 20 -> 0
|
||||
}
|
||||
});
|
||||
|
||||
// Welcome content fade-in
|
||||
_welcomeFadeController = AnimationController(
|
||||
duration: const Duration(milliseconds: 800),
|
||||
vsync: this,
|
||||
);
|
||||
|
||||
_bounceController.addListener(() {
|
||||
setState(() {
|
||||
// Quick dip: goes down 10px at peak (0.5), then back to 0
|
||||
final t = _bounceAnimation.value;
|
||||
// Sine curve: 0 -> 1 -> 0 as t goes 0 -> 0.5 -> 1
|
||||
_bounceOffset = 10.0 * (t < 0.5 ? t * 2 : (1.0 - t) * 2);
|
||||
});
|
||||
// Load hint settings and start welcome immediately if needed
|
||||
_loadHintSettings();
|
||||
}
|
||||
|
||||
Future<void> _loadHintSettings() async {
|
||||
_showHints = await SettingsService.getShowHints();
|
||||
_hasCompletedOnboarding = await SettingsService.getHasCompletedOnboarding();
|
||||
if (!mounted) return;
|
||||
|
||||
setState(() {
|
||||
_settingsLoaded = true;
|
||||
});
|
||||
|
||||
// If first-time user and already connected (AppStartup waited for us),
|
||||
// start welcome screen immediately - no race condition possible
|
||||
if (!_hasCompletedOnboarding && !_hintTriggered) {
|
||||
final provider = context.read<MusicAssistantProvider>();
|
||||
if (provider.isConnected && provider.selectedPlayer != null) {
|
||||
_miniPlayerHintsReady = true;
|
||||
_startWelcomeScreen();
|
||||
_startMiniPlayerBounce();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@override
|
||||
void didChangeDependencies() {
|
||||
super.didChangeDependencies();
|
||||
// Check if we should enable mini player hints now that we have connection
|
||||
_checkConnectionForMiniPlayerHints();
|
||||
}
|
||||
|
||||
/// Check connection state and start welcome screen if appropriate.
|
||||
/// This is called from multiple places:
|
||||
/// 1. didChangeDependencies() - when widget first builds
|
||||
/// 2. _loadHintSettings() - when settings finish loading
|
||||
/// 3. build() - when provider state changes (via post-frame callback)
|
||||
void _checkConnectionForMiniPlayerHints() {
|
||||
if (_hintTriggered || !mounted || !_settingsLoaded) return;
|
||||
if (_hasCompletedOnboarding) return; // Not first-time user
|
||||
|
||||
final provider = context.read<MusicAssistantProvider>();
|
||||
if (provider.isConnected && provider.selectedPlayer != null) {
|
||||
// Connected with a player - start welcome screen now
|
||||
_miniPlayerHintsReady = true;
|
||||
_startWelcomeScreen();
|
||||
// Start the bounce animation now that mini player is visible
|
||||
_startMiniPlayerBounce();
|
||||
}
|
||||
}
|
||||
|
||||
/// Start the bounce animation for mini player hints
|
||||
void _startMiniPlayerBounce() {
|
||||
if (!_isHintModeActive || !mounted) return;
|
||||
_doubleBounceController.reset();
|
||||
_doubleBounceController.forward();
|
||||
|
||||
// Repeat bounce every 2 seconds
|
||||
_hintBounceTimer?.cancel();
|
||||
_hintBounceTimer = Timer.periodic(const Duration(seconds: 2), (_) {
|
||||
if (_isHintModeActive && mounted) {
|
||||
_doubleBounceController.reset();
|
||||
_doubleBounceController.forward();
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
/// Start the welcome screen with fade-in animation
|
||||
void _startWelcomeScreen() {
|
||||
if (_hintTriggered) return;
|
||||
_hintTriggered = true;
|
||||
|
||||
// Activate hint mode immediately (blur backdrop visible)
|
||||
setState(() {
|
||||
_isHintModeActive = true;
|
||||
});
|
||||
|
||||
// Fade in welcome content (logo + title)
|
||||
_welcomeFadeController.forward();
|
||||
|
||||
// Mini player bounce is started separately once connected via _startMiniPlayerBounce()
|
||||
}
|
||||
|
||||
@override
|
||||
void dispose() {
|
||||
_hintBounceTimer?.cancel();
|
||||
_slideController.dispose();
|
||||
_bounceController.dispose();
|
||||
_singleBounceController.dispose();
|
||||
_doubleBounceController.dispose();
|
||||
_welcomeFadeController.dispose();
|
||||
_bounceOffsetNotifier.dispose();
|
||||
_hintOpacityNotifier.dispose();
|
||||
super.dispose();
|
||||
}
|
||||
|
||||
@@ -209,18 +343,37 @@ class _GlobalPlayerOverlayState extends State<GlobalPlayerOverlay>
|
||||
GlobalPlayerOverlay.collapsePlayer();
|
||||
}
|
||||
HapticFeedback.mediumImpact();
|
||||
_bounceController.reset();
|
||||
|
||||
// Track if coming from hint mode (for onboarding hints in player selector)
|
||||
final wasInHintMode = _isHintModeActive;
|
||||
|
||||
// End hint mode if active (user learned the gesture!)
|
||||
_hintBounceTimer?.cancel();
|
||||
_hintBounceTimer = null;
|
||||
_hintOpacityNotifier.value = 0.0;
|
||||
_isHintModeActive = false;
|
||||
|
||||
// Mark onboarding as completed if coming from welcome screen
|
||||
if (wasInHintMode) {
|
||||
SettingsService.setHasCompletedOnboarding(true);
|
||||
}
|
||||
|
||||
// Trigger single bounce on expand
|
||||
_singleBounceController.reset();
|
||||
_singleBounceController.forward();
|
||||
|
||||
setState(() {
|
||||
_isRevealVisible = true;
|
||||
_isOnboardingReveal = wasInHintMode;
|
||||
});
|
||||
_bounceController.forward();
|
||||
}
|
||||
|
||||
void _hidePlayerReveal() {
|
||||
if (!_isRevealVisible) return;
|
||||
_bounceOffsetNotifier.value = 0;
|
||||
setState(() {
|
||||
_isRevealVisible = false;
|
||||
_bounceOffset = 0;
|
||||
_isOnboardingReveal = false;
|
||||
});
|
||||
}
|
||||
|
||||
@@ -228,14 +381,27 @@ class _GlobalPlayerOverlayState extends State<GlobalPlayerOverlay>
|
||||
void _dismissPlayerReveal() {
|
||||
if (!_isRevealVisible) return;
|
||||
// Call the overlay's dismiss method which has the slide animation
|
||||
// Note: dismiss() triggers the bounce animation internally
|
||||
_revealKey.currentState?.dismiss();
|
||||
}
|
||||
|
||||
/// Trigger bounce animation on mini player
|
||||
/// Trigger single bounce on mini player (called when device selector collapses)
|
||||
void _triggerBounce() {
|
||||
_bounceController.reset();
|
||||
_bounceController.forward();
|
||||
_singleBounceController.reset();
|
||||
_singleBounceController.forward();
|
||||
}
|
||||
|
||||
/// End hint mode (called when user taps skip button)
|
||||
void _endHintMode() {
|
||||
if (!_isHintModeActive) return;
|
||||
_hintBounceTimer?.cancel();
|
||||
_hintBounceTimer = null;
|
||||
_hintOpacityNotifier.value = 0.0;
|
||||
_bounceOffsetNotifier.value = 0.0;
|
||||
// Mark onboarding as completed (first use only)
|
||||
SettingsService.setHasCompletedOnboarding(true);
|
||||
setState(() {
|
||||
_isHintModeActive = false;
|
||||
});
|
||||
}
|
||||
|
||||
@override
|
||||
@@ -243,12 +409,46 @@ class _GlobalPlayerOverlayState extends State<GlobalPlayerOverlay>
|
||||
final theme = Theme.of(context);
|
||||
final colorScheme = theme.colorScheme;
|
||||
|
||||
// Handle back gesture at top level - dismiss device list if visible
|
||||
// Watch provider to trigger rebuilds when connection state changes
|
||||
final provider = context.watch<MusicAssistantProvider>();
|
||||
|
||||
// Compute whether this is a first-time user ready for welcome screen.
|
||||
// This is SYNCHRONOUS - no setState needed - so it works in the same frame.
|
||||
final isFirstTimeUserReady = _settingsLoaded &&
|
||||
!_hasCompletedOnboarding &&
|
||||
provider.isConnected &&
|
||||
provider.selectedPlayer != null;
|
||||
|
||||
// Show welcome backdrop if:
|
||||
// 1. Already in hint mode (_isHintModeActive), OR
|
||||
// 2. First-time user ready but hint mode not started yet (!_hintTriggered)
|
||||
// This ensures backdrop appears IMMEDIATELY when HomeScreen renders,
|
||||
// preventing the flash. Welcome content fades in after via animation.
|
||||
final shouldShowWelcomeBackdrop = _isHintModeActive ||
|
||||
(isFirstTimeUserReady && !_hintTriggered);
|
||||
|
||||
// Trigger hint mode if conditions are met (for animations, bounce, etc)
|
||||
if (isFirstTimeUserReady && !_hintTriggered) {
|
||||
// Schedule for post-frame to avoid setState during build
|
||||
WidgetsBinding.instance.addPostFrameCallback((_) {
|
||||
if (mounted && !_hintTriggered) {
|
||||
_miniPlayerHintsReady = true;
|
||||
_startWelcomeScreen();
|
||||
_startMiniPlayerBounce();
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
// Handle back gesture at top level - dismiss hint mode or device list if visible
|
||||
return PopScope(
|
||||
canPop: !_isRevealVisible,
|
||||
canPop: !_isRevealVisible && !_isHintModeActive,
|
||||
onPopInvokedWithResult: (didPop, result) {
|
||||
if (!didPop && _isRevealVisible) {
|
||||
_dismissPlayerReveal();
|
||||
if (!didPop) {
|
||||
if (_isHintModeActive) {
|
||||
_endHintMode();
|
||||
} else if (_isRevealVisible) {
|
||||
_dismissPlayerReveal();
|
||||
}
|
||||
}
|
||||
},
|
||||
child: Stack(
|
||||
@@ -260,14 +460,18 @@ class _GlobalPlayerOverlayState extends State<GlobalPlayerOverlay>
|
||||
child: widget.child,
|
||||
),
|
||||
// Global persistent bottom navigation bar - positioned at bottom
|
||||
Positioned(
|
||||
left: 0,
|
||||
right: 0,
|
||||
bottom: 0,
|
||||
child: ListenableBuilder(
|
||||
listenable: navigationProvider,
|
||||
builder: (context, _) {
|
||||
return Consumer<ThemeProvider>(
|
||||
// Hide when: not connected, no player selected, OR showing welcome screen
|
||||
// For first-time users, selectedPlayer becomes non-null at the same time
|
||||
// as shouldShowWelcomeBackdrop becomes true, preventing any gap.
|
||||
if (provider.isConnected && provider.selectedPlayer != null && !shouldShowWelcomeBackdrop)
|
||||
Positioned(
|
||||
left: 0,
|
||||
right: 0,
|
||||
bottom: 0,
|
||||
child: ListenableBuilder(
|
||||
listenable: navigationProvider,
|
||||
builder: (context, _) {
|
||||
return Consumer<ThemeProvider>(
|
||||
builder: (context, themeProvider, _) {
|
||||
// Use adaptive primary color for bottom nav when adaptive theme is enabled
|
||||
final sourceColor = themeProvider.adaptiveTheme
|
||||
@@ -356,9 +560,125 @@ class _GlobalPlayerOverlayState extends State<GlobalPlayerOverlay>
|
||||
);
|
||||
},
|
||||
);
|
||||
},
|
||||
},
|
||||
),
|
||||
),
|
||||
),
|
||||
// Blur backdrop for device selector (reveal mode) - static, no animation
|
||||
if (_isRevealVisible && !_isHintModeActive)
|
||||
Positioned.fill(
|
||||
child: GestureDetector(
|
||||
behavior: HitTestBehavior.opaque,
|
||||
onTap: _dismissPlayerReveal,
|
||||
child: BackdropFilter(
|
||||
filter: ImageFilter.blur(sigmaX: 8.0, sigmaY: 8.0),
|
||||
child: Container(
|
||||
color: colorScheme.surface.withOpacity(0.5),
|
||||
),
|
||||
),
|
||||
),
|
||||
),
|
||||
|
||||
// Welcome/hint backdrop - shows IMMEDIATELY when first-time user is ready.
|
||||
// Uses computed `shouldShowWelcomeBackdrop` which is true BEFORE _isHintModeActive,
|
||||
// preventing the 1-frame gap where home screen would be visible.
|
||||
if (shouldShowWelcomeBackdrop)
|
||||
Positioned.fill(
|
||||
child: TweenAnimationBuilder<double>(
|
||||
// Hold solid for 2s, then fade to 0.5 over 1s
|
||||
tween: Tween<double>(begin: 1.0, end: 0.5),
|
||||
duration: const Duration(seconds: 3),
|
||||
curve: const Interval(0.67, 1.0, curve: Curves.easeOut),
|
||||
builder: (context, opacity, child) {
|
||||
return BackdropFilter(
|
||||
filter: ImageFilter.blur(sigmaX: 8.0, sigmaY: 8.0),
|
||||
child: Container(
|
||||
// Use same dark color as connection screen for seamless transition
|
||||
color: const Color(0xFF1a1a1a).withOpacity(opacity),
|
||||
),
|
||||
);
|
||||
},
|
||||
),
|
||||
),
|
||||
|
||||
// Welcome message during hint mode - two positioned sections with fade-in
|
||||
// Top section: Logo and Welcome title (stays fixed at top area)
|
||||
if (_isHintModeActive)
|
||||
Positioned(
|
||||
left: 24,
|
||||
right: 24,
|
||||
// Position logo section high up - about 1/3 from top
|
||||
top: MediaQuery.of(context).size.height * 0.15,
|
||||
child: FadeTransition(
|
||||
opacity: CurvedAnimation(
|
||||
parent: _welcomeFadeController,
|
||||
curve: Curves.easeOut,
|
||||
),
|
||||
child: Column(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
// Ensemble logo - same as settings screen
|
||||
Image.asset(
|
||||
'assets/images/ensemble_icon_transparent.png',
|
||||
width: MediaQuery.of(context).size.width * 0.5,
|
||||
fit: BoxFit.contain,
|
||||
),
|
||||
const SizedBox(height: 24),
|
||||
// Welcome title
|
||||
Text(
|
||||
S.of(context)!.welcomeToEnsemble,
|
||||
style: theme.textTheme.headlineSmall?.copyWith(
|
||||
color: Colors.white,
|
||||
fontWeight: FontWeight.bold,
|
||||
),
|
||||
textAlign: TextAlign.center,
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
|
||||
// Bottom section: Hint text and Skip button (only show once mini player is visible)
|
||||
if (_isHintModeActive && _miniPlayerHintsReady)
|
||||
Positioned(
|
||||
left: 24,
|
||||
right: 24,
|
||||
// Position so skip button is ~32px above mini player, matching skip-to-miniplayer gap
|
||||
bottom: BottomSpacing.navBarHeight + BottomSpacing.miniPlayerHeight + MediaQuery.of(context).padding.bottom + 32,
|
||||
child: FadeTransition(
|
||||
opacity: CurvedAnimation(
|
||||
parent: _welcomeFadeController,
|
||||
curve: Curves.easeOut,
|
||||
),
|
||||
child: Column(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
// Hint text
|
||||
Text(
|
||||
S.of(context)!.welcomeMessage,
|
||||
style: theme.textTheme.bodyLarge?.copyWith(
|
||||
color: Colors.white,
|
||||
fontSize: 16,
|
||||
height: 1.4,
|
||||
),
|
||||
textAlign: TextAlign.center,
|
||||
),
|
||||
const SizedBox(height: 32),
|
||||
// Skip button - same gap above as below to mini player
|
||||
TextButton(
|
||||
onPressed: _endHintMode,
|
||||
child: Text(
|
||||
S.of(context)!.skip,
|
||||
style: TextStyle(
|
||||
color: Colors.white.withOpacity(0.7),
|
||||
fontSize: 14,
|
||||
),
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
|
||||
// Player reveal overlay - renders BELOW mini player so cards slide behind it
|
||||
if (_isRevealVisible)
|
||||
PlayerRevealOverlay(
|
||||
@@ -366,30 +686,45 @@ class _GlobalPlayerOverlayState extends State<GlobalPlayerOverlay>
|
||||
onDismiss: _hidePlayerReveal,
|
||||
miniPlayerBottom: BottomSpacing.navBarHeight + MediaQuery.of(context).padding.bottom + 12,
|
||||
miniPlayerHeight: 64,
|
||||
showOnboardingHints: _isOnboardingReveal,
|
||||
),
|
||||
|
||||
// Global player overlay - renders ON TOP so cards slide behind it
|
||||
// Use Selector instead of Consumer to avoid rebuilds during animation
|
||||
Selector<MusicAssistantProvider, ({bool isConnected, bool hasPlayer})>(
|
||||
Selector<MusicAssistantProvider, ({bool isConnected, bool hasPlayer, bool hasTrack})>(
|
||||
selector: (_, provider) => (
|
||||
isConnected: provider.isConnected,
|
||||
hasPlayer: provider.selectedPlayer != null,
|
||||
hasTrack: provider.currentTrack != null,
|
||||
),
|
||||
builder: (context, state, child) {
|
||||
// Only show player if connected and has a selected player
|
||||
if (!state.isConnected || !state.hasPlayer) {
|
||||
return const SizedBox.shrink();
|
||||
}
|
||||
return AnimatedBuilder(
|
||||
animation: _slideAnimation,
|
||||
child: ExpandablePlayer(key: globalPlayerKey, slideOffset: 0),
|
||||
builder: (context, staticChild) {
|
||||
// Only slideOffset changes during animation, player widget stays same
|
||||
return ExpandablePlayer(
|
||||
key: globalPlayerKey,
|
||||
slideOffset: _slideAnimation.value,
|
||||
bounceOffset: _bounceOffset,
|
||||
onRevealPlayers: _showPlayerReveal,
|
||||
|
||||
// Combine slide, bounce, and hint animations with ValueListenableBuilders
|
||||
// This prevents full widget tree rebuilds - only ExpandablePlayer updates
|
||||
return ValueListenableBuilder<double>(
|
||||
valueListenable: _bounceOffsetNotifier,
|
||||
builder: (context, bounceOffset, _) {
|
||||
return ValueListenableBuilder<double>(
|
||||
valueListenable: _hintOpacityNotifier,
|
||||
builder: (context, hintOpacity, _) {
|
||||
return AnimatedBuilder(
|
||||
animation: _slideAnimation,
|
||||
builder: (context, _) {
|
||||
return ExpandablePlayer(
|
||||
key: globalPlayerKey,
|
||||
slideOffset: _slideAnimation.value,
|
||||
bounceOffset: bounceOffset,
|
||||
onRevealPlayers: _showPlayerReveal,
|
||||
isDeviceRevealVisible: _isRevealVisible,
|
||||
isHintVisible: hintOpacity > 0,
|
||||
);
|
||||
},
|
||||
);
|
||||
},
|
||||
);
|
||||
},
|
||||
);
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
import 'package:flutter/material.dart';
|
||||
import '../../l10n/app_localizations.dart';
|
||||
import 'mini_player_content.dart';
|
||||
|
||||
/// A compact device selector bar shown when no track is playing
|
||||
class DeviceSelectorBar extends StatelessWidget {
|
||||
@@ -34,6 +35,8 @@ class DeviceSelectorBar extends StatelessWidget {
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
final swipeHint = hasMultiplePlayers ? S.of(context)!.swipeToSwitchDevice : null;
|
||||
|
||||
return GestureDetector(
|
||||
onHorizontalDragStart: hasMultiplePlayers ? onHorizontalDragStart : null,
|
||||
onHorizontalDragUpdate: hasMultiplePlayers ? onHorizontalDragUpdate : null,
|
||||
@@ -52,59 +55,19 @@ class DeviceSelectorBar extends StatelessWidget {
|
||||
children: [
|
||||
// Peek player content (shows when dragging)
|
||||
if (slideOffset.abs() > 0.01 && peekPlayer != null)
|
||||
_buildPeekContent(context),
|
||||
_buildPeekContent(context, swipeHint),
|
||||
|
||||
// Current player content
|
||||
Transform.translate(
|
||||
offset: Offset(slideOffset * width, 0),
|
||||
child: Row(
|
||||
children: [
|
||||
// Speaker icon - same size as album art for consistent text alignment
|
||||
SizedBox(
|
||||
width: height,
|
||||
height: height,
|
||||
child: Container(
|
||||
color: Color.lerp(backgroundColor, Colors.black, 0.15),
|
||||
child: Center(
|
||||
child: Icon(
|
||||
_getPlayerIcon(selectedPlayer.name),
|
||||
color: textColor.withOpacity(0.4),
|
||||
size: 28,
|
||||
),
|
||||
),
|
||||
),
|
||||
),
|
||||
Expanded(
|
||||
child: Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 12),
|
||||
child: Column(
|
||||
mainAxisAlignment: MainAxisAlignment.center,
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
children: [
|
||||
Text(
|
||||
selectedPlayer.name,
|
||||
style: TextStyle(
|
||||
color: textColor,
|
||||
fontSize: 16,
|
||||
fontWeight: FontWeight.w500,
|
||||
),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
if (hasMultiplePlayers)
|
||||
Text(
|
||||
S.of(context)!.swipeToSwitchDevice,
|
||||
style: TextStyle(
|
||||
color: textColor.withOpacity(0.6),
|
||||
fontSize: 14,
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
MiniPlayerContent(
|
||||
primaryText: selectedPlayer.name,
|
||||
secondaryText: swipeHint,
|
||||
imageUrl: null,
|
||||
playerName: selectedPlayer.name,
|
||||
backgroundColor: backgroundColor,
|
||||
textColor: textColor,
|
||||
width: width,
|
||||
slideOffset: slideOffset,
|
||||
isHint: swipeHint != null,
|
||||
),
|
||||
],
|
||||
),
|
||||
@@ -115,7 +78,7 @@ class DeviceSelectorBar extends StatelessWidget {
|
||||
}
|
||||
|
||||
/// Build peek player content that slides in from the edge
|
||||
Widget _buildPeekContent(BuildContext context) {
|
||||
Widget _buildPeekContent(BuildContext context, String? swipeHint) {
|
||||
final isFromRight = slideOffset < 0;
|
||||
final peekProgress = slideOffset.abs();
|
||||
|
||||
@@ -126,70 +89,17 @@ class DeviceSelectorBar extends StatelessWidget {
|
||||
|
||||
return Transform.translate(
|
||||
offset: Offset(peekBaseOffset, 0),
|
||||
child: Row(
|
||||
children: [
|
||||
// Speaker icon - same size as album art for consistent text alignment
|
||||
SizedBox(
|
||||
width: height,
|
||||
height: height,
|
||||
child: Container(
|
||||
color: Color.lerp(backgroundColor, Colors.black, 0.15),
|
||||
child: Center(
|
||||
child: Icon(
|
||||
_getPlayerIcon(peekPlayer.name),
|
||||
color: textColor.withOpacity(0.4),
|
||||
size: 28,
|
||||
),
|
||||
),
|
||||
),
|
||||
),
|
||||
Expanded(
|
||||
child: Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 12),
|
||||
child: Column(
|
||||
mainAxisAlignment: MainAxisAlignment.center,
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
children: [
|
||||
Text(
|
||||
peekPlayer.name,
|
||||
style: TextStyle(
|
||||
color: textColor,
|
||||
fontSize: 16,
|
||||
fontWeight: FontWeight.w500,
|
||||
),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
if (hasMultiplePlayers)
|
||||
Text(
|
||||
S.of(context)!.swipeToSwitchDevice,
|
||||
style: TextStyle(
|
||||
color: textColor.withOpacity(0.6),
|
||||
fontSize: 14,
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
],
|
||||
child: MiniPlayerContent(
|
||||
primaryText: peekPlayer.name,
|
||||
secondaryText: swipeHint,
|
||||
imageUrl: null,
|
||||
playerName: peekPlayer.name,
|
||||
backgroundColor: backgroundColor,
|
||||
textColor: textColor,
|
||||
width: width,
|
||||
slideOffset: 0, // No additional slide - Transform handles positioning
|
||||
isHint: swipeHint != null,
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
/// Get appropriate icon for player based on name
|
||||
IconData _getPlayerIcon(String playerName) {
|
||||
final nameLower = playerName.toLowerCase();
|
||||
if (nameLower.contains('phone') || nameLower.contains('ensemble')) {
|
||||
return Icons.phone_android_rounded;
|
||||
} else if (nameLower.contains('group')) {
|
||||
return Icons.speaker_group_rounded;
|
||||
} else if (nameLower.contains('tv') || nameLower.contains('television')) {
|
||||
return Icons.tv_rounded;
|
||||
} else if (nameLower.contains('cast') || nameLower.contains('chromecast')) {
|
||||
return Icons.cast_rounded;
|
||||
} else {
|
||||
return Icons.speaker_rounded;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,249 @@
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:cached_network_image/cached_network_image.dart';
|
||||
|
||||
/// Shared constants for mini player layout
|
||||
class MiniPlayerLayout {
|
||||
static const double height = 72.0;
|
||||
static const double artSize = 72.0;
|
||||
static const double textLeftOffset = 10.0; // Gap between art and text
|
||||
static const double textLeft = artSize + textLeftOffset; // 82px
|
||||
// 3-line layout: track, artist, player
|
||||
static const double primaryTop = 7.0;
|
||||
static const double secondaryTop = 27.0;
|
||||
static const double tertiaryTop = 46.0;
|
||||
// 2-line layout (centered): player name, hint
|
||||
static const double primaryTop2Line = 16.0;
|
||||
static const double secondaryTop2Line = 36.0;
|
||||
static const double textRightPadding = 12.0;
|
||||
static const double iconSize = 28.0;
|
||||
static const double iconOpacity = 0.4;
|
||||
static const double secondaryTextOpacity = 0.6;
|
||||
static const double primaryFontSize = 16.0;
|
||||
static const double secondaryFontSize = 14.0;
|
||||
static const double tertiaryFontSize = 14.0;
|
||||
static const FontWeight primaryFontWeight = FontWeight.w500;
|
||||
}
|
||||
|
||||
/// Unified mini player content widget used by:
|
||||
/// - DeviceSelectorBar (non-playing state)
|
||||
/// - ExpandablePlayer collapsed state (playing state)
|
||||
/// - Peek content during swipe gestures
|
||||
class MiniPlayerContent extends StatelessWidget {
|
||||
/// Primary text line (track name or device name)
|
||||
final String primaryText;
|
||||
|
||||
/// Secondary text line (artist name or "Swipe to switch device")
|
||||
/// If null, primary text will be vertically centered
|
||||
final String? secondaryText;
|
||||
|
||||
/// Tertiary text line (player name when playing)
|
||||
/// If provided, uses 3-line layout; if null, uses centered 2-line layout
|
||||
final String? tertiaryText;
|
||||
|
||||
/// Album art URL - if null, shows device icon
|
||||
final String? imageUrl;
|
||||
|
||||
/// Player name for icon selection when no image
|
||||
final String playerName;
|
||||
|
||||
/// Background color for the content area
|
||||
final Color backgroundColor;
|
||||
|
||||
/// Text color
|
||||
final Color textColor;
|
||||
|
||||
/// Width of the content area
|
||||
final double width;
|
||||
|
||||
/// Horizontal slide offset for swipe animation (-1 to 1)
|
||||
final double slideOffset;
|
||||
|
||||
/// Whether secondary text is a hint (shows lightbulb icon)
|
||||
final bool isHint;
|
||||
|
||||
/// Whether to show the progress bar overlay (for playing state)
|
||||
final bool showProgress;
|
||||
|
||||
/// Progress value 0.0 to 1.0 (only used if showProgress is true)
|
||||
final double progress;
|
||||
|
||||
const MiniPlayerContent({
|
||||
super.key,
|
||||
required this.primaryText,
|
||||
this.secondaryText,
|
||||
this.tertiaryText,
|
||||
this.imageUrl,
|
||||
required this.playerName,
|
||||
required this.backgroundColor,
|
||||
required this.textColor,
|
||||
required this.width,
|
||||
this.slideOffset = 0.0,
|
||||
this.isHint = false,
|
||||
this.showProgress = false,
|
||||
this.progress = 0.0,
|
||||
});
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
final hasSecondaryLine = secondaryText != null && secondaryText!.isNotEmpty;
|
||||
final hasTertiaryLine = tertiaryText != null && tertiaryText!.isNotEmpty;
|
||||
final slidePixels = slideOffset * width;
|
||||
|
||||
// Use 3-line layout when tertiary exists, 2-line centered otherwise
|
||||
final primaryTop = hasTertiaryLine ? MiniPlayerLayout.primaryTop : MiniPlayerLayout.primaryTop2Line;
|
||||
final secondaryTop = hasTertiaryLine ? MiniPlayerLayout.secondaryTop : MiniPlayerLayout.secondaryTop2Line;
|
||||
|
||||
// Calculate text width (leaves room for right padding)
|
||||
final textWidth = width - MiniPlayerLayout.textLeft - MiniPlayerLayout.textRightPadding;
|
||||
|
||||
// Darkened background for icon area (matches DeviceSelectorBar)
|
||||
final iconAreaBackground = Color.lerp(backgroundColor, Colors.black, 0.15)!;
|
||||
|
||||
return SizedBox(
|
||||
width: width,
|
||||
height: MiniPlayerLayout.height,
|
||||
child: Stack(
|
||||
clipBehavior: Clip.hardEdge,
|
||||
children: [
|
||||
// Progress bar background (only for playing state)
|
||||
if (showProgress && progress > 0)
|
||||
Positioned(
|
||||
left: MiniPlayerLayout.artSize + slidePixels,
|
||||
top: 0,
|
||||
bottom: 0,
|
||||
width: (width - MiniPlayerLayout.artSize) * progress,
|
||||
child: Container(color: backgroundColor),
|
||||
),
|
||||
|
||||
// Art / Icon area - centered vertically
|
||||
Positioned(
|
||||
left: slidePixels,
|
||||
top: (MiniPlayerLayout.height - MiniPlayerLayout.artSize) / 2,
|
||||
child: SizedBox(
|
||||
width: MiniPlayerLayout.artSize,
|
||||
height: MiniPlayerLayout.artSize,
|
||||
child: imageUrl != null
|
||||
? CachedNetworkImage(
|
||||
imageUrl: imageUrl!,
|
||||
fit: BoxFit.cover,
|
||||
memCacheWidth: 256,
|
||||
memCacheHeight: 256,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (_, __) => _buildIconArea(iconAreaBackground),
|
||||
errorWidget: (_, __, ___) => _buildIconArea(iconAreaBackground),
|
||||
)
|
||||
: _buildIconArea(iconAreaBackground),
|
||||
),
|
||||
),
|
||||
|
||||
// Primary text line
|
||||
Positioned(
|
||||
left: MiniPlayerLayout.textLeft + slidePixels,
|
||||
top: hasSecondaryLine
|
||||
? primaryTop
|
||||
: (MiniPlayerLayout.height - MiniPlayerLayout.primaryFontSize) / 2,
|
||||
right: MiniPlayerLayout.textRightPadding - slidePixels,
|
||||
child: Text(
|
||||
primaryText,
|
||||
style: TextStyle(
|
||||
color: textColor,
|
||||
fontSize: MiniPlayerLayout.primaryFontSize,
|
||||
fontWeight: MiniPlayerLayout.primaryFontWeight,
|
||||
),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
),
|
||||
|
||||
// Secondary text line (with optional hint icon)
|
||||
if (hasSecondaryLine)
|
||||
Positioned(
|
||||
left: MiniPlayerLayout.textLeft + slidePixels,
|
||||
top: secondaryTop,
|
||||
right: MiniPlayerLayout.textRightPadding - slidePixels,
|
||||
child: isHint
|
||||
? Row(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
Icon(
|
||||
Icons.lightbulb_outline,
|
||||
size: 14,
|
||||
color: textColor.withOpacity(MiniPlayerLayout.secondaryTextOpacity),
|
||||
),
|
||||
const SizedBox(width: 4),
|
||||
Flexible(
|
||||
child: Text(
|
||||
secondaryText!,
|
||||
style: TextStyle(
|
||||
color: textColor.withOpacity(MiniPlayerLayout.secondaryTextOpacity),
|
||||
fontSize: MiniPlayerLayout.secondaryFontSize,
|
||||
),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
),
|
||||
],
|
||||
)
|
||||
: Text(
|
||||
secondaryText!,
|
||||
style: TextStyle(
|
||||
color: textColor.withOpacity(MiniPlayerLayout.secondaryTextOpacity),
|
||||
fontSize: MiniPlayerLayout.secondaryFontSize,
|
||||
),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
),
|
||||
|
||||
// Tertiary text line (player name, only for 3-line layout)
|
||||
if (hasTertiaryLine)
|
||||
Positioned(
|
||||
left: MiniPlayerLayout.textLeft + slidePixels,
|
||||
top: MiniPlayerLayout.tertiaryTop,
|
||||
right: MiniPlayerLayout.textRightPadding - slidePixels,
|
||||
child: Text(
|
||||
tertiaryText!,
|
||||
style: TextStyle(
|
||||
color: textColor,
|
||||
fontSize: MiniPlayerLayout.tertiaryFontSize,
|
||||
),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
/// Build the icon area with device-appropriate icon
|
||||
Widget _buildIconArea(Color background) {
|
||||
return Container(
|
||||
color: background,
|
||||
child: Center(
|
||||
child: Icon(
|
||||
_getPlayerIcon(playerName),
|
||||
color: textColor.withOpacity(MiniPlayerLayout.iconOpacity),
|
||||
size: MiniPlayerLayout.iconSize,
|
||||
),
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
/// Get appropriate icon based on player name
|
||||
static IconData _getPlayerIcon(String playerName) {
|
||||
final nameLower = playerName.toLowerCase();
|
||||
if (nameLower.contains('phone') || nameLower.contains('ensemble') || nameLower.contains('mobile')) {
|
||||
return Icons.phone_android_rounded;
|
||||
} else if (nameLower.contains('group') || nameLower.contains('sync') || nameLower.contains('all')) {
|
||||
return Icons.speaker_group_rounded;
|
||||
} else if (nameLower.contains('tv') || nameLower.contains('television')) {
|
||||
return Icons.tv_rounded;
|
||||
} else if (nameLower.contains('cast') || nameLower.contains('chromecast')) {
|
||||
return Icons.cast_rounded;
|
||||
} else {
|
||||
return Icons.speaker_rounded;
|
||||
}
|
||||
}
|
||||
}
|
||||
+280
-135
@@ -1,4 +1,5 @@
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter/services.dart';
|
||||
import 'package:cached_network_image/cached_network_image.dart';
|
||||
import '../../providers/music_assistant_provider.dart';
|
||||
import '../../theme/design_tokens.dart';
|
||||
@@ -6,18 +7,25 @@ import '../../l10n/app_localizations.dart';
|
||||
|
||||
/// A player card that matches the mini player's visual style.
|
||||
/// Used in the player reveal overlay when swiping down or tapping the device button.
|
||||
class PlayerCard extends StatelessWidget {
|
||||
/// Supports horizontal swipe to adjust volume with a two-tone overlay.
|
||||
class PlayerCard extends StatefulWidget {
|
||||
final dynamic player;
|
||||
final dynamic trackInfo;
|
||||
final String? albumArtUrl;
|
||||
final bool isSelected;
|
||||
final bool isPlaying;
|
||||
final bool isGrouped;
|
||||
final Color backgroundColor;
|
||||
final Color textColor;
|
||||
final VoidCallback onTap;
|
||||
final VoidCallback? onLongPress;
|
||||
final VoidCallback? onPlayPause;
|
||||
final VoidCallback? onSkipNext;
|
||||
final VoidCallback? onPower;
|
||||
final ValueChanged<double>? onVolumeChange;
|
||||
|
||||
// Pastel yellow for grouped players
|
||||
static const Color groupBorderColor = Color(0xFFFFF59D);
|
||||
|
||||
const PlayerCard({
|
||||
super.key,
|
||||
@@ -26,176 +34,313 @@ class PlayerCard extends StatelessWidget {
|
||||
this.albumArtUrl,
|
||||
required this.isSelected,
|
||||
required this.isPlaying,
|
||||
this.isGrouped = false,
|
||||
required this.backgroundColor,
|
||||
required this.textColor,
|
||||
required this.onTap,
|
||||
this.onLongPress,
|
||||
this.onPlayPause,
|
||||
this.onSkipNext,
|
||||
this.onPower,
|
||||
this.onVolumeChange,
|
||||
});
|
||||
|
||||
@override
|
||||
State<PlayerCard> createState() => _PlayerCardState();
|
||||
}
|
||||
|
||||
class _PlayerCardState extends State<PlayerCard> {
|
||||
bool _isDraggingVolume = false;
|
||||
double _dragVolumeLevel = 0.0;
|
||||
double _cardWidth = 0.0;
|
||||
int _lastVolumeUpdateTime = 0;
|
||||
static const int _volumeThrottleMs = 150; // Only send volume updates every 150ms
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
// Match mini player dimensions
|
||||
const double cardHeight = Dimensions.miniPlayerHeight; // 64px
|
||||
const double cardHeight = Dimensions.miniPlayerHeight;
|
||||
const double artSize = cardHeight;
|
||||
const double borderRadius = Radii.xl; // 16px - same as mini player
|
||||
|
||||
return GestureDetector(
|
||||
onTap: onTap,
|
||||
child: Container(
|
||||
height: cardHeight,
|
||||
decoration: BoxDecoration(
|
||||
color: backgroundColor,
|
||||
borderRadius: BorderRadius.circular(borderRadius),
|
||||
boxShadow: [
|
||||
BoxShadow(
|
||||
color: Colors.black.withOpacity(0.2),
|
||||
blurRadius: 8,
|
||||
offset: const Offset(0, 2),
|
||||
),
|
||||
],
|
||||
),
|
||||
clipBehavior: Clip.antiAlias,
|
||||
child: Row(
|
||||
children: [
|
||||
// Album art or speaker icon - same size for consistent text alignment
|
||||
SizedBox(
|
||||
width: artSize,
|
||||
height: artSize,
|
||||
child: albumArtUrl != null
|
||||
? CachedNetworkImage(
|
||||
imageUrl: albumArtUrl!,
|
||||
fit: BoxFit.cover,
|
||||
memCacheWidth: 128,
|
||||
memCacheHeight: 128,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (_, __) => _buildSpeakerIcon(),
|
||||
errorWidget: (_, __, ___) => _buildSpeakerIcon(),
|
||||
)
|
||||
: _buildSpeakerIcon(),
|
||||
),
|
||||
// Colors for volume overlay (same as mini player progress bar)
|
||||
final filledColor = widget.backgroundColor;
|
||||
final unfilledColor = Color.lerp(widget.backgroundColor, Colors.black, 0.3)!;
|
||||
|
||||
// Player info
|
||||
Expanded(
|
||||
child: Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 12),
|
||||
child: Column(
|
||||
mainAxisAlignment: MainAxisAlignment.center,
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
children: [
|
||||
// Player name
|
||||
Row(
|
||||
children: [
|
||||
// Status indicator
|
||||
Container(
|
||||
width: 8,
|
||||
height: 8,
|
||||
margin: const EdgeInsets.only(right: 8),
|
||||
decoration: BoxDecoration(
|
||||
shape: BoxShape.circle,
|
||||
color: _getStatusColor(),
|
||||
),
|
||||
),
|
||||
Expanded(
|
||||
child: Text(
|
||||
player.name,
|
||||
style: TextStyle(
|
||||
color: textColor,
|
||||
fontSize: 16,
|
||||
fontWeight: FontWeight.w500,
|
||||
fontFamily: 'Roboto',
|
||||
decoration: TextDecoration.none,
|
||||
),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
const SizedBox(height: 2),
|
||||
// Track name or status
|
||||
Text(
|
||||
_getSubtitle(context),
|
||||
style: TextStyle(
|
||||
color: textColor.withOpacity(0.6),
|
||||
fontSize: 14,
|
||||
fontFamily: 'Roboto',
|
||||
decoration: TextDecoration.none,
|
||||
return LayoutBuilder(
|
||||
builder: (context, constraints) {
|
||||
_cardWidth = constraints.maxWidth;
|
||||
|
||||
return GestureDetector(
|
||||
onTap: _isDraggingVolume ? null : widget.onTap,
|
||||
onLongPress: _isDraggingVolume ? null : widget.onLongPress,
|
||||
onHorizontalDragStart: _onDragStart,
|
||||
onHorizontalDragUpdate: _onDragUpdate,
|
||||
onHorizontalDragEnd: _onDragEnd,
|
||||
onHorizontalDragCancel: _onDragCancel,
|
||||
// Use Stack to render border ON TOP of content, preventing album art clipping
|
||||
child: Stack(
|
||||
children: [
|
||||
// Main card content (hidden when dragging volume)
|
||||
if (!_isDraggingVolume)
|
||||
_buildCardContent(cardHeight, artSize, borderRadius),
|
||||
|
||||
// Volume overlay (shown when dragging)
|
||||
if (_isDraggingVolume)
|
||||
Container(
|
||||
height: cardHeight,
|
||||
decoration: BoxDecoration(
|
||||
color: unfilledColor,
|
||||
borderRadius: BorderRadius.circular(borderRadius),
|
||||
boxShadow: [
|
||||
BoxShadow(
|
||||
color: Colors.black.withOpacity(0.2),
|
||||
blurRadius: 8,
|
||||
offset: const Offset(0, 2),
|
||||
),
|
||||
],
|
||||
),
|
||||
clipBehavior: Clip.antiAlias,
|
||||
child: Align(
|
||||
alignment: Alignment.centerLeft,
|
||||
child: FractionallySizedBox(
|
||||
widthFactor: _dragVolumeLevel.clamp(0.0, 1.0),
|
||||
heightFactor: 1.0,
|
||||
child: Container(
|
||||
decoration: BoxDecoration(
|
||||
color: filledColor,
|
||||
borderRadius: BorderRadius.only(
|
||||
topLeft: Radius.circular(borderRadius),
|
||||
bottomLeft: Radius.circular(borderRadius),
|
||||
),
|
||||
),
|
||||
),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
|
||||
// Transport controls - compact sizing to align with mini player
|
||||
// Play/Pause and Next only shown when powered with content
|
||||
if (player.available && player.powered && trackInfo != null) ...[
|
||||
// Play/Pause - slight nudge right
|
||||
Transform.translate(
|
||||
offset: const Offset(3, 0),
|
||||
child: SizedBox(
|
||||
width: 28,
|
||||
height: 28,
|
||||
child: IconButton(
|
||||
icon: Icon(
|
||||
isPlaying ? Icons.pause_rounded : Icons.play_arrow_rounded,
|
||||
color: textColor,
|
||||
size: 28,
|
||||
),
|
||||
onPressed: onPlayPause,
|
||||
padding: EdgeInsets.zero,
|
||||
),
|
||||
),
|
||||
|
||||
// Border overlay - renders ON TOP to prevent clipping by album art
|
||||
if (widget.isGrouped)
|
||||
Positioned.fill(
|
||||
child: Container(
|
||||
decoration: BoxDecoration(
|
||||
borderRadius: BorderRadius.circular(borderRadius),
|
||||
border: Border.all(color: PlayerCard.groupBorderColor, width: 1.5),
|
||||
),
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
);
|
||||
},
|
||||
);
|
||||
}
|
||||
|
||||
Widget _buildCardContent(double cardHeight, double artSize, double borderRadius) {
|
||||
return Container(
|
||||
height: cardHeight,
|
||||
decoration: BoxDecoration(
|
||||
color: widget.backgroundColor,
|
||||
borderRadius: BorderRadius.circular(borderRadius),
|
||||
boxShadow: [
|
||||
BoxShadow(
|
||||
color: Colors.black.withOpacity(0.2),
|
||||
blurRadius: 8,
|
||||
offset: const Offset(0, 2),
|
||||
),
|
||||
],
|
||||
),
|
||||
clipBehavior: Clip.antiAlias,
|
||||
child: Row(
|
||||
children: [
|
||||
// Album art or speaker icon - same size for consistent text alignment
|
||||
SizedBox(
|
||||
width: artSize,
|
||||
height: artSize,
|
||||
child: widget.albumArtUrl != null
|
||||
? CachedNetworkImage(
|
||||
imageUrl: widget.albumArtUrl!,
|
||||
fit: BoxFit.cover,
|
||||
memCacheWidth: 128,
|
||||
memCacheHeight: 128,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (_, __) => _buildSpeakerIcon(),
|
||||
errorWidget: (_, __, ___) => _buildSpeakerIcon(),
|
||||
)
|
||||
: _buildSpeakerIcon(),
|
||||
),
|
||||
|
||||
// Player info
|
||||
Expanded(
|
||||
child: Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 12),
|
||||
child: Column(
|
||||
mainAxisAlignment: MainAxisAlignment.center,
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
children: [
|
||||
// Player name
|
||||
Row(
|
||||
children: [
|
||||
// Status indicator
|
||||
Container(
|
||||
width: 8,
|
||||
height: 8,
|
||||
margin: const EdgeInsets.only(right: 8),
|
||||
decoration: BoxDecoration(
|
||||
shape: BoxShape.circle,
|
||||
color: _getStatusColor(),
|
||||
),
|
||||
),
|
||||
Expanded(
|
||||
child: Text(
|
||||
widget.player.name,
|
||||
style: TextStyle(
|
||||
color: widget.textColor,
|
||||
fontSize: 16,
|
||||
fontWeight: FontWeight.w500,
|
||||
fontFamily: 'Roboto',
|
||||
decoration: TextDecoration.none,
|
||||
),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
const SizedBox(height: 2),
|
||||
// Track name or status
|
||||
Text(
|
||||
_getSubtitle(context),
|
||||
style: TextStyle(
|
||||
color: widget.textColor.withOpacity(0.6),
|
||||
fontSize: 14,
|
||||
fontFamily: 'Roboto',
|
||||
decoration: TextDecoration.none,
|
||||
),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
],
|
||||
),
|
||||
// Skip next - nudged right to close gap with power
|
||||
Transform.translate(
|
||||
offset: const Offset(6, 0),
|
||||
),
|
||||
),
|
||||
|
||||
// Transport controls - compact sizing to align with mini player
|
||||
// Play/Pause and Next only shown when powered with content
|
||||
if (widget.player.available && widget.player.powered && widget.trackInfo != null) ...[
|
||||
// Play/Pause - slight nudge right
|
||||
// Touch target increased to 44dp for accessibility (icon remains 28)
|
||||
Transform.translate(
|
||||
offset: const Offset(3, 0),
|
||||
child: SizedBox(
|
||||
width: 44,
|
||||
height: 44,
|
||||
child: IconButton(
|
||||
icon: Icon(
|
||||
Icons.skip_next_rounded,
|
||||
color: textColor,
|
||||
widget.isPlaying ? Icons.pause_rounded : Icons.play_arrow_rounded,
|
||||
color: widget.textColor,
|
||||
size: 28,
|
||||
),
|
||||
onPressed: onSkipNext,
|
||||
onPressed: widget.onPlayPause,
|
||||
padding: EdgeInsets.zero,
|
||||
constraints: const BoxConstraints(),
|
||||
),
|
||||
),
|
||||
],
|
||||
// Power button - smallest
|
||||
if (player.available)
|
||||
IconButton(
|
||||
),
|
||||
// Skip next - nudged right to close gap with power
|
||||
Transform.translate(
|
||||
offset: const Offset(6, 0),
|
||||
child: IconButton(
|
||||
icon: Icon(
|
||||
Icons.power_settings_new_rounded,
|
||||
color: player.powered ? textColor : textColor.withOpacity(0.5),
|
||||
size: 20,
|
||||
Icons.skip_next_rounded,
|
||||
color: widget.textColor,
|
||||
size: 28,
|
||||
),
|
||||
onPressed: onPower,
|
||||
onPressed: widget.onSkipNext,
|
||||
padding: EdgeInsets.zero,
|
||||
constraints: const BoxConstraints(),
|
||||
),
|
||||
|
||||
const SizedBox(width: 4),
|
||||
),
|
||||
],
|
||||
),
|
||||
// Power button - smallest
|
||||
if (widget.player.available)
|
||||
IconButton(
|
||||
icon: Icon(
|
||||
Icons.power_settings_new_rounded,
|
||||
color: widget.player.powered ? widget.textColor : widget.textColor.withOpacity(0.5),
|
||||
size: 20,
|
||||
),
|
||||
onPressed: widget.onPower,
|
||||
padding: EdgeInsets.zero,
|
||||
constraints: const BoxConstraints(),
|
||||
),
|
||||
|
||||
const SizedBox(width: 4),
|
||||
],
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
void _onDragStart(DragStartDetails details) {
|
||||
// Get current volume from player
|
||||
final currentVolume = (widget.player.volumeLevel ?? 0).toDouble() / 100.0;
|
||||
setState(() {
|
||||
_isDraggingVolume = true;
|
||||
_dragVolumeLevel = currentVolume;
|
||||
});
|
||||
HapticFeedback.lightImpact();
|
||||
}
|
||||
|
||||
void _onDragUpdate(DragUpdateDetails details) {
|
||||
if (!_isDraggingVolume || _cardWidth <= 0) return;
|
||||
|
||||
// Directional volume: drag right = increase, drag left = decrease
|
||||
// Distance determines amount of change (full card width = 100%)
|
||||
// Multiple swipes accumulate - each starts from current volume
|
||||
final dragDelta = details.delta.dx;
|
||||
final volumeDelta = dragDelta / _cardWidth;
|
||||
|
||||
final newVolume = (_dragVolumeLevel + volumeDelta).clamp(0.0, 1.0);
|
||||
|
||||
// Always update visual
|
||||
if ((newVolume - _dragVolumeLevel).abs() > 0.001) {
|
||||
setState(() {
|
||||
_dragVolumeLevel = newVolume;
|
||||
});
|
||||
|
||||
// Throttle API calls to prevent flooding
|
||||
final now = DateTime.now().millisecondsSinceEpoch;
|
||||
if (now - _lastVolumeUpdateTime >= _volumeThrottleMs) {
|
||||
_lastVolumeUpdateTime = now;
|
||||
widget.onVolumeChange?.call(newVolume);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
void _onDragEnd(DragEndDetails details) {
|
||||
// Send final volume on release
|
||||
widget.onVolumeChange?.call(_dragVolumeLevel);
|
||||
setState(() {
|
||||
_isDraggingVolume = false;
|
||||
});
|
||||
HapticFeedback.lightImpact();
|
||||
}
|
||||
|
||||
void _onDragCancel() {
|
||||
setState(() {
|
||||
_isDraggingVolume = false;
|
||||
});
|
||||
}
|
||||
|
||||
Widget _buildSpeakerIcon() {
|
||||
// Darker shade of the card background to match album art square
|
||||
final iconBgColor = Color.lerp(backgroundColor, Colors.black, 0.15)!;
|
||||
final iconBgColor = Color.lerp(widget.backgroundColor, Colors.black, 0.15)!;
|
||||
return Container(
|
||||
color: iconBgColor,
|
||||
child: Center(
|
||||
child: Icon(
|
||||
Icons.speaker_rounded,
|
||||
color: textColor.withOpacity(0.4),
|
||||
color: widget.textColor.withOpacity(0.4),
|
||||
size: 28,
|
||||
),
|
||||
),
|
||||
@@ -203,30 +348,30 @@ class PlayerCard extends StatelessWidget {
|
||||
}
|
||||
|
||||
Color _getStatusColor() {
|
||||
if (!player.available) {
|
||||
if (!widget.player.available) {
|
||||
return Colors.grey.withOpacity(0.5);
|
||||
}
|
||||
if (!player.powered) {
|
||||
if (!widget.player.powered) {
|
||||
return Colors.grey;
|
||||
}
|
||||
if (isPlaying) {
|
||||
if (widget.isPlaying) {
|
||||
return Colors.green;
|
||||
}
|
||||
if (trackInfo != null) {
|
||||
if (widget.trackInfo != null) {
|
||||
return Colors.orange; // Has content but paused
|
||||
}
|
||||
return Colors.grey.shade400; // Idle
|
||||
}
|
||||
|
||||
String _getSubtitle(BuildContext context) {
|
||||
if (!player.available) {
|
||||
if (!widget.player.available) {
|
||||
return S.of(context)!.playerStateUnavailable;
|
||||
}
|
||||
if (!player.powered) {
|
||||
if (!widget.player.powered) {
|
||||
return S.of(context)!.playerStateOff;
|
||||
}
|
||||
if (trackInfo != null) {
|
||||
return trackInfo.name ?? S.of(context)!.playerStateIdle;
|
||||
if (widget.trackInfo != null) {
|
||||
return widget.trackInfo.name ?? S.of(context)!.playerStateIdle;
|
||||
}
|
||||
return S.of(context)!.playerStateIdle;
|
||||
}
|
||||
|
||||
@@ -55,24 +55,29 @@ class PlayerControls extends StatelessWidget {
|
||||
mainAxisAlignment: isExpanded ? MainAxisAlignment.center : MainAxisAlignment.end,
|
||||
children: [
|
||||
// Shuffle (expanded only)
|
||||
if (isExpanded)
|
||||
Opacity(
|
||||
opacity: expandedElementsOpacity,
|
||||
child: _buildSecondaryButton(
|
||||
icon: Icons.shuffle_rounded,
|
||||
color: shuffle == true ? primaryColor : textColor.withOpacity(0.5),
|
||||
onPressed: isLoadingQueue ? null : onToggleShuffle,
|
||||
),
|
||||
// GPU PERF: Use color alpha instead of Opacity to avoid saveLayer
|
||||
if (isExpanded && expandedElementsOpacity > 0.1)
|
||||
_buildSecondaryButton(
|
||||
icon: Icons.shuffle_rounded,
|
||||
// Fix: compute final opacity once to avoid multiplicative opacity bug
|
||||
color: shuffle == true
|
||||
? primaryColor.withOpacity(expandedElementsOpacity)
|
||||
: textColor.withOpacity(0.5 * expandedElementsOpacity),
|
||||
onPressed: isLoadingQueue ? null : onToggleShuffle,
|
||||
),
|
||||
if (isExpanded) SizedBox(width: _lerpDouble(0, 20, t)),
|
||||
|
||||
// Previous
|
||||
_buildControlButton(
|
||||
icon: Icons.skip_previous_rounded,
|
||||
color: textColor,
|
||||
size: skipButtonSize,
|
||||
onPressed: onPrevious,
|
||||
useAnimation: isExpanded,
|
||||
Semantics(
|
||||
button: true,
|
||||
label: 'Previous track',
|
||||
child: _buildControlButton(
|
||||
icon: Icons.skip_previous_rounded,
|
||||
color: textColor,
|
||||
size: skipButtonSize,
|
||||
onPressed: onPrevious,
|
||||
useAnimation: isExpanded,
|
||||
),
|
||||
),
|
||||
SizedBox(width: _lerpDouble(0, 20, t)),
|
||||
|
||||
@@ -81,26 +86,29 @@ class PlayerControls extends StatelessWidget {
|
||||
SizedBox(width: _lerpDouble(0, 20, t)),
|
||||
|
||||
// Next
|
||||
_buildControlButton(
|
||||
icon: Icons.skip_next_rounded,
|
||||
color: textColor,
|
||||
size: skipButtonSize,
|
||||
onPressed: onNext,
|
||||
useAnimation: isExpanded,
|
||||
Semantics(
|
||||
button: true,
|
||||
label: 'Next track',
|
||||
child: _buildControlButton(
|
||||
icon: Icons.skip_next_rounded,
|
||||
color: textColor,
|
||||
size: skipButtonSize,
|
||||
onPressed: onNext,
|
||||
useAnimation: isExpanded,
|
||||
),
|
||||
),
|
||||
|
||||
// Repeat (expanded only)
|
||||
// GPU PERF: Use color alpha instead of Opacity to avoid saveLayer
|
||||
if (isExpanded) SizedBox(width: _lerpDouble(0, 20, t)),
|
||||
if (isExpanded)
|
||||
Opacity(
|
||||
opacity: expandedElementsOpacity,
|
||||
child: _buildSecondaryButton(
|
||||
icon: repeatMode == 'one' ? Icons.repeat_one_rounded : Icons.repeat_rounded,
|
||||
color: repeatMode != null && repeatMode != 'off'
|
||||
? primaryColor
|
||||
: textColor.withOpacity(0.5),
|
||||
onPressed: isLoadingQueue ? null : onCycleRepeat,
|
||||
),
|
||||
if (isExpanded && expandedElementsOpacity > 0.1)
|
||||
_buildSecondaryButton(
|
||||
icon: repeatMode == 'one' ? Icons.repeat_one_rounded : Icons.repeat_rounded,
|
||||
// Fix: compute final opacity once to avoid multiplicative opacity bug
|
||||
color: (repeatMode != null && repeatMode != 'off')
|
||||
? primaryColor.withOpacity(expandedElementsOpacity)
|
||||
: textColor.withOpacity(0.5 * expandedElementsOpacity),
|
||||
onPressed: isLoadingQueue ? null : onCycleRepeat,
|
||||
),
|
||||
],
|
||||
);
|
||||
@@ -153,21 +161,26 @@ class PlayerControls extends StatelessWidget {
|
||||
final bgColor = Color.lerp(Colors.transparent, primaryColor, progress);
|
||||
final iconColor = Color.lerp(textColor, backgroundColor, progress);
|
||||
|
||||
return GestureDetector(
|
||||
onLongPress: onStop,
|
||||
child: Container(
|
||||
width: playButtonContainerSize,
|
||||
height: playButtonContainerSize,
|
||||
decoration: BoxDecoration(
|
||||
color: bgColor,
|
||||
shape: BoxShape.circle,
|
||||
),
|
||||
child: IconButton(
|
||||
icon: Icon(isPlaying ? Icons.pause_rounded : Icons.play_arrow_rounded),
|
||||
color: iconColor,
|
||||
iconSize: playButtonSize,
|
||||
onPressed: onPlayPause,
|
||||
padding: EdgeInsets.zero,
|
||||
return Semantics(
|
||||
button: true,
|
||||
label: isPlaying ? 'Pause' : 'Play',
|
||||
hint: 'Long press to stop',
|
||||
child: GestureDetector(
|
||||
onLongPress: onStop,
|
||||
child: Container(
|
||||
width: playButtonContainerSize,
|
||||
height: playButtonContainerSize,
|
||||
decoration: BoxDecoration(
|
||||
color: bgColor,
|
||||
shape: BoxShape.circle,
|
||||
),
|
||||
child: IconButton(
|
||||
icon: Icon(isPlaying ? Icons.pause_rounded : Icons.play_arrow_rounded),
|
||||
color: iconColor,
|
||||
iconSize: playButtonSize,
|
||||
onPressed: onPlayPause,
|
||||
padding: EdgeInsets.zero,
|
||||
),
|
||||
),
|
||||
),
|
||||
);
|
||||
|
||||
@@ -2,7 +2,9 @@ import 'dart:async';
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter/services.dart';
|
||||
import 'package:provider/provider.dart';
|
||||
import '../../l10n/app_localizations.dart';
|
||||
import '../../providers/music_assistant_provider.dart';
|
||||
import '../../services/settings_service.dart';
|
||||
import '../../theme/design_tokens.dart';
|
||||
import '../../theme/theme_provider.dart';
|
||||
import '../../theme/palette_helper.dart';
|
||||
@@ -16,12 +18,14 @@ class PlayerRevealOverlay extends StatefulWidget {
|
||||
final VoidCallback onDismiss;
|
||||
final double miniPlayerBottom; // Bottom position of mini player
|
||||
final double miniPlayerHeight;
|
||||
final bool showOnboardingHints; // Show additional hints for first-time users
|
||||
|
||||
const PlayerRevealOverlay({
|
||||
super.key,
|
||||
required this.onDismiss,
|
||||
required this.miniPlayerBottom,
|
||||
required this.miniPlayerHeight,
|
||||
this.showOnboardingHints = false,
|
||||
});
|
||||
|
||||
@override
|
||||
@@ -40,13 +44,25 @@ class PlayerRevealOverlayState extends State<PlayerRevealOverlay>
|
||||
double _dragOffset = 0;
|
||||
bool _isDragging = false;
|
||||
|
||||
// Scroll controller for when player list overflows
|
||||
final ScrollController _scrollController = ScrollController();
|
||||
bool _isScrollable = false;
|
||||
|
||||
// Cache extracted colors per player for per-device accent colors
|
||||
final Map<String, ColorScheme?> _playerColors = {};
|
||||
|
||||
// Hint system
|
||||
bool _showHints = true;
|
||||
|
||||
@override
|
||||
void initState() {
|
||||
super.initState();
|
||||
|
||||
// Load hint settings
|
||||
SettingsService.getShowHints().then((value) {
|
||||
if (mounted) setState(() => _showHints = value);
|
||||
});
|
||||
|
||||
_revealController = AnimationController(
|
||||
vsync: this,
|
||||
);
|
||||
@@ -116,6 +132,7 @@ class PlayerRevealOverlayState extends State<PlayerRevealOverlay>
|
||||
void dispose() {
|
||||
_revealController.dispose();
|
||||
_refreshTimer?.cancel();
|
||||
_scrollController.dispose();
|
||||
super.dispose();
|
||||
}
|
||||
|
||||
@@ -127,7 +144,7 @@ class PlayerRevealOverlayState extends State<PlayerRevealOverlay>
|
||||
|
||||
/// Animate dismissal and call callback when done
|
||||
void dismiss() {
|
||||
// Trigger settle bounce on mini player when cards are ~70% collapsed
|
||||
// Trigger single bounce on mini player when cards are ~70% collapsed
|
||||
// This creates the effect of cards "landing" on the mini player
|
||||
bool bounceFired = false;
|
||||
void checkBounce() {
|
||||
@@ -145,19 +162,51 @@ class PlayerRevealOverlayState extends State<PlayerRevealOverlay>
|
||||
});
|
||||
}
|
||||
|
||||
/// Check if scroll is at top (or not scrollable)
|
||||
bool get _isAtTop {
|
||||
if (!_isScrollable) return true;
|
||||
if (!_scrollController.hasClients) return true;
|
||||
return _scrollController.offset <= 0;
|
||||
}
|
||||
|
||||
void _handleVerticalDragUpdate(DragUpdateDetails details) {
|
||||
final delta = details.primaryDelta ?? 0;
|
||||
|
||||
// If scrollable and not at top, let scroll handle it
|
||||
if (_isScrollable && !_isAtTop) {
|
||||
// Scroll the list
|
||||
if (_scrollController.hasClients) {
|
||||
final newOffset = _scrollController.offset - delta;
|
||||
_scrollController.jumpTo(newOffset.clamp(0.0, _scrollController.position.maxScrollExtent));
|
||||
}
|
||||
return;
|
||||
}
|
||||
|
||||
// At top: check if trying to scroll down (view more) or dismiss
|
||||
if (_isScrollable && delta < 0 && _scrollController.hasClients) {
|
||||
// Swiping up (delta negative) = scroll down to see more players
|
||||
final newOffset = _scrollController.offset - delta;
|
||||
_scrollController.jumpTo(newOffset.clamp(0.0, _scrollController.position.maxScrollExtent));
|
||||
return;
|
||||
}
|
||||
|
||||
// Only process dismiss gesture when swiping DOWN (positive delta = finger moving down)
|
||||
// Ignore swipe up when not scrollable - cards should stay fixed
|
||||
if (delta <= 0) return;
|
||||
|
||||
// Swiping down = dismiss gesture
|
||||
setState(() {
|
||||
_isDragging = true;
|
||||
// Negate delta so swipe down = cards move down (toward dismissal)
|
||||
_dragOffset -= details.primaryDelta ?? 0;
|
||||
// Clamp: allow moving down (positive) freely, limit moving up to 20px
|
||||
_dragOffset = _dragOffset.clamp(-20.0, double.infinity);
|
||||
_dragOffset += delta;
|
||||
});
|
||||
}
|
||||
|
||||
void _handleVerticalDragEnd(DragEndDetails details) {
|
||||
final velocity = details.primaryVelocity ?? 0;
|
||||
|
||||
// If not dragging (was scrolling), don't dismiss
|
||||
if (!_isDragging) return;
|
||||
|
||||
// Dismiss if dragged down enough or with enough velocity
|
||||
if (_dragOffset > 100 || velocity > 500) {
|
||||
HapticFeedback.lightImpact();
|
||||
@@ -203,6 +252,21 @@ class PlayerRevealOverlayState extends State<PlayerRevealOverlay>
|
||||
const cardSpacing = 12.0;
|
||||
final totalStackHeight = players.length * cardHeight + (players.length - 1) * cardSpacing;
|
||||
|
||||
// Calculate max available height (80% of screen minus mini player area)
|
||||
final screenHeight = MediaQuery.of(context).size.height;
|
||||
final statusBarHeight = MediaQuery.of(context).padding.top;
|
||||
final bottomPadding = widget.miniPlayerBottom + widget.miniPlayerHeight + 20;
|
||||
final maxListHeight = (screenHeight - statusBarHeight - bottomPadding) * 0.8;
|
||||
|
||||
// Determine if scrolling is needed
|
||||
final needsScroll = totalStackHeight > maxListHeight;
|
||||
// Update scrollable state (used by gesture handlers)
|
||||
WidgetsBinding.instance.addPostFrameCallback((_) {
|
||||
if (_isScrollable != needsScroll) {
|
||||
_isScrollable = needsScroll;
|
||||
}
|
||||
});
|
||||
|
||||
return AnimatedBuilder(
|
||||
animation: _revealAnimation,
|
||||
builder: (context, child) {
|
||||
@@ -210,13 +274,12 @@ class PlayerRevealOverlayState extends State<PlayerRevealOverlay>
|
||||
|
||||
return Stack(
|
||||
children: [
|
||||
// Backdrop - tap to dismiss
|
||||
// Backdrop - tap to dismiss (darkness handled by GlobalPlayerOverlay)
|
||||
Positioned.fill(
|
||||
child: GestureDetector(
|
||||
onTap: dismiss,
|
||||
child: Container(
|
||||
color: Colors.black.withOpacity(0.6 * _backdropAnimation.value),
|
||||
),
|
||||
behavior: HitTestBehavior.opaque,
|
||||
child: const SizedBox.expand(),
|
||||
),
|
||||
),
|
||||
|
||||
@@ -231,7 +294,134 @@ class PlayerRevealOverlayState extends State<PlayerRevealOverlay>
|
||||
child: Column(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
// Build player cards - all slide from behind mini player
|
||||
// Hint above player list - different for onboarding vs regular use
|
||||
// Onboarding: show first-time hint (how to select)
|
||||
// Regular: show sync hint (tap and hold to sync)
|
||||
if (players.isNotEmpty && (_showHints || widget.showOnboardingHints))
|
||||
Builder(
|
||||
builder: (context) {
|
||||
// Calculate slide offset to match the topmost card
|
||||
const baseOffset = 80.0;
|
||||
final hintDistanceToTravel = baseOffset + (players.length * (cardHeight + cardSpacing));
|
||||
final hintSlideOffset = hintDistanceToTravel * (1.0 - t);
|
||||
|
||||
// Show different hint for onboarding vs regular use
|
||||
final isOnboarding = widget.showOnboardingHints;
|
||||
|
||||
Widget buildHintRow(IconData icon, String text) {
|
||||
return Row(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
Icon(
|
||||
icon,
|
||||
size: 18,
|
||||
color: colorScheme.onSurface.withOpacity(0.7),
|
||||
),
|
||||
const SizedBox(width: 6),
|
||||
Text(
|
||||
text,
|
||||
style: TextStyle(
|
||||
color: colorScheme.onSurface.withOpacity(0.7),
|
||||
fontSize: 16,
|
||||
fontWeight: FontWeight.w500,
|
||||
),
|
||||
),
|
||||
],
|
||||
);
|
||||
}
|
||||
|
||||
return Transform.translate(
|
||||
offset: Offset(0, hintSlideOffset),
|
||||
child: Padding(
|
||||
padding: const EdgeInsets.only(bottom: 12),
|
||||
child: Material(
|
||||
type: MaterialType.transparency,
|
||||
child: isOnboarding
|
||||
? buildHintRow(Icons.touch_app_outlined, S.of(context)!.selectPlayerHint)
|
||||
: Column(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
buildHintRow(Icons.lightbulb_outline, S.of(context)!.holdToSync),
|
||||
const SizedBox(height: 4),
|
||||
buildHintRow(Icons.lightbulb_outline, S.of(context)!.swipeToAdjustVolume),
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
);
|
||||
},
|
||||
),
|
||||
// Build player cards - scrollable when overflow, otherwise static
|
||||
// Using ListView.builder for many players: only builds visible items
|
||||
// This significantly improves animation performance with 10+ players
|
||||
if (needsScroll)
|
||||
ConstrainedBox(
|
||||
constraints: BoxConstraints(maxHeight: maxListHeight),
|
||||
child: ListView.builder(
|
||||
controller: _scrollController,
|
||||
physics: const ClampingScrollPhysics(),
|
||||
itemCount: players.length,
|
||||
// Fixed height per item for optimal scroll performance
|
||||
itemExtent: cardHeight + cardSpacing,
|
||||
itemBuilder: (context, index) {
|
||||
final player = players[index];
|
||||
final isPlaying = player.state == 'playing';
|
||||
final playerTrack = maProvider.getCachedTrackForPlayer(player.playerId);
|
||||
String? albumArtUrl;
|
||||
if (playerTrack != null && player.available && player.powered) {
|
||||
albumArtUrl = maProvider.getImageUrl(playerTrack, size: 128);
|
||||
}
|
||||
final playerColorScheme = _playerColors[player.playerId];
|
||||
final cardBgColor = playerColorScheme?.primaryContainer ?? defaultBgColor;
|
||||
final cardTextColor = playerColorScheme?.onPrimaryContainer ?? defaultTextColor;
|
||||
|
||||
// Animation: slide from behind mini player
|
||||
// Only calculate for items that will be built (visible ones)
|
||||
const baseOffset = 80.0;
|
||||
final reverseIndex = players.length - 1 - index;
|
||||
final distanceToTravel = baseOffset + (reverseIndex * (cardHeight + cardSpacing));
|
||||
final slideOffset = distanceToTravel * (1.0 - t);
|
||||
|
||||
return Transform.translate(
|
||||
offset: Offset(0, slideOffset),
|
||||
child: Padding(
|
||||
padding: const EdgeInsets.only(bottom: cardSpacing),
|
||||
child: PlayerCard(
|
||||
player: player,
|
||||
trackInfo: playerTrack,
|
||||
albumArtUrl: albumArtUrl,
|
||||
isSelected: false,
|
||||
isPlaying: isPlaying,
|
||||
isGrouped: maProvider.isPlayerManuallySynced(player.playerId),
|
||||
backgroundColor: cardBgColor,
|
||||
textColor: cardTextColor,
|
||||
onTap: () {
|
||||
HapticFeedback.mediumImpact();
|
||||
maProvider.selectPlayer(player);
|
||||
dismiss();
|
||||
},
|
||||
onLongPress: () {
|
||||
HapticFeedback.mediumImpact();
|
||||
maProvider.togglePlayerSync(player.playerId);
|
||||
},
|
||||
onPlayPause: () {
|
||||
if (isPlaying) {
|
||||
maProvider.pausePlayer(player.playerId);
|
||||
} else {
|
||||
maProvider.resumePlayer(player.playerId);
|
||||
}
|
||||
},
|
||||
onSkipNext: () => maProvider.nextTrack(player.playerId),
|
||||
onPower: () => maProvider.togglePower(player.playerId),
|
||||
onVolumeChange: (volume) => maProvider.setVolume(player.playerId, (volume * 100).round()),
|
||||
),
|
||||
),
|
||||
);
|
||||
},
|
||||
),
|
||||
)
|
||||
else
|
||||
// Non-scrollable list for when players fit
|
||||
...List.generate(players.length, (index) {
|
||||
final player = players[index];
|
||||
final isPlaying = player.state == 'playing';
|
||||
@@ -269,6 +459,7 @@ class PlayerRevealOverlayState extends State<PlayerRevealOverlay>
|
||||
albumArtUrl: albumArtUrl,
|
||||
isSelected: false,
|
||||
isPlaying: isPlaying,
|
||||
isGrouped: maProvider.isPlayerManuallySynced(player.playerId),
|
||||
backgroundColor: cardBgColor,
|
||||
textColor: cardTextColor,
|
||||
onTap: () {
|
||||
@@ -276,6 +467,17 @@ class PlayerRevealOverlayState extends State<PlayerRevealOverlay>
|
||||
maProvider.selectPlayer(player);
|
||||
dismiss();
|
||||
},
|
||||
onLongPress: () {
|
||||
HapticFeedback.mediumImpact();
|
||||
debugPrint('🔗 Long-press on ${player.name} (${player.playerId})');
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(
|
||||
content: Text('Syncing ${player.name}...'),
|
||||
duration: const Duration(seconds: 2),
|
||||
),
|
||||
);
|
||||
maProvider.togglePlayerSync(player.playerId);
|
||||
},
|
||||
onPlayPause: () {
|
||||
if (isPlaying) {
|
||||
maProvider.pausePlayer(player.playerId);
|
||||
@@ -289,6 +491,7 @@ class PlayerRevealOverlayState extends State<PlayerRevealOverlay>
|
||||
onPower: () {
|
||||
maProvider.togglePower(player.playerId);
|
||||
},
|
||||
onVolumeChange: (volume) => maProvider.setVolume(player.playerId, (volume * 100).round()),
|
||||
),
|
||||
),
|
||||
);
|
||||
|
||||
@@ -118,6 +118,11 @@ class QueuePanel extends StatelessWidget {
|
||||
? CachedNetworkImage(
|
||||
imageUrl: imageUrl,
|
||||
fit: BoxFit.cover,
|
||||
// PERF: 4x cache size for 44x44 display, zero fade for scrolling
|
||||
memCacheWidth: 176,
|
||||
memCacheHeight: 176,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (context, url) => Container(
|
||||
color: textColor.withOpacity(0.1),
|
||||
child: Icon(Icons.music_note, color: textColor.withOpacity(0.3), size: 20),
|
||||
|
||||
@@ -0,0 +1,226 @@
|
||||
import 'package:flutter/material.dart';
|
||||
import '../models/player.dart';
|
||||
import '../l10n/app_localizations.dart';
|
||||
|
||||
/// A themed bottom sheet for selecting a player.
|
||||
///
|
||||
/// Supports adaptive theming - pass [adaptiveColorScheme] to use colors
|
||||
/// extracted from album art, matching the detail screen backgrounds.
|
||||
class PlayerPickerSheet extends StatelessWidget {
|
||||
final String title;
|
||||
final List<Player> players;
|
||||
final Player? selectedPlayer;
|
||||
final ColorScheme? adaptiveColorScheme;
|
||||
final Future<void> Function(Player player) onPlayerSelected;
|
||||
|
||||
const PlayerPickerSheet({
|
||||
super.key,
|
||||
required this.title,
|
||||
required this.players,
|
||||
this.selectedPlayer,
|
||||
this.adaptiveColorScheme,
|
||||
required this.onPlayerSelected,
|
||||
});
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
final themeColorScheme = Theme.of(context).colorScheme;
|
||||
final colorScheme = adaptiveColorScheme ?? themeColorScheme;
|
||||
|
||||
// Use surface container for slightly elevated look, or adaptive surface
|
||||
final backgroundColor = adaptiveColorScheme?.surface ?? themeColorScheme.surfaceContainerHigh;
|
||||
final onBackgroundColor = adaptiveColorScheme?.onSurface ?? themeColorScheme.onSurface;
|
||||
|
||||
return Container(
|
||||
decoration: BoxDecoration(
|
||||
color: backgroundColor,
|
||||
borderRadius: const BorderRadius.vertical(top: Radius.circular(20)),
|
||||
),
|
||||
child: Column(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
// Drag handle
|
||||
Padding(
|
||||
padding: const EdgeInsets.only(top: 12, bottom: 8),
|
||||
child: Container(
|
||||
width: 32,
|
||||
height: 4,
|
||||
decoration: BoxDecoration(
|
||||
color: onBackgroundColor.withOpacity(0.3),
|
||||
borderRadius: BorderRadius.circular(2),
|
||||
),
|
||||
),
|
||||
),
|
||||
|
||||
// Title
|
||||
Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 24, vertical: 8),
|
||||
child: Text(
|
||||
title,
|
||||
style: Theme.of(context).textTheme.titleLarge?.copyWith(
|
||||
color: onBackgroundColor,
|
||||
),
|
||||
textAlign: TextAlign.center,
|
||||
),
|
||||
),
|
||||
|
||||
const SizedBox(height: 8),
|
||||
|
||||
// Player list
|
||||
if (players.isEmpty)
|
||||
Padding(
|
||||
padding: const EdgeInsets.all(32.0),
|
||||
child: Text(
|
||||
S.of(context)!.noPlayersAvailable,
|
||||
style: TextStyle(color: onBackgroundColor.withOpacity(0.6)),
|
||||
),
|
||||
)
|
||||
else
|
||||
Flexible(
|
||||
child: ListView.builder(
|
||||
shrinkWrap: true,
|
||||
padding: const EdgeInsets.symmetric(horizontal: 8),
|
||||
itemCount: players.length,
|
||||
itemBuilder: (context, index) {
|
||||
final player = players[index];
|
||||
final isSelected = selectedPlayer?.playerId == player.playerId;
|
||||
|
||||
return _PlayerTile(
|
||||
player: player,
|
||||
isSelected: isSelected,
|
||||
colorScheme: colorScheme,
|
||||
onBackgroundColor: onBackgroundColor,
|
||||
onTap: () => onPlayerSelected(player),
|
||||
);
|
||||
},
|
||||
),
|
||||
),
|
||||
|
||||
SizedBox(height: MediaQuery.of(context).padding.bottom + 70),
|
||||
],
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
class _PlayerTile extends StatelessWidget {
|
||||
final Player player;
|
||||
final bool isSelected;
|
||||
final ColorScheme colorScheme;
|
||||
final Color onBackgroundColor;
|
||||
final VoidCallback onTap;
|
||||
|
||||
const _PlayerTile({
|
||||
required this.player,
|
||||
required this.isSelected,
|
||||
required this.colorScheme,
|
||||
required this.onBackgroundColor,
|
||||
required this.onTap,
|
||||
});
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
// Status color based on player state
|
||||
Color statusColor;
|
||||
if (!player.available) {
|
||||
statusColor = Colors.grey.withOpacity(0.5);
|
||||
} else if (!player.powered) {
|
||||
statusColor = Colors.grey;
|
||||
} else if (player.state == 'playing') {
|
||||
statusColor = Colors.green;
|
||||
} else {
|
||||
statusColor = Colors.orange; // Idle/paused but powered
|
||||
}
|
||||
|
||||
return Padding(
|
||||
padding: const EdgeInsets.symmetric(vertical: 2),
|
||||
child: Material(
|
||||
color: isSelected
|
||||
? colorScheme.primaryContainer.withOpacity(0.3)
|
||||
: Colors.transparent,
|
||||
borderRadius: BorderRadius.circular(12),
|
||||
child: InkWell(
|
||||
onTap: onTap,
|
||||
borderRadius: BorderRadius.circular(12),
|
||||
child: Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 12),
|
||||
child: Row(
|
||||
children: [
|
||||
// Status indicator
|
||||
Container(
|
||||
width: 8,
|
||||
height: 8,
|
||||
decoration: BoxDecoration(
|
||||
shape: BoxShape.circle,
|
||||
color: statusColor,
|
||||
),
|
||||
),
|
||||
const SizedBox(width: 12),
|
||||
|
||||
// Speaker icon
|
||||
Icon(
|
||||
Icons.speaker_rounded,
|
||||
color: isSelected
|
||||
? colorScheme.primary
|
||||
: onBackgroundColor.withOpacity(0.7),
|
||||
size: 24,
|
||||
),
|
||||
const SizedBox(width: 12),
|
||||
|
||||
// Player name
|
||||
Expanded(
|
||||
child: Text(
|
||||
player.name,
|
||||
style: TextStyle(
|
||||
color: isSelected
|
||||
? colorScheme.primary
|
||||
: onBackgroundColor,
|
||||
fontWeight: isSelected ? FontWeight.w600 : FontWeight.normal,
|
||||
fontSize: 16,
|
||||
),
|
||||
),
|
||||
),
|
||||
|
||||
// Selected checkmark
|
||||
if (isSelected)
|
||||
Icon(
|
||||
Icons.check_circle_rounded,
|
||||
color: colorScheme.primary,
|
||||
size: 20,
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
/// Shows the player picker bottom sheet with adaptive theming.
|
||||
///
|
||||
/// Returns the selected player, or null if dismissed.
|
||||
Future<void> showPlayerPickerSheet({
|
||||
required BuildContext context,
|
||||
required String title,
|
||||
required List<Player> players,
|
||||
Player? selectedPlayer,
|
||||
ColorScheme? adaptiveColorScheme,
|
||||
required Future<void> Function(Player player) onPlayerSelected,
|
||||
}) {
|
||||
return showModalBottomSheet(
|
||||
context: context,
|
||||
backgroundColor: Colors.transparent,
|
||||
isScrollControlled: true,
|
||||
builder: (context) => PlayerPickerSheet(
|
||||
title: title,
|
||||
players: players,
|
||||
selectedPlayer: selectedPlayer,
|
||||
adaptiveColorScheme: adaptiveColorScheme,
|
||||
onPlayerSelected: (player) async {
|
||||
Navigator.pop(context);
|
||||
await onPlayerSelected(player);
|
||||
},
|
||||
),
|
||||
);
|
||||
}
|
||||
@@ -1,5 +1,6 @@
|
||||
import 'dart:async';
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter/services.dart';
|
||||
import 'package:material_design_icons_flutter/material_design_icons_flutter.dart';
|
||||
import 'package:provider/provider.dart';
|
||||
import 'package:cached_network_image/cached_network_image.dart';
|
||||
@@ -18,40 +19,61 @@ class PlayerSelector extends StatelessWidget {
|
||||
final availablePlayers = maProvider.availablePlayers;
|
||||
final colorScheme = Theme.of(context).colorScheme;
|
||||
|
||||
// Count players that are currently playing MA content (excluding selected player)
|
||||
// User already sees if selected player is playing, badge shows "other" activity
|
||||
// Exclude external sources (Spotify Connect, TV optical, etc.) - they're not playing MA content
|
||||
final selectedPlayerId = selectedPlayer?.playerId;
|
||||
final playingCount = availablePlayers
|
||||
.where((p) => p.state == 'playing' && p.playerId != selectedPlayerId && !p.isExternalSource)
|
||||
.length;
|
||||
|
||||
return Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 8.0),
|
||||
child: Material(
|
||||
color: colorScheme.primaryContainer,
|
||||
borderRadius: BorderRadius.circular(8),
|
||||
child: InkWell(
|
||||
onTap: () => _showPlayerSelector(context, maProvider, availablePlayers),
|
||||
child: Badge(
|
||||
isLabelVisible: playingCount > 0,
|
||||
backgroundColor: colorScheme.tertiary,
|
||||
textColor: colorScheme.onTertiary,
|
||||
label: Text(
|
||||
playingCount.toString(),
|
||||
style: TextStyle(
|
||||
fontWeight: FontWeight.w900,
|
||||
fontSize: 11,
|
||||
color: colorScheme.onTertiary,
|
||||
),
|
||||
),
|
||||
child: Material(
|
||||
color: colorScheme.primaryContainer,
|
||||
borderRadius: BorderRadius.circular(8),
|
||||
child: Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 12.0, vertical: 8.0),
|
||||
child: Row(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
if (selectedPlayer != null) ...[
|
||||
ConstrainedBox(
|
||||
constraints: const BoxConstraints(maxWidth: 120),
|
||||
child: Text(
|
||||
selectedPlayer.name,
|
||||
style: TextStyle(
|
||||
color: colorScheme.onPrimaryContainer,
|
||||
fontWeight: FontWeight.w600,
|
||||
child: InkWell(
|
||||
onTap: () => _showPlayerSelector(context, maProvider, availablePlayers),
|
||||
borderRadius: BorderRadius.circular(8),
|
||||
child: Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 12.0, vertical: 8.0),
|
||||
child: Row(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
if (selectedPlayer != null) ...[
|
||||
ConstrainedBox(
|
||||
constraints: const BoxConstraints(maxWidth: 120),
|
||||
child: Text(
|
||||
selectedPlayer.name,
|
||||
style: TextStyle(
|
||||
color: colorScheme.onPrimaryContainer,
|
||||
fontWeight: FontWeight.w600,
|
||||
),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
const SizedBox(width: 8),
|
||||
],
|
||||
Icon(
|
||||
MdiIcons.castAudio,
|
||||
color: colorScheme.onPrimaryContainer,
|
||||
size: 20,
|
||||
),
|
||||
const SizedBox(width: 8),
|
||||
],
|
||||
Icon(
|
||||
MdiIcons.castAudio,
|
||||
color: colorScheme.onPrimaryContainer,
|
||||
size: 20,
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
),
|
||||
@@ -181,23 +203,34 @@ class _PlayerSelectorSheetState extends State<_PlayerSelectorSheet> {
|
||||
// but still have track info - treat as "has content" for display
|
||||
final isIdle = player.state == 'idle';
|
||||
|
||||
// Check for external source (optical, Spotify, etc.)
|
||||
final isExternalSource = player.isExternalSource;
|
||||
|
||||
// Get track info - use current track for selected player, cache for others
|
||||
final playerTrack = isSelected
|
||||
? currentTrack
|
||||
: maProvider.getCachedTrackForPlayer(player.playerId);
|
||||
// Skip track info for external sources
|
||||
final playerTrack = isExternalSource
|
||||
? null
|
||||
: (isSelected
|
||||
? currentTrack
|
||||
: maProvider.getCachedTrackForPlayer(player.playerId));
|
||||
|
||||
// Player has content if playing, paused, or idle with cached track
|
||||
final hasContent = isPlaying || isPaused || (isIdle && playerTrack != null);
|
||||
// Player has content if playing, paused, or idle with cached track (but not external source)
|
||||
final hasContent = !isExternalSource && (isPlaying || isPaused || (isIdle && playerTrack != null));
|
||||
|
||||
// Get album art for any player with content
|
||||
// Get album art for any player with content (skip for external source)
|
||||
String? albumArtUrl;
|
||||
if (playerTrack != null && isOn && hasContent) {
|
||||
if (!isExternalSource && playerTrack != null && isOn && hasContent) {
|
||||
albumArtUrl = maProvider.getImageUrl(
|
||||
playerTrack.album ?? playerTrack,
|
||||
size: 128,
|
||||
);
|
||||
}
|
||||
|
||||
// Check if this player is manually synced (not a pre-configured group)
|
||||
final isGrouped = maProvider.isPlayerManuallySynced(player.playerId);
|
||||
// Pastel yellow for grouped players
|
||||
const groupBorderColor = Color(0xFFFFF59D);
|
||||
|
||||
return Padding(
|
||||
padding: const EdgeInsets.only(bottom: 8),
|
||||
child: InkWell(
|
||||
@@ -205,6 +238,23 @@ class _PlayerSelectorSheetState extends State<_PlayerSelectorSheet> {
|
||||
maProvider.selectPlayer(player);
|
||||
Navigator.pop(context);
|
||||
},
|
||||
onLongPress: () {
|
||||
// Haptic feedback for sync action
|
||||
HapticFeedback.mediumImpact();
|
||||
|
||||
// Show snackbar for visual feedback
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(
|
||||
content: Text('Syncing ${player.name}...'),
|
||||
duration: const Duration(seconds: 2),
|
||||
),
|
||||
);
|
||||
|
||||
// Long-press to sync/unsync player
|
||||
debugPrint('🔗 Long-press on ${player.name} (${player.playerId})');
|
||||
debugPrint('🔗 Player isGrouped: ${player.isGrouped}, groupMembers: ${player.groupMembers}');
|
||||
maProvider.togglePlayerSync(player.playerId);
|
||||
},
|
||||
borderRadius: BorderRadius.circular(16),
|
||||
child: Container(
|
||||
height: 72,
|
||||
@@ -213,6 +263,9 @@ class _PlayerSelectorSheetState extends State<_PlayerSelectorSheet> {
|
||||
? colorScheme.primary.withOpacity(0.15)
|
||||
: colorScheme.surfaceVariant.withOpacity(0.3),
|
||||
borderRadius: BorderRadius.circular(16),
|
||||
border: isGrouped
|
||||
? Border.all(color: groupBorderColor, width: 1.5)
|
||||
: null,
|
||||
),
|
||||
child: Row(
|
||||
children: [
|
||||
@@ -275,11 +328,13 @@ class _PlayerSelectorSheetState extends State<_PlayerSelectorSheet> {
|
||||
? colorScheme.onSurface.withOpacity(0.24)
|
||||
: !isOn
|
||||
? colorScheme.onSurface.withOpacity(0.3)
|
||||
: isPlaying
|
||||
? Colors.green
|
||||
: hasContent
|
||||
? Colors.orange // paused or idle with content
|
||||
: colorScheme.onSurfaceVariant.withOpacity(0.5),
|
||||
: isExternalSource
|
||||
? Colors.cyan // external source (optical, Spotify, etc.)
|
||||
: isPlaying
|
||||
? Colors.green
|
||||
: hasContent
|
||||
? Colors.orange // paused or idle with content
|
||||
: colorScheme.onSurfaceVariant.withOpacity(0.5),
|
||||
),
|
||||
),
|
||||
const SizedBox(width: 6),
|
||||
@@ -289,9 +344,11 @@ class _PlayerSelectorSheetState extends State<_PlayerSelectorSheet> {
|
||||
? S.of(context)!.playerStateUnavailable
|
||||
: !isOn
|
||||
? S.of(context)!.playerStateOff
|
||||
: hasContent && playerTrack != null
|
||||
? playerTrack.name
|
||||
: S.of(context)!.playerStateIdle,
|
||||
: isExternalSource
|
||||
? S.of(context)!.playerStateExternalSource
|
||||
: hasContent && playerTrack != null
|
||||
? playerTrack.name
|
||||
: S.of(context)!.playerStateIdle,
|
||||
style: TextStyle(
|
||||
color: player.available
|
||||
? colorScheme.onSurfaceVariant
|
||||
@@ -302,6 +359,35 @@ class _PlayerSelectorSheetState extends State<_PlayerSelectorSheet> {
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
),
|
||||
if (isGrouped) ...[
|
||||
const SizedBox(width: 8),
|
||||
Container(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 6, vertical: 2),
|
||||
decoration: BoxDecoration(
|
||||
color: groupBorderColor.withOpacity(0.3),
|
||||
borderRadius: BorderRadius.circular(4),
|
||||
),
|
||||
child: Row(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
Icon(
|
||||
Icons.link_rounded,
|
||||
size: 10,
|
||||
color: Colors.amber.shade800,
|
||||
),
|
||||
const SizedBox(width: 3),
|
||||
Text(
|
||||
'Synced',
|
||||
style: TextStyle(
|
||||
color: Colors.amber.shade800,
|
||||
fontSize: 10,
|
||||
fontWeight: FontWeight.w600,
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
],
|
||||
if (isSelected) ...[
|
||||
const SizedBox(width: 8),
|
||||
Container(
|
||||
@@ -325,8 +411,8 @@ class _PlayerSelectorSheetState extends State<_PlayerSelectorSheet> {
|
||||
],
|
||||
),
|
||||
),
|
||||
// Play/Pause button
|
||||
if (player.available && isOn)
|
||||
// Play/Pause button (hidden for external sources - controls don't work)
|
||||
if (player.available && isOn && !isExternalSource)
|
||||
IconButton(
|
||||
icon: Icon(
|
||||
isPlaying ? Icons.pause_rounded : Icons.play_arrow_rounded,
|
||||
|
||||
@@ -6,6 +6,7 @@ import '../models/media_item.dart';
|
||||
import '../providers/music_assistant_provider.dart';
|
||||
import '../services/debug_logger.dart';
|
||||
import '../screens/audiobook_series_screen.dart';
|
||||
import '../utils/page_transitions.dart';
|
||||
|
||||
class SeriesRow extends StatefulWidget {
|
||||
final String title;
|
||||
@@ -267,10 +268,11 @@ class _SeriesCard extends StatelessWidget {
|
||||
|
||||
return GestureDetector(
|
||||
onTap: () {
|
||||
// PERF: Use FadeSlidePageRoute for consistent hero animation timing
|
||||
Navigator.push(
|
||||
context,
|
||||
MaterialPageRoute(
|
||||
builder: (context) => AudiobookSeriesScreen(
|
||||
FadeSlidePageRoute(
|
||||
child: AudiobookSeriesScreen(
|
||||
series: series,
|
||||
heroTag: heroTag,
|
||||
initialCovers: covers,
|
||||
@@ -284,6 +286,44 @@ class _SeriesCard extends StatelessWidget {
|
||||
// Use AspectRatio to guarantee square cover
|
||||
Hero(
|
||||
tag: heroTag,
|
||||
// PERF: Use flightShuttleBuilder to avoid animating complex grid
|
||||
// during hero flight. Show cached first cover image instead.
|
||||
flightShuttleBuilder: (flightContext, animation, direction, fromContext, toContext) {
|
||||
// Use first cover as simple placeholder during flight
|
||||
final heroChild = toContext.widget as Hero;
|
||||
return AnimatedBuilder(
|
||||
animation: animation,
|
||||
builder: (context, child) {
|
||||
return ClipRRect(
|
||||
borderRadius: BorderRadius.circular(8 + 4 * animation.value),
|
||||
child: child,
|
||||
);
|
||||
},
|
||||
child: covers != null && covers!.isNotEmpty
|
||||
? CachedNetworkImage(
|
||||
imageUrl: covers!.first,
|
||||
fit: BoxFit.cover,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (_, __) => Container(
|
||||
color: colorScheme.surfaceContainerHighest,
|
||||
),
|
||||
errorWidget: (_, __, ___) => Container(
|
||||
color: colorScheme.surfaceContainerHighest,
|
||||
),
|
||||
)
|
||||
: Container(
|
||||
color: colorScheme.surfaceContainerHighest,
|
||||
child: Center(
|
||||
child: Icon(
|
||||
Icons.collections_bookmark_rounded,
|
||||
size: 48,
|
||||
color: colorScheme.onSurfaceVariant.withOpacity(0.5),
|
||||
),
|
||||
),
|
||||
),
|
||||
);
|
||||
},
|
||||
child: AspectRatio(
|
||||
aspectRatio: 1,
|
||||
child: ClipRRect(
|
||||
@@ -373,6 +413,8 @@ class _SeriesCard extends StatelessWidget {
|
||||
? CachedNetworkImage(
|
||||
imageUrl: coverUrl,
|
||||
fit: BoxFit.cover,
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (_, __) => Container(
|
||||
color: colorScheme.surfaceContainerHighest,
|
||||
),
|
||||
|
||||
@@ -186,7 +186,9 @@ class _TrackCard extends StatelessWidget {
|
||||
fit: BoxFit.cover,
|
||||
memCacheWidth: 256,
|
||||
memCacheHeight: 256,
|
||||
fadeInDuration: const Duration(milliseconds: 150),
|
||||
// PERF: Duration.zero for smooth scrolling
|
||||
fadeInDuration: Duration.zero,
|
||||
fadeOutDuration: Duration.zero,
|
||||
placeholder: (context, url) => const SizedBox(),
|
||||
errorWidget: (context, url, error) => Icon(
|
||||
Icons.music_note_rounded,
|
||||
|
||||
+2
-1
@@ -1,7 +1,7 @@
|
||||
name: ensemble
|
||||
description: A minimalistic Music Assistant client built with Flutter
|
||||
publish_to: 'none'
|
||||
version: 2.3.3-beta+25
|
||||
version: 2.7.4-beta+36
|
||||
|
||||
environment:
|
||||
sdk: '>=3.0.0 <4.0.0'
|
||||
@@ -28,6 +28,7 @@ dependencies:
|
||||
|
||||
# Storage
|
||||
shared_preferences: ^2.2.2
|
||||
flutter_secure_storage: ^9.2.2
|
||||
drift: ^2.22.0
|
||||
drift_flutter: 0.2.0
|
||||
path_provider: ^2.1.5
|
||||
|
||||
Reference in New Issue
Block a user