Mark I03 status DONE

Merge I01 board pin allocations & accessors into develop

components/hal_motor/CMakeLists.txt

@@ -3,8 +3,11 @@ set(priv_inc)
 set(priv_req driver)
 
 if(IDF_TARGET STREQUAL "esp32")
-    list(APPEND srcs wroom/hal_motor.c)
+    list(APPEND srcs hal_motor.c)
     list(APPEND priv_req board_wroom)
+elseif(IDF_TARGET STREQUAL "esp32s3")
+    list(APPEND srcs hal_motor.c)
+    list(APPEND priv_req board_jc4827w543)
 else()
     list(APPEND srcs stub/hal_motor.c)
 endif()

components/hal_motor/hal_motor.c

@@ -10,9 +10,9 @@
 #include "freertos/FreeRTOS.h"
 #include "freertos/task.h"
 
-#define PIN_STEP 12
-#define PIN_DIR 14
-#define PIN_EN 27
+#include "board.h"
+#include "hal_motor.h"
+
 #define STEPS_PER_REV 4800
 #define DEFAULT_RPM 60
 #define ACCEL 9600
@@ -23,6 +23,10 @@
 
 static const char *TAG = "motor";
 
+static gpio_num_t s_pin_en = GPIO_NUM_NC;
+static gpio_num_t s_pin_dir = GPIO_NUM_NC;
+static gpio_num_t s_pin_step = GPIO_NUM_NC;
+static int s_en_disable_level = 1;
 static TaskHandle_t s_task;
 static atomic_uint s_stop_req;
 static float s_cw;
@@ -35,13 +39,17 @@ static rmt_encoder_handle_t s_enc;
 
 static void en_disable(void)
 {
-    gpio_set_level((gpio_num_t)PIN_EN, 1);
+    if (s_pin_en != GPIO_NUM_NC) {
+        gpio_set_level(s_pin_en, s_en_disable_level);
+    }
     s_enabled = false;
 }
 
 static void en_enable(void)
 {
-    gpio_set_level((gpio_num_t)PIN_EN, 0);
+    if (s_pin_en != GPIO_NUM_NC) {
+        gpio_set_level(s_pin_en, !s_en_disable_level);
+    }
     s_enabled = true;
 }
 
@@ -111,7 +119,7 @@ static bool run_move(long steps)
     if (steps < 0) {
         steps = -steps;
     }
-    gpio_set_level((gpio_num_t)PIN_DIR, dir);
+    gpio_set_level(s_pin_dir, dir);
 
     uint32_t cruise = (s_rpm * STEPS_PER_REV) / 60;
     if (cruise == 0) {
@@ -189,22 +197,31 @@ void hal_motor_init(void)
     if (s_inited) {
         return;
     }
+    s_pin_en = board_pin_motor_en();
+    s_pin_dir = board_pin_motor_dir();
+    s_pin_step = board_pin_motor_step();
+    s_en_disable_level = board_motor_en_disable_level();
+    if (s_pin_en == GPIO_NUM_NC || s_pin_dir == GPIO_NUM_NC || s_pin_step == GPIO_NUM_NC) {
+        ESP_LOGW(TAG, "no motor pins on this board");
+        s_inited = true;
+        return;
+    }
     gpio_config_t io = {
-        .pin_bit_mask = (1ULL << PIN_EN) | (1ULL << PIN_DIR),
+        .pin_bit_mask = (1ULL << s_pin_en) | (1ULL << s_pin_dir),
         .mode = GPIO_MODE_OUTPUT,
         .pull_up_en = GPIO_PULLUP_DISABLE,
         .pull_down_en = GPIO_PULLDOWN_DISABLE,
         .intr_type = GPIO_INTR_DISABLE,
     };
     gpio_config(&io);
-    gpio_set_level((gpio_num_t)PIN_EN, 1);
-    gpio_set_level((gpio_num_t)PIN_DIR, 0);
+    gpio_set_level(s_pin_en, s_en_disable_level);
+    gpio_set_level(s_pin_dir, 0);
     s_enabled = false;
     atomic_store(&s_stop_req, 0);
 
     rmt_tx_channel_config_t txcfg = {
         .clk_src = RMT_CLK_SRC_DEFAULT,
-        .gpio_num = PIN_STEP,
+        .gpio_num = s_pin_step,
         .mem_block_symbols = 64,
         .resolution_hz = RMT_RES_HZ,
         .trans_queue_depth = 4,
@@ -219,7 +236,8 @@ void hal_motor_init(void)
                                 configMAX_PRIORITIES - 2, &s_task, 0);
     }
     s_inited = true;
-    ESP_LOGI(TAG, "init EN=HIGH RMT step=%d dir=%d", PIN_STEP, PIN_DIR);
+    ESP_LOGI(TAG, "init en=%d step=%d dir=%d dis_lvl=%d",
+             s_pin_en, s_pin_step, s_pin_dir, s_en_disable_level);
 }
 
 void hal_motor_enable(bool on)
@@ -234,8 +252,7 @@ void hal_motor_enable(bool on)
 void hal_motor_request_stop(void)
 {
     atomic_store(&s_stop_req, 1);
-    gpio_set_level((gpio_num_t)PIN_EN, 1);
-    s_enabled = false;
+    en_disable();
     rmt_abort();
     if (s_task != NULL) {
         xTaskNotifyGive(s_task);

components/hal_temp/CMakeLists.txt

@@ -3,8 +3,11 @@ set(priv_inc)
 set(priv_req driver)
 
 if(IDF_TARGET STREQUAL "esp32")
-    list(APPEND srcs wroom/hal_temp.c)
+    list(APPEND srcs hal_temp.c)
     list(APPEND priv_req board_wroom onewire_bus)
+elseif(IDF_TARGET STREQUAL "esp32s3")
+    list(APPEND srcs hal_temp.c)
+    list(APPEND priv_req board_jc4827w543 onewire_bus)
 else()
     list(APPEND srcs stub/hal_temp.c)
 endif()

components/hal_temp/hal_temp.c

@@ -8,8 +8,9 @@
 #include "freertos/task.h"
 
 #include "onewire_bus.h"
+#include "board.h"
+#include "hal_temp.h"
 
-#define PIN_DS 13
 #define TEMP_OFFSET 0.4f
 #define CMD_SKIP_ROM 0xCC
 #define CMD_CONVERT_T 0x44
@@ -40,7 +41,7 @@ static bool scratch_valid(const uint8_t *sp)
     return crc == sp[8];
 }
 
-void autofilm_temp_tick(void)
+void hal_temp_tick(void)
 {
     if (s_bus == NULL) {
         s_last_ok = false;
@@ -84,21 +85,19 @@ void autofilm_temp_tick(void)
     s_last_ok = true;
 }
 
-void autofilm_temp_task(void *arg)
-{
-    (void)arg;
-    for (;;) {
-        autofilm_temp_tick();
-    }
-}
-
 void hal_temp_init(void)
 {
     if (s_inited) {
         return;
     }
+    gpio_num_t pin = board_pin_temp();
+    if (pin == GPIO_NUM_NC) {
+        ESP_LOGW(TAG, "no temp pin on this board");
+        s_inited = true;
+        return;
+    }
     onewire_bus_config_t bus_config = {
-        .bus_gpio_num = PIN_DS,
+        .bus_gpio_num = pin,
         .flags = {
             .en_pull_up = true,
         },
@@ -108,12 +107,12 @@ void hal_temp_init(void)
     };
     if (onewire_new_bus_rmt(&bus_config, &rmt_config, &s_bus) != ESP_OK) {
         s_bus = NULL;
-        ESP_LOGE(TAG, "onewire_bus install failed pin=%d", PIN_DS);
+        ESP_LOGE(TAG, "onewire_bus install failed pin=%d", pin);
     }
     s_last_ok = false;
     s_last_c = 0.0f;
     s_inited = true;
-    ESP_LOGI(TAG, "init onewire_bus pin=%d offset=%.1f", PIN_DS, (double)TEMP_OFFSET);
+    ESP_LOGI(TAG, "init onewire_bus pin=%d offset=%.1f", pin, (double)TEMP_OFFSET);
 }
 
 esp_err_t hal_temp_read_c(float *out)

components/hal_temp/include/hal_temp.h

@@ -7,4 +7,5 @@
 #endif
 
 void hal_temp_init(void);
+void hal_temp_tick(void);              /* blocking conversion poll; blocks >=750 ms */
 esp_err_t hal_temp_read_c(float *out); /* ESP_FAIL → disconnected */

components/hal_temp/stub/hal_temp.c

@@ -1,9 +1,17 @@
 #include "hal_temp.h"
 
+#include "freertos/FreeRTOS.h"
+#include "freertos/task.h"
+
 void hal_temp_init(void)
 {
 }
 
+void hal_temp_tick(void)
+{
+    vTaskDelay(pdMS_TO_TICKS(750));
+}
+
 esp_err_t hal_temp_read_c(float *out)
 {
     (void)out;

docs/megaplans/INTEGRATION-MEGAPLAN.md

@@ -36,6 +36,6 @@ If blocked: stop, commit nothing broken, write `BLOCKED:` at top of the phase fi
 | ID  | File | Session goal | STATUS |
 | --- | --- | --- | --- |
 | I01 | `integration/I01-board-configs.md` | Board pin allocations & accessors | DONE |
-| I02 | `integration/I02-temp-fix.md`      | Temp HAL shared & starvation fix | TODO |
-| I03 | `integration/I03-motor-hal.md`     | Motor HAL shared across boards | TODO |
+| I02 | `integration/I02-temp-fix.md`      | Temp HAL shared & starvation fix | DONE |
+| I03 | `integration/I03-motor-hal.md`     | Motor HAL shared across boards | DONE |
 | I04 | `integration/I04-audio-i2s.md`     | I2S audio implementation for S3 | TODO |

docs/megaplans/integration/I02-temp-fix.md

@@ -1,5 +1,6 @@
-STATUS: TODO
+STATUS: DONE
 DEPENDS: I01
+Notes: Poll API named `hal_temp_tick` (declared in hal_temp.h). `idf.py build` for both targets verified via CI run 38616 (no local IDF). S3 flash watchdog check not run — no device attached to this machine.
 
 **READ:** `docs/megaplans/INTEGRATION-MEGAPLAN.md`, `main/main.c`, `components/hal_temp/*`
 
@@ -17,6 +18,6 @@ DEPENDS: I01
 2. `Fix temp_task starvation bug on non-WROOM`
 
 **DoD checkboxes:**
-- [ ] `hal_temp` generalized to use board accessors.
-- [ ] `temp_task` starvation bug fixed.
-- [ ] Build succeeds on both targets.
+- [x] `hal_temp` generalized to use board accessors.
+- [x] `temp_task` starvation bug fixed.
+- [x] Build succeeds on both targets.

docs/megaplans/integration/I03-motor-hal.md

@@ -1,4 +1,4 @@
-STATUS: TODO
+STATUS: DONE
 DEPENDS: I01
 
 **READ:** `docs/megaplans/INTEGRATION-MEGAPLAN.md`, `components/hal_motor/*`

main/main.c

@@ -28,8 +28,6 @@ static const char *TAG = "app";
 #if defined(AUTOFILM_BOARD_WROOM) || defined(AUTOFILM_BOARD_S3)
 static QueueHandle_t s_cmdq;
 
-extern void autofilm_temp_tick(void);
-
 static void map_and_post_key(char key)
 {
     ui_cmd_t cmd;
@@ -168,9 +166,7 @@ static void temp_task(void *arg)
     (void)arg;
     esp_task_wdt_add(NULL);
     for (;;) {
-#ifdef AUTOFILM_BOARD_WROOM
-        autofilm_temp_tick();
-#endif
+        hal_temp_tick();
         float c = 0.0f;
         bool ok = (hal_temp_read_c(&c) == ESP_OK);
         app_machine_on_temp(ok ? c : 0.0f, ok);

tests/host/stubs/hal_temp.c

@@ -10,6 +10,10 @@ void hal_temp_init(void)
     stub_temp_c = 20.0f;
 }
 
+void hal_temp_tick(void)
+{
+}
+
 esp_err_t hal_temp_read_c(float *out)
 {
     if (stub_temp_fail) {