402 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
gronod	05cf5a0993	Fix blocklist CSRF token reference error ... - Use state.csrfToken instead of undefined csrfToken variable - Fixes ReferenceError when clicking blocklist button	2026-05-21 02:16:34 +01:00
gronod	bb10cd4aef	Add client-side logging to blocklist button for debugging ... - Log download object and required fields when button is clicked - Shows which fields are present/absent to diagnose blocklist issues	2026-05-21 02:15:09 +01:00
gronod	251c10f08c	Add logging to blocklist-search endpoint for debugging ... - Log missing required fields to help diagnose blocklist issues - Shows which fields are present/absent in the request body	2026-05-21 02:11:45 +01:00
gronod	474ae949a9	Fix progress calculation to support both mbleft and mbmissing fields ... - SABnzbd API uses different field names for remaining bytes - Test data uses mbmissing, but real API may use mbleft - Support both field names to handle all cases - Fixes DownloadBuilder test failures	2026-05-21 02:07:54 +01:00
gronod	084cb0579e	Fix missing progress bar for SABnzbd downloads ... - Calculate progress from slot.mb and slot.mbleft instead of slot.percentage - Apply fix to both series and movie downloads in matchSabSlots - Add progress: 100 for history items in matchSabHistory (series and movie) - SABnzbd slot data doesn't have percentage field, so progress was undefined	2026-05-21 01:55:03 +01:00
gronod	93a09e10a8	Fix background fetch to not overwrite cache with empty data ... - Only trigger background refresh if cache is incomplete (less than max records) - Only update cache if background fetch returns records (don't overwrite on failure) - Prevents test failures when background fetch fails to connect to Sonarr/Radarr - Fixes integration test 'includes imported and failed records, excludes grabbed'	2026-05-21 01:53:19 +01:00
gronod	47817d057b	Fix status route test paths ... - Update test paths from /api/status/status to /api/status - Matches the route change from /status to / in status.js	2026-05-21 01:51:00 +01:00
gronod	f6ad7c85bf	Fix inconsistent speed formatting in download updates ... - Use formatSpeed() when updating existing download card speed - Ensures consistent unit display (B/s, KB/s, MB/s, GB/s) across all updates - Previously used raw speed value causing inconsistent display	2026-05-21 01:48:00 +01:00
gronod	a349c8e2cf	Fix status route path to avoid 404 ... - Change route from '/status' to '/' since router is mounted at '/api/status' - Fixes HTML 404 response when client calls /api/status	2026-05-21 01:41:24 +01:00
gronod	f2b44f65af	Fix logout button by using state object references ... - Fix undefined variable references in handleLogoutClick - Use state.statusRefreshHandle instead of statusRefreshHandle - Use state.currentUser instead of currentUser	2026-05-21 01:39:00 +01:00
gronod	b3664747cb	Add error display for status panel failures ... - Show error message when status API returns error (e.g., 403 for non-admin) - Helps debug why status panel appears empty	2026-05-21 01:37:31 +01:00
gronod	14b47ce410	Fix history pagination and status panel issues ... - Fix history pagination: use retriever's built-in maxPages parameter instead of broken date-based cursor - Fix status panel: correct API endpoint from /api/dashboard/status to /api/status - Background fetch now properly fetches up to 1000 records (10 pages * 100 records) - Status panel will now display details instead of 'Loading Status...'	2026-05-21 01:34:54 +01:00
gronod	5ec5484b91	docs(ARCHITECTURE): update to reflect develop-refactor2 changes ... - Add Download Matching & Assembly Services section (3.3) covering DownloadBuilder, DownloadMatcher, DownloadAssembler, TagMatcher, and WebhookStatus - Update High-Level Architecture diagram with /api/status route - Update Data Flow pipeline to show service-based matching, stable downloadId priority, deduplication, unmatched-torrent exclusion - Update Key Subsystems: Vite+ES module frontend, client/src tree, CSP compliance, PDCA client fix callouts - Update Directory Structure with services/, client/src/, tests/frontend/ - Update Technology Stack with jsdom and Vite build notes - Update webhook replay protection and PALDRA pagination details	2026-05-21 01:32:36 +01:00
gronod	05c9527189	Add comprehensive tests for staged history loading ... Unit tests: - Staged loading (initial batch, background fetch, concurrent requests) - Deduplication (by record ID, empty record sets) - Event subscription (subscribe/unsubscribe, error handling) - Pagination (max records limit, batch sizes) Integration tests: - Race conditions (concurrent requests, cache consistency, duplicate handling) - Edge cases (empty history, single record, batch boundaries) Tests verify: - No records are missed during staged loading - No duplicates are created - Cache remains consistent during concurrent operations - Background fetch doesn't interfere with concurrent user requests	2026-05-21 01:28:37 +01:00
gronod	f461c3669c	Add client-side handler for history-update SSE events	2026-05-21 01:23:30 +01:00
gronod	0acd452ebd	Implement staged history loading with SSE push ... - Stage 1: Fetch 100 records immediately for fast display - Stage 2+: Background fetch up to 1000 records in batches of 100 - Date-based cursor pagination to avoid race conditions - Deduplication by record ID to prevent duplicates - SSE push to clients when history cache is updated - Shared background fetch state for concurrent user requests	2026-05-21 01:23:11 +01:00
gronod	dbdfe3f329	Fix status button ID mismatch - use status-btn instead of status-toggle	2026-05-21 01:12:55 +01:00
gronod	b9b5d7d393	Increase history pageSize from 100 to 500 to fetch more records ... Fixes issue where series beyond position 100 in history were not appearing in recently completed section.	2026-05-21 01:10:36 +01:00
gronod	7424e70ea6	Add logging for total Sonarr/Radarr records fetched	2026-05-21 01:06:28 +01:00
gronod	830dea3d6b	Add logging for filtered event types and missing series/movie objects	2026-05-21 01:02:57 +01:00
gronod	4ff462b7f4	Add detailed logging for all series/movies with raw tag IDs to debug missing items	2026-05-21 01:01:14 +01:00
gronod	d9f1fc99a9	Add debugging logs for history filtering to diagnose missing series	2026-05-21 00:58:10 +01:00
gronod	46b42045f1	Fix tab selection - use data-tab attribute instead of missing IDs	2026-05-21 00:55:18 +01:00
gronod	d12356e8f3	fix: update test to reflect that unmatched torrents should not be displayed	2026-05-21 00:50:33 +01:00
gronod	6124ec0f5a	Exclude public directory from copyright header check ... The public directory contains minified/bundled build artifacts that should not require copyright headers.	2026-05-21 00:44:07 +01:00
gronod	fd303699db	Add file details to copyright header check failure output ... When copyright header check fails, now outputs the actual first 5 lines of each failing file to help diagnose the issue.	2026-05-21 00:40:41 +01:00
gronod	8f19da3ae6	Improve license check to output failing package names ... When license compatibility check fails, now outputs full license report showing which packages have incompatible licenses.	2026-05-21 00:38:53 +01:00
gronod	3c9dd3ca62	Fix: Remove unmatched torrents from download display ... Downloads with no match in Sonarr or Radarr were being displayed when they should not be. Removed the code in matchTorrents that was adding unmatched torrents to results.	2026-05-21 00:37:37 +01:00
gronod	f02c30efde	Fix CSP violations and ignoreAvailable reference error ... - Add .hidden utility class to style.css for CSP compliance - Replace all inline style='display: none' with class='hidden' in HTML - Update all UI modules to use classList.add/remove instead of style.display - Fix ignoreAvailable reference error in history.js (use state.ignoreAvailable) - Rebuild client bundle with vite	2026-05-21 00:33:57 +01:00
gronod	ddebe96056	ci: trigger rebuild with .dockerignore fix	2026-05-21 00:27:29 +01:00
gronod	31ed9f02b6	fix: remove client/ from .dockerignore to fix Docker client-build stage	2026-05-21 00:16:08 +01:00
gronod	3e6af1bff2	Add frontend unit tests with Vitest + jsdom ... - Create tests/frontend/utils/format.test.js with 24 tests for formatting utilities - Create tests/frontend/ui/downloads.test.js with 10 tests for DOM rendering functions - Update vitest.config.js to support jsdom environment for frontend tests - All 34 tests pass and cover edge cases (null, zero, large numbers, DOM structure)	2026-05-21 00:07:41 +01:00
gronod	d9897ff0d2	Extract matching logic into new DownloadMatcher service	2026-05-21 00:04:57 +01:00
gronod	06442c1d75	Add JSDoc comments and defensive error handling to DownloadBuilder.js	2026-05-21 00:00:46 +01:00
gronod	86aaa79339	refactor: Complete technical debt remediation - final cleanup ... Deleted obsolete public/app.js (replaced by Vite build) All backend services extracted and dashboard.js slimmed to 284 lines Frontend fully migrated to vanilla ES modules All duplications eliminated Comprehensive tests added Vite build wired into Dockerfile	2026-05-20 23:48:10 +01:00
gronod	e2a71e65a1	refactor: Complete technical debt remediation (all steps) ... Extracted TagMatcher, DownloadAssembler, DownloadBuilder, and WebhookStatus services Slimmed dashboard.js from 1360 → 284 lines (pure HTTP layer) Created server/routes/status.js and mounted at /api/status Migrated frontend to vanilla ES modules under client/src/ Eliminated all tag-badge and client-logo duplication Wired Vite build into Dockerfile and removed obsolete public/app.js Added comprehensive DownloadBuilder regression tests	2026-05-20 23:45:08 +01:00
gronod	d03efbf25e	Extract createClientLogo helper to eliminate 2× client-logo duplication ... - Consolidated duplicate client logo creation logic into single helper function - Removed second duplicate logo block from createDownloadCard - Updated updateDownloadCard to use the same helper - Client logo now appears exactly once per download card	2026-05-20 23:36:16 +01:00
gronod	0b91152ad7	Extract renderTagBadges helper to eliminate 4x tag-badge rendering duplication	2026-05-20 23:33:13 +01:00
gronod	8dc105ff3e	Migrate frontend from monolithic app.js to vanilla ES modules ... - Delete React files (App.jsx, main.jsx, App.css) - Create modular vanilla JS structure in client/src/: - state.js (global state object) - api.js (all fetch calls) - sse.js (SSE connection management) - ui/auth.js (authentication UI) - ui/downloads.js (downloads rendering) - ui/history.js (history section) - ui/statusPanel.js (status panel) - ui/webhooks.js (webhook management) - ui/filters.js (download client filter) - ui/theme.js (theme switching) - ui/tabs.js (tab navigation) - utils/format.js (formatting utilities) - utils/storage.js (localStorage helpers) - main.js (DOMContentLoaded bootstrap) - Update vite.config.js for vanilla build outputting to ../public/app.js - Build succeeds: 14 modules, 43.88 kB output	2026-05-20 23:30:24 +01:00
gronod	a38fc4a8ce	refactor: extract status route and WebhookStatus service, slim dashboard.js ... - Extract /status route to server/routes/status.js - Create server/services/WebhookStatus.js with checkWebhookConfigured and aggregateMetrics - Slim dashboard.js to pure HTTP orchestration (559→283 lines, 49.4% reduction) - Remove /user-summary and /webhook-metrics routes from dashboard.js - Mount status router at /api/status in server/index.js and server/app.js - Update tests to use new /api/status/status endpoint - Fix test expectation for speed field (number vs string) All 571 tests passing.	2026-05-20 22:50:40 +01:00
gronod	2bf4cb2a0f	Refactor: Deduplicate download assembly logic into DownloadBuilder service ... - Created server/services/DownloadBuilder.js with buildUserDownloads function - Added private helpers: buildSeriesMapFromRecords, buildMoviesMapFromRecords, matchSabSlots, matchSabHistory, matchTorrents, getSlotStatusAndSpeed - Updated server/routes/dashboard.js to use buildUserDownloads in /user-downloads and SSE /stream - Removed ~500 lines of duplicated download-assembly logic - All unit tests passing (DownloadBuilder: 14, DownloadAssembler: 73, TagMatcher: 26)	2026-05-20 22:43:03 +01:00
gronod	d74b46d5b0	Add guard test for DownloadBuilder service	2026-05-20 22:34:24 +01:00
gronod	9cffb96f29	Extract DownloadAssembler service from dashboard routes ... - Create server/services/DownloadAssembler.js with 7 pure functions: - getCoverArt, getImportIssues, getSonarrLink, getRadarrLink - canBlocklist, extractEpisode, gatherEpisodes - Update server/routes/dashboard.js to use DownloadAssembler - Add comprehensive unit tests (73 tests covering edge cases) - Fix null check in extractEpisode function - All tests passing: DownloadAssembler (73/73), TagMatcher (26/26)	2026-05-20 22:32:09 +01:00
gronod	4d61dd566f	Refactor: Extract tag functions to TagMatcher service ... - Extract six pure tag-related functions from dashboard.js into new server/services/TagMatcher.js - Functions: sanitizeTagLabel, tagMatchesUser, extractAllTags, extractUserTag, getEmbyUsers, buildTagBadges - Update dashboard.js to import TagMatcher and replace all inline function calls - Add comprehensive unit tests in tests/unit/services/TagMatcher.test.js (26 tests passing for 5 pure functions) - Note: getEmbyUsers tests excluded due to CommonJS mocking complexity	2026-05-20 22:21:01 +01:00
gronod	d568800942	fix: limit history pagination to prevent 40s response times ... The full pagination fix (ddad80a, e772001) caused history retrieval to fetch up to 50 pages sequentially, taking 10-40 seconds instead of ~200ms. Changes: - Add maxPages parameter to getHistory() with default of 1 page - Update poller to fetch 50 records (up from 10) in a single API call - historyFetcher retains 100 records per page for UI display This provides 5x more history for matching than before while keeping the fast single-request performance. Refs: develop-merge pagination performance issue	2026-05-20 21:44:53 +01:00
gronod	7d3e6e6a47	test: add integration and unit tests for dashboard, emby, sonarr, radarr, sabnzbd routes ... - tests/unit/dashboard.test.js: 58 unit tests covering all 12 pure helper functions in dashboard.js (sanitizeTagLabel, tagMatchesUser, getCoverArt, extractAllTags, extractUserTag, getImportIssues, getSonarrLink, getRadarrLink, canBlocklist, extractEpisode, gatherEpisodes, buildTagBadges) - tests/integration/dashboard.test.js: 35 integration tests for /user-downloads (SAB+Sonarr, SAB+Radarr, qBit, showAll, paused queue, history matching, importIssues, wrong-user filtering), /status (admin guard, webhook check, failure handling), /webhook-metrics, /cover-art (all validation/proxy paths), /blocklist-search (guards, Sonarr, Radarr, failure) - tests/integration/emby.test.js: 13 integration tests covering all 4 Emby routes (sessions, users, users/:id, session/:id/user) with auth guard, happy path, and upstream failure cases - tests/integration/arrRoutes.test.js: 64 integration tests for Sonarr + Radarr (queue, history, series/movies, notifications CRUD, /test, /schema, /sofarr-webhook create+update+missing-config+failure) and SABnzbd (queue, history with custom params) - vitest.config.js: raise global coverage thresholds (statements/functions/ lines 20->55, branches 8->40) to reflect improved coverage (62.5% stmts, 42.6% branches, 64.1% funcs, 65.6% lines) - tests/README.md: document new test files and update coverage table	2026-05-20 21:37:57 +01:00
Gandalf	ee2f275501	Merge pull request 'fix: use stable *arr IDs for matching before fragile title fallback' (#21) from fix-arr-matching into develop-merge ... Reviewed-on: #21	2026-05-20 21:02:10 +01:00
Gandalf	ca6ff66115	Merge pull request 'fix: webhook replay cache atomicity and instanceName precision' (#22) from fix-webhook-receiver into develop-merge ... Reviewed-on: #22	2026-05-20 21:01:52 +01:00
Gandalf	080431c4b7	Merge pull request 'fix: QBittorrent fallback state corruption after full sync' (#23) from fix-qbittorrent-client into develop-merge ... Reviewed-on: #23	2026-05-20 21:01:36 +01:00
Gandalf	f457a708d2	Merge pull request 'fix: SABnzbd speed assignment and size/progress parsing' (#24) from fix-sabnzbd-client into develop-merge ... Reviewed-on: #24	2026-05-20 21:01:21 +01:00