Gandalf/OctoPrint-Enclosure
1
0
Fork 0
Code Issues 156 Pull Requests 6 Actions Packages Projects Releases 28 Wiki Activity

Adding fix for #69 #70

Merged
randuhmm merged 1 commits from bugfix/plugin-baseurl into master 2017-12-10 01:35:24 +00:00
Conversation 0 Commits 1 Files Changed 1 +15 -9
randuhmm commented 2017-10-20 06:29:13 +01:00 (Migrated from github.com)
Copy Link

I tested this fix both with and without the X-Script-Name header and verified that it works. I am not 100% certain that using the window.PLUGIN_BASEURL global variable is the prescribed way to go for constructing XHR calls, but it's the only reliable client-side data I could locate. There also seems to be an API_BASEURL for plugins that use the Simple API mixin, so we seem to be on the right track...

I tested this fix both with and without the `X-Script-Name` header and verified that it works. I am not 100% certain that using the `window.PLUGIN_BASEURL` global variable is the prescribed way to go for constructing XHR calls, but it's the only reliable client-side data I could locate. There also seems to be an `API_BASEURL` for plugins that use the Simple API mixin, so we seem to be on the right track...
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
documentation
duplicate
enhancement
help wanted
invalid
Missing Data
Missing necessary data to troubleshoot
 question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Gandalf
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Gandalf/OctoPrint-Enclosure#70
Delete Branch "bugfix/plugin-baseurl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?