Hardware PWM using lightweight rpi_hardware_pwm library #474

2022-01-30T17:55:01Z

shortbloke commented

2022-01-30 17:55:01 +00:00

(Migrated from github.com)

Lightweight hardware PWM implementation with GUI configuration, allowing 25000 Hz PWM signal suitable for controlling Noctua PWM fans.

Another PR #442 but was criticised for needing pigpio and lacking UI configuration. This PR attempts so address the requirement whilst:

Using a lightweight rpi-hardware-pwm library not pigpio
Does not require everyone install the library, only if you enable this option in the UI

Fixes: #349

Lightweight hardware PWM implementation with GUI configuration, allowing 25000 Hz PWM signal suitable for controlling Noctua PWM fans. Another PR #442 but was criticised for needing pigpio and lacking UI configuration. This PR attempts so address the requirement whilst: - Using a lightweight [rpi-hardware-pwm](https://github.com/Pioreactor/rpi_hardware_pwm) library not pigpio - Does not require everyone install the library, only if you enable this option in the UI Fixes: #349

👍 2

GerhardMassenbichler commented

2022-02-15 20:19:42 +00:00

(Migrated from github.com)

Great Work. I like the small and lightweight rpi_hardware_pwm library instead of pigpio.

jneilliii (Migrated from github.com) reviewed 2022-08-24 06:14:37 +01:00

README.md

jneilliii (Migrated from github.com) commented

2022-08-24 06:14:37 +01:00

you can avoid manually installing by adding rpi-hardware-pwm to the setup_requires list here

you can avoid manually installing by adding `rpi-hardware-pwm` to the setup_requires list [here](https://github.com/shortbloke/OctoPrint-Enclosure/blob/63dc9919b0c14d71a0261a02a560899b72881e48/setup.py#L36)

mym0T (Migrated from github.com) approved these changes 2022-09-17 04:26:59 +01:00

pipersw commented

2023-02-28 09:48:54 +00:00

(Migrated from github.com)

Could you provide a binary for Raspbian ?

joh commented

2023-07-07 09:51:23 +01:00

(Migrated from github.com)

Hi, what remains for this PR to be merged? :)

joh commented

2023-07-20 21:50:06 +01:00

(Migrated from github.com)

Just tested this and it works great, thank you! Only snag was that installing rpi-hardware-pwm system-wide (as per instructions) didn't work on OctoPi, since OctoPrint runs in a virtual environment and won't see system-wide packages. Instead I had to install it in the virtual environment, like so:

source ~/oprint/bin/activate
pip install rpi-hardware-pwm

Perhaps the docs can be updated, or even better, that the package can be installed on demand by the plugin?

Just tested this and it works great, thank you! Only snag was that installing `rpi-hardware-pwm` system-wide (as per instructions) didn't work on OctoPi, since OctoPrint runs in a virtual environment and won't see system-wide packages. Instead I had to install it in the virtual environment, like so: ``` source ~/oprint/bin/activate pip install rpi-hardware-pwm ``` Perhaps the docs can be updated, or even better, that the package can be installed on demand by the plugin?

This pull request has changes conflicting with the target branch.

octoprint_enclosure/__init__.py
octoprint_enclosure/templates/enclosure_settings.jinja2

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin shortbloke/hardware_pwm:shortbloke/hardware_pwm

git checkout shortbloke/hardware_pwm

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Gandalf/OctoPrint-Enclosure#474