Gandalf/OctoPrint-Enclosure
1
0
Fork 0
Code Issues 156 Pull Requests 6 Actions Packages Projects Releases 28 Wiki Activity

Update enclosure_settings.jinja2 #433

Merged
hucker merged 2 commits from patch-1 into master 2021-10-13 18:36:32 +01:00
Conversation 4 Commits 2 Files Changed 1 +9 -8
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
octoprint_enclosure/templates/enclosure_settings.jinja2
View File

@@ -1,10 +1,10 @@
<h4>{{ _('Raspberry Pi Outputs') }}</h4>
<p>
Configure all
<strong>outputs</strong>. Outputs can be everything that do actions based on UI button presses or automatic events or alarms.
<strong>outputs</strong>. Outputs can be everything that performs actions based on UI button presses, or automatic events or alarms.
</p>
<p>
Example of possible outputs are gpio pins, neopixel LED's, temperature control or sending gcode to the printer.
Example of possible outputs are GPIO pins, neopixel LED's, temperature control or sending gcode to the printer.
</p>
<form class="form-horizontal">
<div data-bind="foreach: settingsViewModel.settings.plugins.enclosure.rpi_outputs">
@@ -773,7 +773,7 @@
<option value="input_pull_up">Input Pullup</option>
<option value="input_pull_down">Input Pulldown</option>
</select>
<span class="help-inline">Choose what type of pull resistors that you want on the output. If you signal is active low, that means it should
<span class="help-inline">Choose what type of pull resistors that you want on the output. If your signal is active low, that means it should
run the action when receive a low signal (ground), you should choose PULL UP resistors.</span>
</div>
</div>
@@ -784,8 +784,8 @@
<option value="rise">Rise</option>
<option value="fall">Fall</option>
</select>
<span class="help-inline">Do you want thrigger the event on the rise or falling edge? If you signal is active low, that means it should run
the action when receive a low signal (ground), you should choose FALLING EDGE.</span>
<span class="help-inline">Do you want to trigger the event on the rise or falling edge? If you signal is active low, that means it should run
the action when it receives a low signal (ground), you should choose FALLING EDGE.</span>
</div>
</div>
</div>
@@ -796,7 +796,7 @@
<select data-bind="options: $root.settings_possible_outputs, optionsText: 'label',
optionsValue: 'index_id', value: $data.controlled_io">
</select>
<span class="help-inline">When the event happen, you want control which OUTPUT?</span>
<span class="help-inline">When the event happens, do you want control of which OUTPUT?</span>
</div>
</div>
<!-- ko if: ($root.isRegularOutput($data.controlled_io())) -->
@@ -808,7 +808,8 @@
<option value="high">High</option>
qtemp commented 2021-09-07 22:40:25 +01:00 (Migrated from github.com)
Review
Copy Link

Should be "do you" instead of "you do"

Should be "do you" instead of "you do"
hucker commented 2021-09-09 18:37:34 +01:00 (Migrated from github.com)
Review
Copy Link

I'm new to GitLab so I'm not quite sure what you need. Do I need to make a new PR for this?

I'm new to GitLab so I'm not quite sure what you need. Do I need to make a new PR for this?
qtemp commented 2021-09-09 20:08:00 +01:00 (Migrated from github.com)
Review
Copy Link

You can pull in a suggestion...my first time trying this. If it works you should be able to just say accept suggestion...or something like that.

        <span class="help-inline">When the event happens, do you want to turn the controlled IO HIGH or LOW?</span>
You can pull in a suggestion...my first time trying this. If it works you should be able to just say accept suggestion...or something like that. ```suggestion <span class="help-inline">When the event happens, do you want to turn the controlled IO HIGH or LOW?</span> ```
<option value="toggle">Toggle</option>
</select>
<span class="help-inline">When the event happen, you want to turn the controlled IO HIGH or LOW?</span>
<span class="help-inline">When the event happens, do you want to turn the controlled IO HIGH or LOW?</span>
</div>
</div>
<!-- /ko -->
@@ -947,7 +948,7 @@
<div class="controls">
<textarea rows="4" class="block" data-bind="value: settingsViewModel.settings.plugins.enclosure.filament_sensor_gcode"></textarea>
<span class="help-inline">GCODE that will be sent to the printer to pause and allow filament to be changed. You should add
<code>ENTER</code> on the end of every line sent to the printer</span>
<code>ENTER</code> to the end of every line sent to the printer</span>
</div>
</div>