Gandalf/OctoPrint-Enclosure
1
0
Fork 0
Code Issues 156 Pull Requests 6 Actions Packages Projects Releases 28 Wiki Activity

Added full support for Adafruit DotStar LED Strips. #394

Open
IvanGirderboot wants to merge 3 commits from IvanGirderboot/master into master
pull from: IvanGirderboot/master
merge into: Gandalf:master
Conversation 5 Commits 3 Files Changed 5 +327 -5
IvanGirderboot commented 2021-02-11 20:45:06 +00:00 (Migrated from github.com)
Copy Link

This PR adds support for the AdaFruit DotStar LED strips which work really well with the Raspberry Pi.

Using a DotStar strip Requires Python3

Note: I know you're working on complete rewrite at the moment, and I'm happy to contribute DotStar support on the new branch. I think there are several opportunities to streamline things (i.e. not using discrete per-product variables like dotstar_color and neopixel_color) in the rewrite to make the code cleaner.

This PR adds support for the [AdaFruit DotStar](https://learn.adafruit.com/adafruit-dotstar-leds) LED strips which work really well with the Raspberry Pi. Using a DotStar strip **Requires** Python3 Note: I know you're working on complete rewrite at the moment, and I'm happy to contribute DotStar support on the new branch. I think there are several opportunities to streamline things (i.e. not using discrete per-product variables like `dotstar_color` and `neopixel_color`) in the rewrite to make the code cleaner.
👍 1
vitormhenrique commented 2021-10-17 22:16:45 +01:00 (Migrated from github.com)
Copy Link

Would you mind fixing the conflicts?
I'm fixing some issues here and would like to get all PR's on master

Would you mind fixing the conflicts? I'm fixing some issues here and would like to get all PR's on master
IvanGirderboot commented 2021-11-07 15:21:52 +00:00 (Migrated from github.com)
Copy Link

I'll try to load this back up this week and resolve these.

I'll try to load this back up this week and resolve these.
IvanGirderboot commented 2021-11-16 02:05:41 +00:00 (Migrated from github.com)
Copy Link

OK conflicts have been resolved; I'll give it a test locally once my current print is done to ensure it still works.

OK conflicts have been resolved; I'll give it a test locally once my current print is done to ensure it still works.
IvanGirderboot commented 2021-11-18 15:23:35 +00:00 (Migrated from github.com)
Copy Link

I can confirm this works still

I can confirm this works still
IvanGirderboot commented 2021-12-21 16:03:50 +00:00 (Migrated from github.com)
Copy Link

Friendly ping! this is ready to be merged

Friendly ping! this is ready to be merged
This pull request has changes conflicting with the target branch.
  • octoprint_enclosure/templates/enclosure_settings.jinja2
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin IvanGirderboot/master:IvanGirderboot/master
git checkout IvanGirderboot/master
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
documentation
duplicate
enhancement
help wanted
invalid
Missing Data
Missing necessary data to troubleshoot
 question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Gandalf
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Gandalf/OctoPrint-Enclosure#394
Delete Branch "IvanGirderboot/master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?