Gandalf/OctoPrint-Enclosure
1
0
Fork 0
Code Issues 156 Pull Requests 6 Actions Packages Projects Releases 28 Wiki Activity

Update enclosure_settings.jinja2 #433

Merged
hucker merged 2 commits from patch-1 into master 2021-10-13 18:36:32 +01:00
Conversation 4 Commits 2 Files Changed 1 +9 -8
hucker commented 2021-08-05 06:00:19 +01:00 (Migrated from github.com)
Copy Link

Modified grammar to on settings page to sound correct to native English speakers. Fixed minor spelling errors.

Modified grammar to on settings page to sound correct to native English speakers. Fixed minor spelling errors.
qtemp (Migrated from github.com) reviewed 2021-09-07 22:40:26 +01:00
octoprint_enclosure/templates/enclosure_settings.jinja2
@@ -808,7 +808,8 @@
<option value="high">High</option>
qtemp (Migrated from github.com) commented 2021-09-07 22:40:25 +01:00
Copy Link

Should be "do you" instead of "you do"

Should be "do you" instead of "you do"
hucker (Migrated from github.com) reviewed 2021-09-09 18:37:34 +01:00
octoprint_enclosure/templates/enclosure_settings.jinja2
@@ -808,7 +808,8 @@
<option value="high">High</option>
hucker (Migrated from github.com) commented 2021-09-09 18:37:34 +01:00
Copy Link

I'm new to GitLab so I'm not quite sure what you need. Do I need to make a new PR for this?

I'm new to GitLab so I'm not quite sure what you need. Do I need to make a new PR for this?
qtemp (Migrated from github.com) requested changes 2021-09-09 20:08:56 +01:00
octoprint_enclosure/templates/enclosure_settings.jinja2
@@ -808,7 +808,8 @@
<option value="high">High</option>
qtemp (Migrated from github.com) commented 2021-09-09 20:08:00 +01:00
Copy Link

You can pull in a suggestion...my first time trying this. If it works you should be able to just say accept suggestion...or something like that.

        <span class="help-inline">When the event happens, do you want to turn the controlled IO HIGH or LOW?</span>
You can pull in a suggestion...my first time trying this. If it works you should be able to just say accept suggestion...or something like that. ```suggestion <span class="help-inline">When the event happens, do you want to turn the controlled IO HIGH or LOW?</span> ```
hucker commented 2021-09-09 20:58:36 +01:00 (Migrated from github.com)
Copy Link

Cool, that was easy.

Cool, that was easy.
Sign in to join this conversation.
Reviewers
No Reviewers
hucker
qtemp
Labels
Clear labels
bug
documentation
duplicate
enhancement
help wanted
invalid
Missing Data
Missing necessary data to troubleshoot
 question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Gandalf
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Gandalf/OctoPrint-Enclosure#433
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?