Commit Graph

3932 Commits

Author SHA1 Message Date
Tim Krüger
3411728597
Pass 'null' for unset icon in custom status message
The OCS Status API  expect an valid emoji or 'null' for the status icon
in a custom message:

> field: statusIcon
> type: string/null
> Description: The icon picked by the user (must be an emoji, at most one)

See [1] for more details.

Resolves: #1839
See:
 [1] https://docs.nextcloud.com/server/latest/developer_manual/client_apis/OCS/ocs-status-api.html#set-a-custom-message-user-defined

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-03-02 09:50:08 +01:00
Nextcloud bot
98a2a62cbf
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-02 04:21:28 +00:00
Marcel Hibbe
4260666960
Merge pull request #1766 from nextcloud/bugfix/1765/notificationsFromLockScreen
Conversation view stuck in loading state when opened from notification
2022-03-01 14:00:12 +01:00
Dariusz Olszewski
93556da33a
Re-use existing ChatController from notification
NotificationWorker provides the user information under KEY_USER_ENTITY parameter of the notification intent, but does not set the KEY_INTERNAL_USER_ID parameter.
With this change existing ChatController instance that has been opened manually from the conversation list is properly reused when a notification is opened.
Otherwise two instances of the ChatController were running in parallel for the same room, causing unintended side effects.

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:18 +01:00
Dariusz Olszewski
c95d286de4
ktlint
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:18 +01:00
Dariusz Olszewski
a7bd6393df
Prevent overlapping pullChatMessages calls
Sometimes pullChatMessages may be called before response to a previous call is received.
In such cases just ignore the second call. Message processing will continue when response to the earlier call is received.

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:18 +01:00
Dariusz Olszewski
b2aef87b24
Re-organize sessionId handling
- clean session Id when leaving the room rather than in onAttach
- invoke leaveRoom in onDetach only when we have a valid sessionId
This avoid calling joinRoom twice in some scenarios, or calling leaveRoom before joinRoom completes successfully.

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:17 +01:00
Dariusz Olszewski
d31e6de5c4
Second attempt to fix the issue
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:17 +01:00
Dariusz Olszewski
d064ad3f65
Simplified code to avoid NullPointerException when server response arrives after the view was unbound.
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:17 +01:00
Dariusz Olszewski
606c6b0b9e
Avoid NullPointerException when server response arrives after the view was unbound.
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:17 +01:00
Dariusz Olszewski
505bcdfe20
Yet more diagnostic logging
Also in ConversationsListController

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:16 +01:00
Dariusz Olszewski
cfcfcf5bc4
Even more diagnostic logging
Info to correlate calls and responses
Log errors

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:16 +01:00
Dariusz Olszewski
b88530da6f
More diagnostic logging
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:16 +01:00
Dariusz Olszewski
b10d0cb98a
Revert "Notifications from lock screen - initial attempt to fix the issue"
This reverts commit ce8bec73

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:16 +01:00
Dariusz Olszewski
dfa14e7c52
Notifications from lock screen - initial attempt to fix the issue
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:15 +01:00
Dariusz Olszewski
be6e5d78cb
Additional logging to diagnose opening chat view from notification
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:14 +01:00
Andy Scherzinger
2887280bf1
Merge pull request #1838 from nextcloud/dependabot/github_actions/actions/setup-java-3
Bump actions/setup-java from 2.5.0 to 3
2022-03-01 10:38:54 +01:00
Andy Scherzinger
b750f41efd
kotlin code foermatting
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-01 10:21:09 +01:00
dependabot[bot]
4340191b52
Bump actions/setup-java from 2.5.0 to 3
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 2.5.0 to 3.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](https://github.com/actions/setup-java/compare/v2.5.0...v3)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-02-28 23:14:47 +00:00
Andy Scherzinger
c829fa6711
Merge pull request #1837 from nextcloud/feature/noid/ControllerToKotlin
Migrate AccountVerificationController to kotlin
2022-02-28 23:12:35 +01:00
drone
921553d684 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-28 17:30:58 +00:00
drone
045ed8d84f Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-28 17:29:48 +00:00
Andy Scherzinger
243e6161a6
Migrate AccountVerificationController to kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-28 18:25:53 +01:00
Andy Scherzinger
8c00551ac1
Merge pull request #1836 from nextcloud/feature/noid/ControllerToKotlin
Migrate EntryMenuController to Kotlin
2022-02-28 17:33:46 +01:00
drone
2bbe818f28 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-28 16:27:19 +00:00
drone
114ed36da2 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-28 16:25:42 +00:00
Andy Scherzinger
f76d25974e
migrate EntryMenuController to Kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-28 17:21:06 +01:00
Andy Scherzinger
7769a24b64
Merge pull request #1834 from nextcloud/feature/1548/remove-parceler-part-2
Feature/1548/remove parceler part 2
2022-02-28 17:20:36 +01:00
drone
f567967246 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-28 16:07:59 +00:00
Tim Krüger
45085b7e0b
Remove Parceler from model notifications
Resolves: #1548

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-28 16:54:24 +01:00
Tim Krüger
d9587e9d18
Remove Parceler from model mention
Resolves: #1548

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-28 16:54:24 +01:00
Tim Krüger
003d4c6af2
Remove unneeded not-null assertion operator (!!)
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-28 16:54:23 +01:00
Tim Krüger
94f2339baa
Remove unneeded package definition
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-28 16:54:23 +01:00
Tim Krüger
9f62df3a53
Suppress lint for unused result
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-28 16:54:22 +01:00
Tim Krüger
dad4f56e6a
Remove Parceler from model hovercard
Resolves: #1548

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-28 16:54:22 +01:00
Marcel Hibbe
d378c35df1
Merge pull request #1832 from nextcloud/feature/1829/itemViewBinding
Migrate view items to native view bindings
2022-02-28 16:39:48 +01:00
drone
33ab3b7e06 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-28 13:46:39 +00:00
Andy Scherzinger
9b8e145e7b
remove unused layouts and its strings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-28 14:38:22 +01:00
drone
28682c44d0 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-28 12:33:02 +00:00
drone
a52c41468a Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-28 12:31:55 +00:00
Andy Scherzinger
18f180bfe7
rename UserItem to ContactsItem to reflect its use case
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-28 13:26:40 +01:00
Andy Scherzinger
da39d12a7f
remove unneeded null checks
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-28 13:23:35 +01:00
Andy Scherzinger
92a2c44415
remove unused classes
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-28 13:23:10 +01:00
Andy Scherzinger
76270077a1
migrate view items to native view bindings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-28 09:52:49 +01:00
Andy Scherzinger
7374176083
remove unused getter
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-28 09:52:48 +01:00
Andy Scherzinger
f47690db22
use seperate xml designs for Items (+use viewbinding)
Resolves #1829

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-28 09:52:45 +01:00
Nextcloud bot
7227347339
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-28 04:17:36 +00:00
Nextcloud Android Bot
515a87e6d1 Weekly 13.1.0 Alpha 14 2022-02-28 03:16:02 +00:00
Nextcloud bot
573fd63b7c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-27 03:56:40 +00:00
Nextcloud bot
5d2e6ba6ae
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-26 03:57:18 +00:00