Commit Graph

1569 Commits

Author SHA1 Message Date
Andy Scherzinger
73e96198de Handle async call back to already destroyed UI
Fixes #1426

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-12 10:55:03 +00:00
Dariusz Olszewski
d0e5b768bb Share from a browser should share the page URL
Fixes #1415

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2021-07-10 23:09:51 +02:00
Marcel Hibbe
27bbb399be catch FileNotFoundException in copyFileToCache
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-09 18:35:47 +00:00
Joas Schilling
976ca95959
Merge pull request #1442 from nextcloud/bugfix/1429/fix-capability-check-for-14-to-18
Fix capability check for 14-18
2021-07-09 20:24:07 +02:00
Joas Schilling
4f94d7f96c
Fix capability check for 14-18
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-07-09 19:45:05 +02:00
Andy Scherzinger
f8ae4ca8a3
Merge pull request #1420 from nextcloud/bugfix/1417/botSystemConversationIcon
Use launcher icon as bot-avatar/system-conversation-icon
2021-07-09 16:28:33 +02:00
Andy Scherzinger
1333ce768a
Merge pull request #1425 from nextcloud/bugfix/1424/conversationInfoViewBindingNPE
Binding can be null due to async call
2021-07-09 11:30:18 +02:00
Andy Scherzinger
c47a686db1
replace printStackTrace with Log-statement
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-09 10:54:39 +02:00
Andy Scherzinger
324cd95f43
binding can be null do to async call
Fixes #1424

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-08 23:58:34 +02:00
Andy Scherzinger
e1962883b0
Only parse baseURl if not empty
Fixes #1422

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-08 14:49:59 +02:00
Andy Scherzinger
5e88dc6f57
Use launcher icon as bot-avatar/system-conversation-icon on pre-Android O
Fixes #1417

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-08 14:31:12 +02:00
Marcel Hibbe
e721aa5df6
fix to expand attachment menu in landscape mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-05 14:57:11 +02:00
Marcel Hibbe
83001990b0
set locationName to "Shared location" when geocoding failed
e.g. when someone shares a location from the ocean the name is not "null" anymore

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-05 13:03:18 +02:00
Daniel Calviño Sánchez
6087167d6e
Simplify condition
Now that "newSessions" only contains remote participants it is no longer
needed to check if the participant is an MCU publisher or not, as it
will never be.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-07-02 14:59:05 +02:00
Daniel Calviño Sánchez
9687a9453d
Fix treating the local session as a remote session when the HPB is used
When processing the participants in a room the signaling sessions of the
participants were compared against the Nextcloud session of the local
participant to find out which were the remote sessions. However, when
the HPB is used the signaling session is not the same as the Nextcloud
session, so the signaling session of the local participant never matched
her Nextcloud session, so it was always seen as a remote participant.

This caused the call state to be changed to "in conversation" (which,
for example, stopped the calling sound), when only the local participant
was in the call.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-07-02 14:59:05 +02:00
Daniel Calviño Sánchez
004c7b296a
Move "hasMCU" update to the top of the method
"hasMCU" was used before being updated, so this caused an unneeded call
to "getPeersForCall" when processing the users in the room for the first
time even if the MCU is actually used.

A better fix might be moving "hasMCU" to a method instead of relying on
the cached value, but just moving the update to the top of the method
should have no side effects (as calling "getPeersForCall" just updates
"participantMap", which is unused when the MCU is used, and sets the
avatars, which has no effect until the peer layout is set, which also
sets the avatar), so this is good enough for now.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-07-02 14:59:05 +02:00
Marcel Hibbe
c07ef4acc8
define call controls height in dimens.xml
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Marcel Hibbe
99b247850b
set minHeight for call item by dp
reduce number of possible columns to avoid design issues

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Marcel Hibbe
8e8fd882f9
return false for ridView.setOnTouchListener
NOT TESTED

should allow both click and scrolling?

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Marcel Hibbe
98f8a29eae
set constants for min item height and call controls height
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Marcel Hibbe
64d98aefb4
- set bottom margin for grid for voicecall
- temporarily comment out setOnTouchListener for grid (disables toggle of controls for now)
- set android:scrollbars="vertical" for gridview
- add callControlsHeight for item height calculation
- add fake height to item that scrolling is testable

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Andy Scherzinger
394a640555
shorten app label Nextcloud Talk -> Talk while keeping "Nextcloud Talk" as a label within the app itself
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 18:07:54 +02:00
Andy Scherzinger
996770e470
check if view is (still) available
...since grid initialization is called in various places throughout the lifecycle

Fixes #1233

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 16:54:57 +02:00
Andy Scherzinger
60def3cc0c
optimize message input for size+a11y
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 15:53:30 +02:00
Marcel Hibbe
bebf716da7
temporarily disable logging to file
see issue
https://github.com/nextcloud/talk-android/issues/1376

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-30 14:24:53 +02:00
Andy Scherzinger
b989c62055
Merge pull request #1373 from nextcloud/bugfix/1343/stopVoiceMessage
Bugfix/1343/stop voice message
2021-06-30 13:53:13 +02:00
Andy Scherzinger
60d14f3b35
SuppressLint("SetTextI18n")
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:44:00 +02:00
Andy Scherzinger
d37783d7a0
fix ktlint
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:38:48 +02:00
Andy Scherzinger
3e57018615
remove unused member variables
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:12:15 +02:00
Andy Scherzinger
195bdfb05a
extract visibility toggle for play/pause Vs. loading-animation
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:03:17 +02:00
Andy Scherzinger
78cc0df7bd
spotbugs: use literal as comparison base
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:03:14 +02:00
Andy Scherzinger
7bca54373f
Improve ktlint
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:02:57 +02:00
Andy Scherzinger
a393685a63
else/if rather than if/if
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:01:32 +02:00
Andy Scherzinger
5b457a67cb
remove unused member variable
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:01:31 +02:00
Andy Scherzinger
f435646b23
Add license header 2021-06-30 13:01:26 +02:00
Marcel Hibbe
6fc83bbca0
fix klint warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 23:09:39 +02:00
Marcel Hibbe
741748137a
fix lint/spotbugs warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 22:49:33 +02:00
Marcel Hibbe
c7bb6402fe
stop mediaPlayer in onDestroy
a voice message now continues to play if app goes to background, but whenever the user returns he can pause or stop the playback (UI is updated).
Also, the playback survives a screen orientation change.

instead stopping the mediaPlayer in onDetach would stop playback when moving app to background but also stop the playback on a screen orientation change.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 22:49:33 +02:00
Marcel Hibbe
d47deb42c8
move mediaPlayer and download-logic for voicemessages to ChatController
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 22:49:33 +02:00
Andy Scherzinger
3514d6b3fc
Catch IllegalStateException in case EmojiCompat hasn't been initialized yet
Fixes #1371

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-29 13:00:32 +02:00
Andy Scherzinger
c4057b7ac4
Add dark/light aware high-res conversation icons for share:password and document
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-28 23:09:18 +02:00
Andy Scherzinger
0b49b65094
check if attendeePin exists
resolves #1314

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-24 16:27:51 +02:00
Joas Schilling
9411614175
Show the bridge-bot avatar for bridged messages
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-23 10:13:20 +02:00
Joas Schilling
c2125f9a81
Always fallback to the guest avatar instead of none
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-23 10:12:58 +02:00
Joas Schilling
7e1cc872bd
Add tracking circles support
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-22 11:40:40 +02:00
Andy Scherzinger
2db4cbf4d1
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:07 +02:00
Andy Scherzinger
fc0962780c
improve lint score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:07 +02:00
Andy Scherzinger
4ebc64de1c
improve codacy score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:06 +02:00
Andy Scherzinger
2cf5952fae
bump detekt score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:05 +02:00
Andy Scherzinger
2b71d30637
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:04 +02:00
Andy Scherzinger
19dcd8267a
replace deprecated method calls
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:02 +02:00
Andy Scherzinger
db68b4e93d
improve voice message UI
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:02 +02:00
Marcel Hibbe
7709967712
fix imports
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-22 11:18:00 +02:00
Joas Schilling
9fbf9ef492
add voice messages
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-22 11:17:59 +02:00
Andy Scherzinger
df6b0980ac
improve contacts preview UI
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-21 17:35:05 +02:00
Joas Schilling
b9893e031c
Show "contact-name" and "contact-photo" when applicable
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-21 17:35:04 +02:00
Marcel Hibbe
0e66d75b7d
improve handling for missing location permissions
add fallback to gps if no NETWORK_PROVIDER was found

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-21 13:14:38 +02:00
Andy Scherzinger
dd162e8c61
@Suppress("Detekt.TooGenericExceptionCaught")
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 16:38:52 +02:00
Andy Scherzinger
005dfa9397
prevent crash on async callback
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 15:29:26 +02:00
Andy Scherzinger
57ddb317fd
hide icon on location picker
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 15:16:45 +02:00
Andy Scherzinger
cedc54dbb6
Improve codacy
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 12:53:27 +02:00
Andy Scherzinger
fb04505663
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:59:11 +02:00
Andy Scherzinger
f242b5fcec
hide deletion action ob object_share messages popup menu
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:55:32 +02:00
Marcel Hibbe
80e1bc6505
add ACCESS_COARSE_LOCATION for LocationPickerController
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:51:30 +02:00
Andy Scherzinger
686e499875
cleanup client implementation
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:23:01 +02:00
Andy Scherzinger
f52d7f29d9
replace nominatimClient with copied/pacthes version replacing legacy httpClient with okhttp3
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:58 +02:00
Andy Scherzinger
ba64d693ef
further codacy improvements
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:56 +02:00
Andy Scherzinger
03fda89a22
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:55 +02:00
Andy Scherzinger
a8368e626e
improve codacy score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:52 +02:00
Andy Scherzinger
01a552b8d3
reformat code for ktlint compliance
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:47 +02:00
Andy Scherzinger
f899ee1d2f
make httpclient compileOnly since it ships with the OS
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:46 +02:00
Andy Scherzinger
6ba541b6b1
Move message holders to native view bindings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:44 +02:00
Andy Scherzinger
71bffc0ea8
suppress generic exception handling warnings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:42 +02:00
Andy Scherzinger
3c4714f716
fix after rebase
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:39 +02:00
Andy Scherzinger
ac986c61aa
cleanup to new base controller logic
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:36 +02:00
Andy Scherzinger
73e0b4e719
polish location map and move to native view bindings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:34 +02:00
Andy Scherzinger
9f8a98ba07
remove unused imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:32 +02:00
Andy Scherzinger
adda60c7fb
Use native view bindings for GeocodingController
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:30 +02:00
Andy Scherzinger
43bf2ca7ae
use right context to be day/night theme aware
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:27 +02:00
Marcel Hibbe
94e466598e
add copyright headers
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:26 +02:00
Marcel Hibbe
4cdd13c92e
use CapabilitiesUtil for geo-location-sharing
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:23 +02:00
Marcel Hibbe
0568ea6e72
update location when gps changed
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:21 +02:00
Marcel Hibbe
751cd1268e
replace current-position icon
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:19 +02:00
Marcel Hibbe
22333d2f57
disable text fields for location messages (workaround)
i tried to suppress that zip codes are shown as clickable telephopne numbers. but
  android:autoLink="none"
and
  messageText!!.linksClickable = false
don't seem to work.
as a workaround i disabled the text field completely. so the links are still underlined but nut clickable. and it's also not possible now to mark text and get the context menu.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:18 +02:00
Marcel Hibbe
3cb0fe75b1
remove unnecessary logic from LocationMessageViewHolders
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:16 +02:00
Marcel Hibbe
4190cf1dfe
add FLAG_ACTIVITY_NEW_TASK for incoming location message
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:14 +02:00
Marcel Hibbe
2154b6cf94
improve design of share location button / location description
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:12 +02:00
Marcel Hibbe
9ffd5a7579
hide location sharing when capability is missing
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:09 +02:00
Marcel Hibbe
d4e49a20bb
decrease lint warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:06 +02:00
Marcel Hibbe
fdf6b04fb8
decrease spotbugs warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:02 +02:00
Marcel Hibbe
60827afe5c
decrease lint warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:59 +02:00
Marcel Hibbe
ffdc630b76
avoid UNSAFE_HASH_EQUALS reported by SpotBugs
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:58 +02:00
Marcel Hibbe
ab63a1970b
extract hardcodings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:56 +02:00
Marcel Hibbe
49b2455a23
reverse-geocode before sharing if address-name is empty
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:54 +02:00
Marcel Hibbe
d7a8935709
show geocoded location on map before sharing
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:53 +02:00
Marcel Hibbe
96e5e544ea
share geocoding-result on click
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:51 +02:00
Marcel Hibbe
26ae4fa548
share geocoded location
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:50 +02:00
Marcel Hibbe
2f0105abd3
add location search with nominatim
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:49 +02:00
Marcel Hibbe
d5face5941
improve design for locationpicker screen
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:47 +02:00
Marcel Hibbe
e8a9fa6303
add "...sent a location" strings for Conversation list
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:46 +02:00