Commit Graph

63 Commits

Author SHA1 Message Date
Álvaro Brey
704df25a6d
Refactor and extract ViewThemeUtils to common library
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-31 19:54:05 +02:00
Álvaro Brey
4c5bacc4eb
Rename NewBaseController to just BaseController
Old BaseController is no more!

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-18 17:20:40 +02:00
Álvaro Brey
447be67caf
Get rid of BaseController, ButterknifeController, and ButterKnife
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-18 17:19:08 +02:00
Álvaro Brey
929d6b3964
ConversationListController: use NewBaseController + viewBinding
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-18 16:58:42 +02:00
Andy Scherzinger
fa82641f31
theme toolbar icons including overflow icon and search field
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-08-11 09:50:54 +02:00
Andy Scherzinger
4d93a2099f
Move theme utils reference to base class and use new status bar coloring in all relevant places
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-08-11 09:50:48 +02:00
Andy Scherzinger
0c4513678d
improve search toolbar theming
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-08-11 09:50:48 +02:00
Andy Scherzinger
a6ba545aef
material 3 theming for search bar, toolbar and fab
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-08-11 09:50:47 +02:00
Álvaro Brey
8e3dc066b2
Add method in NewBaseController to handle NPE catches for viewbinding
This is really a symptom of unreliable design around the async logic in Controllers. The data async calls should have been separate from the controller,
so that the only asynchronicity the Controller has to deal with is UI-related, and can be cancelled safely on destroyView.

In the future as those controllers are converted to something that has a separate ViewModel, this kind of catch should be completely unneeded.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-07-12 12:46:10 +02:00
Álvaro Brey
e176b38d8b
NewBaseController: Inject kotlin fields without @JvmField and nullable type
These do not need to be nullable as they will be injected immediately.
This will make child controllers code much cleaner.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-06-28 17:00:01 +02:00
Andy Scherzinger
4fb61ed046
improve detekt score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-16 11:34:07 +01:00
Andy Scherzinger
394a640555
shorten app label Nextcloud Talk -> Talk while keeping "Nextcloud Talk" as a label within the app itself
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 18:07:54 +02:00
Andy Scherzinger
b513d0f154
improve detekt score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:37:06 +02:00
Andy Scherzinger
40a08394bc
hardened view binding interaction
...in case of asynchronous UI interaction with already destroyed UI

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:37:02 +02:00
Andy Scherzinger
ebc3dbdf79
improve readability of toolbar/searchbar handling code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:58 +02:00
Andy Scherzinger
45a88c0722
replace menu switch statements with if/else
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:34 +02:00
Andy Scherzinger
63fabeda09
convert lock controller to kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:31 +02:00
Andy Scherzinger
0e92e5ea2d
code format kotlin code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:18 +02:00
Andy Scherzinger
4784a22e18
update headers and format code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:16 +02:00
Andy Scherzinger
ca8d6cb782
Move controller to new view binding utilizing logic
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:10 +02:00
Marcel Hibbe
36fdd6d82b
add ability to "share to" files to nextcloud talk app
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-25 11:03:21 +02:00
Andy Scherzinger
833ebbc9e3
use native view bindings in activities
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-18 17:58:09 +02:00
Andy Scherzinger
34041b0358
Code changes due to conductor update to 3.0.1
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-07 21:56:26 +02:00
Andy Scherzinger
e82808080d
reformat kotlin code to comply with ktlint
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-27 18:16:51 +02:00
Andy Scherzinger
a125185915
Introduce SearchBar/Toolbar dark/light design
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-07 14:52:43 +02:00
Marcel Hibbe
d7bc01e954
resolve some lint warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-02-10 14:35:25 +01:00
Mario Danic
362042e27e Better scroll on new messages & Kotlin
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2019-09-09 21:59:40 +02:00
Mario Danic
6a5aaac224 Lobby & Various bugfixes and improvements
Includes conversion to Kotlin of some files

Signed-off-by: Mario Danic <mario@lovelyhq.com>
2019-08-30 12:13:33 +02:00
Mario Danic
455601b5a6 Reformat
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2019-02-15 01:49:57 +01:00
Mario Danic
8fd1ef031d Implement parts of #462
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2019-02-14 07:28:51 +01:00
Mario Danic
68c45f6831 Fix #461 and #457
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2019-02-14 03:36:00 +01:00
Mario Danic
081050eb42 Fix a crashing bug
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2019-01-09 14:32:32 +01:00
Mario Danic
96f027726e Fix conversation info crash
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2019-01-02 00:46:59 +01:00
Mario Danic
d189c49367 Fix an issue with cancelling bottom sheet
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-12-17 13:40:43 +01:00
Mario Danic
f48a441d98 Fix theming issues & clean up
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-12-17 13:40:43 +01:00
Mario Danic
5ff7316aa5 Significant progress on changing the app layout 2018-12-17 13:40:43 +01:00
Mario Danic
ce5f1706b9 Clean ups & More progress towards #206 2018-10-23 21:46:22 +02:00
Mario Danic
cced5fd2c0 Finish migration to AndroidX 2018-10-03 14:21:14 +02:00
Mario Danic
bd2820c90e First step to AndroidX migration 2018-10-02 22:34:00 +02:00
Mario Danic
60d11108c8 Rename a callslist controller
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-08-04 21:58:51 +02:00
Mario Danic
621468b81f Do lots of work on call notification
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-06-19 13:17:01 +02:00
Mario Danic
75fbf37210 Partly fix back button in ringtone selection
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-06-15 16:31:58 +02:00
Mario Danic
a2c45a3736 Fix #157
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-05-10 15:31:15 +02:00
Mario Danic
08f44a04e1 Partly implement mention highlight
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-05-04 11:59:16 +02:00
Mario Danic
36c57066e8 Fix a bug with layout animation
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-04-20 08:12:31 +02:00
Mario Danic
1c625fbb27 Updates
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-04-20 00:35:28 +02:00
Mario Danic
1c12ecd3c5 Add additional classes to exceptions
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-04-10 17:18:04 +02:00
Mario Danic
ea80b3c9d9 Initial support for client certificate auth
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-04-10 16:34:11 +02:00
Mario Danic
2087598db3 Implement nice material animation for done/clear buttons
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-03-08 20:39:32 +01:00
Mario Danic
8ae9ccc9af Add a nice bottom navigation animation
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-03-08 20:08:40 +01:00