Commit Graph

86 Commits

Author SHA1 Message Date
Tim Krüger
0ea29ee0cd
Remove unused fields remoteVideoOn and remoteAudioOn
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 12:21:41 +01:00
Tim Krüger
844cf09a2b
Rename remoteMediaStream to remoteStream
Align naming to the names used in WebRTC example code and documentation.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:36:42 +01:00
Tim Krüger
5580c15ea6
Rename magicDataChannel to dataChannel
There is no 🧙 in a data channel.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:36:42 +01:00
Tim Krüger
272ea7e846
Rename sdpConstraints to mediaConstraints
SDP is a native detail of the native WebRTC library.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:36:42 +01:00
Tim Krüger
890dda0c68
Remove unused method 'restartIce'
The method 'restartIce' is dead code since years. So this and related
fields are removed.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:36:42 +01:00
Tim Krüger
557602d1bf
Make fields final
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:36:42 +01:00
Tim Krüger
5e778c94fb
Make use of Objects#requireNonNull to check for null references
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:36:41 +01:00
Tim Krüger
5b95b5675d
Rename localMediaStream to localStream
Align naming to the names used in WebRTC example code and documentation.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:36:41 +01:00
Tim Krüger
86f20dcfd3
Migrate WebRTC from plan b to unified plan
The in 'MagicPeerConnectionWrapper#removePeerConnection' used method
'PeerConnection#removeStream' was not longer available in the unified
plan. So to make sure that the local stream is disposed, it will now be
done in 'CallActivity#hangup'.

Resolves: #1773
See: [1]

[1] https://webrtc.org/getting-started/unified-plan-transition-guide
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:36:41 +01:00
Tim Krüger
bad5b5f9bc
Update WebRTC library
The  updated libwebrtc will be load from the talk-clients-webrtc repository [1]
and not from a dependency repository. The 'lint' task must now depend on the
'perBuild' task to make sure that the WebRTC library is downloaded from the
configured URL.

To get the new version to work a change is needed because of this announcement:

> Google is planning to transition Chrome’s WebRTC implementation from the
> current SDP format (called “Plan B”) to a standards conformant format
> (“Unified Plan”, draft-ietf-rtcweb-jsep) over the next couple of quarters.
>
> - [2]

Currently we are in phase 4 of the transition [3]. So actually 'Plan B'
must be used to avoid bigger changes to our code base at this time. But
'Plan B' is depracted and will be removed in phase 5 of the transition
[4].

Resolves: #1773
See:
  - [1] https://github.com/nextcloud-releases/talk-clients-webrtc
  - [2] https://webrtc.org/getting-started/unified-plan-transition-guide
  - [3] https://webrtc.org/getting-started/unified-plan-transition-guide#phase_4_make_%E2%80%9Cplan_b%E2%80%9D_throw
  - [4] https://webrtc.org/getting-started/unified-plan-transition-guide#phase_5_remove_%E2%80%9Cplan_b%E2%80%9D

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:34:30 +01:00
Andy Scherzinger
56d57c0b37
improve code check score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:45 +01:00
Andy Scherzinger
febaaf8ea7
Revert "improve code check score"
This reverts commit 6415f163bd.

Revert "use context compat to load resources"

This reverts commit 3742c4ed99.

Revert "Adding upload from camera action"

This reverts commit 01a6675795.
2021-08-23 08:54:33 +02:00
Andy Scherzinger
6415f163bd
improve code check score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-08-21 18:28:55 +02:00
Marcel Hibbe
bebf716da7
temporarily disable logging to file
see issue
https://github.com/nextcloud/talk-android/issues/1376

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-30 14:24:53 +02:00
Andy Scherzinger
0bc3be1b6e
codacy: Avoid unused imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-17 13:35:34 +02:00
Marcel Hibbe
b8e4c4da56
add grid view for calls. make own video movable
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-07 09:45:51 +02:00
Andy Scherzinger
f1f5c3b19c
improve logging, remove unused member var
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-27 22:45:14 +02:00
Tobias Kaminsky
05a21590da
Merge pull request #907 from nextcloud/fix-data-channel-support-with-newer-janus-versions
[v8.0.x] Fix data channel suport with newer Janus versions
2020-10-27 10:51:38 +01:00
Biswajit Das
518d1ea62e
Merge pull request #905 from nextcloud/fix-frozen-video-when-screen-is-shared
[v8.0.x] Fix frozen video when screen is shared
2020-10-03 00:00:47 +01:00
Daniel Calviño Sánchez
fcb45e94f3 Fix data channel suport with newer Janus versions
When Janus is used even if it is possible to open several data channels
with different labels and send data on them all the messages are
received in the first data channel opened.

In Talk the "status" data channel is used to send the data channel
messages, and before Janus 0.7.0 it was the first data channel opened,
so the messages were received on it.

However, since Janus 0.7.0 the data channel messages are received
instead on a data channel opened by Janus, which is named
"JanusDataChannel". It is not possible to change that behaviour on Janus
except by patching it, so for broader compatibility the messages
received in "JanusDataChannel" are treated like messages received in the
"status" data channel

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-10-02 20:15:03 +02:00
Daniel Calviño Sánchez
1321cb21a0 Fix frozen video when screen is shared
When another participant shared the screen a new offer was requested.
However, the offer was requested for the video instead of for the
screen, which caused the HPB to stop the previous video connection and
replace it with a new one. As receiving new offers for an existing
connection is not properly handled the offer was applied to the existing
peer connection, which caused the new offer to be ignored and the old
peer connection to be kept (but frozen due to the HPB not sending more
data for that connection).

Requesting offers are not needed when the peer connection is a screen,
as the HPB will automatically send the offers itself. Therefore, now
offers are requested only when the connection is of "video" type.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-10-02 10:10:49 +02:00
Daniel Calviño Sánchez
6b2720653a Always pass the session id in "NICK_CHANGE" PeerConnectionEvents
Before the NICK_CHANGE event include either the session id or the user
id, depending on whether the participant was a guest or a user. However,
as the session id is also known for users the event can be unified to
always include the session id only.

This also fixes an exception when handling the "NICK_CHANGE" event, as
the session id was got from the user id given in the event, but if the
event already included the session id the look up failed and the session
id was replaced with an empty value. This in turn caused an exception
when trying to use the view for the now invalid session id. Now the
session id provided in the event is always directly used.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-10-01 19:07:25 +02:00
Daniel Calviño Sánchez
5b9f02e99c Fix setting guest nicks
The "nick" attribute was set with itself instead of with the
"internalNick" variable that holds the value received in the
"nickChanged" event.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-10-01 19:00:07 +02:00
Mario Danic
6a5aaac224 Lobby & Various bugfixes and improvements
Includes conversion to Kotlin of some files

Signed-off-by: Mario Danic <mario@lovelyhq.com>
2019-08-30 12:13:33 +02:00
Mario Danic
aca1f9a13d Fix various issues with emojis
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2019-07-22 12:41:54 +02:00
Mario Danic
6ce0d53412 Fix nick & some reconnection
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2019-06-25 10:17:08 +02:00
Mario Danic
6e68f41d1f Improve reconnections & Avatar handling
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2019-06-06 12:33:12 +02:00
Mario Danic
7d44805c9e Additional logging
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2019-05-31 17:08:42 +02:00
Mario Danic
455601b5a6 Reformat
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2019-02-15 01:49:57 +01:00
Mario Danic
ed7cd1b788 Add screensharing support
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2019-01-07 02:17:47 +01:00
Mario Danic
1c504bdfe6 Fix #392
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-12-27 14:20:44 +01:00
Mario Danic
b531ca59c6 Switch to a different codec 2018-11-08 13:41:55 +01:00
Mario Danic
9b09848838 Clean up 2018-10-30 22:33:17 +01:00
Mario Danic
f3ff2e247b Real fix for regular calls 2018-10-30 10:50:42 +01:00
Mario Danic
498ae0dfc3 Nick sending + fix regular calls 2018-10-30 10:50:42 +01:00
Mario Danic
98cabbfc11 Fix nickname & fonts 2018-10-29 10:27:38 +01:00
Mario Danic
15b53c701a Fix a typo 2018-10-18 11:51:37 +02:00
Mario Danic
6ef2e3bfd8 Fix offer request 2018-10-18 11:32:47 +02:00
Mario Danic
7a31c4c659 Dont show publisher stream 2018-10-18 01:12:39 +02:00
Mario Danic
ade92c0344 New updates 2018-10-17 23:27:12 +02:00
Mario Danic
6b46e078c1 Some fixes 2018-10-17 22:43:46 +02:00
Mario Danic
db026c4a9e Clean ups 2018-10-17 13:20:48 +02:00
Mario Danic
0bb65795ad Revert "Prefer H264"
This reverts commit 589f7f934f.
2018-10-16 21:53:35 +02:00
Mario Danic
589f7f934f Prefer H264 2018-10-16 14:46:13 +02:00
Mario Danic
9f1fef7ff1 Smaller progress for websocket communication 2018-10-16 13:16:53 +02:00
Mario Danic
54144b1c8c Fix a few bugs 2018-10-15 21:57:30 +02:00
Mario Danic
8af047926e Fix media stream & data channel messages sending 2018-10-15 12:17:57 +02:00
Mario Danic
53bc42fbea Some progress in websockets communication 2018-10-13 22:39:46 +02:00
Mario Danic
72d3f5ef66 More work towards working websockets 2018-10-12 20:07:12 +02:00
Mario Danic
e3581f03f5 Fix case of no media stream from remote
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-05-10 21:49:23 +02:00