From 1f5807b8def66615269299d075b006ff1e9e4a0c Mon Sep 17 00:00:00 2001 From: Marcel Hibbe Date: Mon, 11 Jul 2022 19:03:00 +0200 Subject: [PATCH] fix NPE for binding in onEmojiClickListener Signed-off-by: Marcel Hibbe --- .../com/nextcloud/talk/controllers/ChatController.kt | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/com/nextcloud/talk/controllers/ChatController.kt b/app/src/main/java/com/nextcloud/talk/controllers/ChatController.kt index 4ffb93eec..19f08d51d 100644 --- a/app/src/main/java/com/nextcloud/talk/controllers/ChatController.kt +++ b/app/src/main/java/com/nextcloud/talk/controllers/ChatController.kt @@ -1679,6 +1679,7 @@ class ChatController(args: Bundle) : currentConversation?.sessionId != "0" } + @Suppress("Detekt.TooGenericExceptionCaught") override fun onAttach(view: View) { super.onAttach(view) Log.d( @@ -1718,7 +1719,13 @@ class ChatController(args: Bundle) : ) }, onEmojiClickListener = { - binding.messageInputView.inputEditText?.editableText?.append(" ") + try { + binding.messageInputView.inputEditText?.editableText?.append(" ") + } catch (npe: NullPointerException) { + // view binding can be null + // since this is called asynchronously and UI might have been destroyed in the meantime + Log.i(WebViewLoginController.TAG, "UI destroyed - view binding already gone") + } } ) }