From a504f53b3acd0e0f3b4d33342ef07fc565cc4b48 Mon Sep 17 00:00:00 2001
From: sowjanyakch <sowjanya.kch@gmail.com>
Date: Thu, 28 Nov 2024 08:33:04 +0100
Subject: [PATCH 1/2] use TextInputLayout

Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
---
 .../ListOpenConversationsActivity.kt          | 10 ++++-----
 .../layout/activity_open_conversations.xml    | 22 ++++++++++++++++---
 app/src/main/res/values/strings.xml           |  1 +
 3 files changed, 25 insertions(+), 8 deletions(-)

diff --git a/app/src/main/java/com/nextcloud/talk/openconversations/ListOpenConversationsActivity.kt b/app/src/main/java/com/nextcloud/talk/openconversations/ListOpenConversationsActivity.kt
index 949c5ee98..187e7ab4f 100644
--- a/app/src/main/java/com/nextcloud/talk/openconversations/ListOpenConversationsActivity.kt
+++ b/app/src/main/java/com/nextcloud/talk/openconversations/ListOpenConversationsActivity.kt
@@ -58,7 +58,7 @@ class ListOpenConversationsActivity : BaseActivity() {
         setContentView(binding.root)
         setupSystemColors()
         viewThemeUtils.platform.colorImageView(binding.searchOpenConversations, ColorRole.ON_SURFACE)
-        viewThemeUtils.platform.colorEditText(binding.searchEdit)
+        viewThemeUtils.material.colorTextInputLayout(binding.textInputLayout)
 
         val user = currentUserProvider.currentUser.blockingGet()
 
@@ -68,7 +68,7 @@ class ListOpenConversationsActivity : BaseActivity() {
             searching = !searching
             handleSearchUI(searching)
         }
-        binding.searchEdit.doOnTextChanged { text, _, _, count ->
+        binding.editText.doOnTextChanged { text, _, _, count ->
             adapter.filter(text.toString())
         }
 
@@ -78,11 +78,11 @@ class ListOpenConversationsActivity : BaseActivity() {
     private fun handleSearchUI(show: Boolean) {
         if (show) {
             binding.searchOpenConversations.visibility = View.GONE
-            binding.searchEdit.visibility = View.VISIBLE
-            binding.searchEdit.showKeyboardAndFocus()
+            binding.textInputLayout.visibility = View.VISIBLE
+            binding.editText.showKeyboardAndFocus()
         } else {
             binding.searchOpenConversations.visibility = View.VISIBLE
-            binding.searchEdit.visibility = View.GONE
+            binding.textInputLayout.visibility = View.GONE
         }
     }
 
diff --git a/app/src/main/res/layout/activity_open_conversations.xml b/app/src/main/res/layout/activity_open_conversations.xml
index 06bae2172..eac904dec 100644
--- a/app/src/main/res/layout/activity_open_conversations.xml
+++ b/app/src/main/res/layout/activity_open_conversations.xml
@@ -7,6 +7,7 @@
 -->
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
+    xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     android:orientation="vertical"
@@ -38,13 +39,28 @@
                 android:layout_marginHorizontal="@dimen/standard_margin"
                 android:src="@drawable/ic_search_white_24dp" />
 
-            <com.google.android.material.textfield.TextInputEditText
-                android:id="@+id/search_edit"
+            <com.google.android.material.textfield.TextInputLayout
+                android:id="@+id/textInputLayout"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
+                app:endIconMode="clear_text"
+                app:boxBackgroundMode="none"
                 android:visibility="gone"
-                />
+                tools:visibility="visible"
+                app:hintEnabled="false"
+                app:endIconTint="@color/icon_on_bg_default"
+                android:layout_marginEnd = "8dp">
+
+                <com.google.android.material.textfield.TextInputEditText
+                    android:id="@+id/editText"
+                    android:layout_width="match_parent"
+                    android:layout_height="wrap_content"
+                    android:hint="Search"
+                    android:textColorHint="@color/low_emphasis_text"
+                    android:textColor = "@color/high_emphasis_text"/>
+            </com.google.android.material.textfield.TextInputLayout>
         </com.google.android.material.appbar.MaterialToolbar>
+
     </com.google.android.material.appbar.AppBarLayout>
 
     <androidx.recyclerview.widget.RecyclerView
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 700af1ab2..458464a39 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -400,6 +400,7 @@ How to translate with transifex:
     <string name="nc_refresh">Refresh</string>
     <string name="nc_check_your_internet">Please check your internet connection</string>
     <string name="nc_visible">Visible</string>
+    <string name="nc_clear_text">Clear search text</string>
 
     <!-- Chat -->
     <string name="nc_hint_enter_a_message">Enter a message …</string>

From bda05313627235880843da84978dbeb1fe5759e7 Mon Sep 17 00:00:00 2001
From: sowjanyakch <sowjanya.kch@gmail.com>
Date: Wed, 11 Dec 2024 13:29:10 +0100
Subject: [PATCH 2/2] use string resource

Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
---
 app/src/main/res/layout/activity_open_conversations.xml | 2 +-
 app/src/main/res/values/strings.xml                     | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/app/src/main/res/layout/activity_open_conversations.xml b/app/src/main/res/layout/activity_open_conversations.xml
index eac904dec..13ebaf2a0 100644
--- a/app/src/main/res/layout/activity_open_conversations.xml
+++ b/app/src/main/res/layout/activity_open_conversations.xml
@@ -55,7 +55,7 @@
                     android:id="@+id/editText"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
-                    android:hint="Search"
+                    android:hint="@string/nc_search"
                     android:textColorHint="@color/low_emphasis_text"
                     android:textColor = "@color/high_emphasis_text"/>
             </com.google.android.material.textfield.TextInputLayout>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 458464a39..700af1ab2 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -400,7 +400,6 @@ How to translate with transifex:
     <string name="nc_refresh">Refresh</string>
     <string name="nc_check_your_internet">Please check your internet connection</string>
     <string name="nc_visible">Visible</string>
-    <string name="nc_clear_text">Clear search text</string>
 
     <!-- Chat -->
     <string name="nc_hint_enter_a_message">Enter a message …</string>