From ecfe91f36fb148bed4e6a1f4251828feb5d9617f Mon Sep 17 00:00:00 2001 From: Mario Danic Date: Mon, 23 Sep 2019 14:26:13 +0200 Subject: [PATCH] Significant improvements to the dark theme Signed-off-by: Mario Danic --- .../talk/adapters/items/ConversationItem.java | 27 +++++++------- .../MagicIncomingTextMessageViewHolder.java | 11 +++--- .../MagicOutcomingTextMessageViewHolder.java | 36 +++++++------------ .../MagicSystemMessageViewHolder.java | 30 ++++------------ .../MentionAutocompleteCallback.java | 2 +- .../ConversationsListController.java | 7 ++-- .../nextcloud/talk/utils/DisplayUtils.java | 15 ++++---- .../main/res/drawable/ic_link_white_24px.xml | 2 +- .../drawable/ic_people_group_white_24px.xml | 2 +- .../shape_grouped_incoming_message.xml | 2 +- .../res/drawable/shape_incoming_message.xml | 2 +- app/src/main/res/layout/controller_chat.xml | 2 +- app/src/main/res/layout/rv_item_mention.xml | 4 +-- app/src/main/res/values-night/colors.xml | 21 +++++------ app/src/main/res/values/colors.xml | 11 ++++-- ...ip_incoming_others.xml => chip_others.xml} | 4 +-- app/src/main/res/xml/chip_outgoing_others.xml | 28 --------------- .../res/xml/chip_outgoing_own_mention.xml | 26 -------------- app/src/main/res/xml/chip_text_entry.xml | 26 -------------- ...hip_accent_background.xml => chip_you.xml} | 2 +- 20 files changed, 77 insertions(+), 183 deletions(-) rename app/src/main/res/xml/{chip_incoming_others.xml => chip_others.xml} (89%) delete mode 100644 app/src/main/res/xml/chip_outgoing_others.xml delete mode 100644 app/src/main/res/xml/chip_outgoing_own_mention.xml delete mode 100644 app/src/main/res/xml/chip_text_entry.xml rename app/src/main/res/xml/{chip_accent_background.xml => chip_you.xml} (93%) diff --git a/app/src/main/java/com/nextcloud/talk/adapters/items/ConversationItem.java b/app/src/main/java/com/nextcloud/talk/adapters/items/ConversationItem.java index fc71c46cf..07f0752a1 100644 --- a/app/src/main/java/com/nextcloud/talk/adapters/items/ConversationItem.java +++ b/app/src/main/java/com/nextcloud/talk/adapters/items/ConversationItem.java @@ -61,10 +61,13 @@ public class ConversationItem extends AbstractFlexibleItem adapter, ConversationItemViewHolder holder, int position, List payloads) { - Context context = NextcloudTalkApplication.Companion.getSharedApplication().getApplicationContext(); - + Context appContext = + NextcloudTalkApplication.Companion.getSharedApplication().getApplicationContext(); holder.dialogAvatar.setController(null); if (adapter.hasFilter()) { @@ -152,13 +155,13 @@ public class ConversationItem extends AbstractFlexibleItem individualHashMap = message.getMessageParameters().get(key); if (individualHashMap != null) { if (individualHashMap.get("type").equals("user") || individualHashMap.get("type").equals("guest") || individualHashMap.get("type").equals("call")) { - if (!individualHashMap.get("id").equals(message.getActiveUser().getUserId())) { - messageString = - DisplayUtils.searchAndReplaceWithMentionSpan(messageText.getContext(), - messageString, - individualHashMap.get("id"), - individualHashMap.get("name"), - individualHashMap.get("type"), - userUtils.getUserById(message.getActiveUser().getUserId()), - R.xml.chip_outgoing_others); - } else { - messageString = - DisplayUtils.searchAndReplaceWithMentionSpan(messageText.getContext(), - messageString, - individualHashMap.get("id"), - individualHashMap.get("name"), - individualHashMap.get("type"), - userUtils.getUserById(message.getActiveUser().getUserId()), - R.xml.chip_outgoing_own_mention); - } + messageString = + DisplayUtils.searchAndReplaceWithMentionSpan(messageText.getContext(), + messageString, + individualHashMap.get("id"), + individualHashMap.get("name"), + individualHashMap.get("type"), + userUtils.getUserById(message.getActiveUser().getUserId()), + R.xml.chip_others); } else if (individualHashMap.get("type").equals("file")) { itemView.setOnClickListener(v -> { Intent browserIntent = new Intent(Intent.ACTION_VIEW, Uri.parse(individualHashMap.get("link"))); @@ -132,14 +121,15 @@ public class MagicOutcomingTextMessageViewHolder extends MessageHolders.Outcomin Resources resources = NextcloudTalkApplication.Companion.getSharedApplication().getResources(); if (message.isGrouped) { - Drawable bubbleDrawable = DisplayUtils.getMessageSelector(resources.getColor(R.color.colorPrimary), + Drawable bubbleDrawable = + DisplayUtils.getMessageSelector(resources.getColor(R.color.bg_message_list_outcoming_bubble), resources.getColor(R.color.transparent), - resources.getColor(R.color.colorPrimary), R.drawable.shape_grouped_outcoming_message); + resources.getColor(R.color.bg_message_list_outcoming_bubble), R.drawable.shape_grouped_outcoming_message); ViewCompat.setBackground(bubble, bubbleDrawable); } else { - Drawable bubbleDrawable = DisplayUtils.getMessageSelector(resources.getColor(R.color.colorPrimary), + Drawable bubbleDrawable = DisplayUtils.getMessageSelector(resources.getColor(R.color.bg_message_list_outcoming_bubble), resources.getColor(R.color.transparent), - resources.getColor(R.color.colorPrimary), R.drawable.shape_outcoming_message); + resources.getColor(R.color.bg_message_list_outcoming_bubble), R.drawable.shape_outcoming_message); ViewCompat.setBackground(bubble, bubbleDrawable); } diff --git a/app/src/main/java/com/nextcloud/talk/adapters/messages/MagicSystemMessageViewHolder.java b/app/src/main/java/com/nextcloud/talk/adapters/messages/MagicSystemMessageViewHolder.java index 8865a16b8..0340e6fd7 100644 --- a/app/src/main/java/com/nextcloud/talk/adapters/messages/MagicSystemMessageViewHolder.java +++ b/app/src/main/java/com/nextcloud/talk/adapters/messages/MagicSystemMessageViewHolder.java @@ -56,22 +56,14 @@ public class MagicSystemMessageViewHolder extends MessageHolders.IncomingTextMes public void onBind(ChatMessage message) { super.onBind(message); - Resources resources = NextcloudTalkApplication.Companion.getSharedApplication().getResources(); - int normalColor; + Resources resources = itemView.getResources(); + int normalColor = resources.getColor(R.color.bg_message_list_incoming_bubble); int pressedColor; - int mentionYouColor; - int mentionOthersColor; + int mentionColor; + - if(DisplayUtils.isDarkModeActive(context)) { - normalColor = resources.getColor(R.color.bg_system_bubble_dark); - mentionYouColor = resources.getColor(R.color.fg_mention_you_dark); - mentionOthersColor = resources.getColor(R.color.fg_mention_others_dark); - } else { - normalColor = resources.getColor(R.color.white_two); - mentionYouColor = resources.getColor(R.color.fg_mention_you); - mentionOthersColor = resources.getColor(R.color.fg_mention_others); - } pressedColor = normalColor; + mentionColor = resources.getColor(R.color.nc_author_text); Drawable bubbleDrawable = DisplayUtils.getMessageSelector(normalColor, resources.getColor(R.color.transparent), pressedColor, @@ -83,18 +75,8 @@ public class MagicSystemMessageViewHolder extends MessageHolders.IncomingTextMes if (message.getMessageParameters() != null && message.getMessageParameters().size() > 0) { for (String key : message.getMessageParameters().keySet()) { Map individualHashMap = message.getMessageParameters().get(key); - int color; if (individualHashMap != null && (individualHashMap.get("type").equals("user") || individualHashMap.get("type").equals("guest") || individualHashMap.get("type").equals("call"))) { - - if (individualHashMap.get("id").equals(message.getActiveUser().getUserId())) { - color = mentionYouColor; - } else { - color = mentionOthersColor; - } - - messageString = - DisplayUtils.searchAndColor(messageString, - "@" + individualHashMap.get("name"), color); + messageString = DisplayUtils.searchAndColor(messageString, "@" + individualHashMap.get("name"), mentionColor); } } } diff --git a/app/src/main/java/com/nextcloud/talk/callbacks/MentionAutocompleteCallback.java b/app/src/main/java/com/nextcloud/talk/callbacks/MentionAutocompleteCallback.java index e431e1eae..8e1d21501 100644 --- a/app/src/main/java/com/nextcloud/talk/callbacks/MentionAutocompleteCallback.java +++ b/app/src/main/java/com/nextcloud/talk/callbacks/MentionAutocompleteCallback.java @@ -67,7 +67,7 @@ public class MentionAutocompleteCallback implements AutocompleteCallback - - - + diff --git a/app/src/main/res/drawable/shape_incoming_message.xml b/app/src/main/res/drawable/shape_incoming_message.xml index 92559940b..b7b2b8f58 100644 --- a/app/src/main/res/drawable/shape_incoming_message.xml +++ b/app/src/main/res/drawable/shape_incoming_message.xml @@ -28,6 +28,6 @@ android:bottomLeftRadius="@dimen/message_bubble_corners_radius" android:topRightRadius="@dimen/message_bubble_corners_radius" /> - + \ No newline at end of file diff --git a/app/src/main/res/layout/controller_chat.xml b/app/src/main/res/layout/controller_chat.xml index 007be67ae..a85703c88 100644 --- a/app/src/main/res/layout/controller_chat.xml +++ b/app/src/main/res/layout/controller_chat.xml @@ -66,7 +66,7 @@ app:inputButtonMargin="8dp" app:inputButtonWidth="36dp" app:inputHint="@string/nc_hint_enter_a_message" - app:inputTextColor="@color/fg_default" + app:inputTextColor="@color/nc_incoming_text_default" app:inputTextSize="16sp" app:showAttachmentButton="true" /> diff --git a/app/src/main/res/layout/rv_item_mention.xml b/app/src/main/res/layout/rv_item_mention.xml index 3fc86ebde..55c0221a5 100644 --- a/app/src/main/res/layout/rv_item_mention.xml +++ b/app/src/main/res/layout/rv_item_mention.xml @@ -58,7 +58,7 @@ android:layout_height="wrap_content" android:ellipsize="middle" android:singleLine="true" - android:textColor="@color/nc_incoming_text_default" + android:textColor="@color/nc_author_text" android:textSize="16sp" tools:text="Call item text" /> @@ -68,7 +68,7 @@ android:layout_height="wrap_content" android:ellipsize="middle" android:singleLine="true" - android:textColor="@color/warm_grey_four" + android:textColor="@color/nc_incoming_text_default" android:textSize="12sp" tools:text="A week ago" /> diff --git a/app/src/main/res/values-night/colors.xml b/app/src/main/res/values-night/colors.xml index 9dd098c88..adbbabf07 100644 --- a/app/src/main/res/values-night/colors.xml +++ b/app/src/main/res/values-night/colors.xml @@ -25,22 +25,19 @@ #9FBDCC - #eeeeee - - #333333 - #333333 + #222222 + #222222 - #9FBDCC - - - #C98879 - - @color/nc_darkRed - + #D8D8D8 + #65A7CA + #0083C9 + #6F6F6F @android:color/holo_purple #222222 - #444444 + #484848 + #003F62 + #313031 #15FFFFFF diff --git a/app/src/main/res/values/colors.xml b/app/src/main/res/values/colors.xml index a933d395c..157374e80 100644 --- a/app/src/main/res/values/colors.xml +++ b/app/src/main/res/values/colors.xml @@ -63,10 +63,15 @@ #FFFFFF @color/white60 - #444444 + @color/colorAccent + #6F6F6F #333333 - #EFEFEF - #444444 + + + #D5D5D5 + #003F62 + + @color/colorPrimary #46ffffff diff --git a/app/src/main/res/xml/chip_incoming_others.xml b/app/src/main/res/xml/chip_others.xml similarity index 89% rename from app/src/main/res/xml/chip_incoming_others.xml rename to app/src/main/res/xml/chip_others.xml index a7db22890..c7f46b6d8 100644 --- a/app/src/main/res/xml/chip_incoming_others.xml +++ b/app/src/main/res/xml/chip_others.xml @@ -22,7 +22,5 @@ diff --git a/app/src/main/res/xml/chip_outgoing_others.xml b/app/src/main/res/xml/chip_outgoing_others.xml deleted file mode 100644 index 56bc98529..000000000 --- a/app/src/main/res/xml/chip_outgoing_others.xml +++ /dev/null @@ -1,28 +0,0 @@ - - - - diff --git a/app/src/main/res/xml/chip_outgoing_own_mention.xml b/app/src/main/res/xml/chip_outgoing_own_mention.xml deleted file mode 100644 index 28f7a4e4a..000000000 --- a/app/src/main/res/xml/chip_outgoing_own_mention.xml +++ /dev/null @@ -1,26 +0,0 @@ - - - - diff --git a/app/src/main/res/xml/chip_text_entry.xml b/app/src/main/res/xml/chip_text_entry.xml deleted file mode 100644 index ce12409f3..000000000 --- a/app/src/main/res/xml/chip_text_entry.xml +++ /dev/null @@ -1,26 +0,0 @@ - - - - diff --git a/app/src/main/res/xml/chip_accent_background.xml b/app/src/main/res/xml/chip_you.xml similarity index 93% rename from app/src/main/res/xml/chip_accent_background.xml rename to app/src/main/res/xml/chip_you.xml index 9d595e0ae..4b84184ac 100644 --- a/app/src/main/res/xml/chip_accent_background.xml +++ b/app/src/main/res/xml/chip_you.xml @@ -22,5 +22,5 @@