From 9ca6acc933143b583732edfdcc93c5aad9496641 Mon Sep 17 00:00:00 2001 From: sowjanyakch Date: Tue, 1 Jul 2025 17:44:29 +0200 Subject: [PATCH 1/4] add content description to buttons Signed-off-by: sowjanyakch --- app/src/main/res/layout/call_activity.xml | 4 ++-- app/src/main/res/values/strings.xml | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/app/src/main/res/layout/call_activity.xml b/app/src/main/res/layout/call_activity.xml index ca67beaa2..dd6721637 100644 --- a/app/src/main/res/layout/call_activity.xml +++ b/app/src/main/res/layout/call_activity.xml @@ -298,7 +298,7 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_margin="@dimen/standard_quarter_margin" - android:contentDescription="@string/nc_call_button_content_description_microphone" + android:contentDescription="@string/nc_common_more_options" app:backgroundTint="@color/call_buttons_background" app:borderWidth="0dp" app:fabCustomSize="40dp" @@ -311,7 +311,7 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_margin="@dimen/standard_quarter_margin" - android:contentDescription="@string/nc_call_button_content_description_microphone" + android:contentDescription="@string/end_call" app:backgroundTint="@color/nc_darkRed" app:borderWidth="0dp" app:fabCustomSize="40dp" diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 569be28ac..b3943895d 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -332,6 +332,7 @@ How to translate with transifex: The call has been running for one hour. End call for everyone Leave call + End call Mute microphone From 8c0432efbfb07e293cb2608bab16915c7a5910e2 Mon Sep 17 00:00:00 2001 From: sowjanyakch Date: Tue, 1 Jul 2025 17:59:24 +0200 Subject: [PATCH 2/4] add content description to buttons Signed-off-by: sowjanyakch --- app/src/main/res/layout/view_message_input.xml | 4 ++-- app/src/main/res/values/strings.xml | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/src/main/res/layout/view_message_input.xml b/app/src/main/res/layout/view_message_input.xml index 9eb2d7624..e0ad06bff 100644 --- a/app/src/main/res/layout/view_message_input.xml +++ b/app/src/main/res/layout/view_message_input.xml @@ -131,7 +131,7 @@ android:layout_marginEnd="@dimen/standard_double_margin" android:scaleType="centerInside" android:src="@drawable/ic_send" - android:contentDescription="@null" + android:contentDescription="@string/nc_send_voice_message" android:background="?android:attr/selectableItemBackgroundBorderless" android:visibility="gone" /> @@ -147,7 +147,7 @@ android:scaleType="centerInside" android:layout_alignParentStart="true" android:src="@drawable/ic_baseline_mic_red_24" - android:contentDescription="@null" + android:contentDescription="@string/nc_microphone_enabled_audio_recording" android:visibility="gone" tools:visibility="gone" /> diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index b3943895d..f36ec441e 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -299,6 +299,7 @@ How to translate with transifex: To enable video communication please grant \"Camera\" permission. To enable voice communication please grant \"Microphone\" permission. To enable bluetooth speakers please grant \"Nearby devices\" permission. + Microphone is enabled and audio is recording %s voice call @@ -452,6 +453,7 @@ How to translate with transifex: See %d similar message See %d similar messages + Send voice message Guest access From df2a820e88275c2c37bd5c7b7ba4907f3db372e5 Mon Sep 17 00:00:00 2001 From: sowjanyakch Date: Tue, 1 Jul 2025 18:06:14 +0200 Subject: [PATCH 3/4] add content description to buttons Signed-off-by: sowjanyakch --- app/src/main/res/layout/view_message_input.xml | 2 +- app/src/main/res/values/strings.xml | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app/src/main/res/layout/view_message_input.xml b/app/src/main/res/layout/view_message_input.xml index e0ad06bff..0a305a8e5 100644 --- a/app/src/main/res/layout/view_message_input.xml +++ b/app/src/main/res/layout/view_message_input.xml @@ -116,7 +116,7 @@ android:layout_marginStart="@dimen/standard_double_margin" android:scaleType="centerInside" android:src="@drawable/ic_delete" - android:contentDescription="@null" + android:contentDescription="@string/delete_voice_message" android:background="?android:attr/selectableItemBackgroundBorderless" android:visibility="gone" /> diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index f36ec441e..9ce361919 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -594,6 +594,7 @@ How to translate with transifex: Play/pause voice message Permission for audio recording is required Playback speed control + Delete voice message Match contacts based on phone number to integrate Talk shortcut into system contacts app From c208b3d0b16f38a1197c74424f87f291013ca17f Mon Sep 17 00:00:00 2001 From: sowjanyakch Date: Wed, 2 Jul 2025 18:42:48 +0200 Subject: [PATCH 4/4] use proper wording recording instead of message Signed-off-by: sowjanyakch --- .../res/layout/fragment_message_input_voice_recording.xml | 4 ++-- app/src/main/res/layout/view_message_input.xml | 4 ++-- app/src/main/res/values/strings.xml | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/src/main/res/layout/fragment_message_input_voice_recording.xml b/app/src/main/res/layout/fragment_message_input_voice_recording.xml index cf5d667c5..d6c1bdc4f 100644 --- a/app/src/main/res/layout/fragment_message_input_voice_recording.xml +++ b/app/src/main/res/layout/fragment_message_input_voice_recording.xml @@ -80,7 +80,7 @@ android:layout_marginVertical="@dimen/standard_margin" android:scaleType="centerInside" android:src="@drawable/ic_delete" - android:contentDescription="@null" + android:contentDescription="@string/delete_voice_recording" android:background="?android:attr/selectableItemBackgroundBorderless" android:layout_weight="1" /> @@ -103,7 +103,7 @@ android:layout_marginVertical="@dimen/standard_margin" android:scaleType="centerInside" android:src="@drawable/ic_send" - android:contentDescription="@null" + android:contentDescription="@string/nc_send_voice_recording" android:background="?android:attr/selectableItemBackgroundBorderless" android:layout_weight="1" /> diff --git a/app/src/main/res/layout/view_message_input.xml b/app/src/main/res/layout/view_message_input.xml index 0a305a8e5..3f021f6f3 100644 --- a/app/src/main/res/layout/view_message_input.xml +++ b/app/src/main/res/layout/view_message_input.xml @@ -116,7 +116,7 @@ android:layout_marginStart="@dimen/standard_double_margin" android:scaleType="centerInside" android:src="@drawable/ic_delete" - android:contentDescription="@string/delete_voice_message" + android:contentDescription="@string/delete_voice_recording" android:background="?android:attr/selectableItemBackgroundBorderless" android:visibility="gone" /> @@ -131,7 +131,7 @@ android:layout_marginEnd="@dimen/standard_double_margin" android:scaleType="centerInside" android:src="@drawable/ic_send" - android:contentDescription="@string/nc_send_voice_message" + android:contentDescription="@string/nc_send_voice_recording" android:background="?android:attr/selectableItemBackgroundBorderless" android:visibility="gone" /> diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 9ce361919..807019db5 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -453,7 +453,7 @@ How to translate with transifex: See %d similar message See %d similar messages - Send voice message + Send voice recording Guest access @@ -594,7 +594,7 @@ How to translate with transifex: Play/pause voice message Permission for audio recording is required Playback speed control - Delete voice message + Delete voice recording Match contacts based on phone number to integrate Talk shortcut into system contacts app