From 3e6c846d62f73483bbdd627a2a2fa30f326bfc1a Mon Sep 17 00:00:00 2001
From: Marcel Hibbe <dev@mhibbe.de>
Date: Mon, 5 Dec 2022 12:51:21 +0100
Subject: [PATCH] fix crash when joining call while silent ringtone is set

E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.nextcloud.talk2, PID: 10874
    java.lang.NullPointerException: uri param can not be null.
        at android.media.MediaPlayer.setDataSource(MediaPlayer.java:1058)
        at android.media.MediaPlayer.setDataSource(MediaPlayer.java:1021)
        at com.nextcloud.talk.activities.CallActivity.playCallingSound(CallActivity.java:2643)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
---
 .../talk/activities/CallActivity.java         | 54 ++++++++++---------
 1 file changed, 28 insertions(+), 26 deletions(-)

diff --git a/app/src/main/java/com/nextcloud/talk/activities/CallActivity.java b/app/src/main/java/com/nextcloud/talk/activities/CallActivity.java
index cbd377bc9..1154b0d15 100644
--- a/app/src/main/java/com/nextcloud/talk/activities/CallActivity.java
+++ b/app/src/main/java/com/nextcloud/talk/activities/CallActivity.java
@@ -1485,20 +1485,20 @@ public class CallActivity extends CallBaseActivity {
                                 .takeWhile(observable -> isConnectionEstablished())
                                 .doOnNext(value -> delayOnError.set(0))
                                 .retryWhen(errors -> errors
-                                    .flatMap(error -> {
-                                        if (!isConnectionEstablished()) {
-                                            return Observable.error(error);
-                                        }
+                                               .flatMap(error -> {
+                                                   if (!isConnectionEstablished()) {
+                                                       return Observable.error(error);
+                                                   }
 
-                                        if (delayOnError.get() == 0) {
-                                            delayOnError.set(1);
-                                        } else if (delayOnError.get() < 16) {
-                                            delayOnError.set(delayOnError.get() * 2);
-                                        }
+                                                   if (delayOnError.get() == 0) {
+                                                       delayOnError.set(1);
+                                                   } else if (delayOnError.get() < 16) {
+                                                       delayOnError.set(delayOnError.get() * 2);
+                                                   }
 
-                                        return Observable.timer(delayOnError.get(), TimeUnit.SECONDS);
-                                    })
-                                )
+                                                   return Observable.timer(delayOnError.get(), TimeUnit.SECONDS);
+                                               })
+                                          )
                                 .subscribe(new Observer<SignalingOverall>() {
                                     @Override
                                     public void onSubscribe(@io.reactivex.annotations.NonNull Disposable d) {
@@ -1927,7 +1927,7 @@ public class CallActivity extends CallBaseActivity {
             Log.d(TAG, "   newSession joined: " + sessionId);
             getOrCreatePeerConnectionWrapperForSessionIdAndType(sessionId, VIDEO_STREAM_TYPE_VIDEO, false);
 
-	        String userId = userIdsBySessionId.get(sessionId);
+            String userId = userIdsBySessionId.get(sessionId);
 
             runOnUiThread(() -> {
                 setupVideoStreamForLayout(
@@ -2637,22 +2637,24 @@ public class CallActivity extends CallBaseActivity {
                                         "/tr110_1_kap8_3_freiton1");
         }
 
-        mediaPlayer = new MediaPlayer();
-        try {
-            mediaPlayer.setDataSource(this, ringtoneUri);
-            mediaPlayer.setLooping(true);
-            AudioAttributes audioAttributes = new AudioAttributes.Builder().setContentType(
-                    AudioAttributes.CONTENT_TYPE_SONIFICATION)
-                .setUsage(AudioAttributes.USAGE_VOICE_COMMUNICATION)
-                .build();
-            mediaPlayer.setAudioAttributes(audioAttributes);
+        if (ringtoneUri != null) {
+            mediaPlayer = new MediaPlayer();
+            try {
+                mediaPlayer.setDataSource(this, ringtoneUri);
+                mediaPlayer.setLooping(true);
+                AudioAttributes audioAttributes = new AudioAttributes.Builder().setContentType(
+                        AudioAttributes.CONTENT_TYPE_SONIFICATION)
+                    .setUsage(AudioAttributes.USAGE_VOICE_COMMUNICATION)
+                    .build();
+                mediaPlayer.setAudioAttributes(audioAttributes);
 
-            mediaPlayer.setOnPreparedListener(mp -> mediaPlayer.start());
+                mediaPlayer.setOnPreparedListener(mp -> mediaPlayer.start());
 
-            mediaPlayer.prepareAsync();
+                mediaPlayer.prepareAsync();
 
-        } catch (IOException e) {
-            Log.e(TAG, "Failed to play sound");
+            } catch (IOException e) {
+                Log.e(TAG, "Failed to play sound");
+            }
         }
     }