add disposable

however i was not able to see onDestroy being executed.

anyway, disposables won't be necessary when coroutine is used.

also: remove a useless outdated log line

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
This commit is contained in:
Marcel Hibbe 2024-11-14 12:27:22 +01:00
parent 8dd1b885f3
commit acd964869d
No known key found for this signature in database
GPG Key ID: C793F8B59F43CE7B

View File

@ -2448,7 +2448,7 @@ class ChatActivity :
currentlyPlayedVoiceMessage?.let { stopMediaPlayer(it) } // FIXME, mediaplayer can sometimes be null here currentlyPlayedVoiceMessage?.let { stopMediaPlayer(it) } // FIXME, mediaplayer can sometimes be null here
adapter = null adapter = null
Log.d(TAG, "inConversation was set to false!") disposables.dispose()
} }
private fun joinRoomWithPassword() { private fun joinRoomWithPassword() {
@ -2513,7 +2513,7 @@ class ChatActivity :
?.observeOn(AndroidSchedulers.mainThread()) ?.observeOn(AndroidSchedulers.mainThread())
?.subscribe(object : Observer<SignalingSettingsOverall> { ?.subscribe(object : Observer<SignalingSettingsOverall> {
override fun onSubscribe(d: Disposable) { override fun onSubscribe(d: Disposable) {
// unused atm disposables.add(d)
} }
override fun onNext(signalingSettingsOverall: SignalingSettingsOverall) { override fun onNext(signalingSettingsOverall: SignalingSettingsOverall) {