gronod/talk-android
1
0
Fork 1
mirror of https://github.com/nextcloud/talk-android synced 2025-07-19 18:55:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

Reduce number of return statements

Browse Source 
Codacy reported:

  Function itemFromObject has 4 return statements which exceeds the limit of 2.

Signed-off-by: Tim Krüger <t@timkrueger.me>
This commit is contained in:
Tim Krüger 2022-08-09 18:48:25 +02:00
parent 43f2d1badf
commit aae7e851c9
No known key found for this signature in database
GPG Key ID: FECE3A7222C52A4E
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/src/main/java/com/nextcloud/talk/shareditems/repositories/SharedItemsRepositoryImpl.kt
View File

@ -134,9 +134,10 @@ class SharedItemsRepositoryImpl @Inject constructor(private val ncApi: NcApi) :
actorParameters: HashMap<String?, String?>, actorParameters: HashMap<String?, String?>,
dateTime: String dateTime: String
): SharedItem { ): SharedItem {
val returnValue: SharedItem
when (objectParameters["type"]) { when (objectParameters["type"]) {
"talk-poll" -> { "talk-poll" -> {
return SharedPollItem( returnValue = SharedPollItem(
objectParameters["id"]!!, objectParameters["id"]!!,
objectParameters["name"]!!, objectParameters["name"]!!,
actorParameters["id"]!!, actorParameters["id"]!!,
@ -145,7 +146,7 @@ class SharedItemsRepositoryImpl @Inject constructor(private val ncApi: NcApi) :
) )
} }
"geo-location" -> { "geo-location" -> {
return SharedLocationItem( returnValue = SharedLocationItem(
objectParameters["id"]!!, objectParameters["id"]!!,
objectParameters["name"]!!, objectParameters["name"]!!,
actorParameters["id"]!!, actorParameters["id"]!!,
@ -155,7 +156,7 @@ class SharedItemsRepositoryImpl @Inject constructor(private val ncApi: NcApi) :
) )
} }
"deck-card" -> { "deck-card" -> {
return SharedDeckCardItem( returnValue = SharedDeckCardItem(
objectParameters["id"]!!, objectParameters["id"]!!,
objectParameters["name"]!!, objectParameters["name"]!!,
actorParameters["id"]!!, actorParameters["id"]!!,
@ -165,7 +166,7 @@ class SharedItemsRepositoryImpl @Inject constructor(private val ncApi: NcApi) :
) )
} }
else -> { else -> {
return SharedOtherItem( returnValue = SharedOtherItem(
objectParameters["id"]!!, objectParameters["id"]!!,
objectParameters["name"]!!, objectParameters["name"]!!,
actorParameters["id"]!!, actorParameters["id"]!!,
@ -174,6 +175,7 @@ class SharedItemsRepositoryImpl @Inject constructor(private val ncApi: NcApi) :
) )
} }
} }
return returnValue
} }
override fun availableTypes(parameters: SharedItemsRepository.Parameters): Observable<Set<SharedItemType>> { override fun availableTypes(parameters: SharedItemsRepository.Parameters): Observable<Set<SharedItemType>> {