From aae7e851c9bf052918a1a8414eb5e883b3c3b900 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tim=20Kr=C3=BCger?= <t@timkrueger.me>
Date: Tue, 9 Aug 2022 18:48:25 +0200
Subject: [PATCH] Reduce number of return statements
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Codacy reported:

  Function itemFromObject has 4 return statements which exceeds the limit of 2.

Signed-off-by: Tim Krüger <t@timkrueger.me>
---
 .../repositories/SharedItemsRepositoryImpl.kt          | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/app/src/main/java/com/nextcloud/talk/shareditems/repositories/SharedItemsRepositoryImpl.kt b/app/src/main/java/com/nextcloud/talk/shareditems/repositories/SharedItemsRepositoryImpl.kt
index 0f1541e2c..e012bb18b 100644
--- a/app/src/main/java/com/nextcloud/talk/shareditems/repositories/SharedItemsRepositoryImpl.kt
+++ b/app/src/main/java/com/nextcloud/talk/shareditems/repositories/SharedItemsRepositoryImpl.kt
@@ -134,9 +134,10 @@ class SharedItemsRepositoryImpl @Inject constructor(private val ncApi: NcApi) :
         actorParameters: HashMap<String?, String?>,
         dateTime: String
     ): SharedItem {
+        val returnValue: SharedItem
         when (objectParameters["type"]) {
             "talk-poll" -> {
-                return SharedPollItem(
+                returnValue = SharedPollItem(
                     objectParameters["id"]!!,
                     objectParameters["name"]!!,
                     actorParameters["id"]!!,
@@ -145,7 +146,7 @@ class SharedItemsRepositoryImpl @Inject constructor(private val ncApi: NcApi) :
                 )
             }
             "geo-location" -> {
-                return SharedLocationItem(
+                returnValue = SharedLocationItem(
                     objectParameters["id"]!!,
                     objectParameters["name"]!!,
                     actorParameters["id"]!!,
@@ -155,7 +156,7 @@ class SharedItemsRepositoryImpl @Inject constructor(private val ncApi: NcApi) :
                 )
             }
             "deck-card" -> {
-                return SharedDeckCardItem(
+                returnValue = SharedDeckCardItem(
                     objectParameters["id"]!!,
                     objectParameters["name"]!!,
                     actorParameters["id"]!!,
@@ -165,7 +166,7 @@ class SharedItemsRepositoryImpl @Inject constructor(private val ncApi: NcApi) :
                 )
             }
             else -> {
-                return SharedOtherItem(
+                returnValue = SharedOtherItem(
                     objectParameters["id"]!!,
                     objectParameters["name"]!!,
                     actorParameters["id"]!!,
@@ -174,6 +175,7 @@ class SharedItemsRepositoryImpl @Inject constructor(private val ncApi: NcApi) :
                 )
             }
         }
+        return returnValue
     }
 
     override fun availableTypes(parameters: SharedItemsRepository.Parameters): Observable<Set<SharedItemType>> {