From 9f5c85cd2e8afcae42df8245d593d8e4281f553f Mon Sep 17 00:00:00 2001 From: Marcel Hibbe Date: Fri, 27 Jan 2023 10:36:44 +0100 Subject: [PATCH] Fix spotbugs + codacy warnings will be reverted for raise hands feature when multiple conditions are checks.. Signed-off-by: Marcel Hibbe --- .../java/com/nextcloud/talk/activities/CallActivity.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/com/nextcloud/talk/activities/CallActivity.java b/app/src/main/java/com/nextcloud/talk/activities/CallActivity.java index 9ba16feed..edd09d7e5 100644 --- a/app/src/main/java/com/nextcloud/talk/activities/CallActivity.java +++ b/app/src/main/java/com/nextcloud/talk/activities/CallActivity.java @@ -95,7 +95,6 @@ import com.nextcloud.talk.utils.ApiUtils; import com.nextcloud.talk.utils.DisplayUtils; import com.nextcloud.talk.utils.NotificationUtils; import com.nextcloud.talk.utils.animations.PulseAnimation; -import com.nextcloud.talk.utils.bundle.BundleKeys; import com.nextcloud.talk.utils.database.user.CapabilitiesUtilNew; import com.nextcloud.talk.utils.permissions.PlatformPermissionUtil; import com.nextcloud.talk.utils.power.PowerManagerUtils; @@ -469,8 +468,7 @@ public class CallActivity extends CallBaseActivity { } private void initFeaturesVisibility() { - boolean showMoreCallActionsItem = isAllowedToStartOrStopRecording(); - if (showMoreCallActionsItem) { + if (isAllowedToStartOrStopRecording()) { binding.moreCallActions.setVisibility(View.VISIBLE); } else { binding.moreCallActions.setVisibility(View.GONE); @@ -1705,9 +1703,9 @@ public class CallActivity extends CallBaseActivity { case "recordingStatus": Log.d(TAG, "onMessageEvent 'recordingStatus'"); - if (webSocketCommunicationEvent.getHashMap().containsKey(BundleKeys.KEY_RECORDING_STATE)) { + if (webSocketCommunicationEvent.getHashMap().containsKey(KEY_RECORDING_STATE)) { String recordingStateString = - webSocketCommunicationEvent.getHashMap().get(BundleKeys.KEY_RECORDING_STATE); + webSocketCommunicationEvent.getHashMap().get(KEY_RECORDING_STATE); if (recordingStateString != null) { runOnUiThread(() -> {